Hi, > -----Original Message----- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Monday, January 8, 2018 9:07 PM > To: Wang, Xiao W <xiao.w.w...@intel.com> > Cc: Bie, Tiwei <tiwei....@intel.com>; dev@dpdk.org; > step...@networkplumber.org > Subject: Re: [PATCH v6 1/3] net/virtio: make control queue thread-safe > > On Sun, Jan 07, 2018 at 04:05:11AM -0800, Xiao Wang wrote: > > diff --git a/drivers/net/virtio/virtio_rxtx.h > > b/drivers/net/virtio/virtio_rxtx.h > > index 54f1e849b..71b5798b0 100644 > > --- a/drivers/net/virtio/virtio_rxtx.h > > +++ b/drivers/net/virtio/virtio_rxtx.h > > @@ -84,6 +84,7 @@ struct virtnet_ctl { > > rte_iova_t virtio_net_hdr_mem; /**< hdr for each xmit packet */ > > uint16_t port_id; /**< Device port identifier. */ > > const struct rte_memzone *mz; /**< mem zone to populate CTL ring. > */ > > + rte_spinlock_t sl; /**< spinlock for control queue. */ > > It's weird to name it "sl". The typical naming is just "lock". > > --yliu
I'm open to the naming method, but you can see that: struct rte_mempool_ops_table also has a "sl" field. BRs, Xiao
