[dpdk-dev] [PATCH v3 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds

2016-03-04 Thread Stephen Hurd
Add additional ETH_LINK_SPEED_* macros for 2, 2.5, 25, and 50 Gbps links Signed-off-by: Stephen Hurd --- lib/librte_ether/rte_ethdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 16da821..cb40bbb 100644 --- a/lib

[dpdk-dev] [PATCH v3 5/7] build: add bnxt PMD to build

2016-03-04 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- config/common_bsdapp | 5 + config/common_linuxapp | 5 + drivers/net/Makefile | 1 + mk/rte.app.mk | 1 + 4 files changed, 12 insertions(+) diff --git a/config/common_bsdapp b/config/common_bsdapp index 696382c..f37c7bb 100644 --- a/config

[dpdk-dev] [PATCH v3 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt

2016-03-04 Thread Stephen Hurd
Add Broadcom Vendor ID and RTE_PCI_DEV_ID_DECL_BNXT() macro. Add Device IDs for Broadcom bnxt devices. Signed-off-by: Stephen Hurd --- lib/librte_eal/common/include/rte_pci_dev_ids.h | 45 ++--- 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal

[dpdk-dev] [PATCH v3 0/7] drivers/net/bnxt: new Broadcom bnxt driver

2016-03-04 Thread Stephen Hurd
uint64_t) Stephen Hurd (7): lib/librte_ether: Add 2/2.5/25/50Gbps link speeds lib/librte_eal: Add PCI IDs for Broadcom bnxt drivers/net/bnxt new driver for Broadcom bnxt maintainers: claim drivers/net/bnxt build: add bnxt PMD to build doc: Add bnxt to overview table doc: add guide for

[dpdk-dev] [PATCH v3 7/7] doc: add guide for new bnxt driver

2016-03-04 Thread Stephen Hurd
Initial guide for bnxt driver, documents current limitations and provides information link. Signed-off-by: Stephen Hurd --- doc/guides/nics/bnxt.rst | 49 1 file changed, 49 insertions(+) create mode 100644 doc/guides/nics/bnxt.rst diff --git a

[dpdk-dev] [PATCH v3 4/7] maintainers: claim drivers/net/bnxt

2016-03-04 Thread Stephen Hurd
Claim ownership of new drivers/net/bnxt driver. Signed-off-by: Stephen Hurd --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 628bc05..6ee6c3c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -359,6 +359,10 @@ F: drivers/crypto/aesni_mb/ Intel

[dpdk-dev] [PATCH v3 6/7] doc: Add bnxt to overview table

2016-03-04 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- doc/guides/nics/overview.rst | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index d4c6ff4..e606bdf 100644 --- a/doc/guides/nics

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-04 Thread Stephen Hurd
New driver for Broadcom bnxt (NexXtreme C-series) devices. Standards-compliant 10/25/50G support with 30MPPS full-duplex throughput http://www.broadcom.com/press/release.php?id=s923886 Signed-off-by: Stephen Hurd --- v3: * Fix incorrect format specifier compilation error on i686 (PRIx64

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-03-04 Thread Stephen Hurd
On Fri, Mar 4, 2016 at 3:02 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > > > New driver for Broadcom bnxt (NexXtreme C-series) devices.> > > Looks good, I just have a couple of functionality comments. > > 1. Driver does not appear to support Link State interrupt. Not a big >

[dpdk-dev] [PATCH v4 01/39] bnxt: new driver for Broadcom NetXtreme-C devices

2016-06-06 Thread Stephen Hurd
ff-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- MAINTAINERS | 5 ++ config/common_base | 5 ++ doc/guides/nics/bnxt.rst| 49 +++ doc/guides/nics/inde

[dpdk-dev] [PATCH v4 02/39] bnxt: add HWRM init code

2016-06-06 Thread Stephen Hurd
large enough for the largest possible response. bnxt_hwrm_queue_qportcfg: Required to get the default queue ID. v4: Fix few issues highlighted by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH v4 03/39] bnxt: add driver register/unregister support

2016-06-06 Thread Stephen Hurd
Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 38 - drivers/net/bnxt/bnxt_hwrm.c | 50 ++ drivers/net/bnxt/bnxt_hwrm.h | 3 + drivers/net/bnxt/hsi_struct_def_dpdk.h

[dpdk-dev] [PATCH v4 04/39] bnxt: add dev infos get operation

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Gets device info from the bp structure filled in the init() function. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt.h| 3 ++ drivers/net/bnxt/bnxt_ethdev.c | 95

[dpdk-dev] [PATCH v4 05/39] bnxt: add dev configure operation

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the bnxt_hwrm_port_phy_cfg() HWRM call, and copies required information into the new struct bnxt_link_info. v4: Fixed few issues identified by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers

[dpdk-dev] [PATCH v4 07/39] bnxt: declare ring structs and free() func

2016-06-06 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile| 1 + drivers/net/bnxt/bnxt_ring.c | 47 ++ drivers/net/bnxt/bnxt_ring.h | 92 3 files changed, 140 insertions(+) create mode 100644 drivers/net/bnxt/bnxt_ring.c

[dpdk-dev] [PATCH v4 13/39] bnxt: initial Tx code implementation

2016-06-06 Thread Stephen Hurd
Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_cpr.h| 4 +- drivers/net/bnxt/bnxt_ethdev.c | 3 +- drivers/net/bnxt/bnxt_ring.c | 145 ++ drivers/net/bnxt/bnxt_ring.h

[dpdk-dev] [PATCH v4 12/39] bnxt: Add statistics operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Add get and clear staitstics operations and the asociated HWRM calls. v4: Address review comments and fix issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH v4 09/39] bnxt: add L2 filter alloc/init/free

2016-06-06 Thread Stephen Hurd
the incoming traffic to an appropriate VNIC or Rx ring. v4: Address review comments and fix issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH v4 06/39] bnxt: add vnic functions and structs

2016-06-06 Thread Stephen Hurd
Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 14 ++ drivers/net/bnxt/bnxt_vnic.c | 277 + drivers/net/bnxt/bnxt_vnic.h | 80

[dpdk-dev] [PATCH v4 08/39] bnxt: add completion ring support

2016-06-06 Thread Stephen Hurd
and fix issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 5 + drivers/net/bnxt/bnxt_cpr.c|

[dpdk-dev] [PATCH v4 11/39] bnxt: add Rx queue create/destroy operations

2016-06-06 Thread Stephen Hurd
-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 2 + drivers/net/bnxt/bnxt_ethdev.c | 3 + drivers/net/bnxt/bnxt_rxq.c| 288 + drivers/net/bnxt/bnxt_rxq.h| 74

[dpdk-dev] [PATCH v4 32/39] bnxt: add all multicast enable/disable operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to enable/disable multicast traffic. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a

[dpdk-dev] [PATCH v4 30/39] bnxt: add start/stop/link update operations

2016-06-06 Thread Stephen Hurd
-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 269 + 1 file changed, 269 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 6888363

[dpdk-dev] [PATCH v4 31/39] bnxt: add promiscuous enable/disable operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde This patch adds the promiscuous mode enable and disable dev_ops. v4: Fix couple of typos in the commit message. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 30

[dpdk-dev] [PATCH v4 22/39] bnxt: add API for L2 Rx mask set/clear functions

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde These HWRM APIs allow setting and clearing of Rx masks in L2 context per VNIC. v4: Address review comments. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 45 +++ drivers/net

[dpdk-dev] [PATCH v4 10/39] bnxt: add Tx queue operations (nonfunctional)

2016-06-06 Thread Stephen Hurd
Signed-off-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c | 3 + drivers/net/bnxt/bnxt_txq.c| 125 + drivers/net/bnxt/bnxt_txq.h| 75 + 4 files changed, 204 insertions(+) create

[dpdk-dev] [PATCH v4 26/39] bnxt: add HWRM stat context free function

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Add function and associated structures and definitions to free statistics context from the ASIC. v4: Address review comments and fix issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net

[dpdk-dev] [PATCH v4 33/39] bnxt: free memory in close operation

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde This patch adds code to free all resources except the one corresponding to HWRM, which are required to notify the HWRM that the driver is unloaded (these are freed in uninit()). Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd

[dpdk-dev] [PATCH v4 15/39] bnxt: Code to alloc/free ring

2016-06-06 Thread Stephen Hurd
issues pointed out by checkpatch. - Change the argument passed to bnxt_alloc_rings. Instead of passing bnxt_tx_ring and bnxt_rx_ring, shorten them to txr and rxr respectively. - Add code to free the reserved memzone Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen

[dpdk-dev] [PATCH v4 18/39] bnxt: add HWRM vnic free function

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Frees a vnic allocated by vnic_alloc in the previous patch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 21 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt

[dpdk-dev] [PATCH v4 23/39] bnxt: add HWRM stats context allocation

2016-06-06 Thread Stephen Hurd
-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 52 drivers/net/bnxt/bnxt_hwrm.h | 3 ++ drivers/net/bnxt/hsi_struct_def_dpdk.h | 89 ++ 3 files changed, 144 insertions(+) diff --git a/d

[dpdk-dev] [PATCH v4 19/39] bnxt: add HWRM vnic configure function

2016-06-06 Thread Stephen Hurd
vnic_alloc function from the previous patch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 34 drivers/net/bnxt/bnxt_hwrm.h | 3 +- drivers/net/bnxt/hsi_struct_def_dpdk.h | 155

[dpdk-dev] [PATCH v4 24/39] bnxt: add HWRM ring alloc/free functions

2016-06-06 Thread Stephen Hurd
port errors, status changes to the host software. v4: Address review comments. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 108 drivers/net/bnxt/bnxt_hwrm.h | 7 + drivers/net/

[dpdk-dev] [PATCH v4 14/39] bnxt: initial Rx code implementation

2016-06-06 Thread Stephen Hurd
-by: Stephen Hurd --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c | 3 +- drivers/net/bnxt/bnxt_ring.c | 60 ++--- drivers/net/bnxt/bnxt_rxq.c| 34 ++- drivers/net/bnxt/bnxt_rxr.c| 341 drivers

[dpdk-dev] [PATCH v4 27/39] bnxt: Add HWRM API to set and clear filters

2016-06-06 Thread Stephen Hurd
Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 69 drivers/net/bnxt/bnxt_hwrm.h | 6 2 files changed, 75 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c

[dpdk-dev] [PATCH v4 21/39] bnxt: add HWRM API to configure RSS

2016-06-06 Thread Stephen Hurd
RSS configuration of the VNIC. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 24 drivers/net/bnxt/bnxt_hwrm.h | 2 ++ drivers/net/bnxt/hsi_struct_def_dpdk.h | 1 + 3 files

[dpdk-dev] [PATCH v4 17/39] bnxt: add HWRM vnic alloc function

2016-06-06 Thread Stephen Hurd
setup various target actions such as RSS, MAC filtering etc.. for the physical function in use. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt.h| 2 + drivers/net/bnxt/bnxt_hwrm.c | 33

[dpdk-dev] [PATCH v4 37/39] bnxt: add RSS device operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Add rss_hash_update and rss_hash_conf_get dev_ops v4: Fix issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 121 + 1 file

[dpdk-dev] [PATCH v4 16/39] bnxt: add HWRM function reset command

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Add bnxt_hwrm_func_reset() function and supporting structs and macros. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 17 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers

[dpdk-dev] [PATCH v4 36/39] bnxt: add reta update/query operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Add code to Update/query reta dev_ops Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH v4 35/39] bnxt: add set link up/down operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Adds dev_ops to set link UP or DOWN as appropriate. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/bnxt

[dpdk-dev] [PATCH v4 20/39] bnxt: add API to allow configuration of vnic

2016-06-06 Thread Stephen Hurd
Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 38 drivers/net/bnxt/bnxt_hwrm.h | 2 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 153 + 3 files changed, 193 insertions(+) diff --git a/drivers/net/bnxt

[dpdk-dev] [PATCH v4 38/39] bnxt: add flow control operations

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde Add flow_ctrl_get and flow_ctrl_set dev_ops. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH v4 28/39] bnxt: add ring alloc, free and group init

2016-06-06 Thread Stephen Hurd
issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 112 +++- drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt/bnxt_ring.c | 119

[dpdk-dev] [PATCH v4 25/39] bnxt: add ring group alloc/free functions

2016-06-06 Thread Stephen Hurd
: Address issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 84 +++ drivers/net/bnxt/bnxt_hwrm.h | 4 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 185

[dpdk-dev] [PATCH v4 29/39] bnxt: add HWRM port PHY config call and helpers

2016-06-06 Thread Stephen Hurd
ed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_hwrm.c | 120 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 790 + 3 files changed, 911 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH v4 34/39] bnxt: add MAC address add/remove dev_ops

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde This patch adds dev_ops to Add/Remove MAC addresses. v4: Fix issues pointed out by checkpatch. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_ethdev.c | 71 ++ 1

[dpdk-dev] [PATCH v4 39/39] bnxt: Replace bnxt_ring_struct with bnxt_ring

2016-06-06 Thread Stephen Hurd
From: Ajit Khaparde As pointed in the previous round of review, Having struct at the end of the structure bnxt_ring_struct is a redundant. Replace it with bnxt_ring. Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen Signed-off-by: Stephen Hurd --- drivers/net/bnxt/bnxt_cpr.c | 4

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-19 Thread Stephen Hurd
On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > This seems a single huge commit. Can this be split up

[dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

2016-04-20 Thread Stephen Hurd
nce he's coming up to speed on the driver code, this could be a good way for him to fully familiarize himself with it. -- Stephen Hurd

[dpdk-dev] [PATCH 04/40] bnxt: add dev infos get operation

2016-05-06 Thread Stephen Hurd
Gets device info from the bp structure filled in the init() function. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 3 ++ drivers/net/bnxt/bnxt_ethdev.c | 96 +- 2 files changed, 98 insertions(+), 1

[dpdk-dev] [PATCH 01/40] bnxt: new driver for Broadcom NetXtreme-C devices

2016-05-06 Thread Stephen Hurd
Initial skeleton simply fails init. Add nic guide and tie into build system. Signed-off-by: Stephen Hurd --- MAINTAINERS | 5 ++ config/common_base | 5 ++ doc/guides/nics/bnxt.rst| 49

[dpdk-dev] [PATCH 02/40] bnxt: add HWRM init code

2016-05-06 Thread Stephen Hurd
. Returns an error if the firmware on the device is not supported by the driver and ensures the response space is large enough for the largest possible response. bnxt_hwrm_queue_qportcfg: Required to get the default queue ID. Signed-off-by: Stephen Hurd Reviewed-by: David

[dpdk-dev] [PATCH 10/40] bnxt: add Tx queue operations (nonfunctional)

2016-05-06 Thread Stephen Hurd
Add code to create/destroy TX queues. This still requires TX ring support to be completed in a future commit. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c | 3 + drivers/net/bnxt/bnxt_txq.c| 125

[dpdk-dev] [PATCH 09/40] bnxt: add L2 filter alloc/init/free

2016-05-06 Thread Stephen Hurd
Add the L2 filter structure and the alloc/init/free functions for dealing with them. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 3 + drivers/net/bnxt/bnxt_filter.c | 175

[dpdk-dev] [PATCH 08/40] bnxt: add completion ring support

2016-05-06 Thread Stephen Hurd
Structures, macros, and functions for working with completion rings in the driver. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 6 + drivers/net/bnxt/bnxt_cpr.c| 139

[dpdk-dev] [PATCH 03/40] bnxt: add driver register/unregister support

2016-05-06 Thread Stephen Hurd
Move init() cleanup into uninit() function Fix .dev_private_size Add require hwrm calls: bnxt_hwrm_func_driver_register() bnxt_hwrm_func_driver_unregister() Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers

[dpdk-dev] [PATCH 07/40] bnxt: declare ring structs and free() func

2016-05-06 Thread Stephen Hurd
Declare ring structures and a ring free() function. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile| 1 + drivers/net/bnxt/bnxt_ring.c | 51 drivers/net/bnxt/bnxt_ring.h | 92

[dpdk-dev] [PATCH 24/40] bnxt: add HWRM ring alloc/free functions

2016-05-06 Thread Stephen Hurd
Add HWRM calls to allocate and free TX/RX/CMPL rings along with the associated structs and definitions. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 108 drivers/net/bnxt/bnxt_hwrm.h | 7 + drivers/net/bnxt

[dpdk-dev] [PATCH 06/40] bnxt: add vnic functions and structs

2016-05-06 Thread Stephen Hurd
Add functions to allocate, initialize, and free vnics. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 14 ++ drivers/net/bnxt/bnxt_vnic.c | 277

[dpdk-dev] [PATCH 18/40] bnxt: add HWRM vnic free function

2016-05-06 Thread Stephen Hurd
Frees a vnic allocated by vnic_alloc. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 21 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 82 ++ 3 files

[dpdk-dev] [PATCH 22/40] bnxt: add L2 Rx mask set/clear functions

2016-05-06 Thread Stephen Hurd
Allows setting and clearing L2 context RX masks per vnic Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 45 +++ drivers/net/bnxt/bnxt_hwrm.h | 3 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 135

[dpdk-dev] [PATCH 21/40] bnxt: add HWRM vnic RSS config function

2016-05-06 Thread Stephen Hurd
Used to enable RSS configuration Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 24 drivers/net/bnxt/bnxt_hwrm.h | 2 ++ drivers/net/bnxt/hsi_struct_def_dpdk.h | 1 + 3 files changed, 27 insertions

[dpdk-dev] [PATCH 11/40] bnxt: add Rx queue create/destroy operations

2016-05-06 Thread Stephen Hurd
Initial create/destroy queue code. Requires RX ring support to be functional. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 2 + drivers/net/bnxt/bnxt_ethdev.c | 3

[dpdk-dev] [PATCH 13/40] bnxt: initial Tx ring code

2016-05-06 Thread Stephen Hurd
Initial implementation of rx_pkt_burst Add code to allocate rings to bnxt_ring.c Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_cpr.h| 4 +- drivers/net/bnxt/bnxt_ethdev.c | 5

[dpdk-dev] [PATCH 12/40] bnxt: statistics operations

2016-05-06 Thread Stephen Hurd
Add get and clear staitstics operations and the asociated HWRM calls. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt.h| 5 +- drivers/net/bnxt/bnxt_cpr.c| 5 +- drivers/net

[dpdk-dev] [PATCH 19/40] bnxt: add HWRM vnic cfg function

2016-05-06 Thread Stephen Hurd
Configurs a vnic allocaed by vnic_alloc function. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 34 drivers/net/bnxt/bnxt_hwrm.h | 3 +- drivers/net/bnxt/hsi_struct_def_dpdk.h | 155

[dpdk-dev] [PATCH 16/40] bnxt: add HWRM function reset command

2016-05-06 Thread Stephen Hurd
Add bnxt_hwrm_func_reset() function and supporting structs and macros. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 17 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 129

[dpdk-dev] [PATCH 17/40] bnxt: add HWRM vnic alloc function

2016-05-06 Thread Stephen Hurd
This requires a group info array in struct bnxt, so add that, save the max size from the func_qcap response, and alloc/free in init/uninit Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 2 + drivers/net/bnxt/bnxt_hwrm.c | 33

[dpdk-dev] [PATCH 35/40] bnxt: add MAC address add/remove operations

2016-05-06 Thread Stephen Hurd
Add/remove MAC addresses Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index edb7427

[dpdk-dev] [PATCH 32/40] bnxt: add promiscuous enable/disable operations

2016-05-06 Thread Stephen Hurd
Enables and diables promiscuous mode. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index

[dpdk-dev] [PATCH 37/40] bnxt: add reta update/query operations

2016-05-06 Thread Stephen Hurd
Update/query reta operations Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index

[dpdk-dev] [PATCH 33/40] bnxt: add all multicast enable/disable operations

2016-05-06 Thread Stephen Hurd
Enables/disables all multicast traffic. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index

[dpdk-dev] [PATCH 27/40] bnxt: add struct forward decl

2016-05-06 Thread Stephen Hurd
Add missing forward declaration of struct bnxt_ring_struct to avoid requiring additional headers for the function declaation. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bnxt

[dpdk-dev] [PATCH 28/40] bnxt: add ring allocation and group init

2016-05-06 Thread Stephen Hurd
Add a function to initialize ring groups, and a function to allocate the rings via HWRM. This should be the last functionality needed to add start/stop device operations. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ring.c | 119

[dpdk-dev] [PATCH 26/40] bnxt: add HWRM stat context free function

2016-05-06 Thread Stephen Hurd
Add function and associated structures and definitions as well as some convenienct functions for manipulating the state of the entire function. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 219

[dpdk-dev] [PATCH 30/40] bnxt: add HWRM port phy qcfg call and wrapper

2016-05-06 Thread Stephen Hurd
Add HWRM port pgy qcfg HWRM command and bnxt_get_hwrm_link_config() wrapper which parses the link state. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 120 + drivers/net/bnxt/bnxt_hwrm.h | 1 + drivers/net/bnxt

[dpdk-dev] [PATCH 34/40] bnxt: add device close operation

2016-05-06 Thread Stephen Hurd
Frees all resources except the hwrm ones, which are required to notify the HWRM that the driver is unloaded (these are freed in uninit()). Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff

[dpdk-dev] [PATCH 38/40] bnxt: add RSS device operations

2016-05-06 Thread Stephen Hurd
Add rss_hash_update and rss_hash_conf_get Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 117 + 1 file changed, 117 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt

[dpdk-dev] [PATCH 39/40] bnxt: add flow control operations

2016-05-06 Thread Stephen Hurd
Add flow_ctrl_get and flow_ctrl_set device operations. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net

[dpdk-dev] [PATCH 05/40] bnxt: add dev configure operation

2016-05-06 Thread Stephen Hurd
This adds the bnxt_hwrm_port_phy_cfg() HWRM call, and copies required information into the new struct bnxt_link_info. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 32 +++ drivers/net/bnxt/bnxt_ethdev.c | 24 ++ drivers/net

[dpdk-dev] [PATCH 20/40] bnxt: add vnic RSS cos lb cTx alloc/free functions

2016-05-06 Thread Stephen Hurd
More HWRM calls. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 38 drivers/net/bnxt/bnxt_hwrm.h | 2 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 153 + 3 files changed, 193

[dpdk-dev] [PATCH 25/40] bnxt: add ring group alloc/free functions

2016-05-06 Thread Stephen Hurd
Add HWRM ring group add/free functions and associated structs and definitions. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 84 +++ drivers/net/bnxt/bnxt_hwrm.h | 4 + drivers/net/bnxt/hsi_struct_def_dpdk.h

[dpdk-dev] [PATCH 36/40] bnxt: add dev set link up/down operations

2016-05-06 Thread Stephen Hurd
Sets link to up or down as appropriate. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 7056f98

[dpdk-dev] [PATCH 29/40] bnxt: work around HWRM error when creating rings

2016-05-06 Thread Stephen Hurd
Some HWRM versions will stop responding if we request poll mode interrupt. As a workaround, request an MSI interrupt even though we never enable it. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 6 +- 1 file changed, 5 insertions(+), 1

[dpdk-dev] [PATCH 40/40] bnxt: cleanup null pointer checks

2016-05-06 Thread Stephen Hurd
Prefer !ptr to ptr == NULL Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 10 +- drivers/net/bnxt/bnxt_filter.c | 2 +- drivers/net/bnxt/bnxt_hwrm.c | 6 +++--- drivers/net/bnxt/bnxt_ring.c | 2 +- drivers/net/bnxt/bnxt_vnic.c

[dpdk-dev] [PATCH 23/40] bnxt: add HWRM stats context allocation

2016-05-06 Thread Stephen Hurd
Add HWRM code to allocate a statistics context and a helper function to allocate one for evert completion ring. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 52 drivers/net/bnxt/bnxt_hwrm.h | 3

[dpdk-dev] [PATCH 31/40] bnxt: add start/stop/link update operations

2016-05-06 Thread Stephen Hurd
BNXT driver will now minimally pass traffic with testpmd. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 267 + 1 file changed, 267 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers

[dpdk-dev] [PATCH 15/40] bnxt: alloc/free ring information

2016-05-06 Thread Stephen Hurd
Perform allocation and free()ing of ring information structures for TX, RX, and completion rings. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_cpr.c | 28 +++- drivers/net/bnxt/bnxt_cpr.h | 2 +- drivers/net/bnxt/bnxt_rxq.c

[dpdk-dev] [PATCH 14/40] bnxt: initial Rx ring code

2016-05-06 Thread Stephen Hurd
Initial implementation of rx_pkt_burst Add code to allocate rings to bnxt_ring.c Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile | 1 + drivers/net/bnxt/bnxt_ethdev.c | 3 +- drivers/net/bnxt/bnxt_ring.c | 20

[dpdk-dev] [PATCH 01/40] bnxt: new driver for Broadcom NetXtreme-C devices

2016-05-11 Thread Stephen Hurd
On Tue, May 10, 2016 at 9:53 PM, Panu Matilainen wrote: > On 05/06/2016 10:25 PM, Stephen Hurd wrote: > >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += lib/librte_malloc >> > > librte_malloc got merged into librte_eal almost a year ago so it no longer > exists at al

[dpdk-dev] Updates to large patchsets

2016-05-11 Thread Stephen Hurd
When submitting an update to a single patch in a large patchset, what's the preferred method? Do I send a single "[PATCH v2 01/40]" email with the modified patch or do I send the entire series of 40 patches again? -- Stephen Hurd Principal Engineer - Software Development Broad

[dpdk-dev] [PATCH v2 40/40] bnxt: cleanup null pointer checks

2016-05-13 Thread Stephen Hurd
Prefer !ptr to ptr == NULL Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 10 +- drivers/net/bnxt/bnxt_filter.c | 2 +- drivers/net/bnxt/bnxt_hwrm.c | 6 +++--- drivers/net/bnxt/bnxt_ring.c | 2 +- drivers/net/bnxt/bnxt_vnic.c

[dpdk-dev] [PATCH v2 39/40] bnxt: add flow control operations

2016-05-13 Thread Stephen Hurd
Add flow_ctrl_get and flow_ctrl_set device operations. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net

[dpdk-dev] [PATCH v2 38/40] bnxt: add RSS device operations

2016-05-13 Thread Stephen Hurd
Add rss_hash_update and rss_hash_conf_get Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 117 + 1 file changed, 117 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt

[dpdk-dev] [PATCH v2 37/40] bnxt: add reta update/query operations

2016-05-13 Thread Stephen Hurd
Update/query reta operations Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index

[dpdk-dev] [PATCH v2 35/40] bnxt: add MAC address add/remove operations

2016-05-13 Thread Stephen Hurd
Add/remove MAC addresses Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index edb7427

[dpdk-dev] [PATCH v2 33/40] bnxt: add all multicast enable/disable operations

2016-05-13 Thread Stephen Hurd
Enables/disables all multicast traffic. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index

[dpdk-dev] [PATCH v2 31/40] bnxt: add start/stop/link update operations

2016-05-13 Thread Stephen Hurd
BNXT driver will now minimally pass traffic with testpmd. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 267 + 1 file changed, 267 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers

[dpdk-dev] [PATCH v2 28/40] bnxt: add ring allocation and group init

2016-05-13 Thread Stephen Hurd
Add a function to initialize ring groups, and a function to allocate the rings via HWRM. This should be the last functionality needed to add start/stop device operations. Signed-off-by: Stephen Hurd Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ring.c | 119

<    1   2   3   >