On Fri, Mar 4, 2016 at 3:02 PM, Stephen Hemminger < stephen at networkplumber.org> wrote:
> > > New driver for Broadcom bnxt (NexXtreme C-series) devices.> > > Looks good, I just have a couple of functionality comments. > > 1. Driver does not appear to support Link State interrupt. Not a big > deal, but would be good to have. > Correct, it currently doesn't, but this is on The List of things to do. > 2. Driver does not support hotplug > I haven't looked into enabling this at all yet. > 3. Since driver does not support scattered receive, it should check > and error out on enable_scatter (ditto for other features in rxmode). > This will save pain in future when some application asks device to do > something it can not do. > Good catch, will do. 4. Does driver support SECONDARY process model, it appears secondary > device will reset hardware. > I don't actually know what this is, I'll look into it. 5. Driver does not supper per-receive queue data interrupts. > This is necessary for power-saving NAPI like code. > This is also on The List. As a somewhat-related process question, should I be submitting this as a growing patch series until the merge window opens up again, or should I submit further changes as new patches? I'm not really sure on this point, and have been holding off adding the header comment commits until I figured out the right answer.
