[PATCH v1] net/ice: fix ice Rx timestamp for E822 NICs

2024-07-31 Thread Soumyadeep Hore
E822 PHY does not support switching from bypass to Vernier mode. Remove ice_phy_exit_bypass_e822() and program fixed offsets for bypass mode. Fixes: ce9ad8c5bc6d ("net/ice/base: remove PHY port timer bypass mode") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/ne

[PATCH v1] net/ice: initialize PHC time with current time of day

2024-08-11 Thread Soumyadeep Hore
The PHC main timer for ice pmd enabled drivers should be initialised to current time of day on enabling timesync else it will be initialized to 0 giving wrong timestamps. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/ice_ethdev.c | 26 ++ 1 file changed, 26

[PATCH v1 01/12] net/ice: use correct format specifiers for unsigned ints

2024-08-22 Thread Soumyadeep Hore
ff-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 54 +++ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 536392776f..48d5fff42a 100644 --- a/drivers/net/ice

[PATCH v1 00/12] Align ICE shared code with Base driver

2024-08-22 Thread Soumyadeep Hore
Updating the latest shared code patches to ICE base driver. Soumyadeep Hore (12): net/ice: use correct format specifiers for unsigned ints net/ice: updates for ptp init GNRD net/ice: add new tag definitions net/ice: avoid reading past end of PFA net/ice: update PTP init net/ice

[PATCH v1 02/12] net/ice: updates for ptp init GNRD

2024-08-22 Thread Soumyadeep Hore
it must be hard coded to default values. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_cgu_regs.h | 19 +++ drivers/net/ice/base/ice_common.c | 4 ++ drivers/net/ice/base/ice_ptp_consts.h | 75 +++ drivers/net/ice/base/ice_ptp_hw.c | 75

[PATCH v1 03/12] net/ice: add new tag definitions

2024-08-22 Thread Soumyadeep Hore
Add E830_GLTCLAN_TSYN_REG_RANGE_ENFORCE* defines to unified_manual.inc to make them available externally. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_hw_autogen.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ice/base/ice_hw_autogen.h b/drivers

[PATCH v1 04/12] net/ice: avoid reading past end of PFA

2024-08-22 Thread Soumyadeep Hore
the last word of the PFA and the word just after the PFA as another TLV. This typically results in one extra iteration before the length check of the while loop is triggered. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_nvm.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH v1 05/12] net/ice: update PTP init

2024-08-22 Thread Soumyadeep Hore
Add BIt macro to init PHY 1 for GNRD. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index e574ae6d4f..e61810cbdc 100644 --- a

[PATCH v1 06/12] net/ice: address compilation errors

2024-08-22 Thread Soumyadeep Hore
Visual Studio C++ compiler does not pass 32->16 or 16->8 bits conversions because of possible loss of data. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 31 --- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/n

[PATCH v1 07/12] net/ice: fix link speed for 200G

2024-08-22 Thread Soumyadeep Hore
("net/ice/base: add helper functions for PHY caching") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_ad

[PATCH v1 08/12] net/ice: update iteration of TLVs in Preserved Fields Area

2024-08-22 Thread Soumyadeep Hore
message. The check for whether the TLV length exceeds the PFA length is also removed, in favor of relying on the overflow warning instead. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_nvm.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff

[PATCH v1 09/12] net/ice: correct Tx Scheduler AQ command RD bit for E825C

2024-08-22 Thread Soumyadeep Hore
In E825C, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E825C, the RD bit must be cleared for the Get Tx Topology operation, whereas for E810 devices, the RD bit must be set. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base

[PATCH v1 10/12] net/ice: support optional flags in signature segment header

2024-08-22 Thread Soumyadeep Hore
done before, assume that this is the last segment being downloaded. However, if the flag field's valid bit IS set, then use the last segment flag to determine if this segment is the last segment to download. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ddp.c | 13 ++--

[PATCH v1 11/12] net/ice: update E830 50G branding strings

2024-08-22 Thread Soumyadeep Hore
Update E830 50G branding strings from "E830-XXV" to "E830-L". Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 6 +++--- drivers/net/ice/base/ice_devids.h | 12 ++-- drivers/net/ice/ice_ethdev.c | 6 +++--- 3 files changed, 12 inserti

[PATCH v1 12/12] net/ice: add support for FEC auto-detect for Connorsville

2024-08-22 Thread Soumyadeep Hore
support for Connorsville adapters. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 08ba0b45a5..c8047ca59f 100644 --- a/drivers/net/ice/base

[PATCH v2 01/12] net/ice: use correct format specifiers for unsigned ints

2024-08-22 Thread Soumyadeep Hore
ff-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 54 +++ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 536392776f..48d5fff42a 100644 --- a/drivers/net/ice

[PATCH v2 00/12] Align ICE shared code with Base driver

2024-08-22 Thread Soumyadeep Hore
Updating the latest shared code patches to ICE base driver. --- v2: - Addressed comments given by reviewer - Corrected errors in Camel Case --- Soumyadeep Hore (12): net/ice: use correct format specifiers for unsigned ints net/ice: updates for ptp init in E825C net/ice: add new tag

[PATCH v2 02/12] net/ice: updates for ptp init in E825C

2024-08-22 Thread Soumyadeep Hore
it must be hard coded to default values. Fixes: 620ecf247c22 ("net/ice/base: support E825-C Tx clock changing") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_cgu_regs.h | 19 +++ drivers/net/ice/base/ice_common.c | 4 ++ drivers/ne

[PATCH v2 03/12] net/ice: add new tag definitions

2024-08-22 Thread Soumyadeep Hore
Add E830_GLTCLAN_TSYN_REG_RANGE_ENFORCE* defines to unified_manual.inc to make them available externally. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_hw_autogen.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ice/base/ice_hw_autogen.h b/drivers

[PATCH v2 04/12] net/ice: avoid reading past end of PFA

2024-08-22 Thread Soumyadeep Hore
the last word of the PFA and the word just after the PFA as another TLV. This typically results in one extra iteration before the length check of the while loop is triggered. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_nvm.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH v2 05/12] net/ice: update PTP init

2024-08-22 Thread Soumyadeep Hore
Add Bit macro to init PHY 1 for E825C devices. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index e574ae6d4f..e61810cbdc

[PATCH v2 06/12] net/ice: address compilation errors

2024-08-22 Thread Soumyadeep Hore
Visual Studio C++ compiler does not pass 32->16 or 16->8 bits conversions because of possible loss of data. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 31 --- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/n

[PATCH v2 07/12] net/ice: fix link speed for 200G

2024-08-22 Thread Soumyadeep Hore
("net/ice/base: add helper functions for PHY caching") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_ad

[PATCH v2 08/12] net/ice: update iteration of TLVs in Preserved Fields Area

2024-08-22 Thread Soumyadeep Hore
message. The check for whether the TLV length exceeds the PFA length is also removed, in favor of relying on the overflow warning instead. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_nvm.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff

[PATCH v2 09/12] net/ice: correct Tx Scheduler AQ command RD bit for E825C

2024-08-22 Thread Soumyadeep Hore
In E825C, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E825C, the RD bit must be cleared for the Get Tx Topology operation, whereas for E810 devices, the RD bit must be set. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base

[PATCH v2 10/12] net/ice: support optional flags in signature segment header

2024-08-22 Thread Soumyadeep Hore
done before, assume that this is the last segment being downloaded. However, if the flag field's valid bit IS set, then use the last segment flag to determine if this segment is the last segment to download. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ddp.c | 13 ++--

[PATCH v2 11/12] net/ice: update E830 50G branding strings

2024-08-22 Thread Soumyadeep Hore
Update E830 50G branding strings from "E830-XXV" to "E830-L". Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 6 +++--- drivers/net/ice/base/ice_devids.h | 12 ++-- drivers/net/ice/ice_ethdev.c | 6 +++--- 3 files changed, 12 inserti

[PATCH v2 12/12] net/ice: add support for FEC auto-detect for E830

2024-08-22 Thread Soumyadeep Hore
for E830 adapters. Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 08ba0b45a5..c8047ca59f 100644 --- a/drivers/net/ice/base/ice_common.c +++ b

[PATCH v3 00/12] Align ICE shared code with Base driver

2024-08-23 Thread Soumyadeep Hore
Updating the latest shared code patches to ICE base driver. --- v3: - Addressed comments givn by reviewer --- v2: - Addressed comments given by reviewer - Corrected errors in Camel Case --- Dan Nowlin (2): net/ice: correct Tx Scheduler AQ command RD bit for E825C net/ice: support optional fla

[PATCH v3 01/12] net/ice: use correct format specifiers for unsigned ints

2024-08-23 Thread Soumyadeep Hore
x27;s needed. Signed-off-by: Yogesh Bhosale Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 54 +++ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c

[PATCH v3 02/12] net/ice: updates for ptp init in E825C

2024-08-23 Thread Soumyadeep Hore
from HW, and therefore it must be hard coded to default values. Fixes: 620ecf247c22 ("net/ice/base: support E825-C Tx clock changing") Cc: sta...@dpdk.org Signed-off-by: Norbert Zulinski Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_cgu_regs.h | 19 +++ drivers/ne

[PATCH v3 03/12] net/ice: add new tag definitions

2024-08-23 Thread Soumyadeep Hore
From: Paul Greenwalt Add E830_GLTCLAN_TSYN_REG_RANGE_ENFORCE* defines to unified_manual.inc to make them available externally. Signed-off-by: Paul Greenwalt Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_hw_autogen.h | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH v3 04/12] net/ice: avoid reading past end of PFA

2024-08-23 Thread Soumyadeep Hore
PFA, misinterpreting the last word of the PFA and the word just after the PFA as another TLV. This typically results in one extra iteration before the length check of the while loop is triggered. Signed-off-by: Jacob Keller Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_nvm.c | 9

[PATCH v3 05/12] net/ice: update PTP init

2024-08-23 Thread Soumyadeep Hore
From: Norbert Zulinski Add Bit macro to init PHY 1 for E825C devices. Signed-off-by: Norbert Zulinski Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers

[PATCH v3 06/12] net/ice: address compilation errors

2024-08-23 Thread Soumyadeep Hore
From: Oleg Akhrem Visual Studio C++ compiler does not pass 32->16 or 16->8 bits conversions because of possible loss of data. Signed-off-by: Oleg Akhrem Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 31 --- 1 file changed, 4 inse

[PATCH v3 07/12] net/ice: fix link speed for 200G

2024-08-23 Thread Soumyadeep Hore
. Fixes: d13ad9cf1721 ("net/ice/base: add helper functions for PHY caching") Cc: sta...@dpdk.org Signed-off-by: Paul Greenwalt Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH v3 08/12] net/ice: update iteration of TLVs in Preserved Fields Area

2024-08-23 Thread Soumyadeep Hore
log a useful warning message. The check for whether the TLV length exceeds the PFA length is also removed, in favor of relying on the overflow warning instead. Signed-off-by: Fabio Pricoco Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_nvm.c | 29 ++--- 1 file

[PATCH v3 09/12] net/ice: correct Tx Scheduler AQ command RD bit for E825C

2024-08-23 Thread Soumyadeep Hore
: Soumyadeep Hore --- drivers/net/ice/base/ice_ddp.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index 24506dfaea..d0c1cb9660 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base

[PATCH v3 10/12] net/ice: support optional flags in signature segment header

2024-08-23 Thread Soumyadeep Hore
T set, then as was done before, assume that this is the last segment being downloaded. However, if the flag field's valid bit IS set, then use the last segment flag to determine if this segment is the last segment to download. Signed-off-by: Dan Nowlin Signed-off-by: Soumyadeep Hore --- d

[PATCH v3 11/12] net/ice: update E830 50G branding strings

2024-08-23 Thread Soumyadeep Hore
From: Paul Greenwalt Update E830 50G branding strings from "E830-XXV" to "E830-L". Signed-off-by: Paul Greenwalt Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 6 +++--- drivers/net/ice/base/ice_devids.h | 12 ++-- drivers/net/ice/ic

[PATCH v3 12/12] net/ice: add support for FEC auto-detect for E830

2024-08-23 Thread Soumyadeep Hore
enable FEC auto-detect support for E830 adapters. Signed-off-by: Przemyslaw Gierszynski Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index

[PATCH v1] net/ice: fix incorrect reading of PHY timestamp

2024-08-23 Thread Soumyadeep Hore
In E830 adapters, PHY timestamp for Tx packets should be read once the ready status of PHY timestamp registers is 1. Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp

[PATCH 00/25] Update IDPF Base Driver

2024-05-28 Thread Soumyadeep Hore
This patchset updates IDPF base driver to latest shared code snapshot. Soumyadeep Hore (25): common/idpf: added NVME CPF specific code with defines common/idpf: updated IDPF VF device ID common/idpf: update ADD QUEUE GROUPS offset common/idpf: update in PTP message validation common

[PATCH 01/25] common/idpf: added NVME CPF specific code with defines

2024-05-28 Thread Soumyadeep Hore
The aim of the changes is to remove NVME dependency on memory allocations, and to use a prepared buffer instead. The changes do not affect other components. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 27 +--- drivers/common/idpf/base

[PATCH 02/25] common/idpf: updated IDPF VF device ID

2024-05-28 Thread Soumyadeep Hore
Update IDPF VF device id to 145C removing the support for legacy AVF of 0x1889. In accordance to DCR-3788 added device ID for S-IOV device. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_devids.h | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a

[PATCH 03/25] common/idpf: update ADD QUEUE GROUPS offset

2024-05-28 Thread Soumyadeep Hore
ved unnecessary zero init Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h index 3900b784d0..f44c0965b4

[PATCH 04/25] common/idpf: update in PTP message validation

2024-05-28 Thread Soumyadeep Hore
When the message for getting timestamp latches is sent by the driver, number of latches is equal to 0. Current implementation of message validation function incorrectly notifies this kind of message length as invalid. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4

[PATCH 05/25] common/idpf: added FLOW STEER capability and a vport flag

2024-05-28 Thread Soumyadeep Hore
Removed unused VIRTCHNL2_CAP_ADQ capability and use that bit for VIRTCHNL2_CAP_INLINE_FLOW_STEER capability. Added VIRTCHNL2_VPORT_INLINE_FLOW_STEER_ENA port flag to allow enable/disable per vport. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 5 +++-- 1 file

[PATCH 06/25] common/idpf: moved the IDPF HW into API header file

2024-05-28 Thread Soumyadeep Hore
resolved in CP by bringing their own idpf_hw definition but that's not the case for other components which wanted to use the idpf_hw directly from the shared code. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.h | 110 +-- drivers/common/idpf

[PATCH 07/25] common/idpf: avoid defensive programming

2024-05-28 Thread Soumyadeep Hore
reasoning works for other components as well. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c index 0ba7281a45..4d31c6e6d8 10

[PATCH 08/25] common/idpf: move related defines into enums

2024-05-28 Thread Soumyadeep Hore
header description based on upstream feedback. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 2042 ++--- drivers/common/idpf/base/virtchnl2_lan_desc.h | 859 --- 2 files changed, 1783 insertions(+), 1118 deletions(-) diff --git a/drivers/common

[PATCH 09/25] common/idpf: add flex array support to virtchnl2 structures

2024-05-28 Thread Soumyadeep Hore
virtchnl2_queue_groups structure to better support the flex array. virtchnl2_vc_validate_vf_msg function is refactored to consider the cases where CP/driver supports or doesn't support the flex array. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 600

[PATCH 10/25] common/idpf: avoid variable 0-init

2024-05-28 Thread Soumyadeep Hore
Dont initialize the variables if not needed. Also use 'err' instead of 'status', 'ret_code', 'ret' etc. for consistency and change the return label 'sq_send_command_out' to 'err_unlock'. Signed-off-by: Soumyadeep H

[PATCH 11/25] common/idpf: support added for xn transactions

2024-05-28 Thread Soumyadeep Hore
Support added for xn transaction apis to send/receive control queue messages. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_osdep.c | 71 + drivers/common/idpf/base/idpf_osdep.h | 80 - drivers/common/idpf/base/idpf_xn.c| 439 ++ drivers

[PATCH 12/25] common/idpf: rename of VIRTCHNL2 CAP INLINE FLOW STEER

2024-05-28 Thread Soumyadeep Hore
This capability bit indicates both inline as well as side band flow steering capability. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base

[PATCH 13/25] common/idpf: update compiler padding

2024-05-28 Thread Soumyadeep Hore
y padding. Also drop the DECLARE_FLEX_ARRAY macro as it is not needed. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl

[PATCH 14/25] common/idpf: avoid compiler padding

2024-05-28 Thread Soumyadeep Hore
ler padding by using "__packed" structure attribute for the virtchnl2_ptype struct. Also align the structure by using "__aligned(2)" for better code optimization. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 1 file changed, 4 insertions(+

[PATCH 15/25] common/idpf: add wmb before tail

2024-05-28 Thread Soumyadeep Hore
Introduced through customer's feedback in their attempt to address some bugs this introduces a memory barrier before posting ctlq tail. This makes sure memory writes have a chance to take place before HW starts messing with the descriptors. Signed-off-by: Soumyadeep Hore --- drivers/common

[PATCH 16/25] common/idpf: add a new Tx context descriptor structure

2024-05-28 Thread Soumyadeep Hore
Adding a new structure for the context descriptor that contains the support for timesync packets, where the index for timestamping is set. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_lan_txrx.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

[PATCH 17/25] common/idpf: removing redundant implementation

2024-05-28 Thread Soumyadeep Hore
Removing idpf_common.c file and its definitions as it is primarily used for WINDOWS and ESX driver support. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_common.c| 382 -- drivers/common/idpf/base/idpf_prototype.h | 23 -- drivers/common/idpf/base

[PATCH 18/25] common/idpf: removing redundant functionality of virtchnl2

2024-05-28 Thread Soumyadeep Hore
The function virtchnl2_vc_validate_vf_msg() currently has implementation based on Linux 6.5 kernel and is redundant for dpdk. In future if required new implementation will be added. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 326 --- 1

[PATCH 19/25] common/idpf: updating common code of latest base driver

2024-05-28 Thread Soumyadeep Hore
Based on latest implemenation of struct VIRTCHNL_QUEUE_TYPE_RX in virtchnl2.h, qg_info field is removed and its members are updated in the abve mentioned structure. Hence updating the same. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- 1 file changed, 1

[PATCH 20/25] net/cpfl: updating cpfl based on latest base driver

2024-05-28 Thread Soumyadeep Hore
Based on latest implemenation of struct VIRTCHNL_QUEUE_TYPE_RX in virtchnl2.h, qg_info field is removed and its members are added in the above mentioned structure. Hence updating the same. Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_ethdev.c | 28 ++-- 1

[PATCH 21/25] common/idpf: defining ethernet address length macro

2024-05-28 Thread Soumyadeep Hore
Introducing ETH_ALEN macro for mac address length. this definition is used in idpf_xn.c and was missing previously. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/idpf_common_device.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/common/idpf/idpf_common_device.h b

[PATCH 22/25] common/idpf: increasing size of xn index

2024-05-28 Thread Soumyadeep Hore
Increasing size of xn_index in idpf_xn.c from u8 to u16 for fixing compilation warning. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_xn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/idpf_xn.c b/drivers/common/idpf/base

[PATCH 23/25] common/idpf: redefining idpf vc queue switch

2024-05-28 Thread Soumyadeep Hore
unint32_t type has been introduced in the function idpf_vc_queue_switch(). This helps in providing right queue type while calling the function. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/idpf_common_virtchnl.c | 8 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 2 +- 2 files

[PATCH 24/25] net/idpf: updating idpf vc queue switch in idpf

2024-05-28 Thread Soumyadeep Hore
unint32_t type has been introduced in the function idpf_vc_queue_switch(). This helps in providing right queue type while calling the function. Signed-off-by: Soumyadeep Hore --- drivers/net/idpf/idpf_rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH 25/25] net/cpfl: updating idpf vc queue switch in cpfl

2024-05-28 Thread Soumyadeep Hore
unint32_t type has been introduced in the function idpf_vc_queue_switch(). This helps in providing right queue type while calling the function. Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_ethdev.c | 8 drivers/net/cpfl/cpfl_rxtx.c | 8 2 files changed, 8

[PATCH v2 00/21] Update MEV TS Base Driver

2024-06-04 Thread Soumyadeep Hore
These patches integrate the latest changes in MEV TS IDPF Base driver. --- v2: - Changed implementation based on review comments - Fixed compilation errors for Windows, Alpine and FreeBSD --- Soumyadeep Hore (21): common/idpf: added NVME CPF specific code with defines common/idpf: updated

[PATCH v2 01/21] common/idpf: added NVME CPF specific code with defines

2024-06-04 Thread Soumyadeep Hore
Removes NVME dependency on memory allocations and uses a prepared buffer instead. The changes do not affect other components. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 23 +++- drivers/common/idpf/base/idpf_controlq_api.h | 7 +- 2

[PATCH v2 02/21] common/idpf: updated IDPF VF device ID

2024-06-04 Thread Soumyadeep Hore
Update IDPF VF device id to 145C. Also added device ID for S-IOV device. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_devids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/idpf_devids.h b/drivers/common/idpf/base

[PATCH v2 03/21] common/idpf: added new virtchnl2 capability and vport flag

2024-06-04 Thread Soumyadeep Hore
Removed unused VIRTCHNL2_CAP_ADQ capability and use that bit for VIRTCHNL2_CAP_INLINE_FLOW_STEER capability. Added VIRTCHNL2_VPORT_INLINE_FLOW_STEER_ENA port flag to allow enable/disable per vport. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 7 --- 1 file

[PATCH v2 04/21] common/idpf: moved the idpf HW into API header file

2024-06-04 Thread Soumyadeep Hore
definition from controlq.h into api.h resolves the problem. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_common.c | 4 +- drivers/common/idpf/base/idpf_controlq.h | 107 +-- drivers/common/idpf/base/idpf_controlq_api.h | 35 ++ drivers/common/idpf

[PATCH v2 05/21] common/idpf: avoid defensive programming

2024-06-04 Thread Soumyadeep Hore
a bug and should be fixed rather than checking for NULL pointer and falling back which is not the right way. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/

[PATCH v2 06/21] common/idpf: use BIT ULL for large bitmaps

2024-06-04 Thread Soumyadeep Hore
For bitmaps greater than 32 bits, use BIT_ULL instead of BIT macro as reported by compiler. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/common/idpf/base

[PATCH v2 07/21] common/idpf: convert data type to 'le'

2024-06-04 Thread Soumyadeep Hore
'u32' data type is used for the struct members in 'virtchnl2_version_info' which should be '__le32'. Make the change accordingly. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH v2 08/21] common/idpf: compress RXDID mask definitions

2024-06-04 Thread Soumyadeep Hore
Instead of using the long RXDID definitions, introduce a macro which uses common part of the RXDID definitions i.e. VIRTCHNL2_RXDID_ and the bit passed to generate a mask. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 31 ++- 1 file changed

[PATCH v2 09/21] common/idpf: refactor size check macro

2024-06-04 Thread Soumyadeep Hore
Instead of using 'divide by 0' to check the struct length, use the static_assert macro Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/driv

[PATCH v2 10/21] common/idpf: update mask of Rx FLEX DESC ADV FF1 M

2024-06-04 Thread Soumyadeep Hore
Mask for VIRTCHNL2_RX_FLEX_DESC_ADV_FF1_M was defined wrongly and this patch fixes it. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2_lan_desc.h b/drivers

[PATCH v2 11/21] common/idpf: use 'pad' and 'reserved' fields appropriately

2024-06-04 Thread Soumyadeep Hore
'pad' naming is used if the field is actually a padding byte and is also used for bytes meant for future addition of new fields, whereas 'reserved' is only used if the field is reserved and cannot be used for any other purpose. Signed-off-by: Soumyadeep Hore --- driv

[PATCH v2 12/21] common/idpf: move related defines into enums

2024-06-04 Thread Soumyadeep Hore
variable names modified and comments updated in descriptive way. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 1849 ++--- drivers/common/idpf/base/virtchnl2_lan_desc.h | 843 +--- 2 files changed, 1687 insertions(+), 1005 deletions(-) diff --git a

[PATCH v2 13/21] common/idpf: avoid variable 0-init

2024-06-04 Thread Soumyadeep Hore
Dont initialize the variables if not needed. Also use 'err' instead of 'status', 'ret_code', 'ret' etc. for consistency and change the return label 'sq_send_command_out' to 'err_unlock'. Signed-off-by: Soumyadeep H

[PATCH v2 14/21] common/idpf: update in PTP message validation

2024-06-04 Thread Soumyadeep Hore
When the message for getting timestamp latches is sent by the driver, number of latches is equal to 0. Current implementation of message validation function incorrectly notifies this kind of message length as invalid. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4

[PATCH v2 15/21] common/idpf: rename INLINE FLOW STEER to FLOW STEER

2024-06-04 Thread Soumyadeep Hore
This capability bit indicates both inline as well as side band flow steering capability. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base

[PATCH v2 16/21] common/idpf: add wmb before tail

2024-06-04 Thread Soumyadeep Hore
Introduced through customer's feedback in their attempt to address some bugs this introduces a memory barrier before posting ctlq tail. This makes sure memory writes have a chance to take place before HW starts messing with the descriptors. Signed-off-by: Soumyadeep Hore --- drivers/common

[PATCH v2 17/21] drivers: add flex array support and fix issues

2024-06-04 Thread Soumyadeep Hore
fields for the dynamic sized structures. Some fixes based on code change is introduced to compile dpdk. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 466 - drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/net/cpfl/cpfl_ethdev.c

[PATCH v2 18/21] common/idpf: enable flow steer capability for vports

2024-06-04 Thread Soumyadeep Hore
Added virtchnl2_flow_types to be used for flow steering. Added flow steer cap flags for vport create. Add flow steer flow types and action types for vport create. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 60 ++-- 1 file changed, 57

[PATCH v2 19/21] common/idpf: add a new Tx context descriptor structure

2024-06-04 Thread Soumyadeep Hore
Adding a new structure for the context descriptor that contains the support for timesync packets, where the index for timestamping is set. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_lan_txrx.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

[PATCH v2 21/21] drivers: adding type to idpf vc queue switch

2024-06-04 Thread Soumyadeep Hore
Adding an argument named type to define queue type in idpf_vc_queue_switch(). This solves the issue of improper queue type in virtchnl2 message. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/idpf_common_virtchnl.c | 8 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 2

[PATCH v2 20/21] common/idpf: remove idpf common file

2024-06-04 Thread Soumyadeep Hore
The file is redundant in our implementation and is not required further. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_common.c | 382 - drivers/common/idpf/base/meson.build | 1 - 2 files changed, 383 deletions(-) delete mode 100644 drivers

[PATCH v3 00/22] Update MEV TS Base Driver

2024-06-11 Thread Soumyadeep Hore
These patches integrate the latest changes in MEV TS IDPF Base driver. --- v3: - Removed additional whitespace changes - Fixed warnings of CI - Updated documentation relating to MEV TS FW release --- Soumyadeep Hore (22): common/idpf: added NVME CPF specific code with defines common/idpf

[PATCH v3 01/22] common/idpf: added NVME CPF specific code with defines

2024-06-11 Thread Soumyadeep Hore
Removes NVME dependency on memory allocations and uses a prepared buffer instead. The changes do not affect other components. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 23 +++- drivers/common/idpf/base/idpf_controlq_api.h | 7 +- 2

[PATCH v3 02/22] common/idpf: updated IDPF VF device ID

2024-06-11 Thread Soumyadeep Hore
Update IDPF VF device id to 145C. Also added device ID for S-IOV device. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_devids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/idpf_devids.h b/drivers/common/idpf/base

[PATCH v3 03/22] common/idpf: added new virtchnl2 capability and vport flag

2024-06-11 Thread Soumyadeep Hore
Removed unused VIRTCHNL2_CAP_ADQ capability and use that bit for VIRTCHNL2_CAP_INLINE_FLOW_STEER capability. Added VIRTCHNL2_VPORT_INLINE_FLOW_STEER_ENA port flag to allow enable/disable per vport. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 7 --- 1 file

[PATCH v3 04/22] common/idpf: moved the idpf HW into API header file

2024-06-11 Thread Soumyadeep Hore
definition from controlq.h into api.h resolves the problem. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_common.c | 4 +- drivers/common/idpf/base/idpf_controlq.h | 107 +-- drivers/common/idpf/base/idpf_controlq_api.h | 35 ++ drivers/common/idpf

[PATCH v3 05/22] common/idpf: avoid defensive programming

2024-06-11 Thread Soumyadeep Hore
a bug and should be fixed rather than checking for NULL pointer and falling back which is not the right way. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/

[PATCH v3 06/22] common/idpf: use BIT ULL for large bitmaps

2024-06-11 Thread Soumyadeep Hore
For bitmaps greater than 32 bits, use BIT_ULL instead of BIT macro as reported by compiler. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/common/idpf/base

[PATCH v3 07/22] common/idpf: convert data type to 'le'

2024-06-11 Thread Soumyadeep Hore
'u32' data type is used for the struct members in 'virtchnl2_version_info' which should be '__le32'. Make the change accordingly. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH v3 08/22] common/idpf: compress RXDID mask definitions

2024-06-11 Thread Soumyadeep Hore
Instead of using the long RXDID definitions, introduce a macro which uses common part of the RXDID definitions i.e. VIRTCHNL2_RXDID_ and the bit passed to generate a mask. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 31 ++- 1 file changed

[PATCH v3 09/22] common/idpf: refactor size check macro

2024-06-11 Thread Soumyadeep Hore
Instead of using 'divide by 0' to check the struct length, use the static_assert macro Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/driv

  1   2   3   >