[dpdk-dev] how to build 'example' folder in dpdk-2.2.0?

2017-06-08 Thread Sam
hi all, I want to build example(DPDK_HOME/example/*) in dpdk, and to have a look at vhost demo. But I can't find guide in dpdk home page or document. So is there some document to tell me HOWTO?

[dpdk-dev] Does ovs-dpdk support QoS on dpdkvhostuser port and other port?

2017-06-11 Thread Sam
Hi, all Does ovs-dpdk support QoS on dpdkvhostuser port and other port, just like 'HTB' for kernel based ovs port? Or will ovs-dpdk support this?

[dpdk-dev] [DPDK-memory] how qemu waste such long time under dpdk huge page envriment?

2017-06-16 Thread Sam
Hi all, I'm running `QEMU_CMD ...` to create a vm under dpdk huge page envriment (which set huge page 1G). And I enable all events in qemu. For qemu and ovs-dpdk(ovs-2.4.9 with dpdk-2.2.0) environment, detail log is: > 30012@1497443246.678304:object_dynamic_cast_assert qemu:memory-region->qemu:m

Re: [dpdk-dev] [DPDK-memory] how qemu waste such long time under dpdk huge page envriment?

2017-06-16 Thread Sam
BTW, while running ovs-dpdk, this log is also take long time, does that mean dpdk request large memory take long time? EAL: Setting up physically contiguous memory... 2017-06-16 16:11 GMT+08:00 Sam : > Hi all, > > I'm running `QEMU_CMD ...` to create a vm under dpdk huge

Re: [dpdk-dev] [DPDK-memory] how qemu waste such long time under dpdk huge page envriment?

2017-06-18 Thread Sam
map` system call, I don't found this system call waste too much time. WHY 2017-06-16 16:59 GMT+08:00 Bruce Richardson : > On Fri, Jun 16, 2017 at 04:26:40PM +0800, Sam wrote: > > BTW, while running ovs-dpdk, this log is also take long time, does that > > mean dpdk r

Re: [dpdk-dev] [DPDK-memory] how qemu waste such long time under dpdk huge page envriment?

2017-06-18 Thread Sam
Additional, this is DPDK-QEMU enviroment. 2017-06-19 11:12 GMT+08:00 Sam : > Hi, > > I print all system call by `strace -f -T -tt -e trace=all -o output.txt > $QEMU_CMD`, and I found this: > > 5900 11:08:11.288701 nanosleep({0, 1000}, 0x7ff103c13a80) = 0 >> &

[dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Sam
Hi all, We plan to use DPDK on HP host machine with several core and big memory. We plan to use qemu-kvm enviroment. The host will carry 4 or more guest vm and 1 ovs. Ovs-dpdk is much faster then normal ovs, but to use ovs-dpdk, we have to enable huge page globally. My question is, will huge pag

Re: [dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-20 Thread Sam
BTW, we also think about use ovs-dpdk in docker enviroment, but test result said it's not good idea, we don't know why. 2017-06-21 11:32 GMT+08:00 Sam : > Hi all, > > We plan to use DPDK on HP host machine with several core and big memory. > We plan to use qemu-kvm env

Re: [dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-21 Thread Sam
For qemu, I don't know why, as there is no log to report this. 2017-06-21 14:15 GMT+08:00 Pavel Shirshov : > Hi Sam, > > Below I'm saying about KVM. I don't have experience with vbox and others. > 1. I'd suggest don't use dpdk inside of VM if you want to see best

[dpdk-dev] A bug of ixgbevf kernel module

2018-11-06 Thread Sam
Hi all, I'm running OVS-DPDK on server: OVS-2.3.0 DPDK-2.2.0 kernel-centos7.3.1611 And sometimes, VF port could NOT send specific flow packet. So how to deal with this problem and where to report this issue? Thank you~

[dpdk-dev] Where is the padding code in DPDK?

2018-11-12 Thread Sam
Hi all, As we know, ethernet frame must longer then 64B. So if I create rte_mbuf and fill it with just 60B data, will rte_eth_tx_burst add padding data, let the frame longer then 64B If it does, where is the code?

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-12 Thread Sam
And what about vhost-user port? Sam 于2018年11月13日周二 下午3:16写道: > Hi all, > > As we know, ethernet frame must longer then 64B. > > So if I create rte_mbuf and fill it with just 60B data, will > rte_eth_tx_burst add padding data, let the frame longer then 64B > > If it does, where is the code? >

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-12 Thread Sam
And what about rte_vhost_user_rx_burst and rte_vhost_user_tx_burst Sam 于2018年11月13日周二 下午3:17写道: > And what about vhost-user port? > > Sam 于2018年11月13日周二 下午3:16写道: > >> Hi all, >> >> As we know, ethernet frame must longer then 64B. >> >> So if I crea

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-13 Thread Sam
OK, then shortly speaking, DPDK will NOT care about padding. NIC will care about padding while send and recv with NIC. kernel will care about while send and recv with vhostuser port. Is that right? Burakov, Anatoly 于2018年11月13日周二 下午5:29写道: > On 13-Nov-18 7:16 AM, Sam wrote: > &g

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-14 Thread Sam
t; which are typically only 14 + 20 + 20 = 54 bytes (incl. the 14 byte > Ethernet header). > > > > > > Med venlig hilsen / kind regards > > - Morten Brørup > > > >> -Original Message- > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-14 Thread Sam
rte_vhost_dequeue_burst and rte_vhost_enqueue_burst is the same Sam 于2018年11月15日周四 上午10:07写道: > So, to be brief, rte_eth_rx_burst and rte_eth_tx_burst, just send mbuf, > will not do anything. > Is that right? > > Wiles, Keith 于2018年11月15日周四 上午12:19写道: > >> >> &g

[dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Sam
Hi all, I'm debugging OVS2.9.0 and DPDK18.02, I found I could not dump DPDK log like vhost module. How can I dump DPDK log into files? Thank you~

Re: [dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Sam
I want DPDK VHOST module DEBUG level log 2018-05-16 16:27 GMT+08:00 Sam : > Hi all, > > I'm debugging OVS2.9.0 and DPDK18.02, I found I could not dump DPDK log > like vhost module. > > How can I dump DPDK log into files? Thank you~ >

Re: [dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Sam
375Z|00012|dpdk|INFO|EAL: Detected 32 lcore(s) 2018-05-17T02:23:04.375Z|00013|dpdk|ERR|EAL: invalid parameters for --log-level 2018-05-16 21:29 GMT+08:00 Ferruh Yigit : > On 5/16/2018 9:30 AM, Sam wrote: > > I want DPDK VHOST module DEBUG level log > > > > 2018-05

Re: [dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Sam
Oh, it should be user1,8 in dpdk-17.05 OMG 2018-05-17 10:26 GMT+08:00 Sam : > How to set this param... > > I use this, but report me bug: > > sudo /usr/local/bin/ovs-vsctl --no-wait set Open_vSwitch . > other_config:dpdk-extra="--log-level=user1,debug -c 0x40004 -n 4

[dpdk-dev] Bug in OVS2.8.0+DPDK17.05+Intel_82599_IXGBE sriov?

2018-05-17 Thread Sam
Hi all, I'm using OVS2.8.0+DPDK17.05+Intel_82599_IXGBE for test, the vf driver is ixgbevf-4.0.3. I use sriov follow like this: echo 1 > /sys/bus/pci/devices/:01:00.0/max_vfs Then test l3fwd-vf demo, it is OK. Then test OVS2.8.0, and assign pf for ovs like this: ovs-vsctl add-port br_t dpdk-

Re: [dpdk-dev] Bug in OVS2.8.0+DPDK17.05+Intel_82599_IXGBE sriov?

2018-05-18 Thread Sam
I have test dpdk testpmd, it is OK in the same enviroment. Why ovs-dpdk could not work? I think that must be some bug in ovs? 2018-05-18 11:42 GMT+08:00 Sam : > Hi all, > > I'm using OVS2.8.0+DPDK17.05+Intel_82599_IXGBE for test, the vf driver is > ixgbevf-4.0.3. > >

[dpdk-dev] Can't ping through specific IP on ixgbevf bond port

2018-04-03 Thread Sam
Hi all, I'm using OVS2.3.0-DPDK2.2 and ixgbevf-4.0.3 under CentOS-7-3.10.0-514 I bond 2 vf port into bond1. Now some IP can't ping through bond1, and bond1 also can't ping these IP. but at the same time, some IP ping bond1 OK. Is there someone got same problem as I said? Thank you~

[dpdk-dev] [ovs-dpdk-tests] where is ovs-dpdk test case?

2017-08-16 Thread Sam
Hi all, I'm working with ovs-dpdk, I want to run ovs-dpdk test case. But I found there is no test case for 'netdev' type bridge and no test case for ovs-dpdk datapath(which is pmd_thread_main). So my question is where could I find these test cases? Also I change some code in dpdk-vhost client mo

[dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Sam
Hi all, I'm using Ovs-2.8.0 + DPDK-17.05-rc1 with two netdev using mlx5 driver, like this: $ sudo /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status > Network devices using DPDK-compatible driver > > > Network devices using kernel driver > ==

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Sam
- RX desc=128 - RX free threshold=0 > RX threshold registers: pthresh=0 hthresh=0 wthresh=0 > TX queues=1 - TX desc=512 - TX free threshold=0 > TX threshold registers: pthresh=0 hthresh=0 wthresh=0 > TX RS bit threshold=0 - TXQ flags=0x0 > testpmd> 2018-03-28 20:49 GMT+08:

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Sam
KNI also works 2018-03-29 10:03 GMT+08:00 Sam : > But testpmd at the same version of DPDK is OK, like this: > > [gangyewei@yf-mos-test-net07 dpdk]$ sudo > /usr/local/share/openvswitch/scripts/dpdk_nic_bind >> --status >> Network devices usin

[dpdk-dev] Bug in "rte_eth_dev_attach" while using mlx5 pmd driver?

2018-03-29 Thread Sam
Hi all, I'm using OVS-2.8.0 + DPDK-17.05-rc1, with 2 pf and 1 vf port under mlx5 pmd driver, like this: $ sudo /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status > Network devices using DPDK-compatible driver > > > Network devices using kerne

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-29 Thread Sam
Hi all, this is fixed by adding "LDFLAGS=-libverbs" while making. 2018-03-29 10:29 GMT+08:00 Sam : > KNI also works > > 2018-03-29 10:03 GMT+08:00 Sam : > >> But testpmd at the same version of DPDK is OK, like this: >> >> [gangyewei@yf-mos-test-net07 dpdk

Re: [dpdk-dev] Bug in "rte_eth_dev_attach" while using mlx5 pmd driver?

2018-03-29 Thread Sam
; + //} + +rte_eth_dev_get_port_by_name(name, port_id); - *port_id = eth_dev_last_created_port; + //*port_id = eth_dev_last_created_port; ret = 0; err: 2018-03-29 15:00 GMT+08:00 Sam : > Hi all, > > I'm using OVS-2.8.0 + DPDK-17.05-rc1, with 2 pf and 1 vf p

[dpdk-dev] Got bug while using valgrind on OVS-DPDK?

2018-04-02 Thread Sam
Hi all, I want to use valgrind to check if there is memleak of OVS-DPDK's ovs-vswitchd, so I use this command: valgrind ovs-vswitchd ... But got errors like this: the system does not support "RDRNAD" > please check that RTE_MACHINE is set correctly Does that mean valgrind does NOT support OV

Re: [dpdk-dev] Got bug while using valgrind on OVS-DPDK?

2018-04-03 Thread Sam
),)-CPUFLAGS += F16C-endif--ifneq ($(filter $(AUTO_CPUFLAGS),__AVX2__),)-CPUFLAGS += AVX2-endif- 2018-04-03 14:45 GMT+08:00 Sam : > Hi all, > > I want to use valgrind to check if there is memleak of OVS-DPDK's > ovs-vswitchd, so I use this command: > > valgrind ovs-vswitchd .

[dpdk-dev] How to show dpdk memory usage?

2017-09-26 Thread Sam
Hi all, I'm running dpdk application, and this application is always hanged after running for a long time, so I want to see if there is memory leak or something. I think the memory allocate by dpdk api such as "rte_rxmbuf_alloc" is located in memory of a core, not system memory, is it right? If

[dpdk-dev] Dpdk ixgbe driver bug?

2017-09-26 Thread Sam
Hi all, I'm running ovs-dpdk using ixgbe driver with sriov mode. My topology is: vf(ens16) and pf(eth0) is from netdevice 1; vf(ens161) and pf(eth1) is from netdevice 2. Then linux kernel driver bond ens16 and ens161 into bond1, ovs-dpdk bond eth0 and eth1 into dpdkb2 as ovs-dpdk port. I found th

Re: [dpdk-dev] Dpdk ixgbe driver bug?

2017-09-26 Thread Sam
switch means hardware switch attach this PC, not ovs-dpdk 2017-09-27 11:57 GMT+08:00 Sam : > Hi all, > > I'm running ovs-dpdk using ixgbe driver with sriov mode. My topology is: > vf(ens16) and pf(eth0) is from netdevice 1; vf(ens161) and pf(eth1) is from > netdevice 2. Then

[dpdk-dev] How to use ixgbe module log?

2017-09-28 Thread Sam
Hi all, I'm working on ixgbe, I want to enable "PMD_RX_LOG" and "PMD_TX_LOG", how to do this? As for normal application, I could use --log-level param to start, but ixgbe is kernel module, how to do this? Thank you~

Re: [dpdk-dev] How to use ixgbe module log?

2017-09-28 Thread Sam
=all) (int) and I use dpdk_nic_bind with --driver option to bind netdevice with ixgbevf kernel driver. So I think I use ixgbevf kernel module which is distributed with kernel, and my kernel is: 3.10.0-514.10.2.el7 2017-09-28 19:54 GMT+08:00 Burakov, Anatoly : > On 28-Sep-17 11:26 AM, Sam wr

[dpdk-dev] [BUG-REPORT] Need to add mutex on vhost_devices[] in virtio-net.c in DPDK-2.2?

2017-10-11 Thread Sam
Hi all, I'm running vhostuser part code of dpdk, and I found a crash, which is caused by call NULL pointer. Then I debug code and I found I use NULL pointer which is got from vhost_devices[]. I read code of virtio-net.c, and I found there is no lock on vhost_devices[] !!! vhost_devices[] is used

Re: [dpdk-dev] [ovs-dpdk bug] Failing to release memory when QEMU exits?

2017-10-30 Thread Sam
add dpdk 2017-10-31 10:43 GMT+08:00 Sam : > Hi all, > > I found in ovs-dpdk it is failing to release memory when QEMU exits. Is > this a clear bug in ovs-dpdk? If it is, when did this bug fixed? Detail is > bellow: > > > For qemu-2.6.0 and ovs-dpdk, in huge page (1G) env

[dpdk-dev] Please help me to debug memory mis-unmap in ovs-dpdk.

2017-11-01 Thread Sam
Hi all, I'm debugging a mis-unmap bug in ovs-dpdk, process is this: 1. start ovs-dpdk with 10G socket memory, then use `top`, ovs-vswitchd take 10G memory. command is bellow. 2. start qemu vm1 with vhost device as server to connect port on ovs-dpdk, command is bellow. qemu share 40G memory with o

[dpdk-dev] Why I can't get max line speed using ovs-dpdk and vhost-user port?

2017-11-09 Thread Sam
Hi all, I'm using ovs-dpdk with vhost-user port and 10 VM started by qemu, topology is: VM1 ~ VM10 | | -OVS | dpdk-bond the start command of ovs-dpdk is: root 8969 200 0.1 107748696 231284 ?S ovs-vswitchd --dpdk -c 0x40004 -n 4 --socket-mem 10240 --proc

[dpdk-dev] In ovs-2.4 version, why can't stop dpdk-bond port by `ovs-ofctl mod br dpdkbond DOWN`?

2017-11-27 Thread Sam
Hi all, I'm working in ovs 2.4 version, and I use "dpdkb" type netdev. Then I call `ovs-ofctl mod br dpdkbond DOWN` to down this device, at last, my code call "rte_eth_dev_stop(dev->port_id);". But counter shows the port is still rx/tx, why?

Re: [dpdk-dev] In ovs-2.4 version, why can't stop dpdk-bond port by `ovs-ofctl mod br dpdkbond DOWN`?

2017-11-27 Thread Sam
The "dev->port_id" is bond port id, should I use slave port id instead ? 2017-11-27 18:07 GMT+08:00 Sam : > Hi all, > > I'm working in ovs 2.4 version, and I use "dpdkb" type netdev. Then I > call `ovs-ofctl mod br dpdkbond DOWN` to down this device, a

[dpdk-dev] kernel crash bug caused by ixgbevf kernel module of centos-3.10.0-229.20.1.el7

2018-01-29 Thread Sam
I found a bug about ixgbevf kernel module in centos-3.10.0-229.20.1.el7. And this bug is also in 3.10.0-514.10.2.el7. How to produce this bug: use SRIOV first, then add lots of network traffic on vf port, and then ifdow/ifup vf port, after many times, this bug happens. BUG: [308026.586026] ixgbe

Re: [dpdk-dev] kernel crash bug caused by ixgbevf kernel module of centos-3.10.0-229.20.1.el7

2018-01-29 Thread Sam
' if=eth3 drv=igb unused=igb_uio Other network devices = 2018-01-30 10:19 GMT+08:00 Sam : > I found a bug about ixgbevf kernel module in centos-3.10.0-229.20.1.el7. > And this bug is also in 3.10.0-514.10.2.el7. > > How to produce this bug: use SRIOV first, then add lots of network t

Re: [dpdk-dev] Kernel Crash bug of ixgbevf kernel module in "Intel(R) 10GbE PCI Express Virtual Function Driver Version: 4.0.3 Release: 1"

2018-01-30 Thread Sam
wrong order, actually is this: 4. stop bond1(ifdown bond1), stop dpdkb2(rte_eth_dev_stop), sleep 5 second, start dpdkb2(rte_eth_dev_start), start bond1(ifup bond1). 2018-01-31 15:34 GMT+08:00 Sam : > Hi all, > > There is a kernel crash bug of ixgbevf kernel module in "Intel(

Re: [dpdk-dev] Kernel Crash bug of ixgbevf kernel module in "Intel(R) 10GbE PCI Express Virtual Function Driver Version: 4.0.3 Release: 1"

2018-01-31 Thread Sam
). At the same time, "ixgbevf_service_task()" loop to "ixgbevf_reinit_locked()" function. Then two thread operate same address, then bug happens. 2018-01-31 15:44 GMT+08:00 Sam : > wrong order, actually is this: > 4. stop bond1(ifdown bond1), stop dpdkb2(rte_eth_dev_stop

[dpdk-dev] [sriov] [ixgbevf] We have to down PF and VF port to reconfig a port?

2017-12-26 Thread Sam
Hi all, I'm running OVS-DPDK on a two netdevice server(eth0 and eth1), and I use sriov to make one VF and one PF on each netdevice, as bellow. Please omit eth2 and eth3. Then two VF port(enp1s16 and enp1s16f1) combine into linux bond1 port as management port, two PF port(:01:00.0 and :01:0

Re: [dpdk-dev] [sriov] [ixgbevf] We have to down PF and VF port to reconfig a port?

2017-12-26 Thread Sam
2017-12-27 10:42 GMT+08:00 Sam : > Hi all, > > I'm running OVS-DPDK on a two netdevice server(eth0 and eth1), and I use > sriov to make one VF and one PF on each netdevice, as bellow. Please omit > eth2 and eth3. Then two VF port(enp1s16 and enp1s16f1) combine into l

Re: [dpdk-dev] [sriov] [ixgbevf] We have to down PF and VF port to reconfig a port?

2018-01-04 Thread Sam
-mos-test-net14 kernel: [103406.865705] [] x86_64_start_reservations+0x2a/0x2c Dec 27 20:23:22 yf-mos-test-net14 kernel: [103406.865708] [] x86_64_start_kernel+0x152/0x175 Dec 27 20:23:22 yf-mos-test-net14 kernel: [103406.865709] ---[ end trace 45a157a1f564e086 ]--- 2017-12-27 10:54 GMT+08:00 Sam

[PATCH] net/netvsc: add support for mtu_set

2023-10-05 Thread Sam Andrew
: Sam Andrew --- drivers/bus/vmbus/vmbus_common.c | 4 +- drivers/net/netvsc/hn_ethdev.c | 185 +-- drivers/net/netvsc/hn_rndis.c| 7 ++ drivers/net/netvsc/hn_rndis.h| 1 + drivers/net/netvsc/hn_var.h | 3 +- drivers/net/netvsc/hn_vf.c | 23

[PATCH v2] net/netvsc: add support for mtu_set

2023-10-06 Thread Sam Andrew
: Sam Andrew --- v2: Fix coding style issue --- drivers/bus/vmbus/vmbus_common.c | 4 +- drivers/net/netvsc/hn_ethdev.c | 185 +-- drivers/net/netvsc/hn_rndis.c| 7 ++ drivers/net/netvsc/hn_rndis.h| 1 + drivers/net/netvsc/hn_var.h | 3 +- drivers

RE: [EXTERNAL] Re: [PATCH] net/netvsc: add support for mtu_set

2023-10-09 Thread Sam Andrew
Hi Stephen, From: Stephen Hemminger Sent: Monday, October 9, 2023 8:18 AM > On Thu, 5 Oct 2023 23:17:28 + > Sam Andrew wrote: > > + > > +static int > > +hn_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > > + struct hn_data *hv = dev->data-&

[PATCH v3] net/netvsc: add support for mtu_set

2023-10-10 Thread Sam Andrew
: Sam Andrew Acked-by: Stephen Hemminger --- v3: If device is not stopped when MTU change attempted, return -EBUSY, instead of -EIO. Fix additional coding style issue. v2: Fix coding style issue. --- drivers/bus/vmbus/vmbus_common.c | 6 +- drivers/net/netvsc/hn_ethdev.c | 185

TCP stack support on DPDK

2023-01-20 Thread Sam Kirubakaran
Hi team, My name is Sam and I am a Software Engineer. Currently, we are trying to improve the performance of proprietary in-house tools by using DPDK but we are not sure whether DPDK has support for TCP stack. If yes, could you please point me to the link of apis alone. I will take it from there

Re: TCP stack support on DPDK

2023-01-23 Thread Sam Kirubakaran
Hi Thomas, Thank you so much for your response :) I will go through the link you shared and make use of it! Regards, Sam On Fri, Jan 20, 2023 at 6:48 PM Thomas Monjalon wrote: > 20/01/2023 09:11, Sam Kirubakaran: > > Hi team, > > > > My name is Sam and I am a Software En

Re: TCP stack support on DPDK

2023-01-25 Thread Sam Kirubakaran
please let me know any viable solution to make use of user space TCP stack compatible with Python? Regards, Sam On Mon, Jan 23, 2023 at 3:48 PM Liang Ma wrote: > On Fri, Jan 20, 2023 at 01:41:56PM +0530, Sam Kirubakaran wrote: > > Hi team, > > > > My name is Sam and I a

RE: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-03 Thread Sam Andrew
Thank you so much, Alexander. I’ve reviewed the patch. It looks good to me as well. Reviewed-by: Sam Andrew mailto:samand...@microsoft.com>> From: Alexander Skorichenko Sent: Wednesday, July 3, 2024 3:14 AM To: Long Li Cc: step...@networkplumber.org; Sam Andrew ; ferruh.yi...@a