0d7cc88335 ("ethdev: release queue before setting up")
[2] http://dpdk.org/ml/archives/dev/2017-January/056470.html
--
Pascal Mazon
www.6wind.com
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 8faf08551b9e..4cc1767da5e8 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net
ermore, creating
several tap vdev would point to the same netdevice.
In any case, it must to be consistent with the tun_alloc() call in
eth_dev_tap_create().
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --
pmd->fds[0], pmd->rxq[0] and pmd->txq[0] are set a couple of lines after
the for loop that initializes them to -1.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/driver
There's no point in having a different internal MAC address than the one
provided by the kernel when creating the netdevice.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/net/tap/rte_eth_ta
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 734e3a579219..9b6bbff5fd81 100644
--- a/drivers/net/tap/rte_eth_tap.c
The probe parses for user-defined iface name. Let's use that value.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index f8b07b4
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
Pascal Mazon wrote:
dev->data->name contains "net_tap", the device driver name.
I see what patch does, just as a note to commit log:
AFAIK, "dev->data->name" is device name, and for this ca
On 01/31/2017 02:21 PM, Ferruh Yigit wrote:
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap
On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
On 1/31/2017 2:23 PM, Pascal Mazon wrote:
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
Pascal Mazon wrote:
dev->data->name contains "net_tap", the device driver name.
I see what patch does, just as a note to
On 01/31/2017 04:44 PM, Wiles, Keith wrote:
On Jan 31, 2017, at 9:38 AM, Yigit, Ferruh wrote:
On 1/31/2017 3:30 PM, Pascal Mazon wrote:
On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
On 1/31/2017 2:23 PM, Pascal Mazon wrote:
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42
would be best done using tap_link_set() in those
functions.
--
Pascal Mazon
www.6wind.com
On 02/01/2017 12:29 AM, Wiles, Keith wrote:
On Jan 31, 2017, at 10:39 AM, Pascal Mazon wrote:
On 01/31/2017 05:06 PM, Wiles, Keith wrote:>
Looking at the changes to set the link up/down and the adding the two
functions. I noticed in the stop/start routines I was set the link in DPDK
On 02/01/2017 04:25 PM, Wiles, Keith wrote:
On Feb 1, 2017, at 2:11 AM, Pascal Mazon wrote:
On 02/01/2017 12:29 AM, Wiles, Keith wrote:
On Jan 31, 2017, at 10:39 AM, Pascal Mazon wrote:
On 01/31/2017 05:06 PM, Wiles, Keith wrote:>
Looking at the changes to set the link up/down and
On 02/01/2017 06:50 PM, Ferruh Yigit wrote:
On 2/1/2017 3:55 PM, Wiles, Keith wrote:
On Feb 1, 2017, at 9:40 AM, Pascal Mazon wrote:
On 02/01/2017 04:25 PM, Wiles, Keith wrote:
On Feb 1, 2017, at 2:11 AM, Pascal Mazon wrote:
On 02/01/2017 12:29 AM, Wiles, Keith wrote:
On Jan 31
On Thu, Feb 2, 2017 at 9:05 AM, Pascal Mazon wrote:
> On 02/01/2017 06:50 PM, Ferruh Yigit wrote:
>
>> On 2/1/2017 3:55 PM, Wiles, Keith wrote:
>>
>>>
>>> On Feb 1, 2017, at 9:40 AM, Pascal Mazon wrote:
>>>>
>>>> On 02/01/2017 04:25 P
dev->data->name contains the device name, e.g. "net_tap0".
dev->data->dev_private->name contains the actual iface name,
e.g. "dtap0".
In any case, the name must to be consistent with the tun_alloc() call in
eth_dev_tap_create().
Signed-off-by: Pascal Mazon
pmd->fds[0], pmd->rxq[0] and pmd->txq[0] are set a couple of lines after
the for loop that initializes them to -1.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/driver
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 8faf08551b9e..4cc1767da5e8 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net
There's no point in having a different internal MAC address than the one
provided by the kernel when creating the netdevice.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/net/tap/rte_eth_ta
The probe parses for user-defined iface name. Let's use that value.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index f8b07b4
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 67 +++
1 file changed, 62 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 734e3a579219..275af9df2252 100644
--- a/drivers/net
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 40
1 file changed, 40 insertions(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 275af9df2252..3f179c3dfb3c 100644
--- a/drivers/net/tap/rte_eth_tap.c
On Thu, 2 Feb 2017 16:33:26 -0600
Keith Wiles wrote:
> Signed-off-by: Keith Wiles
> ---
> doc/guides/nics/tap.rst | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst
> index 622b9e7..2ab60ff 100644
> --- a/d
On Thu, 2 Feb 2017 16:33:27 -0600
Keith Wiles wrote:
> Signed-off-by: Keith Wiles
> ---
> drivers/net/tap/rte_eth_tap.c | 93
> ++- 1 file changed, 48 insertions(+),
> 45 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_e
RTE_LOG(ERR, PMD, "Unable to get MAC address\n");
> @@ -851,8 +847,8 @@ rte_pmd_tap_remove(const char *name)
>
> internals = eth_dev->data->dev_private;
> for (i = 0; i < internals->nb_queues; i++)
> - if (internals->fds[i] != -1)
> - close(internals->fds[i]);
> + if (internals->rxq[i].fd != -1)
> + close(internals->rxq[i].fd);
>
> rte_free(eth_dev->data->dev_private);
> rte_free(eth_dev->data);
Acked-by: Pascal Mazon
_LOG(NOTICE, PMD, "Initializing pmd_tap for %s as %s\n",
> name, tap_name);
>
> ret = eth_dev_tap_create(name, tap_name);
>
> leave:
> if (ret == -1) {
> - RTE_LOG(INFO, PMD, "Failed to create pmd for %s as %s\n",
> + RTE_LOG(ERR, PMD, "Failed to create pmd for %s as %s\n",
> name, tap_name);
> tap_unit--; /* Restore the unit number */
> }
> @@ -837,7 +836,7 @@ rte_pmd_tap_remove(const char *name)
> struct pmd_internals *internals;
> int i;
>
> - RTE_LOG(INFO, PMD, "Closing TUN/TAP Ethernet device on numa %u\n",
> + RTE_LOG(DEBUG, PMD, "Closing TUN/TAP Ethernet device on numa %u\n",
> rte_socket_id());
>
> /* find the ethdev entry */
Acked-by: Pascal Mazon
= 0) || !addr)
> return -1;
>
> memset(&ifr, 0, sizeof(ifr));
> @@ -725,7 +721,7 @@ eth_dev_tap_create(const char *name, char *tap_name)
> pmd->rxq[0].fd = fd;
> pmd->txq[0].fd = fd;
>
> - if (pmd_mac_address(fd, dev, &pmd->eth_addr) < 0) {
> + if (pmd_mac_address(fd, &pmd->eth_addr) < 0) {
> RTE_LOG(ERR, PMD, "Unable to get MAC address\n");
> goto error_exit;
> }
Acked-by: Pascal Mazon
On Sun, 5 Feb 2017 10:05:07 -0600
Keith Wiles wrote:
> At the same time remove the code which created the first device queue
> at probe time. Now all queues are created during queue setup calls.
>
> Signed-off-by: Keith Wiles
> ---
> drivers/net/tap/rte_eth_tap.c | 104
> ++---
On Sun, 5 Feb 2017 10:05:09 -0600
Keith Wiles wrote:
> Signed-off-by: Keith Wiles
> ---
> drivers/net/tap/rte_eth_tap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 65e4bab..966e91a 100644
> --
= dev->data->dev_private;
> +
> + tap_link_set_down(dev);
> +
> + for (i = 0; i < internals->nb_queues; i++) {
> + if (internals->rxq[i].fd != -1)
> + close(internals->rxq[i].fd);
> + internals->rxq[i].fd = -1;
> + internals->txq[i].fd = -1;
> + }
> }
>
> static void
Ok, the series looks good to me.
Acked-by: Pascal Mazon
Acked-by: Pascal Mazon
On 07/06/2017 05:28 PM, Thomas Monjalon wrote:
Some logs are missing the newline character \n.
The logs using only line can be checked with this command:
git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
Fixes: 02f96a0a82d1 ("net/ta
Hi Raslan,
Your patch looks ok at first glance. However, I couldn't test it as it
does not apply on a
fresh next-net branch. Can you send a v2 after rebase?
Thank you.
Pascal
On 07/10/2017 10:13 AM, Raslan Darawsheh wrote:
Remove checks of Linux kernel version
in order to support kernel wit
Hello Raslan,
So I've compiled your code, and it looks fine.
Just one remark:
When trying to _create_ a rule, the error message keep stating
"overlapping rules".
That was fine before, at it was the main cause of error.
But now it is also likely that the error comes from the kernel not
suppor
Ok for me.
Cheers,
Pascal
Acked-by: Pascal Mazon
On 07/17/2017 11:00 AM, Raslan Darawsheh wrote:
Remove checks of Linux kernel version
in order to support kernel with backported features.
the expected behavior with a kernel that doesn't support flower
and other bits is the foll
Support for segmented packets (scatter/gather) is mandatory for most
purposes, regardless of the MTU size. Tx packets are often the result of
mbuf concatenation, and an mbuf is not necessarily large enough for Rx
packets to fit in a single one.
Signed-off-by: Pascal Mazon
Acked-by: Keith Wiles
On Tue, 21 Mar 2017 15:32:06 +
"Wiles, Keith" wrote:
>
> Just noticed this new header does not have the C++ ifdefs. Create a
> new patch to fix this problem, unless you need to update this patch
> series. Just starting my review of this one, sorry was traveling last
> week.
>
> Regards,
> K
Reflect device link status according to the state of the tap netdevice
and the remote netdevice (if any). If both are UP and RUNNING, then the
device link status is set to ETH_LINK_UP, otherwise ETH_LINK_DOWN.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 32
This commit implements link status notification through netlink.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 65 ++--
drivers/net/tap/rte_eth_tap.h| 1 +
drivers/net/tap/tap_netlink.c
In the next patch, access to struct pmd_internals will be necessary in
tap_flow.c to store the flows.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
drivers/net/tap/Makefile | 1 +
drivers/net/tap/rte_eth_tap.c | 36 ++---
drivers/net/tap/rte_eth_tap.h | 75
p of "net/tap: add additional management ops" series
v2 changes:
- support compilation on kernels < 4.2 (where flower support appeared)
- set whitespaces in tap.h
- remove unnecessary goto
Pascal Mazon (4):
net/tap: move private elements to external header
net/tap: add preliminary
brary to help that communication.
Inside netlink.c, functions are generic for any netlink messaging.
Inside tcmsgs.c, functions are specific to deal with TC rules.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
drivers/net/tap/Makefile | 2 +
drivers/net/tap/tap_netlink.c
The flow API provides the ability to classify packets received by a tap
netdevice.
This patch only implements skeleton functions for flow API support, no
patterns are supported yet.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap
nfig.sh.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
doc/guides/nics/tap.rst | 23 ++
drivers/net/tap/Makefile | 40 ++
drivers/net/tap/rte_eth_tap.c | 61 ++-
drivers/net/tap/rte_eth_tap.h | 3 +
drivers/net/tap/tap_flow.c| 911
In the next patch, access to struct pmd_internals will be necessary in
tap_flow.c to store the flows.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
Acked-by: Keith Wiles
---
drivers/net/tap/Makefile | 1 +
drivers/net/tap/rte_eth_tap.c | 36 ++---
drivers/net/tap
brary to help that communication.
Inside netlink.c, functions are generic for any netlink messaging.
Inside tcmsgs.c, functions are specific to deal with TC rules.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
Acked-by: Keith Wiles
---
drivers/net/tap/Makefile | 2 +
drivers/ne
te doc/guides/nics/tap.rst for Flow API support
- rebase on top of "net/tap: add additional management ops" series
v2 changes:
- support compilation on kernels < 4.2 (where flower support appeared)
- set whitespaces in tap.h
- remove unnecessary goto
Pascal Mazon (4):
net/tap: mo
The flow API provides the ability to classify packets received by a tap
netdevice.
This patch only implements skeleton functions for flow API support, no
patterns are supported yet.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
Acked-by: Keith Wiles
---
doc/guides/nics/features/tap.ini
nfig.sh.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
Acked-by: Keith Wiles
---
doc/guides/nics/tap.rst | 45 +++
drivers/net/tap/Makefile | 40 ++
drivers/net/tap/rte_eth_tap.c | 61 ++-
drivers/net/tap/rte_eth_tap.h | 3 +
drivers/net/
correctly handle terminating \0
v2 changes:
- rebase on top of updated "net/tap: support flow API"
- fix implicit flow flush when closing the netdevices
Pascal Mazon (1):
net/tap: add remote netdevice traffic capture
doc/guides/nics/tap.rst | 16 ++
drivers/net/tap/rt
emote"
parameter.
Packets matching filtering rules created with the flow API are matched
on the remote device and redirected to the tap PMD, where the relevant
action will be performed.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
Acked-by: Keith Wiles
---
doc/guides/nics/tap.rst
On Fri, 24 Mar 2017 16:02:48 +
Ferruh Yigit wrote:
> On 3/22/2017 2:11 PM, Wiles, Keith wrote:
> >
> >> On Mar 22, 2017, at 3:40 AM, Pascal Mazon
> >> wrote:
> >>
> >> Reflect device link status according to the state of the tap
> >> ne
On Mon, 27 Mar 2017 12:21:45 +0100
Ferruh Yigit wrote:
>
> There isn't time left for this release, proposal (v1) deadline is
> passed long ago. Almost integration deadline is hit (end of this
> week).
>
> If your other patches slip into next release, can you please send a
> release notes updates
Signed-off-by: Pascal Mazon
---
doc/guides/rel_notes/release_17_05.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/rel_notes/release_17_05.rst
b/doc/guides/rel_notes/release_17_05.rst
index dee63919efe7..4ab3e1a740c0 100644
--- a/doc/guides/rel_notes
whether the
kernel returned -EEXIST when requiring the qdisc creation. It's simpler
and faster.
Add a few messages for clarity when a netlink error occurs.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c| 22 -
drivers/net/tap/tap_netlink.c
This is necessary to ensure packets with the new MAC address as
destination get redirected to the tap device.
Also make the change only if the requested MAC address is different from
the current one.
Fixes: 75b6a1f7f004 ("net/tap: add remote netdevice traffic capture")
Signed-off-
Only full mask (0x) is accepted, there is no way to specify a mask
for layer 4 ports to the kernel using TC rules.
Fixes: 1c71189ab9b7 ("net/tap: add basic flow API patterns and actions")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c | 20
1 fi
the packet will be discarded.
Fixes: 4a6bb33dc67c ("net/tap: support segmented mbufs")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4cb6e4957..46c23a48b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -398,7 +398,7 @@ F: drivers/net/pcap/
> F: doc/guides/nics/pcap_ring.rst
>
> Tap PMD
> -M:
traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 85 ---
1 file changed, 48 insertions(+), 37 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6567bba75b47..72897adcce3b 100644
-
This is necessary to ensure packets with the new MAC address as
destination get redirected to the tap device.
Also change the MAC address only if the current one is different from
the requested one.
Fixes: 75b6a1f7f004 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pa
el's error message:
[PATCH 1/2] net/tap: update netlink error code management
- 1 patch for MAC address: update remote MAC address redirection:
[PATCH 2/2] net/tap: update redirection rule after MAC change
Pascal Mazon (3):
net/tap: update netlink error code management
net/ta
whether the
kernel returned -EEXIST when requiring the qdisc creation. It's simpler
and faster.
Add a few messages for clarity when a netlink error occurs.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c| 22 -
drivers/net/tap/tap_netlink.c
traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 85 ---
1 file changed, 48 insertions(+), 37 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6567bba75b47..72897adcce3b 100644
-
This is necessary to ensure packets with the new MAC address as
destination get redirected to the tap device.
Also change the MAC address only if the current one is different from
the requested one.
Fixes: 75b6a1f7f004 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pa
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 doc/guides/nics/features/tap.ini
diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
new file mode 100644
index
The call to rte_eth_dev_allocate(tap_name) sets dev->data->name to
tap_name (e.g. "dtap0").
A look-up using tap_name is expected to return this device, not a
look-up using name (e.g. "net_tap0").
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1
Signed-off-by: Pascal Mazon
---
app/test-pmd/cmdline.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 43fc6366f279..4bbefa43966e 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -405,6
A tap netdevice actually receives every packet, without any filtering
whatsoever. There is no need for any multicast address registration
to receive multicast packets.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 13 +
2
Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet type.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 15 +++
2 files changed, 16 insertions(+)
diff --git a/doc/guides/nics/features/tap.ini b/doc/guides
up_queue(),
after it's been set.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 88 ++--
2 files changed, 76 insertions(+), 13 deletions(-)
diff --git a/doc/guides/nics/features/tap.ini b/do
A tap netdevice does not support flow control; ensure nothing but
RTE_FC_NONE mode can be set.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 19 +++
2 files changed, 20 insertions(+)
diff --git a/doc/guides/nics
Tap PMD is flexible, it supports any speed.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 35 +++
2 files changed, 36 insertions(+)
diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics
Add a few eth_dev ops to the tap PMD for completeness.
We want it to behave as much as possible as a standard PMD.
Pascal Mazon (6):
net/tap: add MAC address management ops
net/tap: add speed capabilities
net/tap: add multicast addresses management
net/tap: add MTU management
net/tap
The MTU is assigned to the tap netdevice according to the argument, but
packet transmission and reception just write/read on an fd with the
default limit being the socket buffer size.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 37
actions defined in the flow API.
This series applies on top of:
[PATCH 0/6] net/tap: add additional management ops
Pascal Mazon (4):
net/tap: move private elements to external header
net/tap: add preliminary support for rte_flow
net/tap: add netlink back-end for flow API
net/tap: add basic
In the next patch, access to struct pmd_internals will be necessary in
tap_flow.c to store the flows.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
drivers/net/tap/Makefile | 1 +
drivers/net/tap/rte_eth_tap.c | 34 ++--
drivers/net/tap/tap.h | 73
nfig.sh.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
drivers/net/tap/Makefile | 35 ++
drivers/net/tap/rte_eth_tap.c | 33 +-
drivers/net/tap/tap.h | 1 +
drivers/net/tap/tap_flow.c| 891 +-
drivers/net/tap/tap_flow.h| 12
brary to help that communication.
Inside netlink.c, functions are generic for any netlink messaging.
Inside tcmsgs.c, functions are specific to deal with TC rules.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
drivers/net/tap/Makefile | 2 +
drivers/net/tap/tap_netlink.c
The flow API provides the ability to classify packets received by a tap
netdevice.
This patch only implements skeleton functions for flow API support, no
patterns are supported yet.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap
emote"
parameter.
Packets matching filtering rules created with the flow API are matched
on the remote device and redirected to the tap PMD, where the relevant
action will be performed.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
doc/guides/nics/tap.rst | 17 ++
drive
change the tap MAC address, using
standard DPDK APIs. It sets that MAC address on the tap PMD and redirect
any packets matching that destination MAC to the tap PMD. It also tries
setting the MAC address directly on the remote, if supported, through
ioctl() calls.
Signed-off-by: Pascal Mazon
Acked
upport as flow rules will be
configured on the remote netdevice for redirection, using the same
mechanism.
This series applies on top of:
[PATCH 0/4] net/tap: support flow API
Pascal Mazon (4):
net/tap: add remote netdevice traffic capture
net/tap: reflect tap flags on the remote
net/tap
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 98b466aba223..141fc7944a5f 100644
--- a/drivers/net/tap
Synchronize PROMISC and ALLMULTI flags to the remote netdevice if
possible.
Leave the IFF_UP flag as it is, however.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
---
drivers/net/tap/rte_eth_tap.c | 36 +++-
drivers/net/tap/tap.h | 1 +
2 files
is done in
rte_eth_dev_allocate()/rte_eth_dev_data_alloc().
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 47a706070652..839c4187
On Fri, 3 Mar 2017 15:27:12 +
"Wiles, Keith" wrote:
>
> > On Mar 3, 2017, at 3:46 AM, Pascal Mazon
> > wrote:
> >
> > Tap PMD is flexible, it supports any speed.
> >
> > Signed-off-by: Pascal Mazon
> > ---
> > doc/guides/n
On Fri, 3 Mar 2017 15:23:28 +
"Wiles, Keith" wrote:
>
> > On Mar 3, 2017, at 3:46 AM, Pascal Mazon
> > wrote:
> >
> > The MTU is assigned to the tap netdevice according to the argument,
> > but packet transmission and reception just write/read on
On Fri, 3 Mar 2017 15:31:14 +
"Wiles, Keith" wrote:
>
> > On Mar 3, 2017, at 3:46 AM, Pascal Mazon
> > wrote:
> >
> > Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet
> > type.
> >
> > Signed-off-by: Pascal M
On Fri, 3 Mar 2017 15:38:11 +
"Wiles, Keith" wrote:
>
> > On Mar 3, 2017, at 4:45 AM, Pascal Mazon
> > wrote:
> >
> > In the next patch, access to struct pmd_internals will be necessary
> > in tap_flow.c to store the flows.
> >
> >
On Fri, 3 Mar 2017 15:47:58 +
"Wiles, Keith" wrote:
>
> > On Mar 3, 2017, at 4:45 AM, Pascal Mazon
> > wrote:
> >
> > Supported flow rules are now mapped to TC rules on the tap
> > netdevice. The netlink message used for creating the TC rule is
On Mon, 6 Mar 2017 14:27:18 +
Ferruh Yigit wrote:
> On 3/6/2017 1:51 PM, Pascal Mazon wrote:
> > Store the device name in dev->data->name, to have symmetrical
> > behavior between rte_pmd_tap_probe(name) and
> > rte_pmd_tap_remove(name).
> >
> > The n
er to the rte_ethdev_allocate()
as it should use the same name.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 47a706070652..ece3a5fcc897 100644
--- a/driver
On Mon, 6 Mar 2017 15:41:14 +
Ferruh Yigit wrote:
> On 3/6/2017 3:13 PM, Pascal Mazon wrote:
> > Store the device name in dev->data->name, to have symmetrical
> > behavior between rte_pmd_tap_probe(name) and
> > rte_pmd_tap_remove(name).
> >
> > The n
up_queue(),
after it's been set.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 88 ++--
2 files changed, 76 insertions(+), 13 deletions(-)
diff --git a/doc/guides/nics/features/tap.ini b/do
Tap PMD is flexible, it supports any speed.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 35 +++
2 files changed, 36 insertions(+)
diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics
Add a few eth_dev ops to the tap PMD for completeness.
We want it to behave as much as possible as a standard PMD.
v2 change:
- use snprintf in tap_mtu set
Pascal Mazon (6):
net/tap: add MAC address management ops
net/tap: add speed capabilities
net/tap: add multicast addresses
A tap netdevice actually receives every packet, without any filtering
whatsoever. There is no need for any multicast address registration
to receive multicast packets.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 13 +
2
The MTU is assigned to the tap netdevice according to the argument, but
packet transmission and reception just write/read on an fd with the
default limit being the socket buffer size.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 37
Advertize RTE_PTYPE_UNKNOWN since tap does not report any packet type.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features/tap.ini | 1 +
drivers/net/tap/rte_eth_tap.c| 15 +++
2 files changed, 16 insertions(+)
diff --git a/doc/guides/nics/features/tap.ini b/doc/guides
1 - 100 of 251 matches
Mail list logo
