On Mon, 6 Feb 2017 13:40:38 -0600
Keith Wiles <keith.wi...@intel.com> wrote:
> At the same time remove closing fds code from pmd stop routine.
>
> Signed-off-by: Keith Wiles <keith.wi...@intel.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 966e91a..0a7f4af 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -350,14 +350,7 @@ tap_dev_start(struct rte_eth_dev *dev)
> static void
> tap_dev_stop(struct rte_eth_dev *dev)
> {
> - int i;
> - struct pmd_internals *internals = dev->data->dev_private;
> -
> tap_link_set_down(dev);
> -
> - for (i = 0; i < internals->nb_queues; i++)
> - if (internals->rxq[i].fd != -1)
> - close(internals->rxq[i].fd);
> }
>
> static int
> @@ -431,6 +424,17 @@ tap_stats_reset(struct rte_eth_dev *dev)
> static void
> tap_dev_close(struct rte_eth_dev *dev __rte_unused)
> {
> + int i;
> + struct pmd_internals *internals = dev->data->dev_private;
> +
> + tap_link_set_down(dev);
> +
> + for (i = 0; i < internals->nb_queues; i++) {
> + if (internals->rxq[i].fd != -1)
> + close(internals->rxq[i].fd);
> + internals->rxq[i].fd = -1;
> + internals->txq[i].fd = -1;
> + }
> }
>
> static void
Ok, the series looks good to me.
Acked-by: Pascal Mazon <pascal.ma...@6wind.com>
