On 01/31/2017 05:06 PM, Wiles, Keith wrote:>
Looking at the changes to set the link up/down and the adding the two functions. I noticed in the stop/start routines I was set the link in DPDK and not adjusting the interface link. Should the stop/start routine also do the same thing?
Well, my patch is probably wrong. The best option would probably be to set dev->data->dev_link.link_status appropriately inside tap_link_set() only. I'm not sure it's compulsory to actually set the link UP in tap_dev_start() (respectively DOWN in tap_dev_stop()). If it is, however, it would be best done using tap_link_set() in those functions. -- Pascal Mazon www.6wind.com
