> It might also be worth naming what the default is in the doc-string
> (by which I mean that the parameter defaults to True, not the default
> address scheme).
I can fix that.
anything, but that is still useful
> to note by annotating it as "None".
Surprised I never saw that. I'll fix this.
> On Tue, Jul 2, 2024 at 3:25 PM Nicholas Pratte wrote:
> >
> > Several new methods have been added to TestPMDShell in order to pro
v3:
* Minor adjustments to doc strings
* Return labels added for testpmd methods
Nicholas Pratte (3):
dts: add boolean to adjust addresses
dts: add methods for setting mac and multicast addresses
dts: mac filter test suite refactored for new dts
dts/framework/config
boolean is true by default.
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
dts/framework/test_suite.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py
index 694b2eba65..551a587525 100644
--- a/dts/framework
est
suites, and their implementations have been copied, but are subject to
change; they are not the focus of this patch.
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
dts/framework/remote_session/testpmd_shell.py | 179 ++
1 file changed, 179 insertions(+)
diff --git
--rxfreet=64 --mbcache=250 --portmask=0x3
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
v2:
* Refactored the address pool capacity tests to use all available
octets in the mac address.
* Change the payload to 'X' characters instead of 'P' charact
v3:
* Refactored to use TestPMDShell context manager.
NOTE: Assessing the boundaries and discern the correct assumption
for ethernet overhead is still to be discussed. Thus, while each
individual test case may pass, the test cases may not yet be precise.
Nicholas Pratte (2):
dts: add port
Testpmd offers mtu configuration options that omit ethernet overhead
calculations when set. This patch adds easy-of-use methods to leverage
these runtime options.
Bugzilla ID: 1421
Signed-off-by: Nicholas Pratte
---
dts/framework/remote_session/testpmd_shell.py | 20 ++-
1 file
directly from the old DTS framework, and the
general methodology is the same as well. The process, at this point, has
been refactored to operate within the new DTS framework.
Bugzilla ID: 1421
Signed-off-by: Nicholas Pratte
---
dts/framework/config/conf_yaml_schema.json | 3 +-
dts/tests
v3:
* Refactored to use TestPMDShell context manager.
NOTE: Assessing the boundaries and discern the correct assumption
for ethernet overhead is still to be discussed. Thus, while each
individual test case may pass, the test cases may not yet be precise.
Nicholas Pratte (2):
dts: add port
This is great, I'll be using this in-favor of the boolean solution
that I implemented! Just to bring this to your attention. I am
currently working on some Generic Routing Encapsulation suites the
require multiple IP layers at packet creation; they look something
like:
Ether() / IP() / GRE() / IP(
v4:
* Refactored test suite to use context manager.
* Added dependencies for vlan testpmd methods and adjust
addresses.
Nicholas Pratte (2):
dts: add methods for setting mac and multicast addresses
dts: mac filter test suite refactored for new dts
dts/framework/config
based on a boolean 'add or remove' parameter. The success or
failure of each call can be verified if a user deems it necessary.
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
dts/framework/remote_session/testpmd_shell.py | 59 +++
1 file changed, 59 insertions(+)
d
--rxfreet=64 --mbcache=250 --portmask=0x3
depends-on: patch-142691 ("dts: add send_packets to test suites and
rework packet addressing")
depends-on: patch-142696 ("dts: add VLAN methods to testpmd shell")
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
v2:
* Refact
based on a boolean 'add or remove' parameter. The success or
failure of each call can be verified if a user deems it necessary.
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
dts/framework/remote_session/testpmd_shell.py | 59 +++
1 file changed, 59 insertions(+)
d
--rxfreet=64 --mbcache=250 --portmask=0x3
depends-on: patch-142691 ("dts: add send_packets to test suites and
rework packet addressing")
depends-on: patch-142696 ("dts: add VLAN methods to testpmd shell")
Bugzilla ID: 1454
Signed-off-by: Nicholas Pratte
---
v2:
* Refact
I'll make sure to look over the other parts of this series and leave
reviews at some point next week, but I prioritized this since I will
be using this patch at some point in my GRE suites.
> diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py
> index 694b2eba65..0b678ed62d 100
Good work! I left some probing/clarifying comments below for you.
> +@dataclass
> +class TestPmdVerboseOutput(TextParser):
> +"""Verbose output generated by Testpmd.
> +
> +This class is the top level of the output, containing verbose output
> delimited by
> +"port X/queue Y: sent/re
> You're right that in most cases it would come from the stop output,
> but the output from that stop command has one other thing as well that
> I would consider valuable which is statistics of packets handled by
> ports specifically for the duration of the packet forwarding you are
> stopping. It
> I like the sound of this idea a lot actually since it would remove the
> chance of the output just completely being thrown away. In my own test
> suite I managed to dance around this by strategically placing my
> testpmd commands, but this could save people some headache in the
> future. I feel l
ing this test suite is the
need to modify the tpid at the 'Ether' layer within Scapy, as doing so
modifies the correct tpid needed for testing; this might seem
counter-intuitive at first glance.
Nicholas Pratte (2):
dts: add additional vlan configuration to testpmd shell class
dts: po
beena added to adjust both the inner and outer tpids of
ingressing and egressing packets.
Bugzilla ID: 1505
Signed-off-by: Nicholas Pratte
---
dts/framework/remote_session/testpmd_shell.py | 55 +++
1 file changed, 55 insertions(+)
diff --git a/dts/framework/remote_session
ser for testpmd verbose output")
depends-on: 139227 ("dts: skip test cases based on capabilities")
Signed-off-by: Nicholas Pratte
---
dts/framework/config/conf_yaml_schema.json | 3 +-
dts/tests/TestSuite_ethertype_config.py| 381 +
2 files changed,
the use of '$defs' instead of references to a local
file.
Nicholas Pratte (1):
dts: split enums from primary json schema
dts/framework/config/__init__.py | 4 +
dts/framework/config/conf_allowed_values.json | 131 ++
dts/framework/config/conf_yaml_schem
from the primary schema can achieve both
of these needs.
Signed-off-by: Nicholas Pratte
---
dts/framework/config/__init__.py | 4 +
dts/framework/config/conf_allowed_values.json | 131 ++
dts/framework/config/conf_yaml_schema.json| 111 ++-
3 files
Reviewed-by: Nicholas Pratte
On Mon, Aug 12, 2024 at 11:04 AM wrote:
>
> From: Jeremy Spewock
>
> There were two different commands in the hugepage mounting process that
> were not using super-user privileges; one for unmounting hugepages and
> another for re-mounting them. T
Great work!
I think it'd be fine to just keep if you ask me, I could see this
being used in the future. I'm also looking at it from the perspective
of 'what if i would have to write this myself,' if it turns out that
we need it again for something later. It's easier to remove later if
it turns out
Makes sense to me!
Reviewed-by: Nicholas Pratte
On Mon, Aug 12, 2024 at 1:23 PM wrote:
>
> From: Jeremy Spewock
>
> The DTS framework in its current state supports binding ports to
> different drivers on the SUT node but not the TG node. The TG node
> already has the informa
Reviewed-by: Nicholas Pratte
On Mon, Aug 12, 2024 at 12:35 PM Dean Marx wrote:
>
> In the current DTS setup description, the user installs poetry
> with the --no-root option. However, adding 'package-mode = false'
> to the pyproject.toml sets the same configuration, and ru
On Mon, Aug 12, 2024 at 9:39 AM Dean Marx wrote:
>
> add csum_set_hw method to testpmd shell class. Port over
> set_verbose and port start/stop from queue start/stop suite.
>
> Signed-off-by: Dean Marx
> ---
> dts/framework/remote_session/testpmd_shell.py | 94 +++
> 1 file chang
Good catch!
Reviewed-by: Nicholas Pratte
On Tue, Aug 13, 2024 at 1:17 PM Dean Marx wrote:
>
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
> Signed-off-by: Dean Marx
> ---
> dts/conf.yaml | 8
> 1 file cha
within test run
configuration; that is what this series achieves.
Nicholas Pratte (3):
dts: rework port attributes in config module
dts: rework testbed_model Port objects to contain unique identifiers
dts: rework test suite and dts runner to include test_run configs
dts/conf.yaml
testbeds for the SUT and TG must have an equal number of
specified ports. In each given array or ports, SUT port 0 is connected
to TG port 0, SUT port 1 is connected to TG port 1, etc.
Bugzilla ID: 1478
Signed-off-by: Nicholas Pratte
---
dts/conf.yaml | 32
In order to leverage the usability of unique identifiers on ports, the
testbed_model Port object needs some refactoring/trimming of obsolete or
needless attributes.
Bugzilla ID: 1478
Signed-off-by: Nicholas Pratte
---
dts/framework/testbed_model/port.py | 45 +++--
1
: 1478
Signed-off-by: Nicholas Pratte
---
dts/framework/runner.py | 16 +---
dts/framework/test_suite.py | 33 +
2 files changed, 34 insertions(+), 15 deletions(-)
diff --git a/dts/framework/runner.py b/dts/framework/runner.py
index 6b6f6a05f5
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš
wrote:
>
> The device_error_handling_mode of testpmd port may not be present, e.g.
> in VM ports.
>
> Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell")
>
> Signed-off-by: Juraj Linkeš
> ---
Reviewed-by: Nicholas Pratte
stance.
>
> DTS needs to return different instances in the above scenario so that we
> can map capabilities with different names to the same function that
> retrieves the capabilities.
>
> Signed-off-by: Juraj Linkeš
Reviewed-by: Nicholas Pratte
Hi Alex, thanks for the review!
See my comments below.
> > +IP_HEADER_LEN = 20
> > +ETHER_STANDARD_FRAME = 1500
> > +ETHER_JUMBO_FRAME_MTU = 9000
>
> For these constants, I am confused why one is "FRAME" and the other is
> "MTU". The value of 'ETHER_STANDARD_FRAME' is 1500 (the standard MTU
> si
Hi Jeremy, sorry for the delay! See my comments below.
> > > Assumptions:
> > > Two links between SUT and TG, one link is TG -> SUT, the
> > > other SUT -> TG.
> > >
> > > Args:
> > > -packet: The packet to modify.
> > > +packets: The packet
Reviewed-by: Nicholas Pratte
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš
wrote:
>
> Add decorators for functional and performance test cases. These
> decorators add attributes to the decorated test cases.
>
> With the addition of decorators, we change the test case discovery
&
Tested-by: Nicholas Pratte
On Thu, Feb 29, 2024 at 10:48 AM Patrick Robb wrote:
>
>
> -- Forwarded message -
> From:
> Date: Tue, Jan 16, 2024 at 2:18 PM
> Subject: [PATCH v4] dts: add Dockerfile
> To: , , <
> tho...@monjalon.net>, , , <
Tested-by: Nicholas Pratte
The tool used to generate developer docs is Sphinx, which is already in
use in DPDK. The same configuration is used to preserve style, but it's
been augmented with doc-generating configuration. There's a change that
modifies how the sidebar displays t
Tested-by: Nicholas Pratte
>
> Add hyphen to the regex, which is needed for drivers such as vfio-pci.
>
> Fixes: 88489c0501af ("dts: add smoke tests")
> Cc: jspew...@iol.unh.edu
> Signed-off-by: Juraj Linkeš
> ---
> dts/tests/TestSuite_smoke_tests.py | 2 +-
&g
I fixed the docstring under setup_hugepages in os_session, and I also
made a quick fix to the dts.rst documentation. For the dts.rst
documentation, I think the following changes make more sense, based on
the concerns outlined:
(here is a snip of the documentation with the change I made)
"as doing
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v4:
* dts.rst punctuation/grammar corrections and 2mb exclusivity
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Signed-off-by: Nicholas Pratte
cover the difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v4:
* dts.rst punctuation/grammar corrections and 2mb exclusivity
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Signed-off-by: Nicholas Pratte
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v4:
* dts.rst punctuation/grammar corrections and 2mb exclusivity
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Signed-off-by: Nicholas Pratte
Resending the patch and superseding the old one on patchwork. I
accidentally sent this patch series through some kind of container
instance.
On Tue, May 7, 2024 at 1:44 PM Nicholas Pratte wrote:
>
> In order to prevent accidental misconfiguration of hugepages at runtime,
> the followin
ad; I changed the description text
from "amount of" to "number of."
Hopefully this answers your question. Again, I ran into some issues
sending the latest version out for this patch
On Mon, May 13, 2024 at 5:53 AM Juraj Linkeš wrote:
>
> What's the difference between th
On Mon, May 13, 2024 at 6:06 AM Juraj Linkeš wrote:
>
> On Tue, May 7, 2024 at 3:00 PM Bruce Richardson
> wrote:
> >
> > On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote:
> > > On 07/05/2024 13:05, Bruce Richardson wrote:
> > > > Sorry to be late to the reviews here, but since this i
I've been running some local tests using a mock test suite. Each
method you created generates output as expected, but
show_port_stats_all() is printing out an empty list; I'm not sure this
is intentional or not. I don't have much experience with regular
expressions to be able to discern what is goi
Acked-by: Nicholas Pratte
On Thu, May 9, 2024 at 5:59 AM Luca Vizzarro wrote:
>
> On 01/05/2024 17:16, jspew...@iol.unh.edu wrote:
> > This version addresses comments from the last and adds an additional
> > improvement to the logging output that comes from interactive shell
Ran into no issues with this when testing your port stats and info
patch, so I'll provide a tested tag as well. Other than a couple of
issues listed in dts-check-format, everything looks good.
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Tue, May 14, 2024 at 7:34 AM Luca Viz
In addition to the pmd_scatter suite, I refactored my jumboframes
suite to use this new module for testing purposes; everything works
great, and the format looks much better too.
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote
Disregard that last comment, it was a mistake on my end. Updating the
dependencies in my container instance fixed the problem.
On Tue, May 21, 2024 at 10:59 AM Luca Vizzarro wrote:
>
> On 20/05/2024 16:37, Nicholas Pratte wrote:
> > Ran into no issues with this when testing your po
about it.
The current implementation is not developed with both the capabilities
patch and the params patch in mind; however, the current design can and
will be refactored to do so.
Nicholas Pratte (1):
Initial Implementation For Jumbo Frames Test Suite
dts/framework/config/conf_yaml_schema
the old DTS framework, and the general
methodology is the same as well. The process, at this point, has been
refactored to operate within the new DTS framework.
Bugzilla ID: 1421
Signed-off-by: Nicholas Pratte
---
dts/framework/config/conf_yaml_schema.json | 3 +-
dts/framework/test_suite.py
This is being superseded, ignore this submission.
Thanks.
On Fri, May 24, 2024 at 2:07 PM Nicholas Pratte wrote:
>
> The following is a rough design for the implementation of the jumbo
> frames test suite in new DTS. The test suite uses the same
> testing methodology from th
about it.
The current implementation is not developed with both the capabilities
patch and the params patch in mind; however, the current design can and
will be refactored to do so.
Nicholas Pratte (1):
Initial Implementation For Jumbo Frames Test Suite
dts/framework/config/conf_yaml_schema
directly from the old DTS framework, and the
general methodology is the same as well. The process, at this point, has
been refactored to operate within the new DTS framework.
Bugzilla ID: 1421
Signed-off-by: Nicholas Pratte
---
dts/framework/config/conf_yaml_schema.json | 3 +-
dts/tests
I think this implementation is great, and I plan on testing it
properly with the jumbo frames suite that I am developing before
giving the final review. The only input that I could reasonably give
is a couple rewordings on the docstrings which I'll highlight below.
On Thu, Apr 11, 2024 at 4:48 AM
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> This commit introduces a new "params" module, which adds a new way
> to manage command line parameters. The provided Params dataclass
> is able to read the fie
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote:
>
> Make it so that interactive shells accept an implementation of `Params`
> for app arguments. Convert EalParameters to use `Params` instead.
>
> String command line
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> Move EalParams to its own module to avoid circular dependencies.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> ---
> dts/fr
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> Remove the imports in the testbed_model and remote_session modules init
> file, to avoid the initialisation of unneeded modules, thus removing or
> limiting the risk
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> Update the buffer scatter test suite to use TestPmdParameters
> instead of the StrParams implementation.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-b
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> The way nodes and interactive shells interact makes it difficult to
> develop for static type checking and hinting. The current system relies
> on a top-down approach, a
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> Interactive shells that inherit DPDKShell initialise their params
> classes from a kwargs dict. Therefore, static type checking is
> disabled. This change uses the func
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> Implement all the testpmd shell parameters into a data structure.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> ---
> dts/framew
Provided a review for the wrong version...
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> Make it so that interactive shells accept an implementation of `Params`
> for app arguments. Convert EalParameters to use `Params
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v8:
* Some areas of the dts.rst needed to be rewritten to reflect the
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
---
* v8: Decided on a variable name "number_of" to be used
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v7:
* Some areas of the dts.rst needed to be rewritten to reflect the
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Bugzilla ID: 1370
Signed-off-by: Nicho
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> This commit introduces a new "params" module, which adds a new way
> to manage command line parameters. The provided Params dataclass
> is able to read t
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> Make it so that interactive shells accept an implementation of `Params`
> for app arguments. Convert EalParameters to use `Params` instead.
>
> String command line
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> Implement all the testpmd shell parameters into a data structure.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> ---
> dts/framew
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> Remove the imports in the testbed_model and remote_session modules init
> file, to avoid the initialisation of unneeded modules, thus removing or
> limiting the risk
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> Move EalParams to its own module to avoid circular dependencies.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-by: Paul Szczepanek
> ---
> dts/fr
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> Interactive shells that inherit DPDKShell initialise their params
> classes from a kwargs dict. Therefore, static type checking is
> disabled. This change uses the func
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> The way nodes and interactive shells interact makes it difficult to
> develop for static type checking and hinting. The current system relies
> on a top-down approach
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote:
>
> Update the buffer scatter test suite to use TestPmdParameters
> instead of the StrParams implementation.
>
> Signed-off-by: Luca Vizzarro
> Reviewed-b
I was able to use this implementation on the in-development
jumboframes suite, setting restrictions on the required link speeds of
NICs and using this as a requirement to run all test cases. While the
framework you've developed is intuitive for true/false capabilities,
this may not be the case for
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v4:
* dts.rst punctuation/grammar corrections and 2mb exclusivity
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Bugzilla ID: 1370
Signed-off
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v4:
* dts.rst punctuation/grammar corrections and 2mb exclusivity
The term 'amount' is used for uncountable nouns. Since total hugepages
is a discrete value (i.e. countable), the declaration of the 'amount'
key value pair should be changes to a different term in both the config
and the rest of the code.
Bugzilla ID: 1370
Signed-off
difference. If the amount of
hugepages requested is either greater than or equal to the amount
already configured on the system, then nothing is done.
Nicholas Pratte (2):
dts: Change hugepage runtime config to 2MB Exclusively
dts: Change hugepage 'amount' to a different term
difference. If the amount of hugepages requested is
either less than or equal to the amount already configured on the system,
then nothing is done.
Bugzilla ID: 1370
Signed-off-by: Nicholas Pratte
Reviewed-by: Jeremy Spewock
---
v4:
* dts.rst punctuation/grammar corrections and 2mb exclusivity
1 - 100 of 259 matches
Mail list logo
