śr., 5 maj 2021 o 13:45 Ferruh Yigit napisał(a):
>
> On 4/1/2021 3:30 PM, Ferruh Yigit wrote:
> > On 3/31/2021 10:52 AM, Qi Zhang wrote:
> >> PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap
> >> data path debug code. As .config has been removed since the meson build,
> >> It is not friend
sob., 21 maj 2022 o 00:08 Ferruh Yigit napisał(a):
>
> On 8/30/2021 3:05 PM, William Tu wrote:
> > On Mon, Aug 30, 2021 at 12:12 AM Michał Krawczyk wrote:
> > [...]
> >> Hi William,
> >>
> >> It's great to hear that you're working o
wt., 7 cze 2022 o 19:17 Stephen Hemminger
napisał(a):
>
> Rte_memcpy is not needed for small objects only used on control
> path. Regular memcpy is as fast or faster and there is more
> robust since static analysis etc knows what it does.
>
> In this driver it was redefining all memcpy as rte_memc
śr., 8 cze 2022 o 17:32 Stephen Hemminger
napisał(a):
>
> On Wed, 8 Jun 2022 14:29:58 +0200
> Michał Krawczyk wrote:
>
> > wt., 7 cze 2022 o 19:17 Stephen Hemminger
> > napisał(a):
> > >
> > > Rte_memcpy is not needed for small objects only used on con
wt., 6 kwi 2021 o 02:27 David Harton napisał(a):
>
> When ena_tx_queue_release_bufs() frees the mbufs it does not clear
> the mbuf pointers. So, when the device starts and stops multiple
> times it can cause the application to receive duplicate mbufs for
> two different packets. Fix the issue by
wt., 12 paź 2021 o 01:54 Ferruh Yigit napisał(a):
>
> Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag.
>
> Instead of drivers announce this capability, application can deduct the
> capability by checking reported 'dev_info.max_mtu' or
> 'dev_info.max_rx_pktlen'.
>
> And instead of application s
pon., 18 paź 2021 o 22:52 Ferruh Yigit napisał(a):
>
> On 10/15/2021 5:26 PM, Michal Krawczyk wrote:
> > Hi,
> >
> > this version updates the driver to version 2.5.0. It mainly focuses on
> > fixing the offload flags fixes. Other features included in this patchset
> > are:
> >
> >* NUMA aware
+Shai
śr., 10 lis 2021 o 00:34 fwefew 4t4tg <7532ya...@gmail.com> napisał(a):
>
> On AWS EC2 I configure:
>
> - c5n.metal instance
> - Stock AWS AMI Ubuntu 20.04 LTS ($ cat /proc/version
> Linux version 5.4.0-1045-aws)
> - Apply the vfio pci driver from https://github.com/amzn/am
> zn-drivers/tree
śr., 14 lip 2021 o 10:04 Vladimir Medvedkin napisał(a):
>
> Hi Michal,
>
> вт, 13 июл. 2021 г. в 18:42, Michal Krawczyk :
>>
>> Allow user to specify his own hash key and hash ctrl if the
>> device is supporting that. HW interprets the key in reverse byte order,
>> so the PMD reorders the key befo
pon., 12 lip 2021 o 19:03 Ghalem Boudour napisał(a):
>
> The DPDK ENA driver does not provide multi-segment tx offload capability.
> Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by default.
>
Hi Ghalem,
This patch enables announcement of the DEV_TX_OFFLOAD_MULTI_SEGS
capabilit
ation with the key used by the NIC.
But I just double checked it with the rte_softrss() - the results from
the NIC and from the rte_softrss() are the same.
> ср, 14 июл. 2021 г. в 11:21, Michał Krawczyk :
>>
>> śr., 14 lip 2021 o 10:04 Vladimir Medvedkin
>> napisał(a):
&g
pt., 23 lip 2021 o 11:22 Thomas Monjalon napisał(a):
>
> 14/07/2021 12:43, Michal Krawczyk:
> > + PMD_DRV_LOG(WARNING,
> > + "Setting RSS hash fields is not supported. Using
> > default values: 0x%llx\n",
> > + ENA_ALL_RSS_HF);
> >
>
> che
pt., 23 lip 2021 o 11:43 Thomas Monjalon napisał(a):
>
> 23/07/2021 11:39, Michał Krawczyk:
> > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisał(a):
> > >
> > > 14/07/2021 12:43, Michal Krawczyk:
> > > > + PMD_DRV_LOG(WARNING,
> &g
śr., 28 lip 2021 o 16:27 Olivier Matz napisał(a):
>
> Hi Michał,
>
> On Wed, Jul 14, 2021 at 12:02:32PM +0200, Michał Krawczyk wrote:
> > pon., 12 lip 2021 o 19:03 Ghalem Boudour
> > napisał(a):
> > >
> > > The DPDK ENA driver does not provide multi-
czw., 29 lip 2021 o 09:26 Olivier Matz napisał(a):
>
> Hi Michał,
>
> On Thu, Jul 29, 2021 at 08:40:00AM +0200, Michał Krawczyk wrote:
> > śr., 28 lip 2021 o 16:27 Olivier Matz napisał(a):
> > >
> > > Hi Michał,
> > >
> > > On Wed, J
pt., 30 lip 2021 o 10:35 Olivier Matz napisał(a):
>
> From: Ghalem Boudour
>
> The DPDK ENA driver does not provide multi-segment tx offload capability.
> Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by
> default, and always set it in dev->data->dev_conf.txmode.offload.
>
> Thi
pt., 29 sty 2021 o 13:07 Ferruh Yigit napisał(a):
>
> On 1/26/2021 6:32 PM, Michal Krawczyk wrote:
> > From: Igor Chauskin
> >
> > Before starting transmission of Tx burst, the driver checked the
> > available space in the sq and limited the number of packets for
> > transmission accordingly.
> >
pt., 29 sty 2021 o 13:17 Ferruh Yigit napisał(a):
>
> On 1/26/2021 6:32 PM, Michal Krawczyk wrote:
> > Hi,
> >
> > this patchset contains few bug fixes for the ENA PMD and the version
> > upgrade to v2.2.1. Besides that, the validation of the Rx req ID was
> > optimized.
> >
> > Best regards,
> >
czw., 4 lut 2021 o 10:01 David Marchand napisał(a):
>
> On Thu, Feb 4, 2021 at 9:52 AM Michal Krawczyk wrote:
> >
> > DPDK v20.11 removed udata64 field, and changed type of the dynfield1 to
> > uint32_t.
> >
> > Due to define:
> > lib/common/pg_compat.h:#define udata64 dynfield1
pon., 4 paź 2021 o 19:27 Ferruh Yigit napisał(a):
>
> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
>
> ./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’:
> ./drivers/net/ena/ena_rss.c:140:66:
> error: the comparison will always evaluate as ‘false’ for the
> p
czw., 19 sie 2021 o 04:19 William Tu napisał(a):
>
> So I finally set up everything on AWS and tested this patch.
> Virt2phys and netuio (I added ena conf) load OK.
> Finally, starting dpdk-testpmd, I got some errors below:
> ---
> PS C:\dpdk-kmods> cd c:\dpdk
> PS C:\dpdk> .\build\app\dpdk-testpm
wt., 22 lut 2022 o 23:21 Ferruh Yigit napisał(a):
>
> On 2/22/2022 6:11 PM, Michal Krawczyk wrote:
> > Hi,
> >
> > this set contains new ENA features:
> >
> > * New xstats.
> > * Reconfigurable link status event.
> > * Usage of the optimized memcpy on arm/arm64.
> > * Better MP support.
> > * Reco
śr., 23 lut 2022 o 18:26 Ferruh Yigit napisał(a):
>
> On 2/23/2022 12:19 PM, Michal Krawczyk wrote:
> > As the default behavior for arm64 is to alias rte_memcpy as memcpy, ENA
> > cannot redefine memcpy as rte_memcpy as it would cause nested
> > declaration.
> >
> > To make it possible to use opti
śr., 23 lut 2022 o 18:25 Ferruh Yigit napisał(a):
>
> On 2/23/2022 12:19 PM, Michal Krawczyk wrote:
> > Those variables are being set, but never read. As they seem to be
> > leftover from the old offloads API and don't have any purpose right
> > now, they are simply being removed.
> >
>
> It can b
śr., 19 sty 2022 o 15:50 Michal Krawczyk napisał(a):
>
> Patch changing the way of accessing interrupt handle also changed order
> of the rte_pci_map_device() call and rte_pci_device:driver assignment.
> It was causing issues with Write Combine mapping on the Linux platform
> if it was used with t
pt., 7 maj 2021 o 17:52 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > Hi,
> >
> > this version updates the driver to version 2.3.0, which fixes multiple
> > bugs, contains part of the work on making the ENA PMD fully MP aware, and
> > also updates HAL to the latest v
pt., 7 maj 2021 o 18:47 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > Although the ENA DPDK PMD doesn't have to perform any actions for
> > destroying the wait event, some other platforms have to.
> >
> > The macro "ENA_WAIT_EVENT_DESTROY" was renamed to
> > "ENA_WAI
pt., 7 maj 2021 o 18:47 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > To make it possible to the app to determine if the hash was calculated
> > for the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's
> > ol_flags.
> >
> > As the PMD wasn't setting tha
pt., 7 maj 2021 o 18:50 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > This version update contains:
> > * memcpy mapping to the dpdk-optimized version.
> > * ena_com (HAL) update to the latest version.
> > * Bug fixes for the large LLQ headers and devargs parsi
pt., 7 maj 2021 o 18:49 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > From: Stanislaw Kardach
> >
> > rte_pci_device and rte_eth_dev are process-local structures. Therefore
> > ena_adapter::pdev and ena_adapter::rte_dev cannot be used universally.
> > Switch this to
pt., 7 maj 2021 o 16:59 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > Hi,
> >
> > this version updates the driver to version 2.3.0, which fixes multiple
> > bugs, contains part of the work on making the ENA PMD fully MP aware, and
> > also updates HAL to the latest v
wt., 11 maj 2021 o 15:07 Ferruh Yigit napisał(a):
>
> On 5/11/2021 7:45 AM, Michal Krawczyk wrote:
> > Hi,
> >
> > this version updates the driver to version 2.3.0, which fixes multiple
> > bugs, contains part of the work on making the ENA PMD fully MP aware, and
> > also updates HAL to the latest
pon., 18 kwi 2022 o 17:19 Amiya Mohakud
napisał(a):
>
> + Megha, Sharad and Eswar.
>
> On Mon, Apr 18, 2022 at 2:03 PM Amiya Mohakud
> wrote:
>>
>> Hi Michal/DPDK-Experts,
>>
>> I am facing one issue in net/ena driver while fetching extended stats
>> (xstats). The DPDK seems to segfault with be
wt., 19 kwi 2022 o 17:01 Stephen Hemminger
napisał(a):
>
> On Tue, 19 Apr 2022 14:10:23 +0200
> Michał Krawczyk wrote:
>
> > pon., 18 kwi 2022 o 17:19 Amiya Mohakud
> > napisał(a):
> > >
> > > + Megha, Sharad and Eswar.
> > >
> > >
2018-06-18 0:37 GMT+02:00 Thomas Monjalon :
> 07/06/2018 11:43, Michal Krawczyk:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk
>> ---
>> drivers/net/ena/Makefile | 1 +
2018-06-18 10:30 GMT+02:00 Thomas Monjalon :
>
> 18/06/2018 08:04, Michał Krawczyk:
> > 2018-06-18 0:37 GMT+02:00 Thomas Monjalon :
> > > 07/06/2018 11:43, Michal Krawczyk:
> > >> ENA PMD is required to use librte_timer. The appropriate depndency must
> >
2018-06-11 18:15 GMT+02:00 Chas Williams <3ch...@gmail.com>:
>
>
> On Mon, Jun 11, 2018 at 4:01 AM Michał Krawczyk wrote:
>>
>> 2018-06-10 3:35 GMT+02:00 Chas Williams <3ch...@gmail.com>:
>> >
>> >
>> > On Fri, Jun 8, 2018 at 3:37 P
Hi Thomas,
I uploaded patch which is fixing this issue:
http://patches.dpdk.org/patch/41256/
Thanks,
Michal
2018-06-18 22:30 GMT+02:00 Thomas Monjalon :
> +Cc more
>
> 18/06/2018 22:28, Thomas Monjalon:
>> Hi,
>>
>> There is an error when building DPDK master on FreeBSD:
>>
>> drivers/net/ena/b
Hi Daria,
I couldn't find the patch in the patchwork or the mailing list, so
sorry for late response.
2018-06-21 12:14 GMT+02:00 Marcin Wojtas :
> + Ferruh and Michal
>
> 2018-06-20 18:32 GMT+02:00 Daria Kolistratova :
>> When he number of rx queues is 0
Typo (missing 't' letter)
>> (what can
Hi Daria,
>From what you reported on bugzilla, it looks like this patch won't fix
the issue. Have you tried to execute the application with the changes
I suggested in the earlier email thread?
Thanks,
Michal
czw., 21.06.2018, 17:34 użytkownik Daria Kolistratova
napisał:
>
> When he number of
read and it works. Should I
> resend patch with these changes?
>
> Best regards,
> Kolistratova Daria
>
>
> -----Original Message-
> From: Michał Krawczyk [mailto:m...@semihalf.com]
> Sent: Monday, June 25, 2018 11:02 AM
> To: Kolistratova, Daria
> Cc: Yigit, F
Hi Daria,
please see my comments below and answer on them or apply fix and send
2nd version of the patch. You can do that by adding -v2 flag to git
format-patch command.
Please also sent the new version in response to this email. You can
do that by adding --in-reply-to 'msgid' to git send-email.
2018-06-26 13:07 GMT+02:00 Daria Kolistratova :
> When the number of rx queues is 0
> (what can be when application does not receive)
> failed with SIGFPE. It happens when the application
> is also requesting ETH_MQ_RX_RSS_FLAG in the
> rte_dev->data->dev_conf.rxmode.mq_mode.
> Fixed adding zero rx
2018-06-26 18:53 GMT+02:00 Ferruh Yigit :
> On 6/26/2018 6:38 PM, Ferruh Yigit wrote:
>> From: Daria Kolistratova
>
> I re-send the Daria's patch, somehow it didn't appeared in mail list and
> patchwork.
>
>>
>> When the number of rx queues is 0
>> (what can be when application does not receive)
2018-06-28 15:15 GMT+02:00 Rafal Kozik :
>
> Write combining (WC) increases NIC performance by making better
> utilization of PCI bus. ENA PMD may make usage of this feature.
>
> To enable it load igb_uio driver with wc_activate set to 1.
>
> Signed-off-by: Rafal Kozik
> Acked-by: Bruce Richardson
Hi Ferruh,
2018-06-05 18:42 GMT+02:00 Ferruh Yigit :
>
> On 6/4/2018 1:09 PM, Michal Krawczyk wrote:
> > The ENA driver was updated with the new features and few fixes and minor
> > changes are introduced.
> > First of all, the communication layer which is delivered by vendor was
> > updated - the
2018-06-08 21:17 GMT+02:00 Ferruh Yigit :
> On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
>> ENA PMD is required to use librte_timer. The appropriate depndency must
>> be added ifin case the DPDK will be built as shared library.
>>
>> Signed-off-by: Michal Krawczyk
>> ---
>> drivers/net/ena/Makefi
2018-06-10 3:35 GMT+02:00 Chas Williams <3ch...@gmail.com>:
>
>
> On Fri, Jun 8, 2018 at 3:37 PM Ferruh Yigit wrote:
>>
>> On 6/7/2018 10:43 AM, Michal Krawczyk wrote:
>> > From: Rafal Kozik
>> >
>> > Link speed should is not limited to 10Gb/s and it shouldn't be
>> > hardcoded.
>> >
>> > They li
2018-06-08 21:45 GMT+02:00 Ferruh Yigit :
> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
>> and the version number is updated accordingly.
>
> Does it make sense to add a release notes update to announce driver update?
Is
2018-06-11 11:26 GMT+02:00 Ferruh Yigit :
> On 6/11/2018 9:45 AM, Michał Krawczyk wrote:
>> 2018-06-08 21:45 GMT+02:00 Ferruh Yigit :
>>> On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
>>>> The upcoming patches for the ENA PMD are part of 1.1.0 update of the PMD
2018-06-11 11:50 GMT+02:00 Ferruh Yigit :
> On 6/11/2018 10:33 AM, Michał Krawczyk wrote:
>> 2018-06-11 11:26 GMT+02:00 Ferruh Yigit :
>>> On 6/11/2018 9:45 AM, Michał Krawczyk wrote:
>>>> 2018-06-08 21:45 GMT+02:00 Ferruh Yigit :
>>>>> On 6/7/201
Acked-by: Michal Krawczyk
2018-01-18 15:53 GMT+01:00 Ferruh Yigit :
> On 1/17/2018 8:23 AM, Rafal Kozik wrote:
> > Ethdev Tx offloads API has changed since:
> >
> > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
> >
> > This commit support the new Tx offloads API. Queue configur
Acked-by: Michal Krawczyk
2018-01-17 9:26 GMT+01:00 Rafal Kozik :
> Ethdev Rx offloads API has changed since:
>
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
>
> This commit support the new Rx offloads API.
>
> Signed-off-by: Rafal Kozik
> ---
> v2:
> * Use PRIx64 in printf.
2018-01-25 16:27 GMT+01:00 Rafal Kozik :
>
> Information about received packet type detected by NIC should be
> stored in packet_type field of rte_mbuf. TX L4 offload flags should
> not be set in RX path. Only fields that could be set in of_flags
> during packet receiving are information if L4 and
Acked-by: Michal Krawczyk
2017-08-23 2:41 GMT+02:00 David Harton :
> eth_ena_dev_init() was not initializing all of the common
> pci dev info for the rte_eth_dev. Added call to
> rte_eth_copy_pci_info() to complete the init particularly
> the driver name.
>
> Signed-off-by: David Harton
> ---
2018-02-01 14:06 GMT+01:00 Rafal Kozik :
>
> ENA device supports Rx jumbo frames and such information needs to
> be provided in the offloads flags.
>
> Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API")
>
> Signed-off-by: Rafal Kozik
Signed-off-by: Michal Krawczyk
>
> ---
> drivers
2018-02-01 17:49 GMT+01:00 Ferruh Yigit :
> On 2/1/2018 4:36 PM, Michał Krawczyk wrote:
>> 2018-02-01 14:06 GMT+01:00 Rafal Kozik :
>>>
>>> ENA device supports Rx jumbo frames and such information needs to
>>> be provided in the offloads flags.
>>>
&
2018-03-07 17:57 GMT+01:00 Anatoly Burakov :
> Signed-off-by: Anatoly Burakov
Acked-by: Michal Krawczyk
> ---
> drivers/net/ena/base/ena_plat_dpdk.h | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ena/base/ena_plat_dpdk.h
> b/drivers/net/ena/base/ena_
pt., 13 gru 2019 o 17:34 Stephen Hemminger
napisał(a):
>
> On Fri, 13 Dec 2019 14:32:15 +0100
> Michal Krawczyk wrote:
>
> > This version of the HAL allows to use the latest HW features, like
> > rx offsets.
> >
> > Driver was adjusted to the new version to fix the build.
> >
> > Signed-off-by: M
3_outer_hdr_len = 0;
>338 ena_meta->l3_outer_hdr_offset = 0;
>
>
> So even if TSO is enabled should these values be zero.
>
> Thanks,
> Param.
>
> On Wed, Dec 4, 2019 at 7:24 PM Michał Krawczyk wrote:
>
>> Hi Param,
>>
>> Adding atomic operations t
czw., 9 sty 2020 o 15:27 Ferruh Yigit napisał(a):
>
> On 12/13/2019 8:01 PM, Michał Krawczyk wrote:
> > pt., 13 gru 2019 o 17:34 Stephen Hemminger
> > napisał(a):
> >>
> >> On Fri, 13 Dec 2019 14:32:15 +0100
> >> Michal Krawczyk wrote:
> >>
pt., 10 sty 2020 o 10:04 Ferruh Yigit napisał(a):
>
> On 1/9/2020 3:39 PM, Michal Krawczyk wrote:
> > This version of the HAL allows to use the latest HW features, like
> > rx offsets.
> >
> > Driver was adjusted to the new version to fix the build.
> >
> > Signed-off-by: Michal Krawczyk
> > Sign
czw., 7 maj 2020 o 14:03 Ferruh Yigit napisał(a):
>
> Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using
> gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2)
>
> Build error:
> .../drivers/net/ena/ena_ethdev.c: In function ‘eth_ena_dev_init’:
> .../drivers/net/ena/ena_ethdev.c:1815:20:
> e
pt., 27 mar 2020 o 12:12 Andrew Rybchenko
napisał(a):
>
> On 3/27/20 1:17 PM, Michal Krawczyk wrote:
> > The RSS hash key was present in the device, but it wasn't exposed to
> > the user. The other key still cannot be set, but now it can be accessed
> > if one needs to do that.
> >
> > By default,
pt., 27 mar 2020 o 12:21 Andrew Rybchenko
napisał(a):
>
> On 3/27/20 1:18 PM, Michal Krawczyk wrote:
> > If the device supports larger LLQ (Low Latency Queue) headers, the user
> > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS
> > flag in the configuration file.
> >
> > If
pt., 27 mar 2020 o 12:30 Andrew Rybchenko
napisał(a):
>
> On 3/27/20 1:18 PM, Michal Krawczyk wrote:
> > Some ENA devices can pass to the driver descriptor with length 0. To
> > avoid extra allocation, the descriptor can be reused by simply putting
> > it back to the device.
> >
> > Signed-off-by:
pt., 27 mar 2020 o 15:54 Stephen Hemminger
napisał(a):
>
> On Fri, 27 Mar 2020 11:17:56 +0100
> Michal Krawczyk wrote:
>
> > From: Igor Chauskin
> >
> > Memory allocation region id could possibly be non-unique
> > due to non-atomic increment, causing allocation failure.
> >
> > Fixes: 9ba7981ec9
pt., 27 mar 2020 o 11:56 Andrew Rybchenko
napisał(a):
>
> On 3/27/20 1:17 PM, Michal Krawczyk wrote:
> > Some of the ENA devices can't handle buffers which are smaller than a
> > 1400B. Because of this limitation, size of the buffer is being checked
> > and limited during the Rx queue setup.
> >
>
pt., 27 mar 2020 o 15:51 Stephen Hemminger
napisał(a):
>
> On Fri, 27 Mar 2020 11:17:55 +0100
> Michal Krawczyk wrote:
>
> > + /* ENA isn't supporting buffers smaller than 1400 bytes */
> > + buffer_size = mp->elt_size - sizeof(struct rte_mbuf) -
> > + RTE_PKTMBUF_HEADROOM;
>
wt., 31 mar 2020 o 11:40 Michał Krawczyk napisał(a):
>
> pt., 27 mar 2020 o 12:12 Andrew Rybchenko
> napisał(a):
> >
> > On 3/27/20 1:17 PM, Michal Krawczyk wrote:
> > > The RSS hash key was present in the device, but it wasn't exposed to
> > > the
czw., 2 kwi 2020 o 14:36 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > The RSS hash key was present in the device, but it wasn't exposed to
> > the user. The other key still cannot be set, but now it can be accessed
> > if one needs to do that.
>
> What is 'the other
czw., 2 kwi 2020 o 14:41 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > In order to use the accelerated LLQ, the driver must limit the Tx burst
>
> I would be nice to show LLQ means "Low-latency Queue"
>
Ok - will do that in v3.
> > and be aware that the device has
czw., 2 kwi 2020 o 14:53 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > To make the debugging easier, the error logs were added in the Tx path.
> >
> > Signed-off-by: Michal Krawczyk
> > Reviewed-by: Igor Chauskin
> > Reviewed-by: Guy Tzalik
> > ---
> > drivers/ne
czw., 2 kwi 2020 o 14:55 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > ENA device is using 48-bit memory for IO. because of that, the upper
> > limit had to be updated.
>
> What is the impact of this change, and what is the reason of the change? Can
> you
> please e
czw., 2 kwi 2020 o 15:02 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > If the device supports larger LLQ (Low Latency Queue) headers, the user
> > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS
> > flag in the configuration file.
> >
> > If the
czw., 2 kwi 2020 o 15:05 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > ENA device can report in the AENQ handler amount of Tx packets that were
> > dropped and not sent.
> >
> > This statistic is showing global value for the device and because
> > rte_eth_stats is mi
czw., 2 kwi 2020 o 17:51 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > The v2.1.0 making changes in the ena_ethdev files were done this year,
> > so the copyright notice should be updated.
> >
> > Signed-off-by: Michal Krawczyk
> > Reviewed-by: Igor Chauskin
> > Re
czw., 2 kwi 2020 o 17:53 Ferruh Yigit napisał(a):
>
> On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> > The v2.1.0 is refactoring Tx and Rx paths, including few bug fixes and
> > is also adding a new features which are going to be available with the
> > newest hardware:
> > * Accelerated LLQ mode
>
śr., 8 kwi 2020 o 15:23 Ferruh Yigit napisał(a):
>
> On 4/8/2020 9:28 AM, Michal Krawczyk wrote:
> > Hi,
> >
> > This patchset is including severeal changes, including:
> > * ena_com (HAL) update
> > * Support for upcoming device features
> > * Refactor of the IO path
> > * Documentation update ab
same completion context can be used by another consumer C2
> even before the C1 is resetting the occupied flag.
>
> This is because the ena_com_handle_admin_completion is done under spin lock
> and comp_ctxt_release is not under this spin lock.
>
> Thanks,
> Param
>
> On
on in such a way that it is done from one process and not multiple.
>
> Thanks,
> Param.
>
> On Thu, Nov 28, 2019 at 6:44 PM Michał Krawczyk wrote:
>>
>> Hi Param,
>>
>> first of all - you are using very old ena_com. This code comes from
>> the DPDK version be
wt., 10 gru 2019 o 23:37 David Harton napisał(a):
>
> Network drivers were originally modified to initialize PCI info with
> commit eeefe73f0af1 ("drivers: copy PCI device info to ethdev data").
> Modifying net/ena to conform.
>
> Signed-off-by: David Harton
Acked-by: Michal Krawczyk
> ---
> d
pt., 12 lip 2019 o 19:35 David Harton napisał(a):
>
> Recent modifications to admin command queue polling logic
> did not support 32-bit applications. Updated the driver to
> work for 32 or 64 bit applications
>
> Fixes: 3adcba9a89 ("net/ena: update HAL to the newer version")
>
> Signed-off-by: D
czw., 1 sie 2019 o 13:45 Maciej Bielski napisał(a):
>
> During an if-condition evaluation, a 2-bit flag evaluates to 'true' for
> '0x1', '0x2' and '0x3'. Thus, from this perspective these flags are
> indistinguishable. To make them distinct, respective bits must be
> extracted with a mask and then
sob., 19 paź 2019 o 20:26 kumaraparameshwaran rathinavel
napisał(a):
>
> Hi All,
>
> In the ENA poll mode driver I see that every request in the admin queue is
> associated with a completion context and this is preallocated during the
> device initialisation. When the completion context is used we
Hi,
sorry for the late reply.
śr., 29 maj 2019 o 23:01 David Harton napisał(a):
>
> Recent modifications to admin command queue polling logic
> did not support 32-bit applications. Updated the driver to
> work for 32 or 64 bit applications as well as avoiding
> roll-over possibility.
>
> Fixes:
+ folks responsible for ENA on other platforms as this code touches
every ENA target
pt., 28 cze 2019 o 17:46 David Harton (dharton) napisał(a):
>
>
>
> > -Original Message-
> > From: Michał Krawczyk
> > Sent: Friday, June 28, 2019 11:03 AM
> > To: Da
pon., 1 lip 2019 o 14:01 David Harton (dharton) napisał(a):
>
>
>
> > -Original Message-
> > From: Michał Krawczyk
> > Sent: Monday, July 01, 2019 3:24 AM
> > To: David Harton (dharton)
> > Cc: dev@dpdk.org; Marcin Wojtas ; Tzalik, Guy
> >
On 29.05.2019 18:31, Anatoly Burakov wrote:
The ENA driver calculates a ring's NUMA node affinity by directly
accessing the memzone list. Fix it to do it through the public
API's instead.
Signed-off-by: Anatoly Burakov
---
drivers/net/ena/ena_ethdev.c | 18 +++---
1 file changed,
On 03.06.2019 09:33, Michał Krawczyk wrote:
On 29.05.2019 18:31, Anatoly Burakov wrote:
The ENA driver calculates a ring's NUMA node affinity by directly
accessing the memzone list. Fix it to do it through the public
API's instead.
Signed-off-by: Anatoly Burakov
---
drive
wt., 4 cze 2019 o 12:28 Burakov, Anatoly napisał(a):
>
> On 03-Jun-19 2:36 PM, Michał Krawczyk wrote:
> > On 03.06.2019 09:33, Michał Krawczyk wrote:
> >> On 29.05.2019 18:31, Anatoly Burakov wrote:
> >>> The ENA driver calculates a ring's NUMA node af
Hi Reeve,
On 07.06.2019 02:21, Reeve Yang wrote:
some followup ... I debugged more, it looks like rte_pci_probe is not
happening, so the rte_eth_dev_allocate is not called at all ..., buy
why is that? I ran testpmd, it shows no probed ethernet device.
>
# /opt/bluecoat/sslv/bin/testpmd testpm
wt., 16 lip 2019 o 22:43 Stephen Hemminger
napisał(a):
>
> The generic RTE_LOGTYPE_PMD is a historical relic and should
> not be used. Every driver must use dynamic logtypes.
>
> Compile tested only!
>
> Signed-off-by: Stephen Hemminger
Tested-by: Michal Krawczyk
> ---
> drivers/net/ena/base/e
+ Igor
pt., 27 wrz 2019 o 07:32 Hemant Agrawal napisał(a):
>
>
> > -Original Message-
> > From: dev On Behalf Of Ferruh Yigit
> > Sent: Thursday, September 26, 2019 11:17 PM
> > To: Maciej Bielski ; dev@dpdk.org
> > Cc: Marcin Wojtas ; Michal Krawczyk
> > ; Guy Tzalik ; Evgeny Schemeilin
pt., 23 paź 2020 o 10:44 David Marchand napisał(a):
>
> This assert macro is not called anymore.
> This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not
> exist.
>
> Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version")
> Fixes: 6f1c9df9e9cc ("net/ena: use dynamic log ty
95 matches
Mail list logo
