śr., 23 lut 2022 o 18:25 Ferruh Yigit <ferruh.yi...@intel.com> napisał(a):
>
> On 2/23/2022 12:19 PM, Michal Krawczyk wrote:
> > Those variables are being set, but never read. As they seem to be
> > leftover from the old offloads API and don't have any purpose right
> > now, they are simply being removed.
> >
>
> It can be good to add fixes tag, both for
> - document in which commit old offload flags because useless
> - backport the change to LTS, I can see the changes don't do
> much but backporting them can help to reduce future conflicts
> for future fixes (cc'ed LTS maintainers for comment)
>
Good note - I'm ok with adding the fixline. Thanks!
> If agreed please send the fixes line, I can amend it in next-net.
Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
Cc: sta...@dpdk.org
>
> > Signed-off-by: Michal Krawczyk <m...@semihalf.com>
> > Reviewed-by: Artur Rojek <a...@semihalf.com>
> > Reviewed-by: Dawid Gorecki <d...@semihalf.com>
> > Reviewed-by: Igor Chauskin <igo...@semihalf.com>
> > Reviewed-by: Shai Brandes <shaib...@amazon.com>
> > ---
> > drivers/net/ena/ena_ethdev.c | 3 ---
> > drivers/net/ena/ena_ethdev.h | 5 -----
> > 2 files changed, 8 deletions(-)
> >
> > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> > index 2de2dcf12f..de5fdb8f1d 100644
> > --- a/drivers/net/ena/ena_ethdev.c
> > +++ b/drivers/net/ena/ena_ethdev.c
> > @@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev)
> > */
> > adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to /
> > 2;
> >
> > - adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads;
> > - adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads;
> > -
> > return 0;
> > }
> >
> > diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h
> > index f47ba3fb02..4dfa604d51 100644
> > --- a/drivers/net/ena/ena_ethdev.h
> > +++ b/drivers/net/ena/ena_ethdev.h
> > @@ -278,11 +278,6 @@ struct ena_adapter {
> > struct ena_driver_stats *drv_stats;
> > enum ena_adapter_state state;
> >
> > - uint64_t tx_supported_offloads;
> > - uint64_t tx_selected_offloads;
> > - uint64_t rx_supported_offloads;
> > - uint64_t rx_selected_offloads;
> > -
> > bool link_status;
> >
> > enum ena_regs_reset_reason_types reset_reason;
>
>
