Daria, Yes, please. I will ack the patch once it will be resent.
Thanks, Michal 2018-06-25 13:05 GMT+02:00 Kolistratova, Daria <daria.kolistrat...@intel.com>: > Hi Michal, > > Yes, it won't fix the issue, but will return error instead of fail. I tried > to execute with changes from the earlier email thread and it works. Should I > resend patch with these changes? > > Best regards, > Kolistratova Daria > > > -----Original Message----- > From: Michał Krawczyk [mailto:m...@semihalf.com] > Sent: Monday, June 25, 2018 11:02 AM > To: Kolistratova, Daria <daria.kolistrat...@intel.com> > Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; Marcin Wojtas > <m...@semihalf.com>; Tzalik, Guy <gtza...@amazon.com>; Schmeilin, Evgeny > <evge...@amazon.com>; dev@dpdk.org > Subject: Re: [PATCH 1/1] ena: fix SIGFPE with 0 rx queues > > Hi Daria, > > From what you reported on bugzilla, it looks like this patch won't fix the > issue. Have you tried to execute the application with the changes I suggested > in the earlier email thread? > > Thanks, > Michal > > > czw., 21.06.2018, 17:34 użytkownik Daria Kolistratova > <daria.kolistrat...@intel.com> napisał: >> >> When he number of rx queues is 0 >> (what can be when application does not receive) failed with SIGFPE. >> Fixed adding zero check before division. >> >> Signed-off-by: Daria Kolistratova <daria.kolistrat...@intel.com> >> --- >> drivers/net/ena/ena_ethdev.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ena/ena_ethdev.c >> b/drivers/net/ena/ena_ethdev.c index 9ae73e331..76c483921 100644 >> --- a/drivers/net/ena/ena_ethdev.c >> +++ b/drivers/net/ena/ena_ethdev.c >> @@ -684,7 +684,11 @@ static int ena_rss_init_default(struct ena_adapter >> *adapter) >> } >> >> for (i = 0; i < ENA_RX_RSS_TABLE_SIZE; i++) { >> - val = i % nb_rx_queues; >> + if (nb_rx_queues != 0) >> + val = i % nb_rx_queues; >> + else >> + val = 0; >> + >> rc = ena_com_indirect_table_fill_entry(ena_dev, i, >> ENA_IO_RXQ_IDX(val)); >> if (unlikely(rc && (rc != ENA_COM_UNSUPPORTED))) { >> -- >> 2.14.4 >> > > -------------------------------------------------------------------- > Joint Stock Company Intel A/O > Registered legal address: Krylatsky Hills Business Park, > 17 Krylatskaya Str., Bldg 4, Moscow 121614, > Russian Federation > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies.
