[dpdk-dev] [PATCH] net/bnxt: create ring group array only when needed

2019-07-10 Thread Lance Richardson
Fix an overrun of the ring group array with BCM5750X-based adapters by ensuring that the ring group array is not allocated or accessed for adapters that do not support ring groups. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance Richardson Reviewed-by:

Re: [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart

2019-07-12 Thread Lance Richardson
On Fri, Jul 12, 2019 at 2:06 AM Ajit Khaparde wrote: > > From: Lance Richardson > > Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb > and rxq->rxrearm_start are reinitialized correctly when a port is > restarted. > > Fixes: af3ed597e305 (

Re: [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart

2019-07-12 Thread Lance Richardson
On Fri, Jul 12, 2019 at 8:06 AM Lance Richardson wrote: > > On Fri, Jul 12, 2019 at 2:06 AM Ajit Khaparde > wrote: > > > > From: Lance Richardson > > > > Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb > > and rxq->rxrearm_sta

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-22 Thread Lance Richardson
On Mon, Jul 22, 2019 at 11:06 AM Thomas Monjalon wrote: > > 22/07/2019 16:57, Ferruh Yigit: > > On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > > > From: Lance Richardson > > > --- a/config/common_base > > > +++ b/config/common_base > > > @@ -212,6 +2

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-23 Thread Lance Richardson
t; On 7/22/2019 6:57 PM, Lance Richardson wrote: > > > On Mon, Jul 22, 2019 at 11:06 AM Thomas Monjalon > > > wrote: > > >> 22/07/2019 16:57, Ferruh Yigit: > > >>> On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > > >>>> From: Lance

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-23 Thread Lance Richardson
On Mon, Jul 22, 2019 at 2:34 PM Ferruh Yigit wrote: > I dropped this patch from next-net since discussion is going on, I did my best > to resolve the conflicts but please confirm the final result in next-net. > I did some basic testing of the current head of dpdk-next-net and diffed against the

[dpdk-dev] [PATCH] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
ename "def_cp_ring" to "async_cp_ring" to better reflect its purpose (async event notifications) and to avoid confusion with VNIC default receive completion rings. Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

Re: [dpdk-dev] [PATCH] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
On Wed, Jul 24, 2019 at 12:14 PM Lance Richardson wrote: > process async events on a receive completion ring. This behavior > is controlled by a compile-time configuration variable. I will follow up with a v2 to correct the above statement in the commit log and to squash with these fol

[dpdk-dev] [[PATCH v2]] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
eflect its purpose (async event notifications) and to avoid confusion with VNIC default receive completion rings. Allow rxq 0 to be stopped when not being used for async events. Signed-off-by: Lance Richardson Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde ---

[dpdk-dev] [PATCH 1/2] net/bnxt: fix context memory allocation

2019-07-29 Thread Lance Richardson
t;net/bnxt: support thor controller") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnx

[dpdk-dev] [PATCH 2/2] net/bnxt: set Rx checksum flags in vector mode receive

2019-07-29 Thread Lance Richardson
; to indicate L3 and L4 error. Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") Signed-off-by: Kalesh AP Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 47 1 file changed, 47 insertion

[dpdk-dev] [PATCH] net/bnxt: revert fix traffic stall on stop/start

2019-08-09 Thread Lance Richardson
/bnxt: fix traffic stall on Rx queue stop/start") Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- drivers/net/bnxt/bnxt_ring.c | 3 ++- drivers/net/bnxt/bnxt_rxq.c| 5 - drivers/net/bnxt/bnxt_txq.c| 1 - drivers/net/bnxt/bnxt_txr.c| 1 + 5 files

[dpdk-dev] [PATCH] net/bnxt: fix mbuf free when clearing Tx queue

2019-10-23 Thread Lance Richardson
When freeing pending transmit mbufs, use rte_pktmbuf_free_seg() instead of rte_pktmbuf_free(), otherwise linked mbufs may be freed more than once. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Reviewed-by: Ajit Khaparde Signed-off-by: Lance Richardson --- drivers/net/bnxt/

[dpdk-dev] [PATCH 2/4] net/bnxt: keep consistent rxq start/stop state

2019-11-04 Thread Lance Richardson
k.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index ab889c10e..e82eda9d7

[dpdk-dev] [PATCH 3/4] net/bnxt: release hwrm lock before returning

2019-11-04 Thread Lance Richardson
nable RSS for thor-based controllers") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/d

[dpdk-dev] [PATCH 4/4] net/bnxt: fix rxq start/stop for Thor based NICs

2019-11-04 Thread Lance Richardson
started. - When stopping the last (or only) receive queue for a given VNIC, ensure that no packets can reach the default receive ring by temporarily setting the VNIC MRU to zero. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Cc: sta...@dpdk.org Signed-off-by: Lance

[dpdk-dev] [PATCH 1/4] net/bnxt: fix RSS table update for start/stop rxq

2019-11-04 Thread Lance Richardson
lso ensure that vnic->rx_queue_cnt is initialized to zero when reinitializing the VNIC array. Fixes: 36024b2e7fe5 ("net/bnxt: allow dynamic creation of VNIC") Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt

[dpdk-dev] [PATCH 0/4] net/bnxt: rxq stop/start fixes

2019-11-04 Thread Lance Richardson
This patch set fixes several problems involving stopping/starting receive queues in the bnxt PMD. Lance Richardson (4): net/bnxt: fix RSS table update for start/stop rxq net/bnxt: keep consistent rxq start/stop state net/bnxt: release hwrm lock before returning net/bnxt: fix rxq start

Re: [dpdk-dev] [PATCH 0/4] net/bnxt: rxq stop/start fixes

2019-11-04 Thread Lance Richardson
This patch set depends on the "bnxt patchset with bug fixes" series: http://patchwork.dpdk.org/project/dpdk/list/?series=7216 It is based on current dpdk-next-net-brcm. Lance On Mon, Nov 4, 2019 at 3:27 PM Lance Richardson wrote: > > > This patch set fixes several

[dpdk-dev] [PATCH] doc: update bnxt PMD guide

2019-07-03 Thread Lance Richardson
- Include list of supported adapters. - Include list of supported features. - Document requirements for vector mode PMD. - Remove obsolete limitation (scatter rx has been supported for some time). - Fixed broken links. Acked-by: Ajit Khaparde Signed-off-by: Lance Richardson --- doc/guides

Re: [dpdk-dev] testpmd / SR-IOV RX packets, but TX-errors

2019-10-15 Thread Lance Richardson
Hi Bill, This is just a guess, but perhaps the transmit drops are due to MAC anti-spoofing checks? You could probably prove/disprove by making the packet source MAC match the transmit VF's MAC. Lance On Tue, Oct 15, 2019 at 10:01 AM Bill Michalowski wrote: > > I'm trying run testpmd with

Re: [dpdk-dev] [PATCH 04/11] net/bnxt: fix double counting VLAN tags

2019-05-23 Thread Lance Richardson
On Thu, May 23, 2019 at 8:21 AM Maxime Coquelin wrote: ... > Isn't it fixing patch 2? > If so, Fixes line is wrong, and it should be squashed directly into > patch 2. Yes... thanks, will fix in v2. Lance

Re: [dpdk-dev] [PATCH 03/11] net/bnxt: implement vector mode driver

2019-05-23 Thread Lance Richardson
Hi Maxime, thanks for taking the time to review this. On Thu, May 23, 2019 at 8:18 AM Maxime Coquelin wrote: ... > How do we enable it with Meson build? It seems to be missing. Ah, thanks for pointing that out, I had completely missed the Meson piece. Will fix in v2. > > I think we would better

[dpdk-dev] [PATCH v2 00/10] bnxt patchset

2019-05-24 Thread Lance Richardson
for bnxt Lance Richardson (5): net/bnxt: move tx bd checking to header file net/bnxt: compute and store scattered RX status net/bnxt: implement vector mode driver net/bnxt: use reta update mask and translate qid to grp id net/bnxt: fix reta query op config/common_base

[dpdk-dev] [PATCH v2 01/10] net/bnxt: move tx bd checking to header file

2019-05-24 Thread Lance Richardson
To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_txr.c | 15

[dpdk-dev] [PATCH v2 02/10] net/bnxt: compute and store scattered RX status

2019-05-24 Thread Lance Richardson
In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_ethdev.c | 23 +++ 1 file changed, 23

[dpdk-dev] [PATCH v2 03/10] net/bnxt: implement vector mode driver

2019-05-24 Thread Lance Richardson
Introduce vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- v2: * Squashed with v1 patch 4 ("fix double counting VLAN tags"). * Dropped two unnecessary coding style changes from bnxt_txr.h. config/common_base

[dpdk-dev] [PATCH v2 04/10] net/bnxt: fix RSS reta indirection table update

2019-05-24 Thread Lance Richardson
-by: Rahul Gupta Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 18 ++ drivers/net/bnxt/bnxt_hwrm.c | 1 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 52a6b94e0..2d892c

[dpdk-dev] [PATCH v2 05/10] net/bnxt: use reta update mask and translate qid to grp id

2019-05-24 Thread Lance Richardson
Fix the reta update function to only update table entries that are selected by the update mask. Translate queue number to firmware group ID when updating an entry. Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Signed-off-by: Lance Richardson Reviewed-by: Aji

[dpdk-dev] [PATCH v2 06/10] net/bnxt: fix reta query op

2019-05-24 Thread Lance Richardson
Fix reta query op to only return table entries as identfied by the provided mask. Translate firmware group IDs to queue numbers. Removed extraneous code from bnxt_reta_query_op(). Fixes: d819382543f3 ("net/bnxt: add RSS redirection table operations") Signed-off-by: Lance Richardson R

[dpdk-dev] [PATCH v2 07/10] net/bnxt: update HWRM API

2019-05-24 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514 insertions(+), 598 deletions(-) diff --git a/drivers/net/bnxt

[dpdk-dev] [PATCH v2 08/10] net/bnxt: update HWRM version

2019-05-24 Thread Lance Richardson
From: Ajit Khaparde Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions(+), 282 deletions(-) diff --git a/drivers/net/bnxt

[dpdk-dev] [PATCH v2 10/10] net/bnxt: update release notes for bnxt

2019-05-24 Thread Lance Richardson
From: Ajit Khaparde Update release doc briefly describing updates to bnxt PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_19_08.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst inde

[dpdk-dev] [PATCH v2 09/10] net/bnxt: HWRM version update

2019-05-24 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399 1 file changed, 1168 insertions(+), 231 deletions(-) diff --git a/drivers/net/bnxt

Re: [dpdk-dev] [PATCH v2 01/10] net/bnxt: move tx bd checking to header file

2019-05-27 Thread Lance Richardson
Apologies for the confusion. Regards, Lance On Mon, May 27, 2019 at 11:24 AM Ferruh Yigit wrote: > > On 5/27/2019 10:36 AM, Ferruh Yigit wrote: > > On 5/24/2019 3:49 PM, Lance Richardson wrote: > >> To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between >

Re: [dpdk-dev] [PATCH v2 03/10] net/bnxt: implement vector mode driver

2019-05-28 Thread Lance Richardson
On Tue, May 28, 2019 at 5:08 AM Ferruh Yigit wrote: > > On 5/24/2019 3:49 PM, Lance Richardson wrote: > > @@ -1597,6 +1659,8 @@ > > > > bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id, > > > > static int bnxt_mtu_set_op(struct rt

Re: [dpdk-dev] [PATCH v2 09/10] net/bnxt: HWRM version update

2019-05-28 Thread Lance Richardson
WIll do. Thanks, Lance On Tue, May 28, 2019 at 5:12 AM Ferruh Yigit wrote: > > On 5/24/2019 3:49 PM, Lance Richardson wrote: > > From: Ajit Khaparde > > > > Update HWRM API to version 1.10.0.74 > > There are three commits related: > "update HWRM API&

Re: [dpdk-dev] [PATCH v2 00/10] bnxt patchset

2019-05-28 Thread Lance Richardson
On Tue, May 28, 2019 at 5:19 AM Ferruh Yigit wrote: ... > There are warnings from > "./devtools/checkpatches.sh" & "./devtools/check-git-log.sh" > Can you please address them in next version? > > It is acceptable to have some level of "checkpatches.sh" in the base code > update > (HWRM update cod

[dpdk-dev] [PATCH v3 0/8] bnxt patchset

2019-05-28 Thread Lance Richardson
net/bnxt: update HWRM API to version 1.10.0.19 net/bnxt: update HWRM API to version 1.10.0.48 net/bnxt: update HWRM API to version 1.10.0.74 Lance Richardson (3): net/bnxt: move Tx bd checking to header file net/bnxt: compute and store scattered Rx status net/bnxt: implement vector mode

[dpdk-dev] [PATCH v3 2/8] net/bnxt: move Tx bd checking to header file

2019-05-28 Thread Lance Richardson
To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_txr.c | 15

[dpdk-dev] [PATCH v3 3/8] net/bnxt: compute and store scattered Rx status

2019-05-28 Thread Lance Richardson
In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_ethdev.c | 23 +++ 1 file changed, 23

[dpdk-dev] [PATCH v3 4/8] net/bnxt: implement vector mode driver

2019-05-28 Thread Lance Richardson
Introduce SSE vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- v2: * Squashed with v1 patch 4 ("fix double counting VLAN tags"). * Dropped two unnecessary coding style changes from bnxt_txr.h. v3: * Eliminated vector mode configr

[dpdk-dev] [PATCH v3 1/8] net/bnxt: update release notes for bnxt

2019-05-28 Thread Lance Richardson
Signed-off-by: Ajit Khaparde Signed-off-by: Lance Richardson --- doc/guides/rel_notes/release_19_08.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index 5ebb564b1..2b66f41f5 100644 --- a/doc/guides/rel

[dpdk-dev] [PATCH v3 5/8] net/bnxt: fix RSS RETA indirection table ops

2019-05-28 Thread Lance Richardson
de Signed-off-by: Lance Richardson Reviewed-by: Rahul Gupta Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Cc: sta...@dpdk.org --- v3: * Squashed three RSS RETA fix commits into one. drivers/net/bnxt/bnxt_ethdev.c | 92 +- drivers/net/bnxt/bnxt_hwr

[dpdk-dev] [PATCH v3 6/8] net/bnxt: update HWRM API to version 1.10.0.19

2019-05-28 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514

[dpdk-dev] [PATCH v3 7/8] net/bnxt: update HWRM API to version 1.10.0.48

2019-05-28 Thread Lance Richardson
From: Ajit Khaparde Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions

[dpdk-dev] [PATCH v3 8/8] net/bnxt: update HWRM API to version 1.10.0.74

2019-05-28 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. doc/guides/rel_notes/release_19_08.rst |1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399

Re: [dpdk-dev] [PATCH v3 4/8] net/bnxt: implement vector mode driver

2019-05-29 Thread Lance Richardson
On Wed, May 29, 2019 at 2:48 AM Maxime Coquelin wrote: > > > > On 5/28/19 9:23 PM, Lance Richardson wrote: > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > > index 5b3932b7b..bccba445a 100644 > > --- a/drivers/net/bnxt/bnxt_ethde

[dpdk-dev] [PATCH v4 0/8] bnxt patchset

2019-05-29 Thread Lance Richardson
): net/bnxt: update release notes for bnxt net/bnxt: fix RSS RETA indirection table ops net/bnxt: update HWRM API to version 1.10.0.19 net/bnxt: update HWRM API to version 1.10.0.48 net/bnxt: update HWRM API to version 1.10.0.74 Lance Richardson (3): net/bnxt: move Tx bd checking to

[dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
Signed-off-by: Ajit Khaparde Signed-off-by: Lance Richardson --- doc/guides/rel_notes/release_19_08.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index 5ebb564b1..2b66f41f5 100644 --- a/doc/guides/rel

[dpdk-dev] [PATCH v4 2/8] net/bnxt: move Tx bd checking to header file

2019-05-29 Thread Lance Richardson
To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_txr.c | 15

[dpdk-dev] [PATCH v4 5/8] net/bnxt: fix RSS RETA indirection table ops

2019-05-29 Thread Lance Richardson
de Signed-off-by: Lance Richardson Reviewed-by: Rahul Gupta Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Cc: sta...@dpdk.org --- v3: * Squashed three RSS RETA fix commits into one. drivers/net/bnxt/bnxt_ethdev.c | 92 +- drivers/net/bnxt/bnxt_hwr

[dpdk-dev] [PATCH v4 3/8] net/bnxt: compute and store scattered Rx status

2019-05-29 Thread Lance Richardson
In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- v4: * Moved a fix to bnxt_scattered_rx(), which is introduced in this patch, from patch

[dpdk-dev] [PATCH v4 4/8] net/bnxt: implement vector mode driver

2019-05-29 Thread Lance Richardson
Introduce SSE vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- v2: * Squashed with v1 patch 4 ("fix double counting VLAN tags"). * Dropped two unnecessary coding style changes from bnxt_txr.h. v3: * Eliminated vector mode configr

[dpdk-dev] [PATCH v4 6/8] net/bnxt: update HWRM API to version 1.10.0.19

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514

[dpdk-dev] [PATCH v4 7/8] net/bnxt: update HWRM API to version 1.10.0.48

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions

[dpdk-dev] [PATCH v4 8/8] net/bnxt: update HWRM API to version 1.10.0.74

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. doc/guides/rel_notes/release_19_08.rst |1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399

[dpdk-dev] 19.08 scheduling question

2019-05-29 Thread Lance Richardson
This page gives a "proposal deadline" of June 3 for the 19.08 release: https://core.dpdk.org/roadmap/ Apologies if this is a faq, but is the "proposal" simply a v1 patch set implementing the proposed change, or is some other mechanism to be used? Thanks, Lance

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
On Wed, May 29, 2019 at 2:16 PM Kevin Traynor wrote: > > On 29/05/2019 16:02, Lance Richardson wrote: > > From: Ajit Khaparde > > > > Update release doc briefly describing updates to bnxt PMD, > > including transmit optimization changes in the following > > co

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
On Wed, May 29, 2019 at 4:28 PM Lance Richardson wrote: > > On Wed, May 29, 2019 at 2:16 PM Kevin Traynor wrote: > > > > On 29/05/2019 16:02, Lance Richardson wrote: > > > From: Ajit Khaparde > > > > > > Update release doc briefly describing

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
I see now that you had fixed them up... sorry for the noise. On Wed, May 29, 2019 at 4:35 PM Lance Richardson wrote: > > On Wed, May 29, 2019 at 4:28 PM Lance Richardson > wrote: > > > > On Wed, May 29, 2019 at 2:16 PM Kevin Traynor wrote: > > > > > >

[dpdk-dev] [PATCH v5 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
nxt: optimize Tx batching") Signed-off-by: Ajit Khaparde Signed-off-by: Lance Richardson --- v5: * Corrected commit IDs and added Fixes: tags to commit log. doc/guides/rel_notes/release_19_08.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_

[dpdk-dev] [PATCH v5 2/8] net/bnxt: move Tx bd checking to header file

2019-05-29 Thread Lance Richardson
To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_txr.c | 15

[dpdk-dev] [PATCH v5 3/8] net/bnxt: compute and store scattered Rx status

2019-05-29 Thread Lance Richardson
In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- v4: * Moved a fix to bnxt_scattered_rx(), which is introduced in this patch, from patch

[dpdk-dev] [PATCH v5 0/8] bnxt patchset

2019-05-29 Thread Lance Richardson
Lance Richardson (3): net/bnxt: move Tx bd checking to header file net/bnxt: compute and store scattered Rx status net/bnxt: implement vector mode driver doc/guides/rel_notes/release_19_08.rst |6 + drivers/net/bnxt/Makefile |3 + drivers/net/bnxt/bnxt_ethdev.c

[dpdk-dev] [PATCH v5 4/8] net/bnxt: implement vector mode driver

2019-05-29 Thread Lance Richardson
Introduce SSE vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- v2: * Squashed with v1 patch 4 ("fix double counting VLAN tags"). * Dropped two unnecessary coding style changes from bnxt_txr.h. v3: * Eliminated vector mode configr

[dpdk-dev] [PATCH v5 5/8] net/bnxt: fix RSS RETA indirection table ops

2019-05-29 Thread Lance Richardson
de Signed-off-by: Lance Richardson Reviewed-by: Rahul Gupta Reviewed-by: Lance Richardson Reviewed-by: Ajit Khaparde Cc: sta...@dpdk.org --- v3: * Squashed three RSS RETA fix commits into one. drivers/net/bnxt/bnxt_ethdev.c | 92 +- drivers/net/bnxt/bnxt_hwr

[dpdk-dev] [PATCH v5 6/8] net/bnxt: update HWRM API to version 1.10.0.19

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514

[dpdk-dev] [PATCH v5 7/8] net/bnxt: update HWRM API to version 1.10.0.48

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions

[dpdk-dev] [PATCH v5 8/8] net/bnxt: update HWRM API to version 1.10.0.74

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. doc/guides/rel_notes/release_19_08.rst |1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399

[dpdk-dev] [PATCH 00/11] add support for BCM57508 controller

2019-06-02 Thread Lance Richardson
ch 11 adds thor-specific support for RSS. Lance Richardson (11): net/bnxt: endianness conversions in cp ring macros net/bnxt: fix ring type macro name usage net/bnxt: fix width in stats ctx endian conversion net/bnxt: use consistent values for vnic RSS rule net/bnxt: reset function earli

[dpdk-dev] [PATCH 04/11] net/bnxt: use consistent values for vnic RSS rule

2019-06-02 Thread Lance Richardson
Use consistent values for vnic->rss_rule. No functional change, these all equate to uint16_t 0x. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/b

[dpdk-dev] [PATCH 01/11] net/bnxt: endianness conversions in cp ring macros

2019-06-02 Thread Lance Richardson
Descriptor fields in CP ring are in little-endian form, convert to CPU endian before performing arithmetic operations. Also use more general comparison when checking for ring index wrap. Fixes: f2a768d4d186 ("net/bnxt: add completion ring") Cc: sta...@dpdk.org Signed-off-by: Lance

[dpdk-dev] [PATCH 02/11] net/bnxt: fix ring type macro name usage

2019-06-02 Thread Lance Richardson
Use consistent macro names for ring type values. (There is no functional change, the "alloc" and "free" values are identical.) Fixes: 6371b91fb66d ("net/bnxt: add ring alloc/free") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar K

[dpdk-dev] [PATCH 05/11] net/bnxt: reset function earlier in initialization

2019-06-02 Thread Lance Richardson
Move function reset to beginnng of initialization sequence. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt

[dpdk-dev] [PATCH 07/11] net/bnxt: refactor doorbell handling

2019-06-02 Thread Lance Richardson
Reduce code duplication and prepare for newer controllers that use different doorbell protocols by refactoring doorbell handling code. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_cpr.h | 27 -- drivers/net/bnxt/bnxt_irq.c

[dpdk-dev] [PATCH 06/11] net/bnxt: support extended hwrm request sizes

2019-06-02 Thread Lance Richardson
Enable support for extended request sizes. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 31 ++- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 03/11] net/bnxt: fix width in stats ctx endian conversion

2019-06-02 Thread Lance Richardson
Use 32-bit conversion width when converting to 32-bit values. Fixes: 6371b91fb66d ("net/bnxt: add ring alloc/free") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 8 1 file changed, 4 insertions(+), 4

[dpdk-dev] [PATCH 09/11] net/bnxt: add support for thor controller

2019-06-02 Thread Lance Richardson
This commit adds support to the bnxt PMD for devices based on the BCM57508 "thor" Ethernet controller. Signed-off-by: Ajit Kumar Khaparde Signed-off-by: Kalesh AP Signed-off-by: Lance Richardson --- drivers/net/bnxt/bnxt.h| 98 +++- drivers/net/bnxt/bnxt_cpr.

[dpdk-dev] [PATCH 08/11] net/bnxt: refactor ring allocation code

2019-06-02 Thread Lance Richardson
Reduce code duplication and prepare for supporting hardware with different ring allocation requirements by refactoring ring allocation code. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ring.c | 167 ++- 1 file

[dpdk-dev] [PATCH 10/11] net/bnxt: enable completion coalescing for thor

2019-06-02 Thread Lance Richardson
Enable completion coalescing for Thor-based adapters. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 42 +--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b

[dpdk-dev] [PATCH 11/11] net/bnxt: enable RSS for thor-based adapters

2019-06-02 Thread Lance Richardson
Enable rss support for thor-based adapters. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 69 ++-- drivers/net/bnxt/bnxt_hwrm.c | 190 +++-- drivers/net/bnxt/bnxt_hwrm.h | 6 +- drivers/net/bnxt

[dpdk-dev] [PATCH 11/11] net/bnxt: enable RSS for thor-based controllers

2019-06-02 Thread Lance Richardson
Make changes needed to support rss for thor-based controllers. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 69 ++-- drivers/net/bnxt/bnxt_hwrm.c | 190 +++-- drivers/net/bnxt/bnxt_hwrm.h | 6

Re: [dpdk-dev] [PATCH 04/12] net/bnxt: remove unnecessary cast

2019-06-04 Thread Lance Richardson
bnxt/rte_pmd_bnxt.c | 32 ++-- > 8 files changed, 74 insertions(+), 74 deletions(-) > Acked-by: Lance Richardson

[dpdk-dev] [PATCH] doc: update NIC support guide for bnxt and release notes

2019-06-07 Thread Lance Richardson
From: Ajit Khaparde Add support for the Broadcom NetXtreme-E (BCM57500) family of controllers (aka Thor). The BCM57500 device is a 200G Ethernet controller with 50G PAM-4 and PCIe 4.0 Signed-off-by: Ajit Khaparde Signed-off-by: Lance Richardson --- doc/guides/nics/bnxt.rst | 6

Re: [dpdk-dev] [PATCH 00/11] add support for BCM57508 controller

2019-06-07 Thread Lance Richardson
On Fri, Jun 7, 2019 at 6:52 AM Ferruh Yigit wrote: > > On 6/7/2019 11:48 AM, Ferruh Yigit wrote: > > On 6/2/2019 6:42 PM, Lance Richardson wrote: > >> NOTE: This patch series has dependencies on the "bnxt patchset" > >> series that is currently under

Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-11 Thread Lance Richardson
On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger wrote: > > On Mon, 10 Jun 2019 10:51:48 -0700 > Stephen Hemminger wrote: > > > While testing KNI with netvsc, saw lots of places more code > > could be safely removed from KNI kernel driver. > > > > This is still mostly "putting lipstick on a pig"

Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

2019-06-11 Thread Lance Richardson
On Tue, Jun 11, 2019 at 5:30 PM Stephen Hemminger wrote: > > On Tue, 11 Jun 2019 17:18:42 -0400 > Lance Richardson wrote: > > > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > > wrote: > > > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > > St

Re: [dpdk-dev] compilation failing - net/bnxt: add support for thor controller

2019-06-13 Thread Lance Richardson
OK, thanks. On Thu, Jun 13, 2019 at 8:34 PM Ajit Khaparde wrote: > > On Fri, Jun 14, 2019 at 7:47 AM Thomas Monjalon wrote: >> >> Hi, >> >> The line below makes compilation failing on master branch with some >> compilers. >> >> 03/06/2019 02:

[dpdk-dev] [PATCH 1/7] net/bnxt: fix thor tqm entry allocation

2019-08-30 Thread Lance Richardson
The current TQM backing store size isn't sufficient to allow 512 transmit rings. Fix by correcting TQM SP queue size calculation. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH 2/7] net/bnxt: fix ring alignment for thor-based adapters

2019-08-30 Thread Lance Richardson
oller") Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index ec17783cf..bc8b92b04 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/d

[dpdk-dev] [PATCH 0/7] bnxt patchset for thor and bnxt vector PMD

2019-08-30 Thread Lance Richardson
Fixes and enhancements for adapters based on the BCM57500 controller and the bnxt vector PMD. Patch set is against dpdk-next-net. **Note** this patch series is dependent on the "bnxt patchset to support device error recovery" series. Lance Richardson (7): net/bnxt: fix thor

[dpdk-dev] [PATCH 3/7] net/bnxt: use common receive/transmit NQ ring

2019-08-30 Thread Lance Richardson
Thor queue scaling is currently limited by the number of NQs that can be allocated. Fix by using a common NQ for all receive/transmit rings instead of allocating a separate NQ for each ring. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance Richardson R

[dpdk-dev] [PATCH 5/7] net/bnxt: add support for LRO for thor adapters

2019-08-30 Thread Lance Richardson
Add support for LRO for adapters based on Thor (BCM57500). Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- doc/guides/rel_notes/release_19_11.rst | 6 +++ drivers/net/bnxt/bnxt.h| 16 ++ drivers/net/bnxt/bnxt_ethdev.c | 4 ++ drivers/net/bnxt

[dpdk-dev] [PATCH 4/7] net/bnxt: use correct default Rx queue for thor

2019-08-30 Thread Lance Richardson
Use first receive queue assigned to VNIC as the default receive queue when configuring Thor VNICs. This is necessary e.g. in order for flow redirection to a specific receive queue to work correctly. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance

[dpdk-dev] [PATCH 6/7] net/bnxt: fix scatter receive offload capability

2019-08-30 Thread Lance Richardson
Scattered receive is supported but not included in receive offload capabilities. Fix by adding it and including in scattered receive calculation. Fixes: 9c1507d96ab8 ("net/bnxt: switch to the new offload API") Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- d

[dpdk-dev] [PATCH 7/7] net/bnxt: improve CPR handling in vector PMD

2019-08-30 Thread Lance Richardson
/bnxt: implement SSE vector mode") Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/driver

[dpdk-dev] [PATCH 0/2] net/bnxt: fix outer checksum status

2020-12-18 Thread Lance Richardson
From: Lance Richardson Receive checksum offload status flags in the mbuf ol_flags field should include inner/outer status only when outer checksum offload is enabled, which currently isn't the case for the bnxt PMD. Fix by using a hw-to-ol_flags mapping table that is constructed bas

[dpdk-dev] [PATCH 1/2] net/bnxt: make offload flags mapping per-ring

2020-12-18 Thread Lance Richardson
From: Lance Richardson Refactor offload flags mapping table to be dynamic and per-ring instead of static and global. Signed-off-by: Lance Richardson Cc: sta...@dpdk.org --- drivers/net/bnxt/bnxt_rxr.c | 34 +-- drivers/net/bnxt/bnxt_rxr.h | 12

[dpdk-dev] [PATCH 2/2] net/bnxt: fix ol_flags checksum status

2020-12-18 Thread Lance Richardson
From: Lance Richardson The setting of the mbuf ol_flags field for tunneled packets should be different depending upon whether DEV_RX_OFFLOAD_OUTER_* offloads are enabled. Initialize ol_flags mappings based on the receive offload configuration when the receive ring is initialized. Signed-off-by

<    1   2   3   >