[PATCH v2 12/22] pdcp: add control PDU handling

2023-04-14 Thread Anoob Joseph
Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 1 + doc/guides/prog_guide/pdcp_lib.rst | 10 +++ lib/pdcp

[PATCH v2 13/22] pdcp: implement t-Reordering and packet buffering

2023-04-14 Thread Anoob Joseph
se packets would be held in the buffer, waiting for any missing packets to arrive. Introduce packet buffering and state variables which indicate status of the timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/meson.build| 3 +- lib/pdcp/pdcp_entity.h | 19 ++

[PATCH v2 14/22] test/pdcp: add in-order delivery cases

2023-04-14 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr

[PATCH v2 15/22] pdcp: add timer callback handlers

2023-04-14 Thread Anoob Joseph
when a missing packet is received. To avoid dependency on particular timer implementation, PDCP library allows application to register two callbacks, timer_start() and timer_stop() that will be called later by library. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib

[PATCH v2 16/22] pdcp: add timer expiry handle

2023-04-14 Thread Anoob Joseph
notified, and further handling of the event will be performed in the PDCP library. When the timer expires, the PDCP library will return the cached packets, and PDCP internal state variables (like RX_REORD, RX_DELIV etc) will be updated accordingly. Signed-off-by: Anoob Joseph Signed-off-by

[PATCH v2 17/22] test/pdcp: add timer expiry cases

2023-04-14 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 325 +++ 1 file changed, 325 insertions(+) diff --git a/app/test

[PATCH v2 18/22] test/pdcp: add timer restart case

2023-04-14 Thread Anoob Joseph
From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 67 1 file changed, 67 insertions(+) diff

[PATCH v2 19/22] pdcp: add support for status report

2023-04-14 Thread Anoob Joseph
From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib

[PATCH v2 20/22] pdcp: allocate reorder buffer alongside with entity

2023-04-14 Thread Anoob Joseph
From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9

[PATCH v2 21/22] pdcp: add thread safe processing

2023-04-14 Thread Anoob Joseph
requires thread safe processing, the state variables need to be updated atomically. Add config option to select this option per entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 46 + lib/pdcp/pdcp_process.c

[PATCH v2 22/22] test/pdcp: add PDCP status report cases

2023-04-14 Thread Anoob Joseph
From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 310 +++ 1 file changed, 310 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

RE: [PATCH v1] test/event_crypto_adapter: fix runtime parameter test

2023-04-17 Thread Anoob Joseph
; Fixes: 04ed18cd41f1 ("eventdev/crypto: support runtime set/get > parameters") > > Signed-off-by: Shijith Thotton > --- > app/test/test_event_crypto_adapter.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Acked-by: Anoob Joseph <>

[PATCH] app/crypto-perf: check crypto result

2023-04-20 Thread Anoob Joseph
Check crypto result in latency tests. Checking result won't affect the test results as latency is calculated using timestamps which are done before enqueue and after dequeue. Ignoring result means the data can be false positive. Signed-off-by: Anoob Joseph --- app/test-crypto

[PATCH v2] app/crypto-perf: check crypto result

2023-04-20 Thread Anoob Joseph
Check crypto result in latency tests. Checking result won't affect the test results as latency is calculated using timestamps which are done before enqueue and after dequeue. Ignoring result means the data can be false positive. Signed-off-by: Anoob Joseph --- v2: - Improved result check (

[PATCH] cryptodev: clarify error codes returned

2023-04-24 Thread Anoob Joseph
ilure. Clarifying this in the spec to list down possible error codes. Fixes: bdce2564dbf7 ("cryptodev: rework session framework") Signed-off-by: Anoob Joseph --- lib/cryptodev/rte_cryptodev.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_cr

RE: [EXT] [PATCH v5] app/dma-perf: introduce dma-perf application

2023-06-09 Thread Anoob Joseph
Hi, Thanks for adding the app. Few comments inline. Please check. Thanks, Anoob > -Original Message- > From: Cheng Jiang > Sent: Thursday, June 8, 2023 2:14 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > m...@smartsharesystems.com; chenbo@intel.com > Cc: dev@dpdk.org; j

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-14 Thread Anoob Joseph
intel.com; Amit Prakash Shukla > ; Anoob Joseph > Cc: dev@dpdk.org; jiayu...@intel.com; xuan.d...@intel.com; > wenwux...@intel.com; yuanx.w...@intel.com; xingguang...@intel.com; > Cheng Jiang > Subject: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf a

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-15 Thread Anoob Joseph
Hi Cheng, Please see inline. Thanks, Anoob > -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, June 15, 2023 1:31 PM > To: Anoob Joseph ; tho...@monjalon.net; > Richardson, Bruce ; > m...@smartsharesystems.com; Xia, Chenbo ; Amit > Prakash Shukla > Cc:

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-15 Thread Anoob Joseph
Hi Cheng, Please see inline. Thanks, Anoob > -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, June 15, 2023 7:36 PM > To: Anoob Joseph > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; tho...@monjalon.net; Richardson, Bruce > ; m...@smartsharesystems.com;

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-15 Thread Anoob Joseph
Hi Cheng, Please see inline. Thanks, Anoob > -Original Message- > From: Jiang, Cheng1 > Sent: Friday, June 16, 2023 8:26 AM > To: Anoob Joseph > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; tho...@monjalon.net; Richardson, Bruce > ; m...@smartsharesystems.com;

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-16 Thread Anoob Joseph
Hi Cheng, > [Cheng] sure, no problem. Feel free to contact me if you have any more > questions. No further comments from my side. Can you submit next version? Top level, I think you may need to add a doc file for the new app. Few issues that we are also checking in our end, 1. The app is havin

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-16 Thread Anoob Joseph
[i], MAX_EAL_PARAM_LEN); new_argc++; } Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Friday, June 16, 2023 3:19 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; tho...@monjalon.net; Richa

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-18 Thread Anoob Joseph
Hi Cheng, Please see inline. Thanks, Anoob > -Original Message- > From: Jiang, Cheng1 > Sent: Sunday, June 18, 2023 11:05 AM > To: Anoob Joseph > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; tho...@monjalon.net; Richardson, Bruce > ; m...@smartsharesystems.com;

RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-18 Thread Anoob Joseph
1e214240 Author: Anoob Joseph Date: Thu Nov 3 18:16:11 2022 +0530 app/security-perf: add session performance test Thanks, Anoob

RE: [PATCH] test/pdcp: remove side affect from assertion

2023-06-19 Thread Anoob Joseph
> > Remove side affect from test assertion, to avoid different behaviour in non- > debug build. Issues reported by coverity scan. > > Coverity issue: 385419, 385420 > Fixes: 6f00462979ad ("test/pdcp: add timer expiry cases") > > Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph

RE: [EXT] [PATCH v8] app/dma-perf: introduce dma-perf application

2023-06-22 Thread Anoob Joseph
Prakash Shukla > ; Anoob Joseph ; > huangdeng...@huawei.com; kevin.la...@intel.com; > fengcheng...@huawei.com; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; jiayu...@intel.com; xuan.d...@intel.com; > wenwux...@intel.com; yuanx.w...@intel.com; xingguang...@intel.com; > weix.l...@int

RE: [EXT] [PATCH v8] app/dma-perf: introduce dma-perf application

2023-06-25 Thread Anoob Joseph
Hi Cheng, Please see inline. Thanks, Anoob > -Original Message- > From: Jiang, Cheng1 > Sent: Saturday, June 24, 2023 5:23 PM > To: Anoob Joseph ; tho...@monjalon.net; > Richardson, Bruce ; > m...@smartsharesystems.com; Xia, Chenbo ; Amit > Prakash Shukla ; hu

RE: [EXT] [PATCH v10] app/dma-perf: introduce dma-perf application

2023-06-27 Thread Anoob Joseph
0644 > app/test-dma-perf/config.ini create mode 100644 app/test-dma- > perf/main.c create mode 100644 app/test-dma-perf/main.h create mode > 100644 app/test-dma-perf/meson.build create mode 100644 > doc/guides/tools/dmaperf.rst > Thanks Cheng for addressing all the comments. Acked-by: Anoob Joseph Tested-by: Anoob Joseph

RE: [EXT] [PATCH v5 04/11] drivers/crypto: use rte_pktmbuf_mtod_offset

2023-07-10 Thread Anoob Joseph
> Replace explicit packet offset computations with > rte_pktmbuf_mtod_offset(). > > Signed-off-by: Stephen Hemminger Acked-by: Anoob Joseph

RE: [EXT] [PATCH v5 08/11] cpt: use rte_pktmbuf_mtod_offset

2023-07-10 Thread Anoob Joseph
> Replace explicit packet offset computations with > rte_pktmbuf_mtod_offset(). > > Signed-off-by: Stephen Hemminger Acked-by: Anoob Joseph

RE: [PATCH] crypto/openssl: fix segfault due to uninitialized var

2023-07-11 Thread Anoob Joseph
> > In some openSSL 3 libraries, uninitialized output variable cause segfault. It > is > always nice to initialize it. > > Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2") Bugzilla ID: > 1250 > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH] crypto/openssl: check for SM2 support in openssl 3.x lib

2023-07-11 Thread Anoob Joseph
> > In some version of openSSL 3 lib (for an instance, in linux distribution), if > SM2 > is not supported, driver should return error. > > Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2") Bugzilla ID: > 1250 > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH 0/1] Add security perf application

2022-09-26 Thread Anoob Joseph
Hi Akhil, Do you have any further comments? Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Friday, August 19, 2022 12:50 PM > To: Akhil Goyal > Cc: Aakash Sasidharan ; dev@dpdk.org; > techbo...@dpdk.org; Jerin Jacob Kollanukkaran ; Thomas > Monj

Re: [dpdk-dev] [PATCH] crypto/octeontx2: update min headroom and tailroom

2021-09-28 Thread Anoob Joseph
> > The driver consume 208B of tailroom but has min requirement as 8B and > headroom needed is 48B, but minimum requirement is set as 24B. This patch > correct minimum requirements which application should honour. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix lookaside IPsec capabilities

2021-09-28 Thread Anoob Joseph
> > Adding cbc, sha1-hmac and sha256-hmac to lookaside IPsec capabilities. > > Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") > Fixes: 61baeec4682c ("crypto/octeontx2: support AES-CBC SHA256-128- > HMAC") > > Signed-off-by:

[dpdk-dev] [PATCH] doc/guides: update dev list with Marvell crypto PMDs

2021-09-29 Thread Anoob Joseph
Update list with following PMDs, - crypto_cn9k - crypto_cn10k - crypto_octeontx - crypto_octeontx2 Also made the list alphabetical. Signed-off-by: Anoob Joseph --- doc/guides/tools/cryptoperf.rst | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/doc

Re: [dpdk-dev] [PATCH v2 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Anoob Joseph
Hi Konstanin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 29, 2021 4:26 PM > To: Archana Muniganti ; Akhil Goyal > ; Nicolau, Radu ; Zhang, Roy > Fan ; hemant.agra...@nxp.com > Cc: Anoob Jos

Re: [dpdk-dev] [PATCH v2 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 29, 2021 5:09 PM > To: Anoob Joseph ; Archana Muniganti > ; Akhil Goyal ; Nicolau, Radu > ; Zhang, Roy Fan ; > hemant.agra...@nxp.com

Re: [dpdk-dev] [EXT] [PATCH v7 3/8] security: add UDP params for IPsec NAT-T

2021-10-01 Thread Anoob Joseph
inha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > --- > lib/security/rte_security.h | 7 +++ > 1 file changed, 7 insertions(+) > Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH] crypto/cnxk: use IE engine group for IPsec

2021-10-03 Thread Anoob Joseph
> > Use IE engine group for cn9k IPsec. > > Signed-off-by: Archana Muniganti > --- > drivers/crypto/cnxk/cn9k_ipsec.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Acked-by: Anoob Joseph

RE: [PATCH 0/1] Add security perf application

2022-09-28 Thread Anoob Joseph
hich could have been integrated into "test-pmd" in a similar manner. But DPDK community decided to allow "test-flow-perf" and so the same logic can be applied here as well. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 2

RE: [EXT] Re: [PATCH v2 15/18] crypto/cnxk: remove unused ctx buf len

2022-09-28 Thread Anoob Joseph
er 28, 2022 3:44 PM > To: Akhil Goyal ; Jerin Jacob Kollanukkaran > ; Anoob Joseph > Cc: Archana Muniganti ; Tejasree Kondoj > ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v2 15/18] crypto/cnxk: remove unus

RE: [EXT] [PATCH v2 0/2] cryptodev: add SM3 and SM4 algorithms

2022-09-28 Thread Anoob Joseph
s/cryptodevs/features/default.ini | 4 > doc/guides/rel_notes/release_22_11.rst | 9 + > lib/cryptodev/rte_crypto_sym.h | 13 +++-- > lib/cryptodev/rte_cryptodev.c | 8 ++-- > 4 files changed, 30 insertions(+), 4 deletions(-) > > -- > 2.13.6 Series Acked-by: Anoob Joseph

RE: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level

2022-09-28 Thread Anoob Joseph
Hi Stephen, Please see inline. Thanks, Anoob > -Original Message- > From: Stephen Hemminger > Sent: Thursday, September 29, 2022 3:51 AM > To: Anoob Joseph > Cc: Honnappa Nagarahalli ; Jerin Jacob > Kollanukkaran ; dev@dpdk.org; > sean.morris...@intel.com > S

[PATCH v2] rcu: fix build failure with debug dp log level

2022-09-29 Thread Anoob Joseph
~~~ Fixes: 30a1de105a5f ("lib: remove unneeded header includes") Cc: sean.morris...@intel.com Signed-off-by: Anoob Joseph --- lib/rcu/rte_rcu_qsbr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index d81bf5e8db..36571c15df 100644 --- a/li

RE: [v1] crypto/cnxk: add support for fixed point multiplication

2022-10-07 Thread Anoob Joseph
> > Add fixed point multiplication for EC curve in CNXK. > > Signed-off-by: Kiran Kumar K > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

[PATCH 1/2] crypto/cnxk: align HW accessible field to ROC align

2022-10-11 Thread Anoob Joseph
Hardware accessible memory need to be aligned to ROC. Enforce the same. Move software specific fields to padding space. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 33 -- drivers/crypto/cnxk/cn10k_ipsec.c | 77 +++ drivers

[PATCH 2/2] crypto/cnxk: fix failure from session rework

2022-10-11 Thread Anoob Joseph
Post security session rework, CPTR got changed affecting cn9k IPsec functionality. Address the same. Also, move all s/w accessible fastpath fields to rte_security_session cacheline for better perf. Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Signed-off-by: An

RE: [v3] crypto/cnxk: support exponent type private key

2022-10-11 Thread Anoob Joseph
| 2 + > doc/guides/cryptodevs/features/cn9k.ini | 2 + > drivers/crypto/cnxk/cnxk_ae.h| 112 +++ > drivers/crypto/cnxk/cnxk_cryptodev.c | 1 + > 4 files changed, 97 insertions(+), 20 deletions(-) Acked-by: Anoob Joseph

[PATCH v2 1/2] crypto/cnxk: align HW accessible field to ROC align

2022-10-12 Thread Anoob Joseph
Hardware accessible memory need to be aligned to ROC. Enforce the same. Move software specific fields to padding space. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 33 -- drivers/crypto/cnxk/cn10k_ipsec.c | 77 +++ drivers

[PATCH v2 2/2] crypto/cnxk: fix failure from session rework

2022-10-12 Thread Anoob Joseph
Post security session rework, CPTR got changed affecting cn9k IPsec functionality. Address the same. Also, move all s/w accessible fast path fields to rte_security_session cacheline for better perf. Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Signed-off-by: An

[PATCH] test/cryptodev: fix PDCP vectors

2022-10-12 Thread Anoob Joseph
encap cases") Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity cases") Cc: sta...@dpdk.org Signed-off-by: Anoob Joseph --- ...est_cryptodev_security_pdcp_test_vectors.h | 280 +- 1 file changed, 140 insertions(+), 140 deletions(-) d

[dpdk-dev] [PATCH 0/3] Add user specified IV with lookaside IPsec

2021-08-15 Thread Anoob Joseph
random generator source. Depends on 1. http://patches.dpdk.org/project/dpdk/list/?series=18253 Anoob Joseph (2): security: support user specified IV test/crypto: add outbound known vector tests Tejasree Kondoj (1): crypto/cnxk: add IV in SA in lookaside IPsec debug mode app/test

[dpdk-dev] [PATCH 1/3] security: support user specified IV

2021-08-15 Thread Anoob Joseph
Enable user to provide IV to be used per security operation. This would be used with lookaside protocol offload for comparing against known vectors. By default, PMD would generate IV internally and would be random. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- lib/security

[dpdk-dev] [PATCH 2/3] crypto/cnxk: add IV in SA in lookaside IPsec debug mode

2021-08-15 Thread Anoob Joseph
From: Tejasree Kondoj Adding IV in SA in lookaside IPsec debug mode. It helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 16

[dpdk-dev] [PATCH 3/3] test/crypto: add outbound known vector tests

2021-08-15 Thread Anoob Joseph
Add outbound known vector tests. The tests would be skipped on PMDs which do not support IV provided by application. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 44 app/test

[dpdk-dev] [PATCH 0/5] Add SA lifetime in security

2021-08-17 Thread Anoob Joseph
dded for soft and hard expiry with number of packets. Depends on 1. http://patches.dpdk.org/project/dpdk/list/?series=18253 2. http://patches.dpdk.org/project/dpdk/list/?series=18292 Anoob Joseph (5): security: add SA lifetime configuration common/cnxk: support lifetime configuration cr

[dpdk-dev] [PATCH 1/5] security: add SA lifetime configuration

2021-08-17 Thread Anoob Joseph
`rte_crypto_op.aux_flags` field. In case of hard expiry, the packets will not be IPsec processed and would result in error. Signed-off-by: Anoob Joseph --- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- examples/ipsec-secgw/ipsec.c | 2 +- examples/ipsec-secgw/ipsec.h

[dpdk-dev] [PATCH 2/5] common/cnxk: support lifetime configuration

2021-08-17 Thread Anoob Joseph
Add support for SA lifetime configuration. Expiry can be either in units of octets or packets. Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 70

[dpdk-dev] [PATCH 3/5] crypto/octeontx2: add checks for life configuration

2021-08-17 Thread Anoob Joseph
Lifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/octeontx2

[dpdk-dev] [PATCH 4/5] test/crypto: add packets soft expiry tests

2021-08-17 Thread Anoob Joseph
Add tests to validate packets soft expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 21 +++-- app/test/test_cryptodev_security_ipsec.c | 18 -- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38

[dpdk-dev] [PATCH 5/5] test/crypto: add packets hard expiry tests

2021-08-17 Thread Anoob Joseph
Add tests to validate packets hard expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 19 ++- app/test/test_cryptodev_security_ipsec.c | 22 +++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38

[dpdk-dev] [PATCH] crypto/octeontx2: fix unaligned access to device memory

2021-08-26 Thread Anoob Joseph
From: Danny Patel Use otx2_mbox_memcpy() instead of memcpy() to prevent unaligned access. Fixes: a0645ed0d6ef ("crypto/octeontx2: discover capabilities") Cc: ktejas...@marvell.com Signed-off-by: Danny Patel Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev_

Re: [dpdk-dev] [PATCH v2] eventdev: update crypto adapter metadata structures

2021-08-30 Thread Anoob Joseph
ata change. > > Signed-off-by: Shijith Thotton Acked-by: Anoob Joseph

Re: [dpdk-dev] [EXT] Re: [PATCH 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-09-01 Thread Anoob Joseph
drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 + > > drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 28 +++ > > drivers/crypto/cnxk/meson.build | 2 +- > > drivers/crypto/cnxk/version.map | 5 + > > 5 files changed, 205 insertions(+), 71 deletions(-) > > > [SNIP] > > Acked-by: Ray Kinsella Acked-by: Anoob Joseph

Re: [dpdk-dev] [EXT] Re: [PATCH 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-09-01 Thread Anoob Joseph
; drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++ > > drivers/crypto/cnxk/version.map | 2 + > > 3 files changed, 103 insertions(+) > > > [SNIP] > > Acked-by: Ray Kinsella Acked-by: Anoob Joseph

[dpdk-dev] [PATCH 0/7] Improvements and fixes in crypto/cnxk PMDs

2021-09-02 Thread Anoob Joseph
Improvements and fixes to crypto_cn9k & crypto_cn10k PMDs. - Updated IPsec completion codes to match latest firmware - Updated ZUC API to match latest firmware - Added dual submission in crypto_cn9k PMD Depends on: http://patches.dpdk.org/project/dpdk/list/?series=18627 Anoob Josep

[dpdk-dev] [PATCH 1/7] common/cnxk: update to v1.13 ZUC API

2021-09-02 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for ZUC API change in ucode 1.13 Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_se.c| 150 drivers/common/cnxk/roc_se.h| 37 +- drivers/common/cnxk

[dpdk-dev] [PATCH 2/7] common/cnxk: update to v1.16 ucc codes

2021-09-02 Thread Anoob Joseph
Update to v1.16 microcode completion codes. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_ie_ot.h | 65 + 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/drivers/common/cnxk/roc_ie_ot.h b/drivers/common/cnxk/roc_ie_ot.h index

[dpdk-dev] [PATCH 3/7] crypto/cnxk: remove redundant snow3g dec

2021-09-02 Thread Anoob Joseph
The opcode for encryption & decryption is the same and single routine would be able to handle both encryption and decryption operations. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 232 -- 1 file changed, 17 insertions(+),

[dpdk-dev] [PATCH 4/7] crypto/cnxk: remove redundant memcpy of IV for ZUC

2021-09-02 Thread Anoob Joseph
Swap is not required for ZUC. Update IV updation sequence to remove the redundant swap in case of ZUC. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 55 +++ 1 file changed, 30 insertions(+), 25 deletions(-) diff --git a/drivers/crypto

[dpdk-dev] [PATCH 5/7] crypto/cnxk: remove redundant assignment

2021-09-02 Thread Anoob Joseph
The assignment to -1 is not required. Remove the same. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b

[dpdk-dev] [PATCH 6/7] crypto/cnxk: support for ucode API change

2021-09-02 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for API changes in ucode 1.13 Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_se.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index bbad289

[dpdk-dev] [PATCH 7/7] crypto/cnxk: add dual submission in crypto_cn9k

2021-09-02 Thread Anoob Joseph
Submit two instructions with one LMTST operation. Also updated dequeue path to have local var for constants. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 155 +-- 1 file changed, 127 insertions(+), 28 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v3 0/5] Add lookaside IPsec tests

2021-09-02 Thread Anoob Joseph
Dropped outbound known vector tests as lookaside protocol would require IV generated by PMD. The tests would be introduced with spec change to allow user to specify IV. - Added IV generation tests - Minor fixes in combined mode tests to handle multiple packets Anoob Joseph (2): test/crypto: add l

[dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests

2021-09-02 Thread Anoob Joseph
Added test case for lookaside IPsec. Inbound known vector tests are added. Cipher list: AES-GCM 128, 192 & 256 Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/meson.build | 1 + app/test/test.h|

[dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests

2021-09-02 Thread Anoob Joseph
Add framework to test IPsec features with all supported combinations of ciphers. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 73 +++-- app/test/test_cryptodev_security_ipsec.c | 107

[dpdk-dev] [PATCH v3 3/5] test/crypto: add lookaside IPsec ICV corrupt test case

2021-09-02 Thread Anoob Joseph
From: Tejasree Kondoj Adding lookaside IPsec ICV corrupt test case. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 16 app/test/test_cryptodev_security_ipsec.c | 30 -- app/test

[dpdk-dev] [PATCH v3 4/5] test/crypto: add IV gen tests

2021-09-02 Thread Anoob Joseph
From: Tejasree Kondoj Add test cases to verify IV generated by PMD. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 app/test/test_cryptodev_security_ipsec.c | 52 app/test

[dpdk-dev] [PATCH v3 5/5] test/crypto: add UDP encapsulation test cases

2021-09-02 Thread Anoob Joseph
From: Tejasree Kondoj Adding UDP encapsulation test cases. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c| 19 +++ app/test/test_cryptodev_security_ipsec.c | 28 app/test/test_cryptodev_security_ipsec.h | 1 + 3 files

Re: [dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests

2021-09-03 Thread Anoob Joseph
Hi Ciara, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Power, Ciara > Sent: Friday, September 3, 2021 3:09 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan ; Ananyev, Konstantin > > Cc: J

Re: [dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests

2021-09-03 Thread Anoob Joseph
Hi Ciara, Please see inline. Thanks, Anoob > > External Email > > -- > Hi Anoob, > > >-Original Message----- > >From: Anoob Joseph > >Sent: Friday 3 September 2021 05:47 > >To

Re: [dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests

2021-09-03 Thread Anoob Joseph
HI Ciara, Please see inline. Thanks, Anoob > > External Email > > -- > Hi Anoob, > > > >-Original Message- > >From: Anoob Joseph > >Sent: Friday 3 September 2021 11:05 > &g

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-06 Thread Anoob Joseph
; -Original Message- > From: Nicolau, Radu > Sent: Monday, September 6, 2021 4:51 PM > To: Akhil Goyal ; Declan Doherty > > Cc: dev@dpdk.org; m...@ashroe.eu; konstantin.anan...@intel.com; > vladimir.medved...@intel.com; bruce.richard...@intel.com; > roy.fan.zh...@int

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-06 Thread Anoob Joseph
Hi Radu, Akhil, Please see inline Thanks, Anoob > > On 9/6/2021 12:36 PM, Anoob Joseph wrote: > > Hi Radu, > > > >> Hi Akhil, I suppose they can be complementary, with this one being a > >> hard ESN limit that the user can enforce by setting the init

[dpdk-dev] [PATCH v2 0/3] Add user specified IV with lookaside IPsec

2021-09-06 Thread Anoob Joseph
random generator source. Depends on http://patches.dpdk.org/project/dpdk/list/?series=18642 Changes in v2: - Updated crypto/cnxk patch to handle non-aes-gcm cases - Rebased on v3 of lookaside IPsec tests Anoob Joseph (2): security: support user specified IV test/crypto: add outbound known

[dpdk-dev] [PATCH v2 1/3] security: support user specified IV

2021-09-06 Thread Anoob Joseph
Enable user to provide IV to be used per security operation. This would be used with lookaside protocol offload for comparing against known vectors. By default, PMD would generate IV internally and would be random. Signed-off-by: Anoob Joseph --- doc/guides/rel_notes/release_21_11.rst | 5

[dpdk-dev] [PATCH v2 2/3] crypto/cnxk: add IV in SA in lookaside IPsec debug mode

2021-09-06 Thread Anoob Joseph
From: Tejasree Kondoj Adding IV in SA in lookaside IPsec debug mode. It helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_ipsec.c | 16 + drivers

[dpdk-dev] [PATCH v2 3/3] test/crypto: add outbound known vector tests

2021-09-06 Thread Anoob Joseph
Add outbound known vector tests. The tests would be skipped on PMDs which do not support IV provided by application. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 44 app/test/test_cryptodev_security_ipsec.c | 16 +++- 2

Re: [dpdk-dev] [PATCH v2 0/6] add cn9k lookaside IPsec support

2021-09-07 Thread Anoob Joseph
create mode 100644 > drivers/crypto/cnxk/cn9k_ipsec.h create mode 100644 > drivers/crypto/cnxk/cn9k_ipsec_la_ops.h > > -- > 2.22.0 Series Acked-by: Anoob Joseph

[dpdk-dev] [PATCH v3 0/3] Add user specified IV with lookaside IPsec

2021-09-07 Thread Anoob Joseph
Joseph (2): security: support user specified IV test/crypto: add outbound known vector tests Tejasree Kondoj (1): crypto/cnxk: add IV in SA in lookaside IPsec debug mode app/test/test_cryptodev.c | 44 +++ app/test/test_cryptodev_security_ipsec.c

[dpdk-dev] [PATCH v3 1/3] security: support user specified IV

2021-09-07 Thread Anoob Joseph
Enable user to provide IV to be used per security operation. This would be used with lookaside protocol offload for comparing against known vectors. By default, PMD would generate IV internally and would be random. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- doc/guides/rel_notes

[dpdk-dev] [PATCH v3 2/3] crypto/cnxk: add IV in SA in lookaside IPsec debug mode

2021-09-07 Thread Anoob Joseph
From: Tejasree Kondoj Adding IV in SA in lookaside IPsec debug mode. It helps to verify lookaside PMD using known outbound vectors in lookaside autotest. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal --- drivers/crypto/cnxk/cn10k_ipsec.c

[dpdk-dev] [PATCH v3 3/3] test/crypto: add outbound known vector tests

2021-09-07 Thread Anoob Joseph
Add outbound known vector tests. The tests would be skipped on PMDs which do not support IV provided by application. Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal --- app/test/test_cryptodev.c| 44 app/test/test_cryptodev_security_ipsec.c

[dpdk-dev] [PATCH v2 0/6] Add SA lifetime in security

2021-09-07 Thread Anoob Joseph
ries - Updated release notes & deprecation notice Anoob Joseph (6): security: add SA lifetime configuration common/cnxk: support lifetime configuration crypto/octeontx2: add checks for life configuration test/crypto: add packets soft expiry tests test/crypto: add packets hard expiry tests

[dpdk-dev] [PATCH v2 1/6] security: add SA lifetime configuration

2021-09-07 Thread Anoob Joseph
`rte_crypto_op.aux_flags` field. In case of hard expiry, the packets will not be IPsec processed and would result in error. Signed-off-by: Anoob Joseph --- .../test_cryptodev_security_ipsec_test_vectors.h | 3 --- doc/guides/rel_notes/deprecation.rst | 5 doc/guides/rel_notes/release_21_11.rst

[dpdk-dev] [PATCH v2 2/6] common/cnxk: support lifetime configuration

2021-09-07 Thread Anoob Joseph
Add support for SA lifetime configuration. Expiry can be either in units of octets or packets. Also, updated cryptodev dequeue path to update crypto op result to indicate soft expiry. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 70

[dpdk-dev] [PATCH v2 3/6] crypto/octeontx2: add checks for life configuration

2021-09-07 Thread Anoob Joseph
Lifetime tracking is not supported by hardware and is not implemented in software either. Return failure when lifetime is configured. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/octeontx2

[dpdk-dev] [PATCH v2 4/6] test/crypto: add packets soft expiry tests

2021-09-07 Thread Anoob Joseph
Add tests to validate packets soft expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 21 +++-- app/test/test_cryptodev_security_ipsec.c | 18 -- app/test/test_cryptodev_security_ipsec.h | 4 +++- 3 files changed, 38

[dpdk-dev] [PATCH v2 5/6] test/crypto: add packets hard expiry tests

2021-09-07 Thread Anoob Joseph
Add tests to validate packets hard expiry handling. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 19 ++- app/test/test_cryptodev_security_ipsec.c | 22 +++--- app/test/test_cryptodev_security_ipsec.h | 1 + 3 files changed, 38

<    3   4   5   6   7   8   9   10   11   12   >