Hi Stephen,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Thursday, September 29, 2022 3:51 AM
> To: Anoob Joseph <ano...@marvell.com>
> Cc: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>; Jerin Jacob
> Kollanukkaran <jer...@marvell.com>; dev@dpdk.org;
> sean.morris...@intel.com
> Subject: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
>
> External Email
>
> ----------------------------------------------------------------------
> On Mon, 29 Aug 2022 22:21:51 +0530
> Anoob Joseph <ano...@marvell.com> wrote:
>
> > Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same
> > by including the required header when RTE_LOG_DP_LEVEL is set to
> > RTE_LOG_DEBUG.
> >
> > ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
> > 678 | "%s: status: least acked token = %" PRIu64,
> > | ^~~~~~
> >
> > Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> > Cc: sean.morris...@intel.com
> >
> > Signed-off-by: Anoob Joseph <ano...@marvell.com>
> > ---
> > lib/rcu/rte_rcu_qsbr.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> > d81bf5e8db..b0f1720ca1 100644
> > --- a/lib/rcu/rte_rcu_qsbr.h
> > +++ b/lib/rcu/rte_rcu_qsbr.h
> > @@ -37,6 +37,10 @@ extern "C" {
> > #include <rte_atomic.h>
> > #include <rte_ring.h>
> >
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h>
> #endif
> > +
> > extern int rt
>
> This is not the best way to fix this.
> Just always include the header file.
> Having it conditional can lead to more problems
[Anoob] The header include is only required when RTE_LOG_DP_LEVEL is lower than
RTE_LOG_DEBUG. I'm not sure how the tool runs, but it may still flag this
include as an unnecessary include. But I can make the change if the tool can
ignore this case.
@Sean, do you agree with the suggestion?
