Hi Thomas,
'struct roc_se_buf_ptr ctx_buf' has fields for a pointer and len. The field for
len was unused. It was removed and the required pointer was added in the parent
struct.
Thanks,
Anoob
> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Wednesday, September 28, 2022 3:44 PM
> To: Akhil Goyal <gak...@marvell.com>; Jerin Jacob Kollanukkaran
> <jer...@marvell.com>; Anoob Joseph <ano...@marvell.com>
> Cc: Archana Muniganti <march...@marvell.com>; Tejasree Kondoj
> <ktejas...@marvell.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH v2 15/18] crypto/cnxk: remove unused ctx buf len
>
> External Email
>
> ----------------------------------------------------------------------
> 09/08/2022 12:53, Anoob Joseph:
> > Ctx len buf field is unused. Remove it.
>
> There is no such field.
> What do you mean exactly?
>
> > -struct roc_se_fc_params {
> > - /* 0th cache line */
> > - union {
> > - struct roc_se_buf_ptr bufs[1];
> > - struct {
> > - struct roc_se_iov_ptr *src_iov;
> > - struct roc_se_iov_ptr *dst_iov;
> > - };
> > - };
> > - void *iv_buf;
> > - void *auth_iv_buf;
> > - struct roc_se_buf_ptr meta_buf;
> > - struct roc_se_buf_ptr ctx_buf;
> > - uint32_t rsvd2;
> > - uint8_t rsvd3;
> > - uint8_t iv_ovr;
> > - uint8_t cipher_iv_len;
> > - uint8_t auth_iv_len;
> > -
> > - /* 1st cache line */
> > - struct roc_se_buf_ptr aad_buf __plt_cache_aligned;
> > - struct roc_se_buf_ptr mac_buf;
> > -};
> > -
> > -PLT_STATIC_ASSERT((offsetof(struct roc_se_fc_params, aad_buf) % 128)
> == 0);
> > -
> > #define ROC_SE_PDCP_ALG_TYPE_ZUC 0
> > #define ROC_SE_PDCP_ALG_TYPE_SNOW3G 1
> > #define ROC_SE_PDCP_ALG_TYPE_AES_CTR 2
> > @@ -349,6 +323,25 @@ struct roc_se_ctx {
> > uint8_t *auth_key;
> > };
> >
> > +struct roc_se_fc_params {
> > + union {
> > + struct roc_se_buf_ptr bufs[1];
> > + struct {
> > + struct roc_se_iov_ptr *src_iov;
> > + struct roc_se_iov_ptr *dst_iov;
> > + };
> > + };
> > + void *iv_buf;
> > + void *auth_iv_buf;
> > + struct roc_se_ctx *ctx;
> > + struct roc_se_buf_ptr meta_buf;
> > + uint8_t cipher_iv_len;
> > + uint8_t auth_iv_len;
> > +
> > + struct roc_se_buf_ptr aad_buf;
> > + struct roc_se_buf_ptr mac_buf;
> > +};
>
>
