This series contains minor updates for net/enic. The first patch
supports SR-IOV VF, which now requires the use of admin channel. The
other patches are not related to VF, but included here to ease review.
Hyong Youb Kim (3):
net/enic: support SR-IOV VF using admin channel
net/enic: add speed
pport only
VF_CAPABILITY_REQUEST message or not support the admin channel at
all. When the VF driver detects such PF driver, it reverts to the
compatibility mode and does not use the admin channel. In this mode,
trust mode (e.g. enabling promiscuous mode) does not work.
Signed-off-by: Hyong You
Add 1400/14000 and 15000 models to the speed_capa list.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index
unicast check in
enic_set_mac_address().
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_main.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index e59b0a5077..b755b15d92
This series contains minor updates for net/enic. The first patch
supports SR-IOV VF, which now requires the use of admin channel. The
other patches are not related to VF, but included here to ease review.
---
v2:
* fix compiler warnings
Hyong Youb Kim (3):
net/enic: support SR-IOV VF using
pport only
VF_CAPABILITY_REQUEST message or not support the admin channel at
all. When the VF driver detects such PF driver, it reverts to the
compatibility mode and does not use the admin channel. In this mode,
trust mode (e.g. enabling promiscuous mode) does not work.
Signed-off-by: Hyong You
Add 1400/14000 and 15000 models to the speed_capa list.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index
unicast check in
enic_set_mac_address().
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_main.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index e59b0a5077..b755b15d92
Hyong Youb Kim (3):
net/enic: support SR-IOV VF using admin channel
net/enic: add speed capabilities for newer models
net/enic: allow multicast in MAC address add callback
doc/guides/nics/enic.rst | 123 ++--
doc/guides/rel_notes/release_24_11.rst | 5 +
drivers/net/enic
pport only
VF_CAPABILITY_REQUEST message or not support the admin channel at
all. When the VF driver detects such PF driver, it reverts to the
compatibility mode and does not use the admin channel. In this mode,
trust mode (e.g. enabling promiscuous mode) does not work.
Signed-off-by: Hyong You
Add 1400/14000 and 15000 models to the speed_capa list.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/enic.rst | 3 ++-
doc/guides/rel_notes/release_24_11.rst | 1 +
drivers/net/enic/enic_ethdev.c | 21 +
3 files changed
unicast check in
enic_set_mac_address().
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_main.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index e59b0a5077..b755b15d92
Recent VIC models can parse GENEVE, including options, and inner
packet headers. Enable GENEVE header and option flow items. Currently,
only the first option that follows the GENEVE header can be matched,
and the GENEVE header item must specify option length.
Signed-off-by: Hyong Youb Kim
. So, treat
ERR_EPERM as "no filtering available" instead of an unexpected error.
Fixes: 322b355f2183 ("net/enic/base: bring NIC interface functions up to date")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/base/vnic_dev.c
e real Rx handler, not
the dummy one set by (2). And, (3) causes a segfault in the real Rx
handler (e.g. dereferencing freed structures).
Fix the segfault by updating the fast-path pointer as well.
Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
Signed-off-b
advanced filtering is a prerequisite, check first
if it is available and avoid the error message altogether.
Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager
API")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net
Recent VIC models can parse GENEVE, including options, and inner
packet headers. Enable GENEVE header and option flow items. Currently,
only the first option that follows the GENEVE header can be matched,
and the GENEVE header item must specify option length.
Signed-off-by: Hyong Youb Kim
director implementation
(enic_clsf.c).
Fixes: 26faa126d87e ("net/enic: flow API for NICs with advanced filters
disabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/d
A debug message for filter API is using a wrong flag. Use the correct
one.
Fixes: 936a9b9975e7 ("net/enic: flow API debug")
Cc: sta...@dpdk.org
Reported-by: Hanoch Haim
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 2 +-
1 file changed, 1
(rte_ether_hdr) and
sizeof(rte_ipv6_hdr) instead.
Coverity issue: 363572, 363573
Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager
API")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_fm_flow.c | 10 +++
These are patches for 19.02.
Hyong Youb Kim (4):
net/enic: release port upon close
net/enic: add handler to return firmware version string
net/enic: support multicast filtering
doc: update release notes for enic
doc/guides/nics/features/enic.ini | 3 +-
doc/guides/rel_notes
Cisco VIC adapters run firmware. Add the fw_version_get handler to
help diagnostics.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/features/enic.ini | 1 +
drivers/net/enic/base/vnic_dev.c | 26 ++
drivers/net/enic/enic_ethdev.c| 21
Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so rte_eth_dev_close() can
later free port resources including mac_addrs.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 2 ++
drivers/net/enic/enic_main.c | 4 +---
2 files changed, 3 insertions(+), 3
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/rel_notes/release_19_02.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_02.rst
b/doc/guides/rel_notes/release_19_02.rst
index a94fa86a7..4c789d2a9 100644
--- a/doc/guides/rel_notes
The VIC hardware has 64 MAC filters per vNIC, which can be either
unicast or multicast. Use one half for unicast and the other half for
multicast, as the VIC kernel drivers for Linux and Windows do.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/features/enic.ini
On Tue, Dec 11, 2018 at 02:44:43AM +, Varghese, Vipin wrote:
> Hi Hyong,
>
> Thanks for sharing the information a query 'is ENIC Poll Mode Driver is been
> updated too?'(Section 16 under Network Interface Controller).
> a. If yes is it ok to link the patchwork in comment section?
> b. If no
On Tue, Dec 11, 2018 at 04:31:50PM +, Varghese, Vipin wrote:
> Hi Hyong,
>
> snipped
> > > Hi Hyong,
> > >
> > > Thanks for sharing the information a query 'is ENIC Poll Mode Driver is
> > > been
> > updated too?'(Section 16 under Network Interface Controller).
> > > a. If yes is it ok to lin
On Tue, Dec 11, 2018 at 04:49:26PM +, Varghese, Vipin wrote:
> snipped
[...]
>
> Apologies if the question was not clear, Let me try again 'Is there plan add
> test cases under dpdk/test/test folder?'
Not in this cycle.
Thanks.
-Hyong
A couple patches for minor issues found during in-house testing. I do
not have a strong opinion on the first one, as it is just a warning
message not technically a bug. But, the second one addresses an
easy-to-reproduce crash. If someone has a better/cleaner fix, I am all
ears.
Hyong Youb Kim (2
driver. This warning message is
harmless but can be confusing to the user. So do not try to set
promisc on a primary port when we know it does not exist (i.e. no
slaves).
Fixes: 2efb58cbab6e ("bond: new link bonding library")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
dri
rray and causing a crash.
Make the rx burst function to first check that active_slave is within
bound. If not, reset it to 0 to avoid out-of-range array access.
Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
d
On Mon, Oct 01, 2018 at 03:01:40PM +0100, Ferruh Yigit wrote:
> On 9/26/2018 4:06 AM, John Daley wrote:
> > From: Hyong Youb Kim
> >
> > Since the following commit, PKT_RX_VLAN indicates the presence of
> > mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED.
> >
On Tue, Oct 02, 2018 at 05:08:21PM +0100, Ferruh Yigit wrote:
> On 9/28/2018 8:25 PM, John Daley wrote:
> > From: Hyong Youb Kim
> >
> > Add the vectorized version of the no-scatter Rx handler. It aims to
> > process 8 descriptors per loop using AVX2 SIMD instructions.
73822 ("mbuf: fix Tx offload mask")
Hyong Youb Kim (3):
net/enic: fix supported packet types
net/enic: add missing Tx offload flags
doc: update release notes for the enic driver
doc/guides/rel_notes/release_18_11.rst | 7 +++
drivers/net/e
AVX2 based vectorized Rx handler")
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 30 +++---
1 file changed, 27 insertions(+), 3 deleti
Fixes: 8a6ff33d6d36 ("net/enic: add AVX2 based vectorized Rx handler")
Fixes: 86df6c4e2fce ("net/enic: support flow counter action")
Fixes: 70401fd7784d ("net/enic: add VLAN and csum offloads to simple Tx
handler")
Fixes: c0aae00d7da0 ("net/enic: enable IOVA mo
TX_OFFLOAD_MASK.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_main.c | 6 ++
drivers/net/enic/enic_res.c | 2 ++
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index b2581322d..e
heck_devargs(struct rte_eth_dev *dev)
> return 0;
> }
>
> -struct enic *enicpmd_list_head = NULL;
> /* Initialize the driver
> * It returns 0 on success.
> */
For net/enic.
Acked-by: Hyong Youb Kim
Thank you.
-Hyong
Fixes: 8a6ff33d6d36 ("net/enic: add AVX2 based vectorized Rx handler")
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index e81c3f3b7..c3869d
On Wed, Oct 31, 2018 at 05:47:40PM +, Alejandro Lucero wrote:
> On Wed, Oct 31, 2018 at 5:29 PM Alejandro Lucero <
> alejandro.luc...@netronome.com> wrote:
>
> > A patchset sent introducing DMA mask checks has several critical
> > issues precluding apps to execute. The patchset was reviewed an
The current code wrongly assumes that packets are non-TSO and ends up
rejecting large TSO packets. Check non-TSO and TSO max packet sizes
separately.
Fixes: 5a12c387405a ("net/enic: check maximum packet size in Tx prepare
handler")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
R
On Tue, Oct 23, 2018 at 11:01:58AM +0200, Olivier Matz wrote:
> Hi,
>
> You are right, the current code does not take IP or IPv6 options
> in account. I think this should be considered as a bug.
>
> The fix for IPv4 is not complicated, I did a quick draft here:
> http://git.droids-corp.org/?p=dpd
Hi Ferruh,
Please ignore this patch, as it never assigns the default handler to
rx_pkt_burst. We will send a v2. Sorry about that.
On Fri, Jul 13, 2018 at 05:54:52PM -0700, John Daley wrote:
> From: Hyong Youb Kim
>
> enic_set_mtu always reverts to the default Rx handler after chang
> ---
Thanks.
The patch looks good to me. I've tested it on top of dpdk-net-next. It
works as expected.
Acked-by: Hyong Youb Kim
>
> Changes since v1:
> - rebased on dpdk-next-net following mac_addr_set rework,
> - since enicpmd_remove_mac_addr() does not return an error cod
D_SCATTER |
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> - DEV_RX_OFFLOAD_CRC_STRIP |
> DEV_RX_OFFLOAD_VLAN_STRIP |
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
For net/enic.
Acked-by: Hyong Youb Kim
Drop is a fate-deciding action, so mark it as FATE. It was missing in
a previous commit.
Fixes: cc17feb90413 ("ethdev: alter behavior of flow API actions")
Signed-off-by: Hyong Youb Kim
Cc: adrien.mazarg...@6wind.com
---
drivers/net/enic/enic_flow.c | 3 +++
1 file changed, 3
The NIC always strips CRC, so advertise the CRC strip offload in
rx_offload_capa.
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_res.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/driver
On Mon, May 14, 2018 at 12:56:20AM -0700, Hyong Youb Kim wrote:
> The NIC always strips CRC, so advertise the CRC strip offload in
> rx_offload_capa.
Hi Ferruh,
Can you discard this patch? We are finding more offload flags are
missing. Will submit a new patch that sets them all instead
transmit has always been supported.
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_res.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_r
On Fri, Jan 11, 2019 at 03:46:47PM +, Ferruh Yigit wrote:
> On 12/10/2018 6:28 PM, Hyong Youb Kim wrote:
> > The VIC hardware has 64 MAC filters per vNIC, which can be either
> > unicast or multicast. Use one half for unicast and the other half for
> > multicast, as the V
Hyong Youb Kim (2):
net/enic: remove useless include
net/enic: remove redundant log level check
drivers/net/enic/enic_clsf.c | 2 --
drivers/net/enic/enic_ethdev.c | 9 -
drivers/net/enic/enic_main.c | 1 -
3 files changed, 4 insertions(+), 8 deletions(-)
--
2.16.2
Fixes: 8d496995346c ("net/enic: support multicast filtering")
Cc: sta...@dpdk.org
Suggested-by: Ferruh Yigit
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_ethdev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/enic/enic_ethdev.c
libgen.h is not used, so do not include it.
Fixes: fefed3d1e62c ("enic: new driver")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_clsf.c | 2 --
drivers/net/enic/enic_main.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/enic/eni
On Wed, Feb 20, 2019 at 02:56:36PM +, Radu Nicolau wrote:
>
>
> On 2/20/2019 12:33 PM, Ferruh Yigit wrote:
> > On 2/18/2019 3:58 PM, Radu Nicolau wrote:
> > >
> > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote:
> > > > test_alb_reply_from_client test fails due to incorrect active slave
> >
the input
argument, and use const in function signatures to make the intention
clear. Also move a couple function declarations to enic_clsf.c from
enic.h as they are strictly local.
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
Cc: sta...@dpdk.org
Signe
Remove unused functions. Specifically, vnic_set_rss_key() is
obsolete. enic_{add,del}_vlan() has never been supported in the
firmware. And, remove vnic_rss.c altogether as it becomes empty. These
were discovered by cppcheck.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net
s into struct"). I will submit backport
request for these separately, after rc1.
Hyong Youb Kim (15):
net/enic: remove unused code
net/enic: fix flow director SCTP matching
net/enic: fix SCTP match for flow API
net/enic: allow flow mark ID 0
net/enic: check for unsupported flow item t
or handler does the same (enic_clsf.c).
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 28 ++--
1 file changed,
with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index 0f6b6b930..c6ed9e1b9 100644
--- a/drivers/net/enic/enic_flow.c
+++ b/drivers/net/enic/enic_flow.c
purely mechanical and have no impact on
functionalities.
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 209 ++-
1 file changed, 67 insertions(+), 142 deletions(-)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c| 15 +++
drivers/net/enic/enic_rxtx_common.h | 3 ++-
2 files changed, 13 insertions(
ARK is not a fate-deciding action. And, the RSS action has a
most basic config: default hash, level, types, null key, and identity
queue mapping.
Recent VIC adapters can support these "mark and receive" flow
rules. So, enable support for RSS action for this limited use case.
Signed-of
match vxlan. So always reset the port number
when HW vxlan parsing is available.
Fixes: 8a4efd17410c ("net/enic: add handlers to add/delete vxlan port number")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_main.c | 9 -
1 file changed, 8 insert
The VLAN fields in the NIC filter use little endian. The VLAN item is
in big endian, so swap bytes.
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 12 --
/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 46 +++-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/
Some apps like VPP use a raw item to match UDP tunnel headers like
VXLAN or GENEVE. The NIC hardware supports such usage via L5 match,
which does pattern match on packet data immediately following the
outer L4 header. Accept raw items for these limited use cases.
Signed-off-by: Hyong Youb Kim
Minor changes to text around flow API.
- Add vlan to the supported items.
- Describe VLAN stripping's effect on ETH/VLAN match
- Mention limitations on MARK, RAW, RSS, and PASSTHRU
Signed-off-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst | 16 ++--
1 file changed, 14 inser
are mechanical, due to reduced indentation.
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 371 ++-
1 file changed, 224 insertions(+), 147 del
Signed-off-by: Hyong Youb Kim
---
doc/guides/rel_notes/release_19_05.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_notes/release_19_05.rst
index 4a3e2a7f3..9226dc5e9 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b
On Fri, Mar 01, 2019 at 03:26:24PM +0100, Thomas Monjalon wrote:
> Hi,
>
> > Hyong Youb Kim (15):
> > net/enic: remove unused code
> > net/enic: fix flow director SCTP matching
> > net/enic: fix SCTP match for flow API
> > net/enic: allow flow
Remove unused functions. Specifically, vnic_set_rss_key() is
obsolete. enic_{add,del}_vlan() has never been supported in the
firmware. And, remove vnic_rss.c altogether as it becomes empty. These
were discovered by cppcheck.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net
the input
argument, and use const in function signatures to make the intention
clear. Also move a couple function declarations to enic_clsf.c from
enic.h as they are strictly local.
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
Cc: sta...@dpdk.org
Signe
or handler does the same (enic_clsf.c).
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 28 ++--
1 file changed,
s into struct"). I will submit backport
request for these separately, after rc1.
---
v2:
* Merge doc changes with corresponding code changes.
Hyong Youb Kim (13):
net/enic: remove unused code
net/enic: fix flow director SCTP matching
net/enic: fix SCTP match for flow API
net/enic: all
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
doc/guides/nics/enic.rst| 1 +
drivers/net/enic/enic_flow.c| 15 +++
drivers/net/enic/enic_rxtx_commo
with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_flow.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index
Signed-off-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst | 6 +-
doc/guides/rel_notes/release_19_05.rst | 1 +
drivers/net/enic/enic_flow.c | 20
3 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/enic.rst b/doc/g
ARK is not a fate-deciding action. And, the RSS action has a
most basic config: default hash, level, types, null key, and identity
queue mapping.
Recent VIC adapters can support these "mark and receive" flow
rules. So, enable support for RSS action for this limited use case.
Signed-of
Some apps like VPP use a raw item to match UDP tunnel headers like
VXLAN or GENEVE. The NIC hardware supports such usage via L5 match,
which does pattern match on packet data immediately following the
outer L4 header. Accept raw items for these limited use cases.
Signed-off-by: Hyong Youb Kim
purely mechanical and have no impact on
functionalities.
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 209 ++-
1 file changed, 67 insertions(+), 142 deletions(-)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
match vxlan. So always reset the port number
when HW vxlan parsing is available.
Fixes: 8a4efd17410c ("net/enic: add handlers to add/delete vxlan port number")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_main.c | 9 -
1 file changed, 8 insert
The VLAN fields in the NIC filter use little endian. The VLAN item is
in big endian, so swap bytes.
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
doc/guides/nics/enic.rst | 10 --
d
are mechanical, due to reduced indentation.
Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters
enabled")
Signed-off-by: Hyong Youb Kim
---
doc/guides/rel_notes/release_19_05.rst | 2 +
drivers/net/enic/enic_flow.c | 371 -
/enic: flow API for NICs with advanced filters
enabled")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/enic_flow.c | 46 +++-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_flow.c b/drivers/
The driver currently has a devarg to set the rewrite mode during
init. Some apps want to programatically set it after running
rte_eal_init() and finding that ports are VIC. Add a private function
to support such applications.
Signed-off-by: Hyong Youb Kim
---
drivers/net/enic/Makefile
The driver currently has a devarg to set the rewrite mode during
init. Some apps want to programatically set it after running
rte_eal_init() and finding that ports are VIC. Add a private function
to support such applications.
Signed-off-by: Hyong Youb Kim
---
v2:
* Move symbol to the
On Fri, Apr 06, 2018 at 05:15:40PM +0100, Ferruh Yigit wrote:
> On 4/5/2018 12:54 AM, John Daley wrote:
> > From: Hyong Youb Kim
> >
> > Recent NIC models support overlay offload. The overlay offload
> > feature enables the following on the NIC.
> > - Rx/Tx che
>
> Signed-off-by: Stephen Hemminger
> ---
Here is an ack, in case you need it. Please feel free to add it to v4 if you
make it (i.e. dropping the leading _).
Acked-by: Hyong Youb Kim
FWIW, the NIC hardware (Cisco VIC) does autonegotiate. But, the link
settings (autoneg/fixed/10/25
On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote:
> On 1/23/2018 1:05 AM, John Daley wrote:
> > From: Hyong Youb Kim
> >
> > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only
> > for IPv4. The hardware actually validates the TCP/UDP c
On Wed, Jan 24, 2018 at 05:45:48PM +, Ferruh Yigit wrote:
> On 1/24/2018 5:30 PM, Hyong Youb Kim wrote:
> > On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote:
> >> On 1/23/2018 1:05 AM, John Daley wrote:
> >>> From: Hyong Youb Kim
> >>>
On Thu, Jan 25, 2018 at 09:01:01AM +, Harry van Haaren wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren
Acked-by: Hyong Youb Kim
On Fri, Mar 09, 2018 at 03:57:46PM +, Ferruh Yigit wrote:
> On 3/9/2018 3:51 PM, Ananyev, Konstantin wrote:
[...]
> >> Is this work based on an application that uses max_rx_pkt_len and to make
> >> PMD
> >> compatible with that application? If so we can continue with patch, but if
> >> the
>
On Fri, Mar 09, 2018 at 04:00:55PM +, Ferruh Yigit wrote:
[...]
> Series applied to dpdk-next-net/master, thanks.
>
> (typo in 2/10 fixed while applying)
Thanks a lot for fixing that. Adding "build with assert enabled" to our
checklist..
-Hyong
On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote:
> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement
> primary mac address handler.
>
> Signed-off-by: David Marchand
Hi, thanks for taking a stab at this.
> +static void enicpmd_set_mac_addr(struct rte_eth_dev
On Tue, Feb 20, 2018 at 10:17:34AM +0100, David Marchand wrote:
[...]
> Btw, I had forgotten about the deprecation notice [1] sent by Olivier.
> Just discussed it with him, let's wait for this change before looking
> at the issue again.
>
>
> 1:
> http://dpdk.org/browse/dpdk/commit/doc?id=16a700
On Thu, Mar 08, 2018 at 02:14:27PM -0800, Stephen Hemminger wrote:
> On Wed, 7 Mar 2018 18:47:00 -0800
> John Daley wrote:
>
> > 'catch-all' filters should be added last.
> >
> > +- **Statistics**
> > +
> > + - ``rx_good_bytes`` (ibytes) always includes VLAN header (4B) and CRC
> > byte
On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote:
> 13/03/2019 22:11, John Daley (johndale):
> > From: Thomas Monjalon
> > > 13/03/2019 19:32, Ferruh Yigit:
> > > > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote:
> > > > > The driver currentl
MTU to max HW value). This change
incidentally allows such apps to change MTU to max value successfully.
Fixes: bb34ffb848a0 ("net/enic: determine max egress packet size and max MTU")
Cc: sta...@dpdk.org
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic
[...]
> > > I see it can work if an application always wants this config option to
> > > have
> > > *same* value. So it can set this in eal_init() always.
> > >
> > > This requires "driver=xxx,key=value" kind of support in devargs.
> > >
> > >
> > > John, Hyong,
> > >
> > > I guess some lev
1 - 100 of 181 matches
Mail list logo
