On Thu, Jan 11, 2018 at 05:06:58PM +0000, Ferruh Yigit wrote: > From: Stephen Hemminger <step...@networkplumber.org> > > This driver was not doing atomic update of link status information. > And the return value was different than others. > The hardware also does not do autonegotiation (at least on Linux). > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > ---
Here is an ack, in case you need it. Please feel free to add it to v4 if you make it (i.e. dropping the leading _). Acked-by: Hyong Youb Kim <hyon...@cisco.com> FWIW, the NIC hardware (Cisco VIC) does autonegotiate. But, the link settings (autoneg/fixed/10/25/40) are controlled by a management entity (e.g. UCS manager). The drivers including the netdev enic driver cannot change them and currently do not know if the current speed has been autonegotiated or fixed by admin. So, they simply report the current link speed as fixed. I know, it is a little unconventional. -Hyong
