Re: [dpdk-dev] [PATCH v2] net/qede: move SPDX tags to source files

2018-07-15 Thread Hemant
  Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files

2018-07-15 Thread Hemant
files have the Cavium copyright two times (like above).  you may want to clean it in future patch.  Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 1/2] eal: remove deprecated function returning mbuf pool ops name

2018-08-08 Thread Hemant
On 8/8/2018 3:04 AM, Olivier Matz wrote: From: Olivier Matz rte_eal_mbuf_default_mempool_ops() is replaced by rte_mbuf_best_mempool_ops(). Signed-off-by: Olivier Matz Reviewed-by: Anatoly Burakov Acked-by: Santosh Shukla ---   Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 2/2] eal: remove experimental tag from user mbuf pool ops func

2018-08-08 Thread Hemant
On 8/8/2018 3:04 AM, Olivier Matz wrote: From: Olivier Matz Remove experimental tag from rte_eal_mbuf_user_pool_ops(). Signed-off-by: Olivier Matz Acked-by: Santosh Shukla ---   Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-08-29 Thread Hemant
On 8/29/2018 9:28 PM, eric zhang wrote: This patch adds a configuration option to force the IOVA mode to physical address (PA). There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detection of the IOVA mode based on probing the PCI bus and IOMMU conf

Re: [dpdk-dev] [PATCH 1/8] net/mvneta: add neta PMD skeleton

2018-08-30 Thread Hemant
Hi, On 8/28/2018 8:40 PM, Andrzej Ostruszka wrote: diff --git a/doc/guides/nics/mvneta.rst b/doc/guides/nics/mvneta.rst new file mode 100644 index 000..6e9f511 --- /dev/null +++ b/doc/guides/nics/mvneta.rst @@ -0,0 +1,182 @@ +.. SPDX-License-Identifier: BSD-3-Clause +Copyright(c) 2018 M

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-08-30 Thread Hemant
Hi, On 8/30/2018 3:13 PM, Gaëtan Rivet wrote: Hi, On Thu, Aug 30, 2018 at 10:09:04AM +0100, Burakov, Anatoly wrote: On 29-Aug-18 4:58 PM, eric zhang wrote: This patch adds a configuration option to force the IOVA mode to physical address (PA). There exists virtual devices that are not directl

Re: [dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

2018-09-18 Thread Hemant
On 9/18/2018 7:33 PM, Thomas Monjalon wrote: 18/09/2018 15:31, Hemant Agrawal: Avoid return after the jumbo buffer config in dev config API Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Thanks for a

Re: [dpdk-dev] [PATCH 07/21] net/atlantic: hardware register access routines

2018-09-23 Thread Hemant
Hi Igor, On 9/7/2018 8:51 PM, Igor Russkikh wrote: Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_hw_regs.c | 58 + drivers/net/atlantic/atl_hw_regs.h | 59 ++ 2 files changed, 117 insertions(+) create mode

Re: [dpdk-dev] [PATCH v2 2/2] eal: force IOVA to particular mode

2018-09-26 Thread Hemant
and IOMMU configuration may not report the required addressing mode. Using the EAL option permits the mode to be explicitly configured in this scenario. Signed-off-by: eric zhang Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 1/2] eal: add eal option to configure iova mode

2018-09-26 Thread Hemant
ff-by: Jerin Jacob Just wondering if you want to add some description in: 1. Prog Guide - EAL section 2. EAL Command line options for testpmd (https://doc.dpdk.org/guides/testpmd_app_ug/run_app.html?highlight=eal) Otherwise LGTM Acked-by: Hemant Agrawal --- lib/librte_eal/common/

RE: [PATCH 1/2] license/README: fix pathnames and add MIT

2022-10-17 Thread Hemant Agrawal
icense directory README are incorrect. > The current repository puts license text in license/ not licenses/. [Hemant] Can you break it into two parts: 1. for correcting the pathname - this can be merged asap. 2. adding MIT license - this need to wait till GB approval. > > Also, MIT li

RE: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code

2022-10-19 Thread Hemant Agrawal
ion macro in the code, is version information required in the > file comment? > > > + * Copyright (C) 2015-2022 Google, Inc. > > + * Copyright(C) 2022 Intel Corporation > > I don't know if it is OK to add Intel copyright, as far as I know this > requires big > e

RE: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code

2022-10-19 Thread Hemant Agrawal
> On 10/19/2022 4:13 PM, Hemant Agrawal wrote: > >> On 10/10/2022 11:17 AM, Junfeng Guo wrote: > >>> The following base code is based on Google Virtual Ethernet (gve) > >>> driver v1.3.0 under MIT license. > >>> - gve_adminq.c > >>&

Re: [PATCH] examples/l2fwd: add check of Rx packets count

2022-11-02 Thread Hemant Agrawal
: Rahul Bhansali This makes sense. Could drop the unlikely() since in general unlikely should be reserved for error cases. But doubt it matters at all. Did a quick check the other examples do similar thing already. Acked-by: Stephen Hemminger Acked-by: Hemant Agrawal

RE: [PATCH 7/7] dpaax: replace zero length array with flex array

2023-01-15 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Minutes of Technical Board Meeting, 2022-09-21

2023-01-23 Thread Hemant Agrawal
Members Attending: 5 - Aaron Conole - Bruce Richardson - Hemant Agrawal (Chair) - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Thomas Monjalon - Stephen Hemminger NOTE

RE: [EXT] Re: [dpdk-dev] [PATCH 2/4] cryptodev: promote asym APIs to stable

2023-02-02 Thread Hemant Agrawal
Hi Akhil > > Can we promote the Asym APIs to stable now? +1 for it > > Regards, > Akhil > > > > > On 07/09/2021 12:45, Akhil Goyal wrote: > > >>> Do you think all the asym APIs are not eligible for promoting it > > >>> to stable > > >> APIs? > > >>> I haven't seen any changes for quite some

Re: [PATCH v2 5/5] devtools: ignore changes into bbdev experimental API

2023-09-05 Thread Hemant Agrawal
On 15-Jun-23 10:19 PM, Nicolas Chautru wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button Developpers are warned that the related fft experimental functions do not pre

Re: [PATCH v2 0/5] bbdev: API extension for 23.11

2023-09-05 Thread Hemant Agrawal
Hi Nic,     One small comment in the commit message. Acked-by: Hemant Agrawal Regards Hemant On 15-Jun-23 10:18 PM, Nicolas Chautru wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'R

RE: [PATCH v2 5/5] devtools: ignore changes into bbdev experimental API

2023-09-13 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Vargas, Hernan > Sent: Wednesday, September 13, 2023 2:03 AM > To: Hemant Agrawal ; Chautru, Nicolas > ; dev@dpdk.org; maxime.coque...@redhat.com > Cc: Rix, Tom ; david.march...@redhat.com > Subject: RE: [P

RE: [PATCH] app/bbdev: fix link with NXP LA12XX

2023-09-14 Thread Hemant Agrawal
Thanks Acked-by: Hemant Agrawal > -Original Message- > From: David Marchand > Sent: Wednesday, September 13, 2023 7:29 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; sta...@dpdk.org; Nicolas Chautru > ; Hemant Agrawal ; > Akhil Goyal > Subject: [PATCH]

RE: [PATCH 1/2] crypto/dpaa2_sec: fix debug prints

2023-09-16 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

RE: [PATCH 09/36] net/dpaa: fix Rx and Tx queue state

2023-09-16 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Jie Hai > Sent: Friday, September 8, 2023 4:59 PM > To: dev@dpdk.org; Hemant Agrawal ; Sachin > Saxena ; Lijun Ou ; Ferruh > Yigit ; Konstantin Ananyev > <"konstantin.v.ananyev@yandex.rukonstantin.a

RE: [PATCH 10/36] net/dpaa2: fix Rx and Tx queue state

2023-09-16 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Jie Hai > Sent: Friday, September 8, 2023 4:59 PM > To: dev@dpdk.org; Hemant Agrawal ; Sachin > Saxena ; Thomas Monjalon > ; Konstantin Ananyev > <"konstantin.v.ananyev@yandex.rukonstantin.ananyev&

Minutes of Technical Board Meeting, 2023-Jun-28

2023-09-17 Thread Hemant Agrawal
Minutes of Technical Board Meeting, 2023-Jun-28 Members Attending - -Aaron -Hemant (Chair) -Jerin -Keven -Konstantin -Maxime -Stephen -Nathan -Ben NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK

[PATCH v2 00/13] crypto/dpaax_sec: misc enhancements

2023-09-20 Thread Hemant Agrawal
): common/dpaax: update IPsec base descriptor length common/dpaax: change mode to wait in shared desc crypto/dpaax_sec: set the authdata in non-auth case Hemant Agrawal (8): crypto/dpaa2_sec: supporting null cipher and auth crypto/dpaa_sec: supporting null cipher and auth crypto/dpaa2_sec

[PATCH v2 01/13] common/dpaax: update IPsec base descriptor length

2023-09-20 Thread Hemant Agrawal
From: Gagandeep Singh If all the keys are inlined, the descriptor would be 32 + 20 = 52 which is the size of the CURRENT shared descriptor created. So 32 * CAAM_CMD_SZ is the value that must be passed to rta_inline_query() for its "sd_base_len" parameter and drivers are using IPSEC_AUTH_VAR_AES_

[PATCH v2 03/13] crypto/dpaa2_sec: initialize the pdcp alg to null

2023-09-20 Thread Hemant Agrawal
From: Vanshika Shukla This patch initializes the pdcp alg to null. Signed-off-by: Vanshika Shukla --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_

[PATCH v2 02/13] common/dpaax: change mode to wait in shared desc

2023-09-20 Thread Hemant Agrawal
From: Gagandeep Singh In case of protocol based offload, it is better to wait before the share descriptor complete the execution. Simultaneous sharing may cause issues. Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 82 +++ 1 file changed, 41

[PATCH v2 04/13] crypto/dpaa2_sec: supporting null cipher and auth

2023-09-20 Thread Hemant Agrawal
IPSEC proto offload support NULL in combo cases, thus adding NULL cipher and auth in security capabilities. Non-supported cases are already protected in the code. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 43 +-- 1 file changed, 41

[PATCH v2 05/13] crypto/dpaa_sec: supporting null cipher and auth

2023-09-20 Thread Hemant Agrawal
Adding NULL cipher and auth in capabilities. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.h | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h index

[PATCH v2 06/13] crypto/dpaax_sec: set the authdata in non-auth case

2023-09-20 Thread Hemant Agrawal
From: Gagandeep Singh The descriptors refers to auth data as well, so initializing it properly for the non-auth cases. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 drivers/crypto/dpaa_sec/dpaa_sec.c | 5 + 2 files changed,

[PATCH v2 08/13] crypto/dpaa2_sec: support copy df and dscp in proto offload

2023-09-20 Thread Hemant Agrawal
This patch adds support for enabling capability to copy dscp and df bits from inner to outer header and vice-versa. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 18 ++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 10 -- 2 files changed

[PATCH v2 09/13] crypto/dpaa2_sec: increase the anti replay window size

2023-09-20 Thread Hemant Agrawal
LX216x can support upto 1024 anti replay window size. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h index

[PATCH v2 10/13] crypto/dpaa2_sec: enable esn support

2023-09-20 Thread Hemant Agrawal
LX216x suppots ESN. Also enable to correctly print the SEC era. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec

[PATCH v2 12/13] crypto/dpaa2_sec: add support to set df and diffserv

2023-09-20 Thread Hemant Agrawal
This patch enables the ipsec protocol offload to copy DF and diffserv Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 32 + drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 2 ++ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a

[PATCH v2 11/13] crypto/dpaa2_sec: add NAT-T support in IPsec offload

2023-09-20 Thread Hemant Agrawal
This patch adds supports for UDP encapsulation in NAT-T for IPSEC security protocol offload case. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 101 ++-- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 3 + 2 files changed, 75 insertions(+), 29

[PATCH v2 13/13] crypto/dpaax_sec: enable sha224-hmac support for IPsec

2023-09-20 Thread Hemant Agrawal
Enabling the SHA224 support in ipsec proto mode for dpaax drivers. Signed-off-by: Hemant Agrawal --- drivers/common/dpaax/caamflib/desc.h | 5 - drivers/common/dpaax/caamflib/desc/ipsec.h | 5 + drivers/common/dpaax/caamflib/rta/protocol_cmd.h | 5 - drivers

[PATCH v2 07/13] crypto/dpaa2_sec: enhance dpaa FD FL FMT offset set

2023-09-20 Thread Hemant Agrawal
From: Apeksha Gupta The macro DPAA2_SET_FLE_OFFSET(fle, offset) only works for masking the offset upto with 12 bits. When the offset value is more that 12 bits, this macro may over writing the FMT/SL/F bits which are beyond the offset bits. The FLE_ADDR is modified to FLE_ADDR + OFFSET, and the F

RE: [EXT] [PATCH v2 00/13] crypto/dpaax_sec: misc enhancements

2023-09-21 Thread Hemant Agrawal
Hi Akhil > -Original Message- > From: Akhil Goyal > Sent: Thursday, September 21, 2023 1:35 PM > To: Hemant Agrawal ; Franck Lenormand > ; Apeksha Gupta ; > Vanshika Shukla ; Gagandeep Singh > > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v2 00/13] crypto/d

RE: [PATCH v3 0/2] ethdev: add the check for PTP capability

2023-09-21 Thread Hemant Agrawal
gt; releated information because of reading Rx timestamp of PTP SYNC > > packet in read_rx_timestamp API. > > > > HW support may be required for PTP but this doesn't mean timestamp > offload is used. > > >> > >>> And then about four years later, ptp

RE: [PATCH v3 1/2] examples/ptpclient: add the check for PTP capability

2023-09-21 Thread Hemant Agrawal
; >>> +    return -ENOTSUP; > >>> +    } > >>> > >> I am not sure why TIMESTAMP offload is required for PTP, I think > >> there is a confusion. > > If TIMESTAMP offload is not required for PTP, there isn't PTP offload > > in eth

RE: [PATCH v4] security: hide security context

2023-09-26 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 6/8] baseband/la12xx: add documentation support

2021-04-14 Thread Hemant Agrawal
On 4/14/2021 6:27 AM, Chautru, Nicolas wrote: Documentation should be ideally embedded within the related commits to go hand in hand when feature are being added, not as a separate commit. Other comments below ok -Original Message- From: Hemant Agrawal Sent: Monday, April 12

Re: [dpdk-dev] [PATCH v3 5/8] baseband/la12xx: add enqueue and dequeue support

2021-04-14 Thread Hemant Agrawal
On 4/14/2021 6:23 AM, Chautru, Nicolas wrote: Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 397 - drivers/baseband/la12xx

Re: [dpdk-dev] [PATCH v3 3/8] baseband/la12xx: add support for multiple modems

2021-04-14 Thread Hemant Agrawal
On 4/14/2021 5:32 AM, Chautru, Nicolas wrote: -Original Message- From: Hemant Agrawal Sent: Monday, April 12, 2021 10:17 PM This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx

Re: [dpdk-dev] [PATCH 4/4] examples/l3fwd: make data struct to be memory efficient

2021-04-20 Thread Hemant Agrawal
case. However observing ~2% regression for 4-8 cores. Regards, Hemant

Re: [dpdk-dev] [PATCH] common/dpaax: fix possible null pointer access

2021-04-21 Thread Hemant Agrawal
LL"); + return; + } entry = dpaax_iova_table_p->entries; for (i = 0; i < dpaax_iova_table_p->count; i++) { Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get

2021-04-22 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH v4 0/8] baseband: add NXP LA12xx driver

2021-04-24 Thread Hemant Agrawal
changes v3: fix 32 bit compilation v4: capability for network byte order, doc patch merged inline. Hemant Agrawal (7): bbdev: add network order data capability baseband: introduce NXP LA12xx driver baseband/la12xx: add devargs for max queues baseband/la12xx: add support for multiple modems

[dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-24 Thread Hemant Agrawal
This patch intoduces a new capability of the bbdev device to process the LDPC data in network byte order. Signed-off-by: Hemant Agrawal --- doc/guides/bbdevs/features/default.ini | 1 + doc/guides/prog_guide/bbdev.rst| 6 ++ lib/bbdev/rte_bbdev_op.h | 8 ++-- 3

[dpdk-dev] [PATCH v4 2/8] baseband: introduce NXP LA12xx driver

2021-04-24 Thread Hemant Agrawal
This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c| 109 ++ .../baseband/la12xx/bbdev_la12xx_pmd_logs.h

[dpdk-dev] [PATCH v4 3/8] baseband/la12xx: add devargs for max queues

2021-04-24 Thread Hemant Agrawal
This patch adds dev args to take max queues as input Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 72 +- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b

[dpdk-dev] [PATCH v4 4/8] baseband/la12xx: add support for multiple modems

2021-04-24 Thread Hemant Agrawal
This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 64 +++--- drivers/baseband/la12xx/bbdev_la12xx.h | 56 +++ drivers/baseband/la12xx

[dpdk-dev] [PATCH v4 5/8] baseband/la12xx: add queue and modem config support

2021-04-24 Thread Hemant Agrawal
This patch add support for connecting with modem and creating the ipc channel as queues with modem for the exchange of data. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- doc/guides/bbdevs/index.rst| 1 + doc/guides/bbdevs/la12xx.rst | 81

[dpdk-dev] [PATCH v4 6/8] baseband/la12xx: add enqueue and dequeue support

2021-04-24 Thread Hemant Agrawal
Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- doc/guides/bbdevs/features/la12xx.ini | 14 + doc/guides/bbdevs/la12xx.rst | 46 +++ drivers/baseband/la12xx/bbdev_la12xx.c | 334

[dpdk-dev] [PATCH v4 7/8] app/bbdev: enable la12xx for bbdev

2021-04-24 Thread Hemant Agrawal
this patch adds la12xx driver in test bbdev Signed-off-by: Hemant Agrawal --- app/test-bbdev/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build index 57335641f0..75fd87ae2d 100644 --- a/app/test-bbdev/meson.build +++ b/app

[dpdk-dev] [PATCH v4 8/8] app/bbdev: add test vectors for transport blocks

2021-04-24 Thread Hemant Agrawal
From: Nipun Gupta This patch adds two test vectors for transport block in network byte order: - LDPC encode for Transport Block - LDPC decode for Transport block Signed-off-by: Nipun Gupta --- app/test-bbdev/test_vectors/ldpc_dec_tb.data | 122 +++ app/test-bbdev/test_vectors/l

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-28 Thread Hemant Agrawal
in DPDK are using Little Endian *(with u32 data)* but standards is open for both. Regards, Hemant On 4/26/2021 10:31 PM, Dave Burley wrote: Hi Hemant Can I ask what the usage case is for RTE_BBDEV_LDPC_ENC_NETWORK_ORDER/RTE_BBDEV_LDPC_DEC_NETWORK_ORDER ? Thanks Dave

Re: [dpdk-dev] [PATCH v4 1/8] bbdev: add network order data capability

2021-04-28 Thread Hemant Agrawal
places do explicitly state BE type.    Our customers/partners are typically using BE and LA12xx is configured to process BE data. Regards, Hemant On 4/26/2021 10:31 PM, Dave Burley wrote: Hi Hemant Can I ask what the usage case is for RTE_BBDEV_LDPC_ENC_NETWORK_ORDER

[dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator

2021-04-28 Thread Hemant Agrawal
.@dpdk.org Signed-off-by: Hemant Agrawal --- lib/ethdev/rte_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index a1879765e8..483013ec7a 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -26

Re: [dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator

2021-04-29 Thread Hemant Agrawal
On 4/29/2021 1:26 PM, Thomas Monjalon wrote: 29/04/2021 07:55, Hemant Agrawal: This patch fixes issue with OVS 2.15 not working on DPAA/FSLMC based platform due to missing support for these busses in dev_iterate. This patch adds dpaa_bus and fslmc to dev iterator for bus arguments. I think

Re: [dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator

2021-04-29 Thread Hemant Agrawal
On 4/29/2021 7:23 PM, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal Sent: Thursday, April 29, 2021 7:56 AM This patch fixes issue with OVS 2.15 not working on DPAA/FSLMC based platform due to missing support for these busses in dev_iterate. This

[dpdk-dev] [PATCH] crypto/dpaa_sec: fix to affine the thread portal affinity

2021-05-03 Thread Hemant Agrawal
affine portal- if not affined already. Fixes: 9a984458f755 ("crypto/dpaa_sec: rewrite Rx/Tx path") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpa

Re: [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-05-05 Thread Hemant Agrawal
Sorry for top posting. Akhil,     Will you please hold for a day on this patch? we are seeing few failures on dpaa2 with this patch, currently debugging them. Regards, Hemant On 5/1/2021 2:30 AM, Doherty, Declan wrote: On 23/04/2021 5:18 PM, Ciara Power wrote: The current crypto unit

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix the close and unint functions

2021-05-05 Thread Hemant Agrawal
being called and causing DPAA2 SEC to fail in configure Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 50 ++--- 1 file c

Re: [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-05-05 Thread Hemant Agrawal
The issue was in dpaa2_sec driver, fix is submitted. Series Acked-by: Hemant Agrawal On 5/5/2021 4:11 PM, Hemant Agrawal wrote: Sorry for top posting. Akhil,     Will you please hold for a day on this patch? we are seeing few failures on dpaa2 with this patch, currently debugging them

Re: [dpdk-dev] [PATCH] event/dpaa2: remove unused macros

2021-05-06 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] bus/fslmc: remove unused macro

2021-05-06 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] [PATCH v4 0/8] baseband: add NXP LA12xx driver

2021-06-26 Thread Hemant Agrawal
work byte. > > > > > > v2: add test case changes > > > v3: fix 32 bit compilation > > > v4: capability for network byte order, doc patch merged inline. > > > > > > Hemant Agrawal (7): > > > bbdev: add network order data capability > > > b

Re: [dpdk-dev] [PATCH v2] test/crypto: fix autotest function parameters

2021-06-30 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] test/crypto: fix typo in ESN testcase

2021-07-01 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [PATCH 2/3] examples/l3fwd: fix return value on rules add

2024-07-15 Thread Hemant Agrawal
dpdk.org Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal

RE: [PATCH] doc: announce change in crypto queue setup

2024-07-31 Thread Hemant Agrawal
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, July 31, 2024 4:51 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Hemant Agrawal > ; ano...@marvell.com; > pablo.de.lara.gua...@intel.com; fiona.tr...@intel.com; > decl

[PATCH 00/17] NXP DPAA ETH driver enhancement and fixes

2024-08-01 Thread Hemant Agrawal
debug net/dpaa: improve the dpaa port cleanup Hemant Agrawal (4): bus/dpaa: fix VSP for 1G fm1-mac9 and 10 bus/dpaa: add port buffer manager stats net/dpaa: implement detailed packet parsing net/dpaa: enhance DPAA frame display Jun Yang (2): net/dpaa: share MAC FMC scheme and CC parse

[PATCH 01/17] bus/dpaa: fix PFDRs leaks due to FQRNIs

2024-08-01 Thread Hemant Agrawal
From: Gagandeep Singh When a Retire FQ command is executed on a FQ in the Tentatively Scheduled or Parked states, in that case FQ is retired immediately and a FQRNI (Frame Queue Retirement Notification Immediate) message is generated. Software must read this message from MR and consume it to free

[PATCH 02/17] net/dpaa: fix typecasting ch ID to u32

2024-08-01 Thread Hemant Agrawal
From: Rohit Raj Avoid typecasting ch_id to u32 and passing it to another API since it can corrupt other data. Instead, create new u32 variable and typecase it back to u16 after it gets updated by the API. NXP CID: 27996293 Fixes: 0c504f6950b6 ("net/dpaa: support push mode") Cc: hemant.agra...@nx

[PATCH 03/17] bus/dpaa: fix VSP for 1G fm1-mac9 and 10

2024-08-01 Thread Hemant Agrawal
No need to classify interface separately for 1G and 10G Fixes: e0718bb2ca95 ("bus/dpaa: add virtual storage profile port init") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 29 +++-- 1 file changed, 27 insert

[PATCH 04/17] bus/dpaa: add port buffer manager stats

2024-08-01 Thread Hemant Agrawal
Add BMI statistics and improving the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++- drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/fsl_fman.h | 12

[PATCH 05/17] net/dpaa: support Tx confirmation to enable PTP

2024-08-01 Thread Hemant Agrawal
From: Vanshika Shukla TX confirmation provides dedicated confirmation queues for transmitted packets. These queues are used by software to get the status and release transmitted packets buffers. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 45

[PATCH 06/17] net/dpaa: add support to separate Tx conf queues

2024-08-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch separates Tx confirmation queues for kernel and DPDK so as to support the VSP case. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 4 ++- drivers/net/dpaa/dpaa_ethdev.c | 47

[PATCH 07/17] net/dpaa: share MAC FMC scheme and CC parse

2024-08-01 Thread Hemant Agrawal
From: Jun Yang For Shared MAC: 1) Allocate RXQ from VSP scheme. 2) Allocate RXQ from CC directed to VSP. 2) Remove RXQ allocated which is reconfigured without VSP. 3) Don't alloc default queue and err queues. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base

[PATCH 08/17] net/dpaa: support Rx/Tx timestamp read

2024-08-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch implements Rx/Tx timestamp read operations for DPAA1 platform. Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/fman/fman.c| 21 +++- drivers/bus/dpaa/base/fman/fman_hw.c | 6 ++- drivers/bus/dpaa/include/fman.h | 18 ++- drivers/net/d

[PATCH 09/17] net/dpaa: support IEEE 1588 PTP

2024-08-01 Thread Hemant Agrawal
From: Vanshika Shukla This patch adds the support for the ethdev APIs to enable/disable and read/write/adjust IEEE1588 PTP timestamps for DPAA platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/dpaa.rst | 1 + drivers/bus/dpaa/base/fman/fman.c | 15 ++ drivers/bus/dpaa/

[PATCH 10/17] net/dpaa: implement detailed packet parsing

2024-08-01 Thread Hemant Agrawal
This patch implements the detailed packet parsing using the annotation info from the hardware. decode parser to set RX muf packet type by dpaa_slow_parsing. Support to identify the IPSec ESP, GRE and SCTP packets. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/net/dpaa

[PATCH 11/17] net/dpaa: enhance DPAA frame display

2024-08-01 Thread Hemant Agrawal
This patch enhances the received packet debugging capability. This help displaying the full packet parsing output. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 5 ++ drivers/net/dpaa/dpaa_ethdev.c | 6 ++ drivers/net/dpaa/dpaa_rxtx.c | 138

[PATCH 12/17] net/dpaa: support mempool debug

2024-08-01 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support to compile time debug the mempool corruptions in dpaa driver. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH 13/17] net/dpaa: add Tx rate limiting DPAA PMD API

2024-08-01 Thread Hemant Agrawal
From: Vinod Pullabhatla Add support to set Tx rate on DPAA platform through PMD APIs Signed-off-by: Vinod Pullabhatla Signed-off-by: Rohit Raj --- .mailmap | 1 + drivers/net/dpaa/dpaa_flow.c | 95 +--- drivers/net/dpaa/fmlib/fm_lib

[PATCH 14/17] bus/dpaa: add OH port mode for dpaa eth

2024-08-01 Thread Hemant Agrawal
From: Rohit Raj NXP DPAA architecture supports the concept of DPAA port as Offline Port - meaning - not connected to an actual MAC. This is an virtual port to be used by application for exchanging data. This property is completely driven by the device-tree. During the DPAA bus scan, based on the

[PATCH 15/17] bus/dpaa: add ONIC port mode for the DPAA eth

2024-08-01 Thread Hemant Agrawal
From: Rohit Raj The OH ports can also be used by two application, processing contexts to communicate to each other. This patch enables this mode for dpaa-eth OH port as ONIC port, so that application can use the dpaa-eth to communicate to each other on the same SoC. Again,this properties is driv

[PATCH 16/17] net/dpaa: improve the dpaa port cleanup

2024-08-01 Thread Hemant Agrawal
From: Gagandeep Singh During DPAA cleanup in FMCLESS mode, application can see segmentation fault in device close API and in DPAA destructor execution. Segmentation fault in device close is because driver reducing the number of queues initialised during device configuration without releasing the

[PATCH 17/17] net/dpaa: improve dpaa errata A010022 handling

2024-08-01 Thread Hemant Agrawal
From: Jun Yang This patch improves the errata handling for "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" Signed-off-by: Jun Yang --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

Re: [v1 7/7] crypto/dpaa2_sec: rework debug code

2024-08-06 Thread Hemant Agrawal
Hi Gagan, On 06-08-2024 14:11, Gagandeep Singh wrote: From: Jun Yang Output debug information according to various modes. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 63 - 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/dri

Re: [v1 5/7] net/dpaa2: support FLC stashing API

2024-08-06 Thread Hemant Agrawal
Hi Gagan, I think this patch shall come before the 4th patch:   [v1 4/7] crypto/dpaa2_sec: enhance pdcp FLC handling - Hemant On 06-08-2024 14:11, Gagandeep Singh wrote: From: Jun Yang Configure flow steering action with FLC enabled to align stashing setting with RSS configuration

Re: [PATCH 00/17] NXP DPAA ETH driver enhancement and fixes

2024-08-08 Thread Hemant Agrawal
On 07-08-2024 21:12, Ferruh Yigit wrote: On 8/1/2024 11:52 AM, Hemant Agrawal wrote: This series adds several enhancement to the NXP DPAA Ethernet driver. Primarily: 1. timestamp and IEEE 1588 support 2. OH and ONIC based virtual port config in DPAA 3. frame display and debugging infra

Re: [PATCH v2 0/3] bbdev: sdditional queue stats

2024-08-13 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal On 13-08-2024 05:11, Nicolas Chautru wrote: v2: update to ABI doc suggested by Maxime. These series include introducing a new paramter in the queue stat which can be used to monitor the number of available enqueue still possible. The acc PMD is then

[PATCH v2 00/18] NXP DPAA ETH driver enhancement and fixes

2024-08-23 Thread Hemant Agrawal
. frame display and debugging infra Gagandeep Singh (3): bus/dpaa: fix PFDRs leaks due to FQRNIs net/dpaa: support mempool debug net/dpaa: improve the dpaa port cleanup Hemant Agrawal (5): bus/dpaa: fix VSP for 1G fm1-mac9 and 10 bus/dpaa: fix the fman details status bus/dpaa: add port

[PATCH v2 01/18] bus/dpaa: fix PFDRs leaks due to FQRNIs

2024-08-23 Thread Hemant Agrawal
From: Gagandeep Singh When a Retire FQ command is executed on a FQ in the Tentatively Scheduled or Parked states, in that case FQ is retired immediately and a FQRNI (Frame Queue Retirement Notification Immediate) message is generated. Software must read this message from MR and consume it to free

[PATCH v2 02/18] net/dpaa: fix typecasting ch ID to u32

2024-08-23 Thread Hemant Agrawal
From: Rohit Raj Avoid typecasting ch_id to u32 and passing it to another API since it can corrupt other data. Instead, create new u32 variable and typecase it back to u16 after it gets updated by the API. Fixes: 0c504f6950b6 ("net/dpaa: support push mode") Cc: hemant.agra...@nxp.com Cc: sta...@d

  1   2   3   4   5   6   7   8   9   10   >