Hi Akhil > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Thursday, September 21, 2023 1:35 PM > To: Hemant Agrawal <hemant.agra...@nxp.com>; Franck Lenormand > <franck.lenorm...@nxp.com>; Apeksha Gupta <apeksha.gu...@nxp.com>; > Vanshika Shukla <vanshika.shu...@nxp.com>; Gagandeep Singh > <g.si...@nxp.com> > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v2 00/13] crypto/dpaax_sec: misc enhancements > Importance: High > > > v2: compilation fixes > > > > This series include misc enhancements in dpaax_sec drivers. > > > > - improving the IPsec protocol offload features > > - enhancing PDCP protocol processing > > - code optimization and cleanup > > > > Apeksha Gupta (1): > > crypto/dpaa2_sec: enhance dpaa FD FL FMT offset set > > > > Gagandeep Singh (3): > > common/dpaax: update IPsec base descriptor length > > common/dpaax: change mode to wait in shared desc > > crypto/dpaax_sec: set the authdata in non-auth case > > > > Hemant Agrawal (8): > > crypto/dpaa2_sec: supporting null cipher and auth > > crypto/dpaa_sec: supporting null cipher and auth > > crypto/dpaa2_sec: support copy df and dscp in proto offload > > crypto/dpaa2_sec: increase the anti replay window size > > crypto/dpaa2_sec: enable esn support > > crypto/dpaa2_sec: add NAT-T support in IPsec offload > > crypto/dpaa2_sec: add support to set df and diffserv > > crypto/dpaax_sec: enable sha224-hmac support for IPsec > > > > Vanshika Shukla (1): > > crypto/dpaa2_sec: initialize the pdcp alg to null > > > > drivers/common/dpaax/caamflib/desc.h | 5 +- > > drivers/common/dpaax/caamflib/desc/ipsec.h | 9 +- > > drivers/common/dpaax/caamflib/desc/pdcp.h | 82 +++--- > > .../common/dpaax/caamflib/rta/protocol_cmd.h | 5 +- > > .../dpaax/caamflib/rta/sec_run_time_asm.h | 2 +- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 245 +++++++++++------- > > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 64 ++++- > > drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 47 +--- > > drivers/crypto/dpaa_sec/dpaa_sec.c | 15 +- > > drivers/crypto/dpaa_sec/dpaa_sec.h | 42 ++- > > drivers/net/dpaa2/dpaa2_rxtx.c | 3 +- > > 11 files changed, 326 insertions(+), 193 deletions(-) > > > Please improve writing the title and description of patches. > Applied to dpdk-next-crypto. > Please review the patches applied. Make sure not to repeat these things. [Hemant] Thanks > > crypto/dpaax_sec: support SHA224-HMAC for IPsec > crypto/dpaa2_sec: support copy DF and diffserv > crypto/dpaa2_sec: support NAT-T in IPsec offload > crypto/dpaa2_sec: support ESN > crypto/dpaa2_sec: increase anti replay window size > crypto/dpaa2_sec: support copy DF and DSCP in IPsec > crypto/dpaa2_sec: prevent FLE offset overflow > crypto/dpaax_sec: set authdata in non-auth case > crypto/dpaa_sec: support null cipher and auth > crypto/dpaa2_sec: support null cipher and auth > crypto/dpaa2_sec: initialize PDCP alg to null > common/dpaax: change mode to wait in shared desc > common/dpaax: update IPsec base descriptor length > > Few capability changes in dpaa2 driver were specific to LX2160. > But are common to other dpaa2 devices. I hope those are taken care of with > appropriate checks. [Hemant] Yes, your observation is correct. However we have not tested these things yet on dpaa, once we test, we will submit the patch.
Regards, Hemant