Re: [PATCH v10 0/8] app/procinfo: add some extended features

2022-10-20 Thread Dongdong Liu
Hi Thomas Could you have a look at the patchset? Thanks, Dongdong On 2022/10/11 19:18, Dongdong Liu wrote: This patchset is to add some extended features for dpdk-proc-info. Thanks to Reshma and Stephen help to review the patchset. v9->v10: - Fix some comments for Rx/Tx descriptor dump.

Re: [PATCH] net/hns3: fix inaccurate RTC time to read

2023-01-12 Thread Dongdong Liu
pdk.org Signed-off-by: Huisong Li Acked-by: Dongdong Liu Thanks, Dongdong --- drivers/net/hns3/hns3_ptp.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/hns3/hns3_ptp.c b/drivers/net/hns3/hns3_ptp.c index 6bbd85ba23..db3c007b12 100644 --- a/d

[PATCH 02/10] net/hns3: extract common API to query device

2023-01-29 Thread Dongdong Liu
From: Huisong Li Extract common function to query device specifications. Fixes: 9c740336f024 ("net/hns3: get device specifications from firmware") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common

[PATCH 01/10] net/hns3: fix error log about indirection table size

2023-01-29 Thread Dongdong Liu
t;net/hns3: fix RSS indirection table size") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c| 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns

[PATCH 00/10] net/hns3: some bugfixes for rss

2023-01-29 Thread Dongdong Liu
This patchset is to do some bugfixes for hns3 rss. Huisong Li (10): net/hns3: fix error log about indirection table size net/hns3: extract common API to query device net/hns3: refactor set RSS hash algorithm and key interface net/hns3: fix fixed RSS key size to be more compatibility net/

[PATCH 03/10] net/hns3: refactor set RSS hash algorithm and key interface

2023-01-29 Thread Dongdong Liu
_info::hash_algo maintained in driver, which also isn't good for the usage of this function. This patch has to use hash algorithm and key length as the input parameters of this interface. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Sig

[PATCH 04/10] net/hns3: fix fixed RSS key size to be more compatibility

2023-01-29 Thread Dongdong Liu
ned-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 12 +++- drivers/net/hns3/hns3_flow.c | 26 -- drivers/net/hns3/hns3_rss.c| 23 +++ drivers/net/hns3/hns3_rss.h| 3 ++- 4 files changed, 36 inserti

[PATCH 05/10] net/hns3: fix misclearing RSS configuration

2023-01-29 Thread Dongdong Liu
From: Huisong Li The RSS configuration will be miscleared when driver receives a RSS rule which has more one RSS action. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 4 +-

[PATCH 06/10] net/hns3: using RSS filter list to check duplicated rule

2023-01-29 Thread Dongdong Liu
From: Huisong Li All rules from user are saved in RSS filter list, so use RSS filter list to check duplicated rule. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_f

[PATCH 07/10] net/hns3: remove useless code when destroy valid RSS rule

2023-01-29 Thread Dongdong Liu
e can be removed. Fixes: eb158fc756a5 ("net/hns3: fix config when creating RSS rule after flush") Fixes: 705a50800334 ("net/hns3: fix RSS filter restore") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 26 ++---

[PATCH 08/10] net/hns3: fix useless warning when flush or destroy rule

2023-01-29 Thread Dongdong Liu
3: fix flushing RSS rule") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flo

[PATCH 09/10] net/hns3: fix bad memory structure conversion

2023-01-29 Thread Dongdong Liu
; to convert this 'conf' pointer to get RSS action configuration. In addition, RSS filter configuration is directly cloned to RSS filter node instead of coping it after successfully setting to hardware. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-

[PATCH 10/10] net/hns3: fix incorrect check for duplicate RSS rule

2023-01-29 Thread Dongdong Liu
ing RSS rule this rule is also mistakenly considered as a duplicate rule. 3) If 'key' or 'queue' in struct rte_flow_action_rss being NULL is used to memcpy, which may cause segment fault. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Sign

[PATCH V2 01/10] net/hns3: fix error log about indirection table size

2023-01-30 Thread Dongdong Liu
t;net/hns3: fix RSS indirection table size") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c| 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns

[PATCH V2 00/10] net/hns3: some bugfixes for rss

2023-01-30 Thread Dongdong Liu
This patchset is to do some bugfixes for hns3 rss. v1->v2: - Fix missing comparison of types and level when verifying duplicate rules for [PATCH 10/10]. Huisong Li (10): net/hns3: fix error log about indirection table size net/hns3: extract common API to query device net/hns3: refactor se

[PATCH V2 04/10] net/hns3: fix fixed RSS key size to be more compatibility

2023-01-30 Thread Dongdong Liu
ned-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 12 +++- drivers/net/hns3/hns3_flow.c | 26 -- drivers/net/hns3/hns3_rss.c| 23 +++ drivers/net/hns3/hns3_rss.h| 3 ++- 4 files changed, 36 inserti

[PATCH V2 03/10] net/hns3: refactor set RSS hash algorithm and key interface

2023-01-30 Thread Dongdong Liu
_info::hash_algo maintained in driver, which also isn't good for the usage of this function. This patch has to use hash algorithm and key length as the input parameters of this interface. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Sig

[PATCH V2 02/10] net/hns3: extract common API to query device

2023-01-30 Thread Dongdong Liu
From: Huisong Li Extract common function to query device specifications. Fixes: 9c740336f024 ("net/hns3: get device specifications from firmware") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common

[PATCH V2 05/10] net/hns3: fix misclearing RSS configuration

2023-01-30 Thread Dongdong Liu
From: Huisong Li The RSS configuration will be miscleared when driver receives a RSS rule which has more one RSS action. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 4 +-

[PATCH V2 08/10] net/hns3: fix useless warning when flush or destroy rule

2023-01-30 Thread Dongdong Liu
3: fix flushing RSS rule") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flo

[PATCH V2 07/10] net/hns3: remove useless code when destroy valid RSS rule

2023-01-30 Thread Dongdong Liu
e can be removed. Fixes: eb158fc756a5 ("net/hns3: fix config when creating RSS rule after flush") Fixes: 705a50800334 ("net/hns3: fix RSS filter restore") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 26 ++---

[PATCH V2 06/10] net/hns3: using RSS filter list to check duplicated rule

2023-01-30 Thread Dongdong Liu
From: Huisong Li All rules from user are saved in RSS filter list, so use RSS filter list to check duplicated rule. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_f

[PATCH V2 09/10] net/hns3: fix bad memory structure conversion

2023-01-30 Thread Dongdong Liu
; to convert this 'conf' pointer to get RSS action configuration. In addition, RSS filter configuration is directly cloned to RSS filter node instead of coping it after successfully setting to hardware. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-

[PATCH V2 10/10] net/hns3: fix incorrect check for duplicate RSS rule

2023-01-30 Thread Dongdong Liu
ing RSS rule this rule is also mistakenly considered as a duplicate rule. 3) If 'key' or 'queue' in struct rte_flow_action_rss being NULL is used to memcpy, which may cause segment fault. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Sign

Re: [PATCH V2 09/10] net/hns3: fix bad memory structure conversion

2023-01-31 Thread Dongdong Liu
On 2023/1/30 17:31, Dongdong Liu wrote: From: Huisong Li When the type in 'struct rte_flow_action' is RTE_FLOW_ACTION_TYPE_RSS, the 'conf' pointer references the 'struct rte_flow_action_rss' instead of the 'struct hns3_rss_conf' in driver. But drive

[PATCH V3 01/10] net/hns3: fix error log about indirection table size

2023-01-31 Thread Dongdong Liu
t;net/hns3: fix RSS indirection table size") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c| 2 +- drivers/net/hns3/hns3_ethdev_vf.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns

[PATCH V3 00/10] net/hns3: some bugfixes for rss

2023-01-31 Thread Dongdong Liu
This patchset is to do some bugfixes for hns3 rss. v2->v3: - Fix segmentation fault when key_len is 40 and key is NULL for [PATCH V2 09/10]. v1->v2: - Fix missing comparison of types and level when verifying duplicate rules for [PATCH 10/10]. Huisong Li (10): net/hns3: fix error log about

[PATCH V3 04/10] net/hns3: fix fixed RSS key size to be more compatibility

2023-01-31 Thread Dongdong Liu
ned-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 12 +++- drivers/net/hns3/hns3_flow.c | 26 -- drivers/net/hns3/hns3_rss.c| 23 +++ drivers/net/hns3/hns3_rss.h| 3 ++- 4 files changed, 36 inserti

[PATCH V3 02/10] net/hns3: extract common API to query device

2023-01-31 Thread Dongdong Liu
From: Huisong Li Extract common function to query device specifications. Fixes: 9c740336f024 ("net/hns3: get device specifications from firmware") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common

[PATCH V3 03/10] net/hns3: refactor set RSS hash algorithm and key interface

2023-01-31 Thread Dongdong Liu
_info::hash_algo maintained in driver, which also isn't good for the usage of this function. This patch has to use hash algorithm and key length as the input parameters of this interface. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Sig

[PATCH V3 06/10] net/hns3: using RSS filter list to check duplicated rule

2023-01-31 Thread Dongdong Liu
From: Huisong Li All rules from user are saved in RSS filter list, so use RSS filter list to check duplicated rule. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_f

[PATCH V3 09/10] net/hns3: fix bad memory structure conversion

2023-01-31 Thread Dongdong Liu
; to convert this 'conf' pointer to get RSS action configuration. In addition, RSS filter configuration is directly cloned to RSS filter node instead of coping it after successfully setting to hardware. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-

[PATCH V3 08/10] net/hns3: fix useless warning when flush or destroy rule

2023-01-31 Thread Dongdong Liu
3: fix flushing RSS rule") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flo

[PATCH V3 07/10] net/hns3: remove useless code when destroy valid RSS rule

2023-01-31 Thread Dongdong Liu
e can be removed. Fixes: eb158fc756a5 ("net/hns3: fix config when creating RSS rule after flush") Fixes: 705a50800334 ("net/hns3: fix RSS filter restore") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 26 ++---

[PATCH V3 05/10] net/hns3: fix misclearing RSS configuration

2023-01-31 Thread Dongdong Liu
From: Huisong Li The RSS configuration will be miscleared when driver receives a RSS rule which has more one RSS action. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 4 +-

[PATCH V3 10/10] net/hns3: fix incorrect check for duplicate RSS rule

2023-01-31 Thread Dongdong Liu
ing RSS rule this rule is also mistakenly considered as a duplicate rule. 3) If 'key' or 'queue' in struct rte_flow_action_rss being NULL is used to memcpy, which may cause segment fault. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Sign

[PATCH 0/6] net/hns3: some code optimization for Rx/Tx function

2023-02-11 Thread Dongdong Liu
This patchset is to do some code optimization for Rx/Tx function. Huisong Li (6): net/hns3: fix querying dummy function failed net/hns3: add debug info for Rx/Tx dummy function net/hns3: remove debug condition for Tx prepare net/hns3: separate tx prepare from getting Tx function net/hns3

[PATCH 1/6] net/hns3: fix querying dummy function failed

2023-02-11 Thread Dongdong Liu
From: Huisong Li The rte_eth_rx/tx_burst_mode_get API will fail when Rx/Tx function is dummy. Fixes: 7ef933908f04 ("net/hns3: add simple Tx path") Fixes: 521ab3e93361 ("net/hns3: add simple Rx path") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong L

[PATCH 2/6] net/hns3: add debug info for Rx/Tx dummy function

2023-02-11 Thread Dongdong Liu
From: Huisong Li Now dummy function can be report by rte_eth_rx/tx_burst_mode_get. So this patch adds debug info for Rx/Tx dummy function. Fixes: 7feb2aee0e2c ("net/hns3: log selected datapath") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- driver

[PATCH 3/6] net/hns3: remove debug condition for Tx prepare

2023-02-11 Thread Dongdong Liu
ng Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 2524f4c3c2..921d72d69d 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c

[PATCH 4/6] net/hns3: separate tx prepare from getting Tx function

2023-02-11 Thread Dongdong Liu
From: Huisong Li Separate getting tx prepare from hns3_get_tx_function by extracting an independent function. Fixes: d7ec2c076579 ("net/hns3: select Tx prepare based on Tx offload") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/h

[PATCH 5/6] net/hns3: remove getting Tx function from head file

2023-02-11 Thread Dongdong Liu
From: Huisong Li The hns3_get_tx_function() is an intrinsic function now and should not be open to other files. Fixes: 96c33cfb06cf ("net/hns3: fix Rx/Tx functions update") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_

[PATCH 6/6] net/hns3: extract common functions to set Rx/Tx

2023-02-11 Thread Dongdong Liu
From: Huisong Li Extract two common functions to set Rx/Tx function in order to reduce duplicate codes. Fixes: 23d4b61fee5d ("net/hns3: support multiple process") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-14 Thread Dongdong Liu
Hi Chengwen On 2023/2/14 15:11, Chengwen Feng wrote: Claim PMD supports pmd_supports_disable_iova_as_pa. Signed-off-by: Chengwen Feng This patch looks good to me. Many thanks for your work. Acked-by: Dongdong Liu Thanks, Dongdong

Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-02-14 Thread Dongdong Liu
Hi Chengwen On 2023/2/9 10:32, Chengwen Feng wrote: The xstats reset is useful for debugging, so add it to the ethdev telemetry command lists. Signed-off-by: Chengwen Feng This patch looks good, so Reviewed-by: Dongdong Liu A minior question Do we need to support stats reset ? Thanks

Re: [PATCH 2/5] net/hns3: replace fp ops config function

2023-03-01 Thread Dongdong Liu
On 2023/3/1 11:06, Chengwen Feng wrote: This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu Thanks, Dongdong

Re: [PATCH 6/9] net/hns3: fix segment fault when parse runtime config

2023-03-07 Thread Dongdong Liu
mailbox limit time") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu Thanks, Dongdong

Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq

2023-03-08 Thread Dongdong Liu
Hi Jie On 2023/1/31 10:58, Jie Hai wrote: Currently the l3fwd-power only supports ACPI cpufreq and Pstate cpufreq, This patch adds CPPC cpufreq. Signed-off-by: Jie Hai Looks good, so Acked-by: Dongdong Liu Thanks, Dongdong --- examples/l3fwd-power/main.c | 9 ++--- 1 file changed

Re: [PATCH 0/2] net/hns3: add some features for hns3 pmd

2023-05-16 Thread Dongdong Liu
Kindly ping. Thanks, Dongdong On 2023/4/21 17:53, Dongdong Liu wrote: This patchset is to add some features for hns3 pmd. Chengwen Feng (1): net/hns3: support dump media type Dongdong Liu (1): net/hns3: simplify for hardware csum offloading drivers/net/hns3/hns3_cmd.c| 3

[PATCH 0/5] ] net/hns3: add some features and bugfixes

2023-05-18 Thread Dongdong Liu
This patchset contains some features and bugfixes for hns3. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3: fix loop code variable type mismatch net/hns3: add Tx/Rx descriptor logs Huisong Li (2): net/hns3: fix never set MAC flow c

[PATCH 1/5] net/hns3: fix never set MAC flow control

2023-05-18 Thread Dongdong Liu
Fixes: 1f411e31a826 ("net/hns3: support flow control autoneg for copper port") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/hns3/

[PATCH 3/5] net/hns3: fix loop code variable type mismatch

2023-05-18 Thread Dongdong Liu
From: Dengdui Huang Loop conditions are compared with different variable types, which may cause overflow risks. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 ++- drivers/net/hns3/hns3_stats.c | 2 +- 2 files changed, 3 insertions(+), 2

[PATCH 4/5] net/hns3: fix receive multiple firmware reset interrupts

2023-05-18 Thread Dongdong Liu
impact of 5ms, the number of PFs managed by a firmware is limited. Therefore, even if a DPDK process takes over all the PFs which managed by the firmware, the delay is controllable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c

[PATCH 2/5] net/hns3: add flow control autoneg for fiber and backplane port

2023-05-18 Thread Dongdong Liu
From: Huisong Li This patch support flow control autoneg for fiber and backplane port. And it depends on the capability of firmware. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 30 +- drivers/net/hns3/hns3_cmd.h| 20

[PATCH 5/5] net/hns3: add Tx/Rx descriptor logs

2023-05-18 Thread Dongdong Liu
From: Dengdui Huang Add Tx/Rx descriptor logs, controlled by 'RTE_ETHDEV_DEBUG_RX/TX' compile time flag with 'pmd.net.hns3.rx/tx' log type. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 6 ++ drivers/net/hns

Re: [PATCH 0/5] ] net/hns3: add some features and bugfixes

2023-05-22 Thread Dongdong Liu
Hi Ferruh Many thanks for your review. On 2023/5/22 19:57, Ferruh Yigit wrote: On 5/18/2023 12:29 PM, Dongdong Liu wrote: This patchset contains some features and bugfixes for hns3. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3

[PATCH v2 0/5] net/hns3: add some features and bugfixes

2023-05-22 Thread Dongdong Liu
This patchset contains some features and bugfixes for hns3. v1->v2: -Fix check-git-log warnings. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3: fix loop code variable type mismatch net/hns3: add Tx/Rx descriptor logs Huisong Li (2)

[PATCH v2 2/5] net/hns3: add flow control autoneg for fiber port

2023-05-22 Thread Dongdong Liu
From: Huisong Li This patch support flow control autoneg for fiber and backplane port. And it depends on the capability of firmware. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 30 +- drivers/net/hns3/hns3_cmd.h| 20

[PATCH v2 3/5] net/hns3: fix loop code variable type mismatch

2023-05-22 Thread Dongdong Liu
k.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- .mailmap | 1 + drivers/net/hns3/hns3_regs.c | 3 ++- drivers/net/hns3/hns3_stats.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 976e4ef6f8..e9a3d443dc 100644

[PATCH v2 4/5] net/hns3: fix receive multiple firmware reset interrupts

2023-05-22 Thread Dongdong Liu
ned-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 5ef66f96c6..664226a6ef 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/d

[PATCH v2 1/5] net/hns3: fix never set MAC flow control

2023-05-22 Thread Dongdong Liu
Fixes: 1f411e31a826 ("net/hns3: support flow control autoneg for copper port") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/hns3/

[PATCH v2 5/5] net/hns3: add Tx/Rx descriptor logs

2023-05-22 Thread Dongdong Liu
From: Dengdui Huang Add Tx/Rx descriptor logs, controlled by 'RTE_ETHDEV_DEBUG_RX/TX' compile time flag with 'pmd.net.hns3.rx/tx' log type. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 6 ++ drivers/net/hns

[PATCH 03/11] net/hns3: add the uninitialization process of PTP

2023-05-29 Thread Dongdong Liu
From: Huisong Li This patch adds the uninitialization process of PTP in case of having an impact on PF driver in kernel. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_eth

[PATCH 01/11] net/hns3: fix uninitialized RTC time

2023-05-29 Thread Dongdong Liu
From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ptp.c | 7

[PATCH 04/11] net/hns3: extract a PTP header file

2023-05-29 Thread Dongdong Liu
From: Huisong Li This patch extracts a PTP header file to contain PTP registers and external API in order to make PTP code structure more clear. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- d

[PATCH 07/11] net/hns3: fix no errcode returned when failed to init queue

2023-05-29 Thread Dongdong Liu
From: Chengwen Feng If hns3_init_queues() return failed, the hns3vf_do_start() should return errcode. This patch fixes it. Fixes: 43d8adf3891c ("net/hns3: fix RSS flow rule restore") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- driver

[PATCH 08/11] net/hns3: fix uninitialized variable

2023-05-29 Thread Dongdong Liu
From: Jie Hai This patch fixes possible use of uninitialized variable "old_tuple_fields". Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 5 +++-

[PATCH 09/11] net/hns3: make code more clean

2023-05-29 Thread Dongdong Liu
From: Dengdui Huang This patch modify the code that violates the coding standards. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 +-- drivers/net/hns3/hns3_rxtx.c | 10 +++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a

[PATCH 11/11] net/hns3: remove log redundant line break

2023-05-29 Thread Dongdong Liu
From: Dengdui Huang This patch remove log redundant line break Fixes: d51867db65c1 ("net/hns3: add initialization") Fixes: c6332c3cf9f0 ("net/hns3: support module EEPROM dump") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/ne

[PATCH 05/11] net/hns3: fix mbuf leak when start rxq in resetting

2023-05-29 Thread Dongdong Liu
_start/rx_queue_stop/ tx_queue_start/tx_queue_stop ops. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 28 1 file changed, 28 insertion

[PATCH 06/11] net/hns3: fix mbuf leak when start rxq after resetting

2023-05-29 Thread Dongdong Liu
rmine whether the Rx ring mbufs were allocated based only on the first sw-ring[0]'s mbuf. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 5

[PATCH 00/11] net/hns3: add some bugfixes for hns3

2023-05-29 Thread Dongdong Liu
This patchset contains some bugfixes for hns3 pmd. Chengwen Feng (3): net/hns3: fix mbuf leak when start rxq in resetting net/hns3: fix mbuf leak when start rxq after resetting net/hns3: fix no errcode returned when failed to init queue Dengdui Huang (3): net/hns3: make code more clean

[PATCH 10/11] net/hns3: fix inaccurate log

2023-05-29 Thread Dongdong Liu
From: Dengdui Huang This patch fix inaccurate log Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdo

[PATCH 02/11] net/hns3: fix unenabled RTC time after reset

2023-05-29 Thread Dongdong Liu
From: Huisong Li The enabled status of RTC time will be cleared after global or IMP reset, which cause the local RTC time doesn't work. So this patch fix it. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-b

Re: [PATCH v2 0/5] net/hns3: add some features and bugfixes

2023-06-01 Thread Dongdong Liu
Hi Ferruh On 2023/6/1 18:30, Ferruh Yigit wrote: On 5/22/2023 5:15 PM, Ferruh Yigit wrote: On 5/22/2023 2:17 PM, Dongdong Liu wrote: This patchset contains some features and bugfixes for hns3. v1->v2: -Fix check-git-log warnings. Chengwen Feng (1): net/hns3: fix receive multiple firmw

Re: [PATCH 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Dongdong Liu
Hi Ferruh Many thanks for your review. On 2023/6/2 17:00, Ferruh Yigit wrote: On 5/29/2023 2:09 PM, Dongdong Liu wrote: From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP

[PATCH v2 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Dongdong Liu
From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/

[PATCH v2 00/11] net/hns3: add some bugfixes for hns3

2023-06-02 Thread Dongdong Liu
This patchset contains some bugfixes for hns3 pmd. v1->v2: - Fix the comments for [PATCH 01/11] suggested by Ferruh. Chengwen Feng (3): net/hns3: fix mbuf leak when start rxq in resetting net/hns3: fix mbuf leak when start rxq after resetting net/hns3: fix no errcode returned when failed to

[PATCH v2 02/11] net/hns3: fix unenabled RTC time after reset

2023-06-02 Thread Dongdong Liu
From: Huisong Li The enabled status of RTC time will be cleared after global or IMP reset, which cause the local RTC time doesn't work. So this patch fix it. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-b

[PATCH v2 03/11] net/hns3: add the uninitialization process of PTP

2023-06-02 Thread Dongdong Liu
From: Huisong Li This patch adds the uninitialization process of PTP in case of having an impact on PF driver in kernel. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_eth

[PATCH v2 04/11] net/hns3: extract a PTP header file

2023-06-02 Thread Dongdong Liu
From: Huisong Li This patch extracts a PTP header file to contain PTP registers and external API in order to make PTP code structure more clear. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- d

[PATCH v2 06/11] net/hns3: fix mbuf leak when start rxq after resetting

2023-06-02 Thread Dongdong Liu
rmine whether the Rx ring mbufs were allocated based only on the first sw-ring[0]'s mbuf. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 5

[PATCH v2 07/11] net/hns3: fix no errcode returned when failed to init queue

2023-06-02 Thread Dongdong Liu
From: Chengwen Feng If hns3_init_queues() return failed, the hns3vf_do_start() should return errcode. This patch fixes it. Fixes: 43d8adf3891c ("net/hns3: fix RSS flow rule restore") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- driver

[PATCH v2 05/11] net/hns3: fix mbuf leak when start rxq in resetting

2023-06-02 Thread Dongdong Liu
_start/rx_queue_stop/ tx_queue_start/tx_queue_stop ops. Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 28 1 file changed, 28 insertion

[PATCH v2 08/11] net/hns3: fix uninitialized variable

2023-06-02 Thread Dongdong Liu
From: Jie Hai This patch fixes possible use of uninitialized variable "old_tuple_fields". Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 5 +++-

[PATCH v2 09/11] net/hns3: make code more clean

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch modify the code that violates the coding standards. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 +-- drivers/net/hns3/hns3_rxtx.c | 10 +++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a

[PATCH v2 10/11] net/hns3: fix inaccurate log

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch fix inaccurate log Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdo

[PATCH v2 11/11] net/hns3: remove log redundant line break

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch remove log redundant line break Fixes: d51867db65c1 ("net/hns3: add initialization") Fixes: c6332c3cf9f0 ("net/hns3: support module EEPROM dump") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/ne

[PATCH 2/5] net/hns3: return ENOSPC if not enough MCAST filter resource

2023-08-05 Thread Dongdong Liu
From: Dengdui Huang Return ENOSPC instead of EINVAL when the hardware has not enough multicast filtering resources. Fixes: 7d7f9f80bbfb ("net/hns3: support MAC address related operations") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- driver

[PATCH 0/5] net/hns3: some bugfixes for hns3

2023-08-05 Thread Dongdong Liu
This patchset is to fix some bugs for hns3. Chengwen Feng (2): net/hns3: fix TM thread safety risk net/hns3: fix un-align format TM info Dengdui Huang (3): net/hns3: fix VF default MAC modified when set failed net/hns3: return ENOSPC if not enough MCAST filter resource net/hns3: flush m

[PATCH 3/5] net/hns3: flush multicast MAC address if mc_addr_set is NULL

2023-08-05 Thread Dongdong Liu
Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index 043c7673b4..c4d47f43fe 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c

[PATCH 1/5] net/hns3: fix VF default MAC modified when set failed

2023-08-05 Thread Dongdong Liu
From: Dengdui Huang When the VF fail to set the default MAC address, "hw->mac.mac_addr" should not be updated. Fixes: a5475d61fa34 ("net/hns3: support VF") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_eth

[PATCH 4/5] net/hns3: fix TM thread safety risk

2023-08-05 Thread Dongdong Liu
: e4cfe6bb9114 ("net/hns3: dump TM configuration info") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 8 +- drivers/net/hns3/hns3_tm.c | 173 ++- 2 files changed, 157 insertions(+), 24

[PATCH 5/5] net/hns3: fix un-align format TM info

2023-08-05 Thread Dongdong Liu
ned-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/hns3/hns3_dump.c b/drivers/net/hns3/hns3_dump.c index 67b45e6dc3..5c21ff0a33 100644 --- a/drivers/net/hns3/hns3_dump.c +++ b/drivers/net/hns3/h

Re: [PATCH 4/5] net/hns3: fix TM thread safety risk

2023-08-07 Thread Dongdong Liu
Hi Stephen On 2023/8/5 23:58, Stephen Hemminger wrote: On Sat, 5 Aug 2023 16:36:26 +0800 Dongdong Liu wrote: From: Chengwen Feng The driver-related TM (traffic management) info is implemented through the linked list. The following threads are involved in the read and write of the TM info

[PATCH 00/16] net/hns3: some code refactor for hns3 RSS

2023-03-10 Thread Dongdong Liu
This patchset is to do some code refactor for hns3 RSS. 1. [PATCH 01/16]-[PATCH 02/16] fix some hns3 RSS bug. 2. [PATCH 03/16]-[PATCH 14/16] refactoring hns3 RSS code. 3. [PATCH 15/16]-[PATCH 16/16] reimplement hash flow function. Huisong Li (16): net/hns3: fix possible truncation of hash key w

[PATCH 01/16] net/hns3: fix possible truncation of hash key when config

2023-03-10 Thread Dongdong Liu
s: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index d6e0

[PATCH 03/16] net/hns3: use hardware config to report hash key

2023-03-10 Thread Dongdong Liu
Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 53 - drivers/net/hns3/hns3_rss.h | 3 ++- 2 files changed, 54 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index f6d677ade8..a046cc31

[PATCH 02/16] net/hns3: fix possible truncation of redirection table

2023-03-10 Thread Dongdong Liu
Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 2011c18b9b..f6d677ade8 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/

[PATCH 04/16] net/hns3: use hardware config to report hash types

2023-03-10 Thread Dongdong Liu
From: Huisong Li Use the configuration in hardware to report hash types instead of data maintained in software. Fixes: c37ca66f2b27 ("net/hns3: support RSS") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_r

  1   2   3   >