From: Dengdui Huang <huangdeng...@huawei.com>
Loop conditions are compared with different variable types,
which may cause overflow risks.
Fixes: 67d010346933 ("net/hns3: adjust data type of some variables")
Fixes: 6ee07e3cb589 ("net/hns3: fix insecure way to query MAC statistics")
Cc: sta...@dpdk.org
Signed-off-by: Dengdui Huang <huangdeng...@huawei.com>
Signed-off-by: Dongdong Liu <liudongdo...@huawei.com>
---
.mailmap | 1 +
drivers/net/hns3/hns3_regs.c | 3 ++-
drivers/net/hns3/hns3_stats.c | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.mailmap b/.mailmap
index 976e4ef6f8..e9a3d443dc 100644
--- a/.mailmap
+++ b/.mailmap
@@ -301,6 +301,7 @@ Deepak Khandelwal <deepak.khandel...@intel.com>
Deepak Kumar Jain <deepak.k.j...@intel.com>
Deirdre O'Connor <deirdre.o.con...@intel.com>
Dekel Peled <dek...@nvidia.com> <dek...@mellanox.com>
+Dengdui Huang <huangdeng...@huawei.com>
Dennis Marinus <dmari...@amazon.com>
Derek Chickles <derek.chick...@caviumnetworks.com>
Des O Dea <des.j.o....@intel.com>
diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c
index 33392fd1f0..5d6f92e4bb 100644
--- a/drivers/net/hns3/hns3_regs.c
+++ b/drivers/net/hns3/hns3_regs.c
@@ -294,8 +294,9 @@ hns3_direct_access_regs(struct hns3_hw *hw, uint32_t *data)
struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
uint32_t *origin_data_ptr = data;
uint32_t reg_offset;
- uint16_t i, j;
size_t reg_num;
+ uint16_t j;
+ size_t i;
/* fetching per-PF registers values from PF PCIe register space */
reg_num = sizeof(cmdq_reg_addrs) / sizeof(uint32_t);
diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c
index bad65fcbed..c2e692a2c5 100644
--- a/drivers/net/hns3/hns3_stats.c
+++ b/drivers/net/hns3/hns3_stats.c
@@ -317,7 +317,7 @@ hns3_update_mac_stats(struct hns3_hw *hw)
uint32_t stats_iterms;
uint64_t *desc_data;
uint32_t desc_num;
- uint16_t i;
+ uint32_t i;
int ret;
/* The first desc has a 64-bit header, so need to consider it. */
--
2.22.0
