Re: [PATCH v2 2/2] dts: improve starting and stopping interactive shells

2024-07-11 Thread Dean Marx
Tested-by: Dean Marx

[PATCH v4 1/3] dts: add multicast set function to shell

2024-07-15 Thread Dean Marx
added set multicast function for changing allmulticast mode within testpmd. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 46 +++ 1 file changed, 46 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework

[PATCH v4 2/3] dts: dynamic config conf schema

2024-07-15 Thread Dean Marx
configuration schema to run dynamic configuration test suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json

[PATCH v4 3/3] dts: dynamic config test suite

2024-07-15 Thread Dean Marx
ework packet addressing") Signed-off-by: Dean Marx --- dts/tests/TestSuite_dynamic_config.py | 152 ++ 1 file changed, 152 insertions(+) create mode 100644 dts/tests/TestSuite_dynamic_config.py diff --git a/dts/tests/TestSuite_dynamic_config.py b

[PATCH v7 1/3] dts: add functions to testpmd shell

2024-07-17 Thread Dean Marx
added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 192 ++ 1 file changed, 192 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework

[PATCH v7 2/3] dts: initial queue start/stop suite implementation

2024-07-17 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 94 + 1 file changed, 94 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py

[PATCH v7 3/3] dts: queue suite conf schema

2024-07-17 Thread Dean Marx
Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index

[PATCH v11 1/3] dts: add VLAN methods to testpmd shell

2024-07-17 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed: bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework

[PATCH v11 2/3] dts: VLAN test suite implementation

2024-07-17 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 170 1 file changed, 170 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git

[PATCH v11 3/3] dts: config schema

2024-07-17 Thread Dean Marx
Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5

Re: [PATCH v3 3/3] dts: mac filter test suite refactored for new dts

2024-07-22 Thread Dean Marx
end up doing that just make it depend on this patch: patch-1142113 ("add send_packets to test suites and rework packet addressing") Reviewed-by: Dean Marx On Thu, Jul 18, 2024 at 3:40 PM Nicholas Pratte wrote: > The mac address filter test suite, whose test cases are based on old

Re: [PATCH v3 2/3] dts: add methods for setting mac and multicast addresses

2024-07-22 Thread Dean Marx
I think Jeremy already mentioned this but just make sure you update vlan_set_filter_on/off to the new version that has an on boolean arg. Reviewed-by: Dean Marx On Thu, Jul 18, 2024 at 3:12 PM Nicholas Pratte wrote: > Several new methods have been added to TestPMDShell in order to prod

Re: [PATCH v2 1/3] dts: add boolean to adjust addresses

2024-07-22 Thread Dean Marx
Reviewed-by: Dean Marx On Tue, Jul 2, 2024 at 3:25 PM Nicholas Pratte wrote: > Various test cases in the mac filter test suite called for granular > manipulation of destination mac addresses to properly test mac address > filtering functionality. To compensate, there

Re: [PATCH v1 2/3] dts: add dual_vlan testing suite

2024-07-22 Thread Dean Marx
> > > +recv = self.send_packet_and_capture(pakt) > +self.verify(len(recv) > 0, "Did not receive and packets when > testing VLAN priority.") > I'm assuming this should say "any" instead of "and." Other than that, everything looks good to me. Reviewed-by: Dean Marx

[PATCH v12 0/3] dts: refactored VLAN test suite

2024-07-24 Thread Dean Marx
Refactored suite to be compatible with context manager, fixed bug in show port info regex for VLAN offload flags. Minor formatting fixes are included as well. Dean Marx (3): dts: add VLAN methods to testpmd shell dts: VLAN test suite implementation dts: config schema dts/framework/config

[PATCH v12 1/3] dts: add VLAN methods to testpmd shell

2024-07-24 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework

[PATCH v12 2/3] dts: VLAN test suite implementation

2024-07-24 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 168 1 file changed, 168 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git

[PATCH v12 3/3] dts: config schema

2024-07-24 Thread Dean Marx
Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5

[PATCH v8 0/3] dts: refactored queue start/stop suite

2024-07-24 Thread Dean Marx
Refactored queue start/stop test suite to be compatible with context manager. Updated queue setup, stop/start, and show queue info methods/dataclasses in testpmd shell. Dean Marx (3): dts: add functions to testpmd shell dts: initial queue start/stop suite implementation dts: queue suite

[PATCH v8 1/3] dts: add functions to testpmd shell

2024-07-24 Thread Dean Marx
added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 232 +- 1 file changed, 231 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts

[PATCH v8 2/3] dts: initial queue start/stop suite implementation

2024-07-24 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 91 + 1 file changed, 91 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py

[PATCH v8 3/3] dts: queue suite conf schema

2024-07-24 Thread Dean Marx
Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index

[PATCH v5 0/3] dts: refactored dynamic config test suite

2024-07-24 Thread Dean Marx
Refactored dynamic configuration suite to be compatible with context manager. Dean Marx (3): dts: add multicast set function to shell dts: dynamic config conf schema dts: dynamic config test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session

[PATCH v5 1/3] dts: add multicast set function to shell

2024-07-24 Thread Dean Marx
added set multicast function for changing allmulticast mode within testpmd. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 46 +++ 1 file changed, 46 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework

[PATCH v5 2/3] dts: dynamic config conf schema

2024-07-24 Thread Dean Marx
configuration schema to run dynamic configuration test suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json

[PATCH v5 3/3] dts: dynamic config test suite

2024-07-24 Thread Dean Marx
ework packet addressing") Signed-off-by: Dean Marx --- dts/tests/TestSuite_dynamic_config.py | 145 ++ 1 file changed, 145 insertions(+) create mode 100644 dts/tests/TestSuite_dynamic_config.py diff --git a/dts/tests/TestSuite_dynamic_config.py b

[RFC v1 0/3] VXLAN-GPE test suite

2024-07-25 Thread Dean Marx
lan description whether the VXLAN layer is fully removed, or if the verbose output on testpmd just prints the VXLAN layer in stdout in the first case and not the second, but I decided to implement the former for now. Dean Marx (3): dts: add UDP tunnel command to testpmd shell dts: VXLAN gpe sup

[RFC v1 1/3] dts: add UDP tunnel command to testpmd shell

2024-07-25 Thread Dean Marx
add udp_tunnel_port command to testpmd shell class, also ports over set verbose method from vlan suite Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session

[RFC v1 2/3] dts: VXLAN gpe support test suite

2024-07-25 Thread Dean Marx
Test suite for verifying vxlan gpe support on NIC, as well as expected behavior while sending vxlan packets through tunnel Signed-off-by: Dean Marx --- dts/tests/TestSuite_vxlan_gpe_support.py | 77 1 file changed, 77 insertions(+) create mode 100644 dts/tests

[RFC v1 3/3] dts: conf schema VXLAN gpe support

2024-07-25 Thread Dean Marx
Configuration schema to run vxlan gpe support test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index

[PATCH v1] dts: add flow rule dataclass to testpmd shell

2024-07-26 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for intializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 66

[PATCH v2] dts: add flow rule dataclass to testpmd shell

2024-07-26 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58

[PATCH v1] dts: add flow rule dataclass to testpmd shell

2024-07-26 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58

[PATCH v2] dts: add flow rule dataclass to testpmd shell

2024-08-06 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58

Re: [PATCH v2 1/2] dts: add dual_vlan testing suite

2024-08-07 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH v6 0/2] dts: refactored dynamic config test suite

2024-08-07 Thread Dean Marx
*v6: combined conf schema patch with test suite patch Dean Marx (2): dts: add multicast set function to shell dts: dynamic config test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 46 ++ dts/tests

[PATCH v6 2/2] dts: dynamic config test suite

2024-08-07 Thread Dean Marx
ework packet addressing") Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_dynamic_config.py | 145 + 2 files changed, 147 insertions(+), 1 deletion(-) create mode 100644 dts/tests/TestSuite_dynamic_config.py di

[PATCH v6 1/2] dts: add multicast set function to shell

2024-08-07 Thread Dean Marx
added set multicast function for changing allmulticast mode within testpmd. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 46 +++ 1 file changed, 46 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework

[PATCH v9 0/2] dts: refactored queue start/stop suite

2024-08-07 Thread Dean Marx
*v9: combined conf schema and test suite patches Dean Marx (2): dts: add functions to testpmd shell dts: initial queue start/stop suite implementation dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 232 +- dts/tests

[PATCH v9 1/2] dts: add functions to testpmd shell

2024-08-07 Thread Dean Marx
added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 232 +- 1 file changed, 231 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts

[PATCH v9 2/2] dts: initial queue start/stop suite implementation

2024-08-07 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_queue_start_stop.py| 91 ++ 2 files changed, 93 insertions(+), 1

[PATCH v13 0/2] dts: refactored VLAN test suite

2024-08-07 Thread Dean Marx
*v13: combined conf schema and test suite patches Dean Marx (2): dts: add VLAN methods to testpmd shell dts: VLAN test suite implementation dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 245 +- dts/tests

[PATCH v13 1/2] dts: add VLAN methods to testpmd shell

2024-08-07 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework

[PATCH v13 2/2] dts: VLAN test suite implementation

2024-08-07 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_vlan.py| 168 + 2 files changed, 170 insertions(+), 1

[RFC v1 0/2] dts: initial checksum offload suite

2024-08-12 Thread Dean Marx
disagrees I can look for more of a workaround. If anyone has any comments or advice about the issues above it is greatly appreciated. Dean Marx (2): dts: add csum HW offload to testpmd shell dts: checksum offload test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/re

[PATCH v1 1/2] dts: add csum HW offload to testpmd shell

2024-08-12 Thread Dean Marx
add csum_set_hw method to testpmd shell class. Port over set_verbose and port start/stop from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 94 +++ 1 file changed, 94 insertions(+) diff --git a/dts/framework/remote_session

[PATCH v1 2/2] dts: checksum offload test suite

2024-08-12 Thread Dean Marx
test suite for verifying layer 3/4 checksum offload features on poll mode driver. Depends-on: patch-142762 ("dts: add text parser for testpmd verbose output") Depends-on: patch-142691 ("dts: add send_packets to test suites and rework packet addressing") Signed-off-by:

[RFC v1 0/2] dts: initial checksum offload suite

2024-08-12 Thread Dean Marx
disagrees I can look for more of a workaround. If anyone has any comments or advice about the issues above it is greatly appreciated. Dean Marx (2): dts: add csum HW offload to testpmd shell dts: checksum offload test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/re

[RFC v1 1/2] dts: add csum HW offload to testpmd shell

2024-08-12 Thread Dean Marx
add csum_set_hw method to testpmd shell class. Port over set_verbose and port start/stop from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 94 +++ 1 file changed, 94 insertions(+) diff --git a/dts/framework/remote_session

[RFC v1 2/2] dts: checksum offload test suite

2024-08-12 Thread Dean Marx
test suite for verifying layer 3/4 checksum offload features on poll mode driver. Depends-on: patch-142762 ("dts: add text parser for testpmd verbose output") Depends-on: patch-142691 ("dts: add send_packets to test suites and rework packet addressing") Signed-off-by:

[PATCH v1] dts: add verify argument to set forward mode

2024-08-12 Thread Dean Marx
Add optional verify argument to the set_forward_mode method in testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework

[PATCH v1] dts: add package mode config and updated README

2024-08-12 Thread Dean Marx
In the current DTS setup description, the user installs poetry with the --no-root option. However, adding 'package-mode = false' to the pyproject.toml sets the same configuration, and running poetry install --no-root will become an error in a future poetry version. Signed-off-by:

Re: [PATCH v4 2/2] dts: mac filter test suite refactored for new dts

2024-08-12 Thread Dean Marx
> payload is not, > +received, then the test case fails. Each call with this method > sends exactly > +one packet. > "and whether or not the packet should be received or not" is redundant Reviewed-by: Dean Marx

Re: [PATCH v4 1/2] dts: add methods for setting mac and multicast addresses

2024-08-12 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH v3] dts: add flow rule dataclass to testpmd shell

2024-08-13 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 57

[PATCH v3] dts: add flow rule dataclass to testpmd shell

2024-08-13 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 57

[PATCH v1] dts: correct typos in conf.yaml

2024-08-13 Thread Dean Marx
correct docstring error in conf.yaml showing incorrect example pci address for TG nodes Signed-off-by: Dean Marx --- dts/conf.yaml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dts/conf.yaml b/dts/conf.yaml index 7d95016e68..ca5e87636e 100644 --- a/dts/conf.yaml

Re: [PATCH v3 1/2] dts: add dual_vlan testing suite

2024-08-13 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v3 2/2] dts: add dual_vlan test suite to the yaml schema

2024-08-13 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH v1 0/2] dts: port over checksum offload suite

2024-08-16 Thread Dean Marx
consistency in testpmd with Tx checksum flags, either not being displayed during packet transmission or showing values that did not align with the original test plan. Dean Marx (2): dts: add csum HW offload to testpmd shell dts: checksum offload test suite dts/framework/remote_session

[PATCH v1 1/2] dts: add csum HW offload to testpmd shell

2024-08-16 Thread Dean Marx
add csum_set_hw method to testpmd shell class. Port over set_verbose and port start/stop from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 124 ++ 1 file changed, 124 insertions(+) diff --git a/dts/framework/remote_session

[PATCH v1 2/2] dts: checksum offload test suite

2024-08-16 Thread Dean Marx
test suite for verifying layer 3/4 checksum offload features on poll mode driver. Depends-on: patch-143033 ("dts: add text parser for testpmd verbose output") Depends-on: patch-142691 ("dts: add send_packets to test suites and rework packet addressing") Signed-off-by: Dean

Re: [PATCH v17 5/5] dts: add API doc generation

2024-08-19 Thread Dean Marx
th docs mentioned in the cover letter and that didn't seem to work either. I was also able to build and compile without -Denable_docs. Thought I'd bring it up because compilation takes a fairly long time, and if a user runs into this I could see it being frustrating. Reviewed-by: Dean Marx

Re: [PATCH v1 2/2] dts: checksum offload test suite

2024-08-19 Thread Dean Marx
> > > > +def send_packet_and_verify( > > Should this not be `send_packets_and_verify(` as the argument is > `packet_list`. > Yeah that would definitely make more sense, I'll change that in the next version. > > > +isL4 = any( > > +VerboseOLFlag.RTE_MBUF_F_RX_L4_CKSUM_GO

Re: [PATCH v1 0/2] dts: port over checksum offload suite

2024-08-19 Thread Dean Marx
On Mon, Aug 19, 2024 at 10:28 AM Alex Chapman wrote: > Hi Dean, > > I went over the test suite and it looks really solid, but noticed you > didn't update the `conf_yaml_schema.json`, is there any reason for this? > Good catch, I must've messed up my git commits earlier. Thanks

Re: [PATCH v17 5/5] dts: add API doc generation

2024-08-19 Thread Dean Marx
the imports. The missing > packages are taken from the DTS pyproject.toml file. > > And finally, the DTS API docs can be accessed from the DPDK API doxygen > page. > > [0] > https://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings > > Signed-off-by: Juraj Linkeš > Tested-by: Dean Marx

Re: [PATCH v17 5/5] dts: add API doc generation

2024-08-19 Thread Dean Marx
On Mon, Aug 19, 2024 at 10:37 AM Dean Marx wrote: > I ran into some dependency issues while testing that I figured I'd mention > here. My build failed while running meson setup with the -Denable_docs=true > option since I didn't have the sphinx-build module installed, th

Re: [PATCH v19 5/5] dts: add API doc generation

2024-08-21 Thread Dean Marx
the imports. The missing > packages are taken from the DTS pyproject.toml file. > > And finally, the DTS API docs can be accessed from the DPDK API doxygen > page. > Tested-by: Dean Marx

[PATCH v2 0/2] dts: port over checksum offload suite

2024-08-21 Thread Dean Marx
--- v2: * added filter for verbose output using dst mac address Dean Marx (2): dts: add csum HW offload to testpmd shell dts: checksum offload test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 124 dts/tests

[PATCH v2 1/2] dts: add csum HW offload to testpmd shell

2024-08-21 Thread Dean Marx
add csum_set_hw method to testpmd shell class. Port over set_verbose and port start/stop from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 124 ++ 1 file changed, 124 insertions(+) diff --git a/dts/framework/remote_session

[PATCH v2 2/2] dts: checksum offload test suite

2024-08-21 Thread Dean Marx
test suite for verifying layer 3/4 checksum offload features on poll mode driver. Depends-on: patch-143033 ("dts: add text parser for testpmd verbose output") Depends-on: patch-142691 ("dts: add send_packets to test suites and rework packet addressing") Signed-off-by:

[PATCH v1 0/2] dts: port over unified packet type suite

2024-08-23 Thread Dean Marx
, tunnel, inner L2, inner L3, and inner L4 types. This suite verifies the ability of the driver to recognize these types. v1: *Removed NVGRE test cases due to lack of SCAPY support *Removed redundant packet flag verification in certain test cases Dean Marx (2): dts: add VXLAN port method to testpmd

[PATCH v1 1/2] dts: add VXLAN port method to testpmd shell

2024-08-23 Thread Dean Marx
Add rx_vxlan_port add/rm method to testpmd shell for adding or removing a vxlan id to the specified port filter list. Port over set_verbose method from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 47 +++ 1 file changed, 47

[PATCH v1 2/2] dts: port over unified packet suite

2024-08-23 Thread Dean Marx
d rework packet addressing") Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_uni_pkt.py | 230 +++-- 2 files changed, 219 insertions(+), 14 deletions(-) diff --git a/dts/framework/config/conf_yaml_schema.j

[PATCH v2 0/2] dts: port over unified packet type suite

2024-08-23 Thread Dean Marx
patch failure *Removed set_verbose duplication and added dependency Dean Marx (2): dts: add VXLAN port method to testpmd shell dts: port over unified packet suite dts/framework/remote_session/testpmd_shell.py | 23 ++ dts/tests/TestSuite_uni_pkt.py| 239 ++ 2

[PATCH v2 1/2] dts: add VXLAN port method to testpmd shell

2024-08-23 Thread Dean Marx
Add rx_vxlan_port add/rm method to testpmd shell for adding or removing a vxlan id to the specified port filter list. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 23 +++ 1 file changed, 23 insertions(+) diff --git a/dts/framework/remote_session

[PATCH v2 2/2] dts: port over unified packet suite

2024-08-23 Thread Dean Marx
d rework packet addressing") Depends-on: Patch-143005 ("dts: add functions to testpmd shell") Signed-off-by: Dean Marx --- dts/tests/TestSuite_uni_pkt.py | 239 + 1 file changed, 239 insertions(+) create mode 100644 dts/tests/TestSuite_uni_

[PATCH v14 0/2] dts: port over VLAN test suite

2024-08-23 Thread Dean Marx
docstrings in suite * Added flag checking to shell methods * Fixed tx_vlan_reset method bug Dean Marx (2): dts: add VLAN methods to testpmd shell dts: VLAN test suite implementation dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 245

[PATCH v14 1/2] dts: add VLAN methods to testpmd shell

2024-08-23 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework

[PATCH v14 2/2] dts: VLAN test suite implementation

2024-08-23 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_vlan.py| 167 + 2 files changed, 169 insertions(+), 1

Re: [PATCH v2 1/2] dts: add csum HW offload to testpmd shell

2024-08-26 Thread Dean Marx
On Fri, Aug 23, 2024 at 10:54 AM Jeremy Spewock wrote: > On Wed, Aug 21, 2024 at 12:25 PM Dean Marx wrote: > > > > add csum_set_hw method to testpmd shell class. Port over > > set_verbose and port start/stop from queue start/stop suite. > > Since we had that discus

Re: [PATCH v2 2/2] dts: checksum offload test suite

2024-08-26 Thread Dean Marx
> You could probably combine this line with the previous since they are > from the same module. > > > +from scapy.packet import Raw # type: ignore[import-untyped] > > I think you can also import `Packet` from this module if you wanted to > combine another two lines as well. > > Wow I didn't even

[PATCH v3 0/2] dts: port over checksum offload suite

2024-08-26 Thread Dean Marx
instance with multiple flags * Fixed docstring errors and method names to be match functionality Dean Marx (2): dts: add csum HW offload to testpmd shell dts: checksum offload test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 51

[PATCH v3 1/2] dts: add csum HW offload to testpmd shell

2024-08-26 Thread Dean Marx
add csum_set_hw method to testpmd shell class. Port over set_verbose and port start/stop from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 51 +++ 1 file changed, 51 insertions(+) diff --git a/dts/framework/remote_session

[PATCH v3 2/2] dts: checksum offload test suite

2024-08-26 Thread Dean Marx
ch-143005 ("dts: add functions to testpmd shell") Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_checksum_offload.py| 257 + 2 files changed, 259 insertions(+), 1 deletion(-) create mode 100644 dts/tests/TestSuite_c

Re: [PATCH v3 01/12] dts: fix default device error handling mode

2024-08-27 Thread Dean Marx
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > The device_error_handling_mode of testpmd port may not be present, e.g. > in VM ports. > > Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 02/12] dts: add the aenum dependency

2024-08-27 Thread Dean Marx
nce. > > DTS needs to return different instances in the above scenario so that we > can map capabilities with different names to the same function that > retrieves the capabilities. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 03/12] dts: add test case decorators

2024-08-28 Thread Dean Marx
e logic in a more sensible manner. > > Bugzilla ID: 1460 > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 04/12] dts: add mechanism to skip test cases or suites

2024-08-28 Thread Dean Marx
lt. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 05/12] dts: add support for simpler topologies

2024-08-28 Thread Dean Marx
; in this commit. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 06/12] dst: add basic capability support

2024-09-03 Thread Dean Marx
ll good to me, it was interesting to see how you've used abstract methods in the Capability class. The only thing I noticed was it seems like you wrote "dst" instead of "dts" in the commit message, otherwise: Reviewed-by: Dean Marx

Re: [PATCH v3 07/12] dts: add testpmd port information caching

2024-09-03 Thread Dean Marx
the update. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 09/12] dts: add topology capability

2024-09-03 Thread Dean Marx
> TopologyType.default are distinct. This is needed to distinguish between > a user passed value and the default value being used (which is used when > a test suite is or isn't decorated). > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 10/12] doc: add DTS capability doc sources

2024-09-03 Thread Dean Marx
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > Add new files to generate DTS API documentation from. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 12/12] dts: add NIC capabilities from show port info

2024-09-03 Thread Dean Marx
know about the members). > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 08/12] dts: add NIC capability support

2024-09-03 Thread Dean Marx
e. The arguments passed > to it are all from the testpmd shell. Everything else (even the actual > capability object creation) is done internally. > > Signed-off-by: Juraj Linkeš > Reviewed-by: Dean Marx

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-03 Thread Dean Marx
I'd ask while it's in mind if there's any specific reason for shifting these two flags? Not a critique of the code, just genuinely curious. Reviewed-by: Dean Marx

Potential Vlan Filtering Bug - Testpmd

2024-06-07 Thread Dean Marx
Hello Testpmd and Ethdev maintainers, I am working at the UNH Community Lab, writing testsuites for DTS. Currently, I am starting work on a testsuite which will test the vlan functions in DPDK. It should include testing of: 1. Positive and Negative test of packet vlan filter on an rx_port 2. VLA

[PATCH v1] dts: Initial vlan test suite implementation

2024-06-10 Thread Dean Marx
This test suite asserts the functionality of vlan filtering, stripping, and insertion on the poll mode driver. It consists of four test cases, which are all based off old DTS test plans, but are modified to account for framework changes. Bugzilla ID: 1453 Signed-off-by: Dean Marx --- dts

[PATCH v2 0/2] VLAN test suite

2024-06-11 Thread Dean Marx
packet reception when tag is not in the filter list 4. Packet reception with tag when tag insertion is on If these all pass, the poll mode driver is correctly configured to use vlan features with no security concerns. Dean Marx (2): Initial implementation for VLAN test suite conf schema dts

  1   2   3   4   5   >