> > +"""Mac address filtering test suite. > + > +This test suite ensures proper and expected behavior of Allowlist > filtering via mac > +addresses on devices bound to the Poll Mode Driver. If a packet received > on a device > +contains a mac address not contained with its mac address pool, the > packet should > +be dropped. Alternatively, if a packet is received that contains a > destination mac > +within the devices address pool, the packet should be accepted and > forwarded. This > +behavior should remain consistent across all packets, namely those > containing dot1q > +tags or otherwise. > <snip>
This should probably say "not contained within its mac address pool" instead of "with", since that's how you're wording the rest of the docstrings <snip> > + Test cases within this suite utilize this method to create, send, > and verify > + packets based on criteria relating to the packet's destination > mac address, > + vlan tag, and whether or not the packet should be received or > not. Packets > + are verified using an inserted payload. Assuming the test case > expects to > + receive a specified packet, if the list of received packets > contains this > + payload within any of its packets, the test case passes. > Alternatively, if > + the designed packet should not be received, and the packet > payload is not, > + received, then the test case fails. Each call with this method > sends exactly > + one packet. > <snip> "and whether or not the packet should be received or not" is redundant Reviewed-by: Dean Marx <dm...@iol.unh.edu>
