This looks fine. Thanks for making the changes!
Signed-off-by: Chas Williams <3ch...@gmail.com>
On 10/11/22 09:20, Chengwen Feng wrote:
Normally, to use the HW offloads capability (e.g. checksum and TSO) in
the Tx direction, the application needs to call rte_eth_tx_prepare() to
d
Thanks for making the change, IMHO this is much clearer.
Signed-off-by: Chas Williams <3ch...@gmail.com>
On 9/29/22 00:05, Usman Tanveer wrote:
when dedicated queues are enable with bonding mode 4 (mlx5), the
application sets the flow, which cannot be set if the device is not
started
This appears to be correct. A minor comment inline.
On 10/17/22 04:42, Andrew Rybchenko wrote:
Chas, Cornor, could you review the patch, please.
Thanks,
Andrew.
On 9/11/22 15:24, Ivan Malov wrote:
According to the documentation, rte_eth_dev_configure()
can be invoked repeatedly while in stopp
This appears to be correct, but it needs to be coordinated with the
proposed changes in net/bonding: make bonded device configure method re-entrant
On 10/17/22 04:41, Andrew Rybchenko wrote:
Chas, Cornor, could you review the patch, please.
Thanks,
Andrew.
On 9/11/22 15:22, Ivan Malov wrote:
Acked-by: Chas Williams <3ch...@gmail.com>
On 10/17/22 04:40, Andrew Rybchenko wrote:
Chas, Cornor, could you review the patch, please.
Thanks,
Andrew.
On 9/11/22 15:19, Ivan Malov wrote:
Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
breaks reporting
On 10/17/22 10:10, Andrew Rybchenko wrote:
On 10/17/22 15:32, Chas Williams wrote:
This appears to be correct. A minor comment inline.
On 10/17/22 04:42, Andrew Rybchenko wrote:
Chas, Cornor, could you review the patch, please.
Thanks,
Andrew.
On 9/11/22 15:24, Ivan Malov wrote
On 9/13/22 06:22, Ferruh Yigit wrote:
> On 7/25/2022 5:08 AM, Chengwen Feng wrote:
>
>
> I assume intention is to make this as transparent as possible to the
> user, that is why you are using a wrapper that combines
> `rte_eth_tx_prepare()` & `rte_eth_tx_burst()` APIs. But for other PMDs
> `rte_eth
On 9/13/22 20:46, fengchengwen wrote:
The main problem is hard to design a tx_prepare for bonding device:
1. as Chas Williams said, there maybe twice hash calc to get target slave
devices.
2. also more important, if the slave devices have changes(e.g. slave device
link down or remove
On 9/15/22 09:14, Huisong Li wrote:
This patch adds link speeds configuration.
---
-v2: resend due to CI compiling failure.
Signed-off-by: Huisong Li
---
drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/
On 9/15/22 22:09, lihuisong (C) wrote:
在 2022/9/15 21:43, Chas Williams 写道:
On 9/15/22 09:14, Huisong Li wrote:
This patch adds link speeds configuration.
---
-v2: resend due to CI compiling failure.
Signed-off-by: Huisong Li
---
drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++
1
On 9/16/22 22:35, fengchengwen wrote:
Hi Chas,
On 2022/9/15 0:59, Chas Williams wrote:
On 9/13/22 20:46, fengchengwen wrote:
The main problem is hard to design a tx_prepare for bonding device:
1. as Chas Williams said, there maybe twice hash calc to get target slave
devices.
2. also
On 9/19/22 10:07, Konstantin Ananyev wrote:
On 9/16/22 22:35, fengchengwen wrote:
Hi Chas,
On 2022/9/15 0:59, Chas Williams wrote:
On 9/13/22 20:46, fengchengwen wrote:
The main problem is hard to design a tx_prepare for bonding device:
1. as Chas Williams said, there maybe twice hash
On 9/21/22 22:12, fengchengwen wrote:
On 2022/9/20 7:02, Chas Williams wrote:
On 9/19/22 10:07, Konstantin Ananyev wrote:
On 9/16/22 22:35, fengchengwen wrote:
Hi Chas,
On 2022/9/15 0:59, Chas Williams wrote:
On 9/13/22 20:46, fengchengwen wrote:
The main problem is hard to
Thanks for making the changes!
Signed-off-by: 3ch...@gmail.com
On 9/21/22 21:33, Huisong Li wrote:
This patch adds link speeds configuration.
---
-v3: add an intersection of the supported speeds to check 'link_speeds'.
-v2: resend due to CI compiling failure.
Signed-off-by: Huisong Li
--
It's probably cleaner to just move the bond_ethdev_8023ad_flow_set
until after the device start. For the reader, they don't need to
understand why you might not have started the device earlier.
On 9/24/22 10:19, Usman Tanveer wrote:
when dedicated queues are enable with bonding mode 4 (mlx5), th
On 9/26/22 06:18, Konstantin Ananyev wrote:
Hi everyone,
Sorry for late reply.
The main problem is hard to design a tx_prepare for bonding device:
1. as Chas Williams said, there maybe twice hash calc to get target slave
devices.
2. also more important, if the slave devices have
On 10/8/22 23:36, Chengwen Feng wrote:
uint16_t slaves[RTE_MAX_ETHPORTS];
uint8_t tx_failed_flag = 0;
uint16_t num_of_slaves;
+ uint16_t num_tx_prep;
uint16_t max_nb_of_tx_pkts = 0;
@@ -1320,12 +1339,18 @@ bond_ethdev_tx_burst_broadcast(void *queue, struc
This PMD driver doesn't seem to work with VFIO. I haven't had time
to look into it very closely, so I was going to ask here first just
in case someone had any ideas why this might be the case. Thanks
for any pointers here!
This patch initializes the eth_dev->link_intr_cbs queue which is
used when af_packet is passed into rte_eth_ev_callback_register().
Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks")
Signed-off-by: Chas Williams <3ch...@gmail.com>
---
drivers/net/af_packet/
On Tue, 2016-12-20 at 14:20 +, Ferruh Yigit wrote:
> On 12/17/2016 6:03 PM, Chas Williams wrote:
> > This patch initializes the eth_dev->link_intr_cbs queue which is
> > used when af_packet is passed into rte_eth_ev_callback_register().
>
> Why do you want to regist
On Thu, 2017-03-16 at 03:18 +, O'Driscoll, Tim wrote:
> > From: Vincent JARDIN [mailto:vincent.jar...@6wind.com]
> >
> > Le 15/03/2017 à 11:55, Thomas Monjalon a écrit :
> > >> I'd suggest that this is a good topic for the next Tech Board
> > meeting.
> > > I agree Tim.
> > > CC'ing techboard
On Wed, 2017-03-01 at 19:19 -0500, Allain Legacy wrote:
> +
> +/**
> + * Memory aligment (cache aligned)
Spelling -- alignment.
> + */
> +#ifndef RTE_AVP_ALIGNMENT
> +#define RTE_AVP_ALIGNMENT 64
> +#endif
This is already provided by DPDK as CONFIG_RTE_CACHE_LINE_SIZE
> + * Defines the number o
On Wed, 2017-03-01 at 19:20 -0500, Allain Legacy wrote:
> + /* Check current migration status */
> + if (avp_dev_migration_pending(eth_dev)) {
> + PMD_DRV_LOG(ERR, "VM live migration operation in progress\n");
> + return -EBUSY;
> + }
> +
> + /* Check BAR res
Don't dereference freed memory.
Fixes: a277c7159876 ("vhost: refactor code structure")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
lib/librte_vhost/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/socket.c b/lib/librte
Correctly hint the cache line size. Remove unused macros associated
with the cache line size.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
Acked-by: Harish Patil
---
drivers/net/bnx2x/bnx2x.h | 5 +
1 file changed, 1
ELINK_INCLUDE_EMUL and ELINK_INCLUDE_FPGA are never defined. Remove them
along with enumeration constants dependent on their inclusion.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.c | 28
d
This 2.5s delay doesn't seem to serve any purpose other than a being a
pause after logging the device configuration.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_ethdev.c | 2 --
1 file changed,
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x_rxtx.c | 13 +++--
drivers/net/bnx2x/bnx2x_rxtx.h | 6 --
2 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/net/bnx2
Don't use bnx2x_fill_accept_flags() to fill the RX mask in the VF
since the PF only handles a subset of the existing flags. now,
bnx2x_fill_accept_flags() can be static.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
driv
Replace BNX2X_TLV_APPEND() with the clearer and safer bnx2x_add_tlv().
bnx2x_add_tlv() was previously prototyped at some point but can be static.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/b
The pf2vf mailbox can only be used by one thread at a time.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.h| 12 +++--
drivers/net/bnx2x/bnx2x_ethdev.c | 2 +
drivers/net/bnx2x/bnx2
Refactor bnx2x_do_req4pf() to be easier to read and return errors when
the transaction fails -- Previously, it could succeed when the control
channel was down.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bn
bnx2x_loop_obtain_resources() returns a struct. This routine either
succeeds or fails -- We don't need a struct for that.
Fixes: 540a211084a7 ("bnx2x: driver core")
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bn
The register read/writes should just be static inline instead of
alternately defined as routines or macros depending on the status of
debugging.
Fix bnx2x_reg_read32() returning 0 during debug unaligned reads.
Fixes: b5bf7719221d ("bnx2x: driver support routines")
Signed-off-by: Cha
On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote:
> In the 802.3ad periodic callback function the link status of all slaves
> is checked using rte_eth_link_get function. Depending on the slave
> device this function can block for up to 9 seconds and therefore
> could cause issues with the L
If the link is up, then the driver cannot be stopped and started
successfully. Instead of checking the link status, use the driver's
state.
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
read cache.
Tidy some init code to make it clearer what the defaults are.
Signed-off-by: Chas Williams <3chas3 at gmail.com>
---
drivers/net/bnx2x/bnx2x.c | 16 +++-
drivers/net/bnx2x/bnx2x_rxtx.c | 2 +-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/
I wouldn't consider myself an expert on this driver but while looking
at some other things, I have noted that?RTE_PMD_BNX2X_TX_MAX_BURST is
defined to be 1. ?This bursts single packets to bnx2x_tx_encap() but it
looks like bnx2x_tx_encap() is far more capable than that.
On Tue, 2015-12-22 at 14:52
From: "Charles (Chas) Williams"
bnx2x_loop_obtain_resources() returns a struct containing the status and
the error message. If bnx2x_do_req4pf() fails, it shouldn't return both
of these fields set to 0 indicating failure and no error.
Further, bnx2x_do_req4pf() needs to be able
From: "Charles (Chas) Williams"
The VF needs to determine the queues sizes before .dev_infos_get
so that it can hint to the upper layer the proper sizes. Move
bnx2x_vf_get_resources() to .eth_dev_init and probe with the guesses
from bnx2x_init_rte().
Signed-off-by: Chas Williams
AM, Linhaifeng wrote:
Hi, Chars
Thank you.
I use it for send pkts to the dedicated queue of slaves.
Maybe i should not use it. I would though another way.
-邮件原件-
发件人: Chas Williams [mailto:3ch...@gmail.com]
发送时间: 2018年11月30日 11:27
收件人: Linhaifeng ; dev@dpdk.org
抄送: ch...@att.com
主题
On 1/7/19 8:01 AM, Hari Kumar Vemula wrote:
Create bonded device test is failing due to improper initialisation in
bonded device configuration. which leads to crash while setting up queues.
The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of
bonded device which fails.
T
Any other error messages? There's really only one path out of
slave_configure() that doesn't emit another error message and
that's slave_configure_slow_queue. You need to set dedicated_queues to
be enabled to see that happen.
On 10/07/18 01:12, chetan bhasin wrote:
Can anybody suggest? Stuc
Cc: sta...@dpdk.org
Signed-off-by: Chas Williams
Acked-by: Radu Nicolau
which was less clumsy attempt at the fix.
On Thu, Jun 14, 2018 at 1:10 PM Ferruh Yigit wrote:
> On 3/16/2018 4:34 PM, Chas Williams wrote:
> > From: "Charles (Chas) Williams"
> >
> >
On Thu, Jun 14, 2018 at 12:49 PM Ferruh Yigit
wrote:
> On 5/23/2018 10:11 AM, Kiran Kumar wrote:
> > Currently when resetting bond mac address, we are getting the
> > persisted mac address from slave info considering primary port
> > as index. But we need to compare the port id from slave info
>
On Thu, Jun 14, 2018 at 1:04 PM Ferruh Yigit wrote:
> On 4/16/2018 8:09 PM, Matan Azrad wrote:
> > Hi Chas
> >
> > From: Chas Williams, Monday, April 16, 2018 7:44 PM
> >> On Mon, Apr 16, 2018 at 4:06 AM, Matan Azrad
> >> wrote:
> >>> Hi Chas
&
On Mon, Jun 18, 2018 at 2:58 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Mon, 18 Jun 2018 15:27:16 +0300
> Alex Kiselev wrote:
>
> > +static const struct ether_addr null_mac_addr;
> > +
> > +/*
> > + * Add additional MAC addresses to the slave
> > + */
> > +int
> > +slave_add_m
On Mon, Jun 18, 2018 at 3:00 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Mon, 18 Jun 2018 15:27:16 +0300
> Alex Kiselev wrote:
>
> > +/*
> > + * Remove additional MAC addresses from the slave
> > + */
> > +int
> > +slave_remove_mac_addresses(struct rte_eth_dev *bonded_eth_dev,
On Wed, Jun 20, 2018 at 4:37 AM Alex Kiselev wrote:
> add functions to add/remove MAC addresses
> Signed-off-by: Alex Kiselev
>
Acked-by: Chas Williams
> ---
> drivers/net/bonding/rte_eth_bond_api.c | 12 ++-
> drivers/net/bonding/rte_eth_bo
From: "Charles (Chas) Williams"
When the bond PMD is stopped, the active slave count is reset.
For 802.3ad mode this potentially leaks memory and clears state since
a second sequential activate_slave() will occur when the bond PMD is
restarted and the LSC callback is triggered while
From: Chas Williams
Calling rte_eth_macaddr_get to get a copy of the MAC address causes
a hot spot according to profiling. We can easily get the current
MAC address by just examining the bonded device.
Signed-off-by: Chas Williams
---
drivers/net/bonding/rte_eth_bond_pmd.c | 14
On 10/31/2018 11:06 AM, Thomas Monjalon wrote:
31/10/2018 14:59, Radu Nicolau:
After the patch below the call to rte_eth_bond_8023ad_agg_selection_set
from probe() segfaults; there is no need to call the function, just set
the mode directly.
Fixes: 391797f04208 ("drivers/bus: move driver ass
river assignment to end of probing")
Fixes: 1620175b400e ("net/bonding: fix invalid port id")
Signed-off-by: Radu Nicolau
Acked-by: Chas Williams
---
v2: reverted earlier patch
drivers/net/bonding/rte_eth_bond_pmd.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff
On 11/02/2018 10:33 AM, Ferruh Yigit wrote:
On 11/1/2018 2:45 PM, Luca Boccassi wrote:
On Mon, 2017-07-17 at 19:05 -0400, Charles (Chas) Williams wrote:
.dev_uninit calls .dev_stop and .dev_close. The work that is done in
those routines doesn't need repeated. Use started and open
On 11/05/2018 12:41 PM, Zhang, Qi Z wrote:
-Original Message-
From: Luca Boccassi [mailto:bl...@debian.org]
Sent: Friday, November 2, 2018 8:19 AM
To: dev@dpdk.org
Cc: Lu, Wenzhuo ; Ananyev, Konstantin
; Zhang, Qi Z ;
3ch...@gmail.com; Luca Boccassi ; sta...@dpdk.org
Subject: [PATCH
On 11/07/2018 04:17 AM, Zhao1, Wei wrote:
Hi, Luca Boccassi
The purpose of this patch is to reduce the mailbox interrupt from vf to
pf, but there seem some point need for discussion in this patch.
First, I do not know why do you change code of function ixgbe_check_mac_link_vf(), beca
;)
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
Acked-by: Chas Williams
---
drivers/net/bonding/rte_eth_bond_pmd.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/drivers/net/bonding/rte_eth_bond_pmd.c
index 1a6d8e4..2661
From: Chas Williams
The same issue was fixed on for the ipv4 version of this routine in
commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8 bytes").
Briefly, the size of an ipv6 header is always 40 bytes. With an MTU of
1500, this will never produce a multiple of 8 byt
On 11/13/2018 11:46 AM, Radu Nicolau wrote:
Queue setup will fail if called before adding slaves.
Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves")
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
Acked-by: Chas Williams
---
examples/bond/m
On 11/14/2018 07:19 AM, Radu Nicolau wrote:
Do not start the packet processing threads until all configured
slaves become active.
Signed-off-by: Radu Nicolau
Acked-by: Chas Williams
---
examples/bond/main.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a
On 11/28/2018 08:48 AM, Radu Nicolau wrote:
Hi
On 11/28/2018 11:08 AM, Ferruh Yigit wrote:
On 11/14/2018 12:19 PM, Radu Nicolau wrote:
Do not start the packet processing threads until all configured
slaves become active.
Hi Radu,
What happens if packet processing threads started before a
On 11/28/18 11:04 AM, Radu Nicolau wrote:
On 11/28/2018 2:28 PM, Chas Williams wrote:
On 11/28/2018 08:48 AM, Radu Nicolau wrote:
Hi
On 11/28/2018 11:08 AM, Ferruh Yigit wrote:
On 11/14/2018 12:19 PM, Radu Nicolau wrote:
Do not start the packet processing threads until all
I guess this is slightly more correct. There is still a race here though.
After you make your copy of active_slave_count, the number of active
slaves could go to 0 and the memcpy() would copy an invalid element,
acitve_slaves[0]. There is no simple fix to this problem. Your patch
reduces the opp
>
> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Radu Nicolau
>
Signed-off-by: Chas Williams
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
I think this adds another race. In
bond_ethdev_slave_link_status_change_monitor(), it checks to see if bonding
is started, if not it exits. So you need to have dev_started = 1 set
before you enable this callback.
On Fri, Jul 20, 2018 at 6:09 AM Radu Nicolau wrote:
> Race condition can appear i
re reconfigured.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Radu Nicolau
>
Acked-by: Chas Williams
> ---
> v2: reworked patch
>
> drivers/net/bonding/rte_eth_bond_pmd.c | 8
> 1 file
From: "Charles (Chas) Williams"
>From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction
Update:
Starting from NVM 5.02, if the Set Local LLDP MIB command is
received while the DCBx specific agent is stopped, the command
returns an EPERM error. If the comman
On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau wrote:
> Update the bonding promiscuous mode enable/disable functions as to
> propagate the change to all slaves instead of doing nothing; this
> seems to be the correct behaviour according to the standard,
> and also implemented in the linux network st
On Wed, Aug 1, 2018 at 9:25 AM Radu Nicolau wrote:
> When a bonding port is stopped also stop and deactivate all slaves.
> Otherwise slaves will be still listed as active.
>
I have to think about this for a bit. The last time I tried this I had a
problem
because nothing activated the slaves aga
On Wed, Aug 1, 2018 at 10:00 AM Zhang, Qi Z wrote:
> Hi Williams:
>
> > -Original Message-
> > From: Chas Williams [mailto:3ch...@gmail.com]
> > Sent: Wednesday, August 1, 2018 12:07 PM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei ; Zhang, Qi Z <
>
On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau wrote:
>
>
> On 8/1/2018 2:34 PM, Chas Williams wrote:
>
>
>
> On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau
> wrote:
>
>> Update the bonding promiscuous mode enable/disable functions as to
>> propagate the change
On Thu, Aug 2, 2018 at 10:24 AM Matan Azrad wrote:
> Hi
>
> From: Doherty, Declan
> > On 02/08/2018 7:35 AM, Matan Azrad wrote:
> > > Hi Chas, Radu
> > >
> > > From: Chas Williams
> > >> On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau
> >
On Thu, Aug 2, 2018 at 1:33 PM Matan Azrad wrote:
> Hi Declan
>
> From: Doherty, Declan
> > On 02/08/2018 3:24 PM, Matan Azrad wrote:
> > > Hi
> > >
> > > From: Doherty, Declan
> > >> On 02/08/2018 7:35 AM, Matan Azrad wrote:
> > >&
On Thu, Aug 2, 2018 at 6:03 AM Radu Nicolau wrote:
> Signed-off-by: Radu Nicolau
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
> b/drivers/net/bonding/rte_eth_bond_802
On Wed, Aug 1, 2018 at 10:16 PM Zhang, Qi Z wrote:
>
>
>
>
> *From:* Chas Williams [mailto:3ch...@gmail.com]
> *Sent:* Wednesday, August 1, 2018 11:31 PM
> *To:* Zhang, Qi Z
> *Cc:* dev@dpdk.org; Xing, Beilei ; Chas Williams <
> ch...@att.com>
> *Subject:* Re
On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon wrote:
> 02/08/2018 15:38, Doherty, Declan:
> > On 01/08/2018 2:18 PM, Radu Nicolau wrote:
> > > When a bonding port is stopped also stop and deactivate all slaves.
> > > Otherwise slaves will be still listed as active.
> > >
> > > Fixes: 69bce062132
On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad wrote:
> Hi Chas
>
> From: Chas Williams [mailto:3ch...@gmail.com] On Thu, Aug 2, 2018 at 1:33
> > PM Matan Azrad wrote:
> > >
> > > > I suggest to do it like next,
> > > > To add one more parameter for
On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad wrote:
> Hi Chas
>
> From: Chas Williams
> >On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad <mailto:ma...@mellanox.com>
> wrote:
> >Hi Chas
> >
> > From: Chas Williams [mailto:mailto:3ch...@gmail.com] On Thu,
On Thu, Aug 2, 2018 at 10:10 PM Zhang, Qi Z wrote:
>
>
>
>
> *From:* Chas Williams [mailto:3ch...@gmail.com]
> *Sent:* Friday, August 3, 2018 5:20 AM
> *To:* Zhang, Qi Z
> *Cc:* dev@dpdk.org; Xing, Beilei ; Chas Williams <
> ch...@att.com>
> *Subject:* Re
How is VMDQ supposed to work?
The i40e .dev_infos_get doesn't seem to look for the VMDQ enabled flag and
just goes ahead and modifies the queue counts to include the VMDQ queues:
if (pf->flags & I40E_FLAG_VMDQ) {
dev_info->max_vmdq_pools = pf->max_nb_vmdq_vsi;
From: "Charles (Chas) Williams"
>From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction
Update:
Starting from NVM 5.02, if the Set Local LLDP MIB command is
received while the DCBx specific agent is stopped, the command
returns an EPERM error. If the comman
On Tue, Aug 7, 2018 at 4:11 AM wangyunjian wrote:
> From: Yunjian Wang
>
> We assume VLAN ethtertype is 0x8100 in get_vlan_offset() function,
> but it could be 0x88A8 if QinQ is supported.
>
> Signed-off-by: Yunjian Wang
>
Acked-by: Chas Williams
> --
On Fri, Aug 17, 2018 at 9:46 PM Jia Yu wrote:
> When bond slave devices cannot transmit all packets in bufs array,
> tx_burst callback shall merge the un-transmitted packets back to
> bufs array. Recent merge logic introduced a bug which causes
> invalid mbuf addresses being written to bufs array
[i];
>
>
> /*
> * Shift bufs to beginning of array to allow reordering
> * later
> */
> for (j = 0; j < slave_tx_fail_count[i]; j++) {
> slave_bufs[i][j] =
> slave_bufs[i][(sla
ight notice that
slave_tx_fail_count doesn't need to be an array. It's local to
if (unlikely(slave_tx_count < slave_nb_bufs[i])) now.
>
> }
> }
> }
>
>
>
> Thanks,
>
> Jia
>
>
>
> *From: *Chas Williams <3ch
sh calculation")
> Cc: sta...@dpdk.org
> Signed-off-by: Jia Yu
>
Acked-by: Chas Williams
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 116
> +++--
> 1 file changed, 23 insertions(+), 93 deletions(-)
>
> diff --git a/drivers/net/bonding
>
>
> Thanks,
>
> Jia
>
>
>
> *From: *Chas Williams <3ch...@gmail.com>
> *Date: *Sunday, August 19, 2018 at 5:07 PM
> *To: *Jia Yu
> *Cc: *"dev@dpdk.org" , Declan Doherty <
> declan.dohe...@intel.com>, Chas Williams
> *Subject: *Re
small change improves performances of the bonding driver
> considerably. Vyatta has been using it for years in production.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Eric Kinzie
> Signed-off-by: Luca Boccassi
>
Acked-by: Chas Williams
> ---
> v2 and v3: fix checkpat
On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad wrote:
> Hi
>
> From: Chas Williams
> > This will need to be implemented for some of the other RX burst methods
> at
> > some point for other modes to see this performance improvement (with the
> > exception of activ
On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad wrote:
> Hi Chas
>
> From: Chas Williams
> > On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad
> > wrote:
> > Hi
> >
> > From: Chas Williams
> > > This will need to be implemented for some of the other RX b
On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit wrote:
> On 8/6/2018 4:50 PM, Chas Williams wrote:
> > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon
> wrote:
> >
> >> 02/08/2018 15:38, Doherty, Declan:
> >>> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
>
rote:
> > > > > Hi Chas
> > > > >
> > > > > From: Chas Williams
> > > > > > On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad
> > > > > > <mailto:matan@mellanox .com> wrote:
> > > > > > Hi Chas
>
On Fri, Aug 24, 2018 at 6:39 AM Ferruh Yigit wrote:
> On 8/23/2018 4:21 PM, Chas Williams wrote:
> >
> >
> > On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote:
> >
> > On 8/6/2018 4:50 PM, Chas Williams wr
On Sun, Aug 26, 2018 at 3:40 AM Matan Azrad wrote:
>
> From: Chas Williams <3ch...@gmail.com>
> >On Thu, Aug 23, 2018 at 3:28 AM Matan Azrad <mailto:ma...@mellanox.com>
> wrote:
> >Hi
> >
> >From: Eric Kinzie
> >> On Wed Aug 22
On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad wrote:
> Hi Chas
>
> From: Chas Williams <3ch...@gmail.com>
> >On Sun, Aug 26, 2018 at 3:40 AM Matan Azrad <mailto:ma...@mellanox.com>
> wrote:
> >
> >From: Chas Williams <mailto:3ch...@gmail.com>
VLAN is stripped from the mbuf. To limit any potential performance
> impact on the PF data path, the RX path is split into PF and VF
> versions with the transparent VLAN stripping only done in the VF
> path. Measurements with our application show ~2% performance hit for
> the VF ca
On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad wrote:
>
>
> From: Chas Williams
> >On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad <mailto:ma...@mellanox.com>
> wrote:
>
> >>>Because rings are generally quite efficient.
> >>
> >>But you are
This is not an
> expected behaviour.
>
> Make the bond_ethdev_configure() set default RSS key only if
> requested key is set to NULL.
>
> Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Igor Romanov
>
> Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Igor Romanov
> Signed-off-by: Andrew Rybchenko
>
Acked-by: Chas Williams
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++-
> 1 file cha
On Sun, Sep 2, 2018 at 7:34 AM Matan Azrad wrote:
>
> Hi Luca\Chas
>
> From: Luca Boccassi
> > On Wed, 2018-08-29 at 15:20 +, Matan Azrad wrote:
> > >
> > > From: Chas Williams
> > > > On Tue, Aug 28, 2018 at 5:51 AM Matan
1 - 100 of 353 matches
Mail list logo
