On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote:
> In the 802.3ad periodic callback function the link status of all slaves
> is checked using rte_eth_link_get function. Depending on the slave
> device this function can block for up to 9 seconds and therefore
> could cause issues with the LACP Daemon state machine and control
> patches handling. This patch changes to the no-wait version of
> the link get function.
>
> Fixes: 46fb4368 ("bond:add mode 4")
>
> Signed-off-by: Declan Doherty <declan.dohe...@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
> b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index d2b7592..3a97336 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -758,7 +758,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
> uint16_t key;
>
> slave_id = internals->active_slaves[i];
> - rte_eth_link_get(slave_id, &link_info);
> + rte_eth_link_get_nowait(slave_id, &link_info);
> rte_eth_macaddr_get(slave_id, &slave_addr);
>
> if (link_info.link_status != 0) {
It seems like this should be done in bandwidth_left() as well.
