On Tue, 2016-12-20 at 14:20 +0000, Ferruh Yigit wrote:
> On 12/17/2016 6:03 PM, Chas Williams wrote:
> > This patch initializes the eth_dev->link_intr_cbs queue which is
> > used when af_packet is passed into rte_eth_ev_callback_register().
>
> Why do you want to register callback to af_packet PMD, it won't be
> calling them?
Because I have a some other code that basically treats all the PMD's
the same way. Do I really need to write an exception for that code
that says "if this is driver such and such don't call this API routine?"
> >
> > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks")
> >
> > Signed-off-by: Chas Williams <3ch...@gmail.com>
>
> Please cc the maintainers...
OK
>
> CC: John W. Linville <linvi...@tuxdriver.com>
>
> > ---
> > drivers/net/af_packet/rte_eth_af_packet.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
> > b/drivers/net/af_packet/rte_eth_af_packet.c
> > index a1e13ff..ea5070a 100644
> > --- a/drivers/net/af_packet/rte_eth_af_packet.c
> > +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> > @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name,
> > (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name;
> > (*eth_dev)->data->kdrv = RTE_KDRV_NONE;
> > (*eth_dev)->data->numa_node = numa_node;
> > + TAILQ_INIT(&((*eth_dev)->link_intr_cbs));
> >
> > return 0;
> >
> >
>
>
