[dpdk-dev] [PATCH] lib: fix write unlock during ring creation

2018-11-13 Thread Chaitanya Babu Talluri
ned-off-by: Chaitanya Babu Talluri --- lib/librte_efd/rte_efd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index a780e2fe8..0c7ce9612 100644 --- a/lib/librte_efd/rte_efd.c +++ b/lib/librte_efd/rte_efd.c @@ -687,

[dpdk-dev] [PATCH v2] lib/efd: fix write unlock during ring creation

2018-11-14 Thread Chaitanya Babu Talluri
In rte_efd_create() write lock has already been unlocked before ring creation itself. So second unlock after the ring creation has been removed. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri Acked-by: Res

[dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-13 Thread Chaitanya Babu Talluri
port multiprocess") Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- drivers/net/bnx2x/bnx2x.c | 6 -- drivers/net/i40e/i40e_ethdev.c | 6 -- drivers/net/nfp/nfpcore/nf

[dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat

2019-01-18 Thread Chaitanya Babu Talluri
port multiprocess") Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v2: Instead of strncat, used snprintf. --- drivers/net/bnx2x/bnx2x.c | 6 -- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat

2019-01-18 Thread Chaitanya Babu Talluri
port multiprocess") Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v2: Instead of strncat, used snprintf. --- drivers/net/bnx2x/bnx2x.c | 6 -- drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH] lib: fix strcat with equivalent logic

2019-02-14 Thread Chaitanya Babu Talluri
Replace strcat with concatenation logic to avoid buffer overflow. Fixes: a6a47ac9c2 ("cfgfile: rework load function") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/librte_cfgfile/rte_cfgfile.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH] lib: fix strcat with equivalent logic

2019-02-14 Thread Chaitanya Babu Talluri
Replace strcat with concatenation logic to avoid buffer overflow. Fixes: a6a47ac9c2 ("cfgfile: rework load function") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/librte_cfgfile/rte_cfgfile.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat

2019-02-26 Thread Chaitanya Babu Talluri
port multiprocess") Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v3: Instead of strncat, used strlcat. v2: Instead of strncat, used snprintf. --- drivers/net/bnx2x/bnx2x.c | 6 -- drivers

[dpdk-dev] [PATCH v4] drivers: fix possible overflow with strcat

2019-03-05 Thread Chaitanya Babu Talluri
ate ptype and pctype info") Fixes: ef28aa96e5 ("net/nfp: support multiprocess") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v4: Corrected usage of strlcat. v3: Instead of strncat, used strlcat. v2: Instead of strncat, used snprintf. --- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v5] drivers: fix possible overflow with strcat

2019-03-07 Thread Chaitanya Babu Talluri
ate ptype and pctype info") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v5: Removed strcat. v4: Corrected usage of strlcat. v3: Instead of strncat, used strlcat. v2: Instead of strncat, used snprintf. --- app/test/test_cryptodev.c | 3 ++- drivers/net/bnx2x/bnx2x.c

[dpdk-dev] [PATCH v2] lib/cfgfile: replace strcat with strlcat

2019-03-08 Thread Chaitanya Babu Talluri
Replace strcat with strlcat to avoid buffer overflow. Fixes: a6a47ac9c2 ("cfgfile: rework load function") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v2: Instead of strcat, used strlcat. --- lib/librte_cfgfile/rte_cfgfile.c | 4 +++- 1 file changed, 3 insert

[dpdk-dev] [PATCH] app/test: fix possible overflow with strcat

2019-03-14 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- app/test/test_cryptodev.c

[dpdk-dev] [PATCH v6] drivers/net: fix possible overflow with strcat

2019-03-14 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Cc: sta...@dpdk.org Signed-off-by: Ch

[dpdk-dev] [PATCH v2] app/test: fix possible overflow using strlcat

2019-03-18 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v2: Updated title. ---

[dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat

2019-03-18 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Cc: sta...@dpdk.org Signed-off-by: Ch

[dpdk-dev] [PATCH v8] drivers/net: fix possible overflow using strlcat

2019-03-22 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Cc: sta...@dpdk.org Signed-off-by: Ch

[dpdk-dev] [PATCH 0/3] add unit tests for eal vfio library

2019-08-21 Thread Chaitanya Babu Talluri
1/3: fix vfio unmap that fails unexpectedly 2/3: fix vfio unmap that succeeds unexpectedly 3/3: add unit tests for eal vfio Signed-off-by: Chaitanya Babu Talluri Chaitanya Babu Talluri (3): lib/eal: fix vfio unmap that fails unexpectedly lib/eal: fix vfio unmap that succeeds unexpectedly

[dpdk-dev] [PATCH 1/3] lib/eal: fix vfio unmap that fails unexpectedly

2019-08-21 Thread Chaitanya Babu Talluri
ned-off-by: Chaitanya Babu Talluri --- lib/librte_eal/linux/eal/eal_vfio.c | 46 + 1 file changed, 46 insertions(+) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 501c74f23..104912077 100644 --- a/lib/librte_eal/linux/eal/

[dpdk-dev] [PATCH 2/3] lib/eal: fix vfio unmap that succeeds unexpectedly

2019-08-21 Thread Chaitanya Babu Talluri
is is the cause. The solution is that in find_user_mem_maps, check whether user input iova is in relation with input virtual address of the page which is to be unmapped. Fixes: 73a6390859 ("vfio: allow to map other memory regions") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Ta

[dpdk-dev] [PATCH 3/3] app/test: add unit tests for eal vfio

2019-08-21 Thread Chaitanya Babu Talluri
Unit test cases are added for eal vfio library. eal_vfio_autotest added to meson build file. Signed-off-by: Chaitanya Babu Talluri --- app/test/Makefile| 1 + app/test/meson.build | 2 + app/test/test_eal_vfio.c | 728 +++ 3 files changed, 731

[dpdk-dev] [PATCH v2 2/3] lib/eal: fix vfio unmap that succeeds unexpectedly

2019-08-22 Thread Chaitanya Babu Talluri
") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/linux/eal/eal_vfio.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 104912077..04c284cb2 100644

[dpdk-dev] [PATCH v2 1/3] lib/eal: fix vfio unmap that fails unexpectedly

2019-08-22 Thread Chaitanya Babu Talluri
Unmap fails when there are duplicate entries in user_mem_maps. The fix is to validate if the input VA, IOVA exists or overlaps in user_mem_maps before creating map. Fixes: 73a63908 ("vfio: allow to map other memory regions") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri

[dpdk-dev] [PATCH v2 3/3] app/test: add unit tests for eal vfio

2019-08-22 Thread Chaitanya Babu Talluri
Unit test cases are added for eal vfio library. eal_vfio_autotest added to meson build file. Signed-off-by: Chaitanya Babu Talluri --- app/test/Makefile| 1 + app/test/meson.build | 2 + app/test/test_eal_vfio.c | 728 +++ 3 files changed, 731

[dpdk-dev] [PATCH v2 0/3] add unit tests for eal vfio library

2019-08-22 Thread Chaitanya Babu Talluri
1/3: fix vfio unmap that fails unexpectedly 2/3: fix vfio unmap that succeeds unexpectedly 3/3: add unit tests for eal vfio Signed-off-by: Chaitanya Babu Talluri --- v2: Updated commit messages. --- Chaitanya Babu Talluri (3): lib/eal: fix vfio unmap that fails unexpectedly lib/eal: fix

[dpdk-dev] [PATCH v3 0/4] add unit tests for eal vfio library

2019-08-27 Thread Chaitanya Babu Talluri
1/4: fix vfio unmap that fails unexpectedly 2/4: fix vfio unmap that succeeds unexpectedly 3/4: add API to check iommu type is set 4/4: add unit tests for eal vfio Patch 4/4 depends on 1/4,2/4,3/4 Signed-off-by: Chaitanya Babu Talluri --- v3: Added API to check iommu type. v2: Updated commit

[dpdk-dev] [PATCH v3 2/4] lib/eal: fix vfio unmap that succeeds unexpectedly

2019-08-27 Thread Chaitanya Babu Talluri
") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/linux/eal/eal_vfio.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 104912077..04c284cb2 100644

[dpdk-dev] [PATCH v3 3/4] lib/eal: add API to check iommu type is set

2019-08-27 Thread Chaitanya Babu Talluri
Add rte_vfio_iommu_type_is_set() to check IOMMU type for default container. Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/common/include/rte_vfio.h | 10 ++ lib/librte_eal/linux/eal/eal_vfio.c | 16 2 files changed, 26 insertions(+) diff --git a/lib

[dpdk-dev] [PATCH v3 4/4] app/test: add unit tests for eal vfio

2019-08-27 Thread Chaitanya Babu Talluri
Unit test cases are added for eal vfio library. eal_vfio_autotest added to meson build file. Signed-off-by: Chaitanya Babu Talluri --- app/test/Makefile| 1 + app/test/meson.build | 2 + app/test/test_eal_vfio.c | 736 +++ 3 files changed, 739

[dpdk-dev] [PATCH v3 1/4] lib/eal: fix vfio unmap that fails unexpectedly

2019-08-27 Thread Chaitanya Babu Talluri
Unmap fails when there are duplicate entries in user_mem_maps. The fix is to validate if the input VA, IOVA exists or overlaps in user_mem_maps before creating map. Fixes: 73a63908 ("vfio: allow to map other memory regions") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri

[dpdk-dev] [PATCH v4 0/4] add unit tests for eal vfio library

2019-09-04 Thread Chaitanya Babu Talluri
1/4: fix vfio unmap that fails unexpectedly 2/4: fix vfio unmap that succeeds unexpectedly 3/4: add API to check iommu type is set 4/4: add unit tests for eal vfio Patch 4/4 depends on 1/4,2/4,3/4 Signed-off-by: Chaitanya Babu Talluri --- v4: Fixed compilation issues. v3: Added API to check

[dpdk-dev] [PATCH v4 1/4] lib/eal: fix vfio unmap that fails unexpectedly

2019-09-04 Thread Chaitanya Babu Talluri
Unmap fails when there are duplicate entries in user_mem_maps. The fix is to validate if the input VA, IOVA exists or overlaps in user_mem_maps before creating map. Fixes: 73a63908 ("vfio: allow to map other memory regions") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri

[dpdk-dev] [PATCH v4 3/4] lib/eal: add API to check iommu type is set

2019-09-04 Thread Chaitanya Babu Talluri
Add rte_vfio_iommu_type_is_set() to check IOMMU type for default container. Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/common/include/rte_vfio.h | 11 +++ lib/librte_eal/linux/eal/eal_vfio.c | 16 lib/librte_eal/rte_eal_version.map | 3 +++ 3

[dpdk-dev] [PATCH v4 2/4] lib/eal: fix vfio unmap that succeeds unexpectedly

2019-09-04 Thread Chaitanya Babu Talluri
") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/linux/eal/eal_vfio.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c index 104912077..04c284cb2 100644

[dpdk-dev] [PATCH v4 4/4] app/test: add unit tests for eal vfio

2019-09-04 Thread Chaitanya Babu Talluri
Unit test cases are added for eal vfio library. eal_vfio_autotest added to meson build file. Signed-off-by: Chaitanya Babu Talluri --- app/test/Makefile| 1 + app/test/meson.build | 2 + app/test/test_eal_vfio.c | 737 +++ 3 files changed, 740

[dpdk-dev] [PATCH] lib/eventdev: fix null pointer dereferences coverity issue

2019-09-20 Thread Chaitanya Babu Talluri
("eventdev: add crypto adapter implementation") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eventdev/rte_event_crypto_adapter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librt

[dpdk-dev] [PATCH] examples/fips_validation: fix null pointer dereferences

2019-09-24 Thread Chaitanya Babu Talluri
val->val is accessed without null check. The fix is to return the error, if keys are not found in writeback_tdes_hex_str(). Coverity issue: 343408 Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- exa