In rte_efd_create() write lock has already been unlocked
before ring creation itself.
So second unlock after the ring creation has been removed
and added freeing of tail queue entry and efd table.
Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
Cc: sta...@dpdk.org
Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.b...@intel.com>
---
lib/librte_efd/rte_efd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c
index a780e2fe8..0c7ce9612 100644
--- a/lib/librte_efd/rte_efd.c
+++ b/lib/librte_efd/rte_efd.c
@@ -687,12 +687,13 @@ rte_efd_create(const char *name, uint32_t max_num_rules,
uint32_t key_len,
rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK);
snprintf(ring_name, sizeof(ring_name), "HT_%s", table->name);
- /* Create ring (Dummy slot index is not enqueued) */
+ /* Create ring (Dummy slot index is not enqueued) */
r = rte_ring_create(ring_name, rte_align32pow2(table->max_num_rules),
offline_cpu_socket, 0);
if (r == NULL) {
RTE_LOG(ERR, EFD, "memory allocation failed\n");
- goto error_unlock_exit;
+ rte_efd_free(table);
+ return NULL;
}
/* Populate free slots ring. Entry zero is reserved for key misses. */
--
2.13.6
