[DPDK/ethdev Bug 1591] MLX5 Windows : Issue with Packet Loss When Setting Descriptors Above 1<<14 on ConnectX6-DX

https://bugs.dpdk.org/show_bug.cgi?id=1591 Bug ID: 1591 Summary: MLX5 Windows : Issue with Packet Loss When Setting Descriptors Above 1<<14 on ConnectX6-DX Product: DPDK Version: 24.11 Hardware: x86 OS: Wind

[PATCH] doc: add tested platforms with NVIDIA NICs

Add tested platforms with NVIDIA NICs to the 24.11 release notes. Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_24_11.rst | 108 + 1 file changed, 108 insertions(+) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_

Re: [PATCH v1 1/1] usertools/devbind: update coding style

On Mon, 2 Dec 2024 15:09:34 + Anatoly Burakov wrote: > +# For kernels < 3.15 when binding devices to a generic driver (i.e. one > that doesn't have a PCI > +# ID table) using new_id, some devices that are not bound to any other > driver could be bound > +# even if no one has as

RE: [PATCH][v2, 3/3] usertools/dpdk-devbind: add bind/unbind for platform device

Hi, may I ask if there are any further changes needed for this patch? If not, can it be submitted to the open-source community?

Re: [PATCH v1 1/1] usertools/devbind: update coding style

On 12/2/2024 6:01 PM, Stephen Hemminger wrote: On Mon, 2 Dec 2024 15:09:34 + Anatoly Burakov wrote: +# For kernels < 3.15 when binding devices to a generic driver (i.e. one that doesn't have a PCI +# ID table) using new_id, some devices that are not bound to any other driver cou

RE: [External] Re: [PATCH] eal: fix bus cleanup in secondary process

Hi Stephen, Yes, You're right. I'm making a new patch for improving in crypto device to solve this issue. And the modification has already worked in our cases. Anyway, I will upload the patch soon and will mark the status of this patch to Superseded. Thanks. Brs, Yang Ming -Original Messag

[PATCH v2 2/2] usertools/devbind: replace devbind

Signed-off-by: Anatoly Burakov --- Notes: v2: - Added this patch to aid in review - I believe it's better to squash it on apply usertools/dpdk-devbind-new.py | 996 --- usertools/dpdk-devbind.py | 1678 ++--- 2 files changed, 911 inse

[PATCH v2 0/2] Rewrite devbind

It has been suggested [1] that a major cleanup/rewrite of devbind would be beneficial in terms of long term maintainability of the code. I was in a coding mood over the weekend, and so I've went ahead and rewritten devbind. Note that this is one giant patch, rather than a series of patches adjusti

[PATCH v2 1/2] usertools/devbind: update coding style

Devbind is one of the oldest tools in DPDK, and is written in a way that uses a lot of string matching, no type safety, lots of global variables, and has a few inconsistencies in the way it handles data (such as differences between lspci calls and parsing in different circumstances). This patch is

RE: rte_fib network order bug

Hi Robin, I like the second approach with one more suggestion. It would be nice to have 2 different flags - an existing flag (RTE_FIB_F_LOOKUP_NETWORK_ORDER) for the data plane bswap, and a new one for the control plane operations (smth like RTE_FIB/RIB_F_CP_NETWORK_ORDER). Also for user conven

Re: [PATCH v1 0/1] Rewrite devbind

On 12/2/2024 5:14 PM, Bruce Richardson wrote: On Mon, Dec 02, 2024 at 03:09:33PM +, Anatoly Burakov wrote: It has been suggested [1] that a major cleanup/rewrite of devbind would be beneficial in terms of long term maintainability of the code. I was in a coding mood over the weekend, and so

[PATCH] net/mlx5: fix hypervisor detection in VLAN workaround

The mlx5 PMD provides a specific workaround for the VMware ESXi hypervisor, enabling on-demand routing configuration to virtual machines. This workaround activates when the device type is a Virtual Function and either an ESXi hypervisor is detected or the hypervisor type is unknown. For non-x86 ar

[PATCH v2 02/22] net/_common_intel: provide common Tx entry structures

The Tx entry structures, both vector and scalar, are common across Intel drivers, so provide a single definition to be used everywhere. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h| 27 +++ .../net/i40e/i40e_recycle_mbufs_vec_common.c | 2 +

[PATCH v2 01/22] net/_common_intel: add pkt reassembly fn for intel drivers

The code for reassembling a single, multi-mbuf packet from multiple buffers received from the NIC is duplicated across many drivers. Rather than having multiple copies of this function, we can create an "_common_intel" directory to hold such functions and consolidate multiple functions down to a si

[PATCH v2 03/22] net/_common_intel: add Tx mbuf ring replenish fn

Move the short function used to place mbufs on the SW Tx ring to common code to avoid duplication. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h | 7 +++ drivers/net/i40e/i40e_rxtx_vec_altivec.c | 4 ++-- drivers/net/i40e/i40e_rxtx_vec_avx2.c| 4 ++-- dr

[PATCH v2 06/22] net/_common_intel: merge ice and i40e Tx queue struct

The queue structures of i40e and ice drivers are virtually identical, so merge them into a common struct. This should allow easier function merging in future using that common struct. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h| 55 + driver

[PATCH v2 05/22] drivers/net: add prefix for driver-specific structs

In preparation for merging the Tx structs for multiple drivers into a single struct, rename the driver-specific pointers in each struct to have a prefix on it, to avoid conflicts. Signed-off-by: Bruce Richardson --- drivers/net/i40e/i40e_fdir.c | 6 +-- .../net/i40e/i40e_recycl

[PATCH v2 08/22] net/ixgbe: convert Tx queue context cache field to ptr

Rather than having a two element array of context cache values inside the Tx queue structure, convert it to a pointer to a cache at the end of the structure. This makes future merging of the structure easier as we don't need the "ixgbe_advctx_info" struct defined when defining a combined queue stru

[PATCH v2 09/22] net/ixgbe: use common Tx queue structure

Merge in additional fields used by the ixgbe driver and then convert it over to using the common Tx queue structure. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h| 14 +++- drivers/net/ixgbe/ixgbe_ethdev.c | 4 +- .../ixgbe/ixgbe_recycle_mbufs_v

[PATCH v2 07/22] net/iavf: use common Tx queue structure

Merge in the few additional fields used by iavf driver and convert it to using the common Tx queue structure also. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h | 15 +++- drivers/net/iavf/iavf.h | 2 +- drivers/net/iavf/iavf_ethdev.c |

[PATCH v2 04/22] drivers/net: align Tx queue struct field names

Across the various Intel drivers sometimes different names are given to fields in the Tx queue structure which have the same function. Do some renaming to align things better for future merging. Signed-off-by: Bruce Richardson --- drivers/net/i40e/i40e_rxtx.c| 6 +-- drivers/net/i40

[PATCH v2 10/22] net/_common_intel: pack Tx queue structure

Move some fields about to better pack the Tx queue structure and make sure all data used by the vector codepaths is on the first cacheline of the structure. Checking with "pahole" on 64-bit build, only one 6-byte hole is left in the structure - on second cacheline - after this patch. As part of th

[PATCH v2 11/22] net/_common_intel: add post-Tx buffer free function

The actions taken for post-Tx buffer free for the SSE and AVX drivers for i40e, iavf and ice drivers are all common, so centralize those in common/intel_eth driver. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h | 71 drivers/net/i40e/i40e_rx

[PATCH v2 19/22] net/i40e: use vector SW ring for all vector paths

The AVX-512 code path used a smaller SW ring structure only containing the mbuf pointer, but no other fields. The other fields are only used in the scalar code path, so update all vector driver code paths (AVX2, SSE, Neon, Altivec) to use the smaller, faster structure. Signed-off-by: Bruce Richard

[PATCH v2 21/22] net/_common_intel: remove unneeded code

With all drivers using the common Tx structure updated so that their vector paths all use the simplified Tx mbuf ring format, it's no longer necessary to have a separate flag for the ring format and for use of a vector driver. Remove the former flag and base all decisions off the vector flag. With

[PATCH v2 14/22] net/ice: move Tx queue mbuf cleanup fn to common

The functions to loop over the Tx queue and clean up all the mbufs on it, e.g. for queue shutdown, is not device specific and so can move into the common_intel headers. Only complication is ensuring that the correct ring format, either minimal vector or full structure, is used. Ice driver currently

[PATCH v2 15/22] net/i40e: use common Tx queue mbuf cleanup fn

Update driver to be similar to the "ice" driver and use the common mbuf ring cleanup code on shutdown of a Tx queue. Signed-off-by: Bruce Richardson --- drivers/net/i40e/i40e_ethdev.h | 4 +- drivers/net/i40e/i40e_rxtx.c | 70 -- drivers/net/i40e/i40e_rxtx.h

[PATCH v2 17/22] net/iavf: use common Tx queue mbuf cleanup fn

Adjust iavf driver to also use the common mbuf freeing functions on Tx queue release/cleanup. The implementation is complicated a little by the need to integrate the additional "has_ctx" parameter for the iavf code, but changes in other drivers are minimal - just a constant "false" parameter. Sign

[PATCH v2 16/22] net/ixgbe: use common Tx queue mbuf cleanup fn

Update driver to use the common cleanup function. Signed-off-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_rxtx.c| 22 +++--- drivers/net/ixgbe/ixgbe_rxtx.h| 1 - drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 28 ++- drivers/net/ixgbe/ixg

[PATCH v2 18/22] net/ice: use vector SW ring for all vector paths

The AVX-512 code path used a smaller SW ring structure only containing the mbuf pointer, but no other fields. The other fields are only used in the scalar code path, so update all vector driver code paths to use the smaller, faster structure. Signed-off-by: Bruce Richardson --- drivers/net/_comm

[PATCH v2 13/22] net/iavf: use common Tx free fn for AVX-512

Switch the iavf driver to use the common Tx free function. This requires one additional parameter to that function, since iavf sometimes uses context descriptors which means that we have double the descriptors per SW ring slot. Signed-off-by: Bruce Richardson --- drivers/net/_common_intel/tx.h

[PATCH v2 20/22] net/iavf: use vector SW ring for all vector paths

The AVX-512 code path used a smaller SW ring structure only containing the mbuf pointer, but no other fields. The other fields are only used in the scalar code path, so update all vector driver code paths (AVX2, SSE) to use the smaller, faster structure. Signed-off-by: Bruce Richardson --- drive

Re: About DPDK l3fwd

On Fri, Nov 22, 2024 at 09:45:58AM +, 王颢 wrote: > Dear all, > > I have noticed that the performance reports on the official DPDK website > predominantly use l3fwd, while we typically utilize pktgen. Out of curiosity, > I attempted to replicate the experiments from the performance reports. >

[PATCH v2 22/22] net/ixgbe: use common Tx backlog entry fn

Remove the custom vector Tx backlog entry function and use the standard intel_common one, now that all vector drivers are using the same, smaller ring structure. Signed-off-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 10 -- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c

[PATCH v2 00/22] Reduce code duplication across Intel NIC drivers

This RFC attempts to reduce the amount of code duplication across a number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. The first patch extract a function from the Rx side, otherwise the majority of the changes are on the Tx side, leading to a converged Tx queue structure across

Re: [PATCH] net/mlx5: fix hypervisor detection in VLAN workaround

On Tue, 3 Dec 2024 18:22:00 +0200 Viacheslav Ovsiienko wrote: > diff --git a/drivers/net/mlx5/linux/mlx5_vlan_os.c > b/drivers/net/mlx5/linux/mlx5_vlan_os.c > index 81611a8d3f..017953d5cc 100644 > --- a/drivers/net/mlx5/linux/mlx5_vlan_os.c > +++ b/drivers/net/mlx5/linux/mlx5_vlan_os.c > @@ -112

[PATCH v2 12/22] net/_common_intel: add Tx buffer free fn for AVX-512

AVX-512 code paths for ice and i40e drivers are common, and differ from the regular post-Tx free function in that the SW ring from which the buffers are freed does not contain anything other than the mbuf pointer. Merge these into a common function in intel_common to reduce duplication. Signed-off

Re: [PATCH v2 1/2] usertools/devbind: update coding style

On Tue, 3 Dec 2024 11:25:00 + Anatoly Burakov wrote: > + > +def check_installed(program: str, package: str) -> None: > +"""Check if a program is installed.""" > +if subprocess.call( > +["which", program], stdout=subprocess.DEVNULL, > stderr=subprocess.DEVNULL > +): > +

Re: [PATCH v16 1/4] lib: add generic support for reading PMU events

On Mon, 18 Nov 2024 08:37:03 +0100 Tomasz Duszynski wrote: > diff --git a/doc/guides/prog_guide/profile_app.rst > b/doc/guides/prog_guide/profile_app.rst > index a6b5fb4d5e..ecb90a0d94 100644 > --- a/doc/guides/prog_guide/profile_app.rst > +++ b/doc/guides/prog_guide/profile_app.rst > @@ -7,6 +7

Re: [PATCH v16 4/4] eal: add PMU support to tracing library

On Mon, 18 Nov 2024 08:37:06 +0100 Tomasz Duszynski wrote: > +static int > +add_events(const char *pattern) > +{ > + char *token, *copy; > + int ret = 0; > + > + copy = strdup(pattern); > + if (copy == NULL) > + return -ENOMEM; > + > + token = strtok(copy, ","); S

Re: [RFC v3 1/2] pci: introduce the PCIe TLP Processing Hints API

On Mon, 21 Oct 2024 01:52:45 + Wathsala Vithanage wrote: > Extend the PCI driver and the library to extract the Steering Tag (ST) > for a given Processor/Processor Container and Cache ID pair and validate > a Processing Hint from a TPH _DSM associated with a root port device. > The rte_pci_de

Re: [RFC v3 2/2] ethdev: introduce the cache stashing hints API

On Mon, 21 Oct 2024 01:52:46 + Wathsala Vithanage wrote: > Extend the ethdev library to enable the stashing of different data > objects, such as the ones listed below, into CPU caches directly > from the NIC. > > - Rx/Tx queue descriptors > - Rx packets > - Packet headers > - packet payloads

Re: [PATCH 1/2] net/bonding: standard the log message

On Wed, 5 Jun 2024 13:55:19 +0800 Chaoyong He wrote: > From: Long Wu > > According to the check rules in the patch check script, > drivers and libraries must use the logging framework. > > So standard the log message of bonding driver by using > the logging framework. > > Signed-off-by: Long

Re: [PATCH v16 4/4] eal: add PMU support to tracing library

On Mon, 18 Nov 2024 08:37:06 +0100 Tomasz Duszynski wrote: > + > + /* events are matched against occurrences of e=ev1[,ev2,..] pattern */ > + ret = regcomp(®, "e=([_[:alnum:]-],?)+", REG_EXTENDED); > + if (ret) { > + PMU_LOG(ERR, "Failed to compile event matching regexp");

Re: [PATCH v16 0/4] add support for self monitoring

On Mon, 18 Nov 2024 08:37:02 +0100 Tomasz Duszynski wrote: > This series adds self monitoring support i.e allows to configure and > read performance measurement unit (PMU) counters in runtime without > using perf utility. This has certain advantages when application runs on > isolated cores runni

Re: [v22,13/13] compress/zsda: add zsda compressdev capabilities

Hi akhil: I noticed that DPDK24.11 has been released and state of the my patches has been changed to "New" from "Defer". And I have some questions about how to proceed with submitting patches. 1. In the last version, I have submitted to v22. If I want to continue submitting, should I subm

RE: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

> On Fri, 11 Oct 2024 11:24:12 +0800 > Chaoyong He wrote: > > > From: Long Wu > > > > The testpmd application can not modify the value of dedicated hardware > > Rx/Tx queue size, and hardcoded them as (128/512). This will cause the > > bonding port start fail if some NIC requires more Rx/Tx desc

Re: [PATCH] lib/lpm: use standard atomic_store_explicit

Hello Andre, On Wed, Dec 4, 2024 at 3:20 AM Andre Muezerie wrote: > > MSVC issues the warning below: > > ../lib/lpm/rte_lpm.c(297): warning C4013 > '__atomic_store' undefined; assuming extern returning int > ../lib/lpm/rte_lpm.c(298): error C2065: > '__ATOMIC_RELAXED': undeclared identifi

[PATCH] lib/lpm: use standard atomic_store_explicit

MSVC issues the warning below: ../lib/lpm/rte_lpm.c(297): warning C4013 '__atomic_store' undefined; assuming extern returning int ../lib/lpm/rte_lpm.c(298): error C2065: '__ATOMIC_RELAXED': undeclared identifier The fix is to use standard atomic_store_explicit() instead of gcc specific __

[PATCH v2] examples/l3fwd: add option to set Tx burst size

The application send packets only when the buffer is full, or the buffer is empty and the packets to be sent extends TX_PKT_BURST. The change of MAX_PKT_BURST make TX buffer size and TX_PKT_BURST increase, while the default cache size is 256. The packets in the TX direction occupy the cache. As a r

[PATCH] cryptodev: not close device when secondary exit

The secordary process should not close the crypto device when it exits because the primary process still manage the device. There is no reason with occurring error log below when secordary process exits without any operation on the crypto device while primary process starts the device. Case situat

[PATCH] lib/fib: remove warning about implicit 64-bit conversion

MSVC issues the warning below: ../lib/fib/trie.c(341): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The fix is to cast the result explicitly to ptrdiff_t since it is used in pointer arithmetic. Signed-off-by: Andre Muezerie --- lib/fi

Re: [PATCH v1] app/testpmd: use Tx preparation in txonly engine

On Wed, 3 Jan 2024 09:29:12 +0800 Kaiwen Deng wrote: > Txonly forwarding engine does not call the Tx preparation API > before transmitting packets. This may cause some problems. > > TSO breaks when MSS spans more than 8 data fragments. Those > packets will be dropped by Tx preparation API, but

Re: [PATCH v16 1/4] lib: add generic support for reading PMU events

On Wed, 4 Dec 2024 00:49:58 +0100 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Tuesday, 3 December 2024 22.39 > > > > On Mon, 18 Nov 2024 08:37:03 +0100 > > Tomasz Duszynski wrote: > > > > > +Performance counter based profiling > > > +---

Re: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

On Fri, 11 Oct 2024 11:24:12 +0800 Chaoyong He wrote: > From: Long Wu > > The testpmd application can not modify the value of > dedicated hardware Rx/Tx queue size, and hardcoded > them as (128/512). This will cause the bonding port > start fail if some NIC requires more Rx/Tx descriptors > tha

fbdev

fbdev is now runnin FreeBSD 14.2. The former version (14.1) is now running on fbdev141. Thanks, lew

RE: [PATCH v16 1/4] lib: add generic support for reading PMU events

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 3 December 2024 22.39 > > On Mon, 18 Nov 2024 08:37:03 +0100 > Tomasz Duszynski wrote: > > > +Performance counter based profiling > > +--- > > + > > +Majority of architectures support s

Re: lib/eal/arm/include/rte_vect.h fails to compile with clang14 for 32bit ARM

After looking at this a bit closer today, I realize that my assertion that CLANG14 does support vcopyq_laneq_u32() for 32bit ARM was incorrect. It does not. The reason that disabling the implementation in rte_vect.h works for our clang builds is that we do not build the l3fwd app nor the ixgbe

rte_mempool_create fails with --no-huge

Hi, I am facing problem with rte_mempool_create when running my app with -no-huge after rte_eal_init succeeds. Note that this app works fine with hugepages but since it's purpose is unit testing certain packet processing logic, it has no requirements to have ports and the Linux may not necessar