On 12/2/2024 5:14 PM, Bruce Richardson wrote:
On Mon, Dec 02, 2024 at 03:09:33PM +0000, Anatoly Burakov wrote:
It has been suggested [1] that a major cleanup/rewrite of devbind would be
beneficial in terms of long term maintainability of the code. I was in a
coding mood over the weekend, and so I've went ahead and rewritten devbind.
Note that this is one giant patch, rather than a series of patches adjusting
existing code. Making it a patch series is possible, however the internal
code architecture diverges quite significantly from the original devbind
script due to its copious usage of string operations/pattern matching and
global variables, so it is unclear whether subdividing this patch would be
worth the effort.
One suggestion here which might help reviewing. Since it is essentially a
rewrite, is it worth making this a two-patch set, where:
Patch 1: introduces a new script called e.g. dpdk-devbind-new.py, which
contains just the rewrite without any of old code. This then can be
reviewed in isolation
Patch 2: moves dpdk-devbind-new.py to overwrite dpdk-devbind.py
WDYT?
Regards,
/Bruce
I think it's a good idea, provided it gets squashed on apply.
--
Thanks,
Anatoly
