Hi Stephen, Yes, You're right. I'm making a new patch for improving in crypto device to solve this issue. And the modification has already worked in our cases. Anyway, I will upload the patch soon and will mark the status of this patch to Superseded. Thanks.
Brs, Yang Ming -----Original Message----- From: Stephen Hemminger <step...@networkplumber.org> Sent: 2024年11月29日 1:16 To: Ming 1. Yang (NSB) <ming.1.y...@nokia-sbell.com> Cc: Anatoly Burakov <anatoly.bura...@intel.com>; Bruce Richardson <bruce.richard...@intel.com>; Kevin Laatz <kevin.la...@intel.com>; Morten Brørup <m...@smartsharesystems.com>; dev@dpdk.org; sta...@dpdk.org Subject: [External] Re: [PATCH] eal: fix bus cleanup in secondary process Caution: This is an external email. Please be very careful when clicking links or opening attachments. See http://nok.it/nsb for additional information. On Thu, 28 Nov 2024 13:48:29 +0800 myang <ming.1.y...@nokia-sbell.com> wrote: > eal_bus_cleanup has been added in rte_eal_cleanup. But for secondary > process, eal_bus_cleanup will trigger vdev_cleanup which trigger > rte_vdev_driver to remove. Then our crypto devices will execute > ipsec_mb_remove to rte_cryptodev_pmd_destroy. > > Finally error logs occur as below: > CRYPTODEV: rte_cryptodev_close() line 1453: Device 0 must be stopped > before closing > EAL: failed to send to (/tmp/dpdk/l2hicu/mp_socket) due to Bad file > descriptor > EAL: Fail to send request /tmp/dpdk/l2hicu/mp_socket:ipsec_mb_mp_msg > USER1: Create MR request to primary process failed. > > Function call trace: rte_eal_cleanup->eal_bus_cleanup-> > vdev_cleanup->rte_vdev_driver->ipsec_mb_remove-> > 1. ipsec_mb_remove->rte_cryptodev_pmd_destroy-> > rte_cryptodev_pmd_release_device->rte_cryptodev_close > 2. ipsec_mb_remove->ipsec_mb_qp_release->ipsec_mb_secondary_qp_op > ->rte_mp_request_async->mp_request_async > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > Cc: sta...@dpdk.org > > Signed-off-by: myang <ming.1.y...@nokia-sbell.com> There is was a reason for calling cleanup on shutdown. It looks like more of a bug in the crypto device not the EAL. Freebsd and Windows also calls eal_bus_cleanup.
