Re: [PATCH v9 02/23] test: replace use of term segregate

2024-11-26 Thread Thomas Monjalon
05/02/2024 18:43, Stephen Hemminger: > Change comment based on inclusive naming recommendations. > > https://inclusivenaming.org/word-lists/tier-3/ > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff Applied individually, there is another (deferred) series for "sanity" word.

Re: [PATCH v2] replace use of word segregate in comments

2024-11-26 Thread Thomas Monjalon
09/10/2024 02:36, fengchengwen: > Acked-by: Chengwen Feng > > On 2024/10/8 23:49, Stephen Hemminger wrote: > > The use of the word segregate should be avoided. > > Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/ > > > > The word segregation carries strong context in reg

Re: [PATCH v9 04/23] test: remove use of word master in test_red

2024-11-26 Thread Thomas Monjalon
05/02/2024 18:43, Stephen Hemminger: > No need to use term master here. > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff Applied individually, there is another (deferred) series for "sanity" word.

Re: [PATCH v2 0/3] bugfix about KEEP CRC offload

2024-11-26 Thread Stephen Hemminger
On Thu, 18 Jul 2024 19:48:02 +0800 Jie Hai wrote: > From: Dengdui Huang > > For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is still be > stripped in rare scenarios. > Some users of hns3 are already using this feature. So driver has to > recaculate packet CRC. > > In addition, i

[RFC] net/hns3: clarify handling of crc reinsert

2024-11-26 Thread Stephen Hemminger
Use a static assert rather than a comment to express why there will be space in the buffer. Use memcpy() rather than rte_memcpy(). Signed-off-by: Stephen Hemminger --- drivers/net/hns3/hns3_rxtx.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/dri

Re: [RFC PATCH 00/21] Reduce code duplication across Intel NIC drivers

2024-11-26 Thread Thomas Monjalon
25/11/2024 17:31, Bruce Richardson: > On Mon, Nov 25, 2024 at 05:25:47PM +0100, David Marchand wrote: > > Hello Bruce, > > > > On Fri, Nov 22, 2024 at 1:54 PM Bruce Richardson > > wrote: > > > > > > This RFC attempts to reduce the amount of code duplication across a > > > number of Intel NIC driv

Re: [PATCH] devtools: download scripts from linux if not found

2024-11-26 Thread Robin Jarry
Thomas Monjalon, Nov 26, 2024 at 15:03: I would prefer we host our own fork of checkpatch.pl. There are too many irrelevant checks that we should drop. How about get_maintainer.pl? Should we host our copy as well?

Re: [PATCH v4 7/9] test/eal: fix core check in c flag test

2024-11-26 Thread Aaron Conole
Stephen Hemminger writes: > The expression for checking which lcore is enabled for 0-7 > was wrong (missing case for 6). > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > Fixes: b0209034f2bb ("test/eal: check number of cores before running > subtests") > Cc: msant...@redhat.com > Cc:

Re: release candidate 24.11-rc3

2024-11-26 Thread Thinh Tran
IBM - Power Systems DPDK v24.11-rc3-1-gf4ccce58c1 * Build CI on Fedora 38,39,40 and 41 container images for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS: RHEL 9.4 kernel: 5.14.0-427.40.1.el9_4.ppc64le with gcc version 11.4.1 20231218 (Red Hat 11.4.1-3) (

[PATCH] fib: rename configuration flag

2024-11-26 Thread Vladimir Medvedkin
Rename RTE_FIB_F_NETWORK_ORDER with RTE_FIB_F_LOOKUP_NETWORK_ORDER to explicitly indicate that it is only used in lookup. Fixes: e194f3cd5685 ("fib: lookup IPv4 address in network order") Signed-off-by: Vladimir Medvedkin --- lib/fib/rte_fib.c | 4 ++-- lib/fib/rte_fib.h | 4 ++-- 2 files chang

[PATCH] dts: remove leftover Node methods

2024-11-26 Thread Luca Vizzarro
The "remove redundant test suite" removed an unused test suite and some dead code with it. Some dead code which references now-removed symbols, remained though. This removes this code, therefore fixing the related mypy errors. Fixes: e3ab9dd5cd5d ("dts: remove redundant test suite") Signed-off-by

Re: [PATCH v4 0/8] Record and rework component dependencies

2024-11-26 Thread Burakov, Anatoly
On 11/26/2024 3:39 PM, Anatoly Burakov wrote: As part of the meson build, we can record the dependencies for each component as we process it, logging them to a file. This file can be used as input to a number of other scripts and tools, for example, to graph the dependencies, or to allow higher-l

[PATCH] dts: remove html dir from dts doc path

2024-11-26 Thread Paul Szczepanek
To facilitate deploying docs to the website and make paths more consistent remove the html directory from the dts doc path. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- buildtools/call-sphinx-build.py | 5 +++-- doc/api/meson.build | 2 +- 2 files changed, 4 inserti

Re: [PATCH] fib: rename configuration flag

2024-11-26 Thread Thomas Monjalon
26/11/2024 18:18, Vladimir Medvedkin: > Rename RTE_FIB_F_NETWORK_ORDER with RTE_FIB_F_LOOKUP_NETWORK_ORDER to > explicitly indicate that it is only used in lookup. > > Fixes: e194f3cd5685 ("fib: lookup IPv4 address in network order") > > Signed-off-by: Vladimir Medvedkin Applied, thanks.

Re: [PATCH] test: raise fast test timeout to 60s on RISC-V

2024-11-26 Thread David Marchand
On Sat, Nov 23, 2024 at 4:00 PM Eric Long wrote: > > Current RISC-V hardware (e.g. HiFive Unmatched) is still way too slow > compared to other architectures' counterparts. On the most powerful > RISC-V CPU available (SG2042), DPDK still fails with 4 timeouts: > > ``` > Summary of Failures: > > 23/

Re: [PATCH v2] ci: run more checks in private repositories

2024-11-26 Thread David Marchand
On Tue, Jul 9, 2024 at 3:17 PM Robin Jarry wrote: > > From: David Marchand > > Though devtools/checkpatches.sh is run as part of our CI, some other > (not well known) checks could help when run in private repositories > before submitting to the mailing list and even when run from the > ovsrobot.

Re: [PATCH v6 4/4] usertools/dpdk-devbind: print NUMA node

2024-11-26 Thread David Marchand
On Sat, Oct 12, 2024 at 7:58 PM Stephen Hemminger wrote: > On Thu, 22 Aug 2024 11:38:26 +0100 > Anatoly Burakov wrote: > > > Currently, devbind does not print out any NUMA information, which makes > > figuring out which NUMA node device belongs to not trivial. Add printouts > > for NUMA informati

Re: [PATCH] dts: remove leftover Node methods

2024-11-26 Thread Patrick Robb
This looks good, and I can confirm dts-check-format.sh is passing with this patch. Reviewed-by: Patrick Robb Tested-by: Patrick Robb On Tue, Nov 26, 2024 at 10:09 AM Luca Vizzarro wrote: > The "remove redundant test suite" removed an unused test suite and some > dead code with it. Some dead cod

Re: [PATCH] dts: remove leftover Node methods

2024-11-26 Thread Patrick Robb
Applied to next-dts, thanks. On Tue, Nov 26, 2024 at 10:09 AM Luca Vizzarro wrote: > The "remove redundant test suite" removed an unused test suite and some > dead code with it. Some dead code which references now-removed symbols, > remained though. This removes this code, therefore fixing the r

Re: [PATCH v4 0/9] Bug fixes for standalone tests

2024-11-26 Thread Thomas Monjalon
21/11/2024 19:23, Stephen Hemminger: > Recent blog post from PVS studio referenced lots bugs found by > their analyzer against DPDK. This set addresses the ones in > the test suite. > > v4 - rebase and drop code that was already fixed (removed) > > Stephen Hemminger (9): > app/test: do not dupl

Re: [PATCH] test/cfgfile: add check for file removal

2024-11-26 Thread Thomas Monjalon
20/11/2024 17:50, Stephen Hemminger: > The test makes temporary files for parsing and then cleans up. > It was not checking the return value from the remove step > which makes Coverity unhappy. > > Coverity ID: 451207 > Coverity ID: 451209 > Coverity ID: 451212 > Coverity ID: 451213 > Coverity ID:

Re: [PATCH v2 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2024 at 03:02:38PM +, Anatoly Burakov wrote: > Currently, when binding a device to VFIO, the UID/GID for the device will > always stay as system default (`root`). Yet, when running DPDK as non-root > user, one has to change the UID/GID of the device to match the user's > UID/GID

Re: [PATCH v1] net/i40e: updated latest recommended matching list

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 10:45:53AM +0800, hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/i40e.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > index ca6caa0cff..35585efc44 100644 > --- a/doc/guides/nics/i4

Re: [RFC PATCH 00/21] Reduce code duplication across Intel NIC drivers

2024-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2024 at 03:57:42PM +0100, Thomas Monjalon wrote: > 25/11/2024 17:31, Bruce Richardson: > > On Mon, Nov 25, 2024 at 05:25:47PM +0100, David Marchand wrote: > > > Hello Bruce, > > > > > > On Fri, Nov 22, 2024 at 1:54 PM Bruce Richardson > > > wrote: > > > > > > > > This RFC attempts

Re: [PATCH v1] net/ice: updated latest recommended matching list

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 10:52:20AM +0800, hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/ice.rst | 4 > 1 file changed, 4 insertions(+) > Applied to dpdk-next-net-intel. Thanks, /Bruce

Re: [PATCH v2 1/3] net/ixgbe: initialize PTP to system time

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 11:33:24AM +, Anatoly Burakov wrote: > Currently, ixgbe driver initializes PTP timestamp to 0. This is different > from what kernel driver does (which initializes it to system time). > > Align the DPDK driver to kernel driver by setting PTP timestamp to system > time wh

Re: [PATCH v2 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-26 Thread Robin Jarry
Hi Anatoly, Anatoly Burakov, Nov 26, 2024 at 16:02: Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non-root user, one has to change the UID/GID of the device to match the user's UID/GID to use the device

Re: [PATCH] devtools: download scripts from linux if not found

2024-11-26 Thread Thomas Monjalon
04/10/2024 18:31, Stephen Hemminger: > On Fri, 15 Mar 2024 15:14:42 +0100 > Robin Jarry wrote: > > > Both checkpatches.sh and get-maintainer.sh require scripts that come > > from the linux sources. And they require DPDK_*_PATH variables to be set > > to point at these scripts locally. For new con

[PATCH v2 0/1] Add Visual Studio Code configuration script

2024-11-26 Thread Anatoly Burakov
Lots of developers (myself included) uses Visual Studio Code as their primary IDE for DPDK development. I have been successfully using various incarnations of this script internally to quickly set up my development trees whenever I need a new configuration, so this script is being shared in hopes t

[PATCH v2 1/1] devtools: add DPDK build directory setup script

2024-11-26 Thread Anatoly Burakov
Currently, the only way to set up a build directory for DPDK development is through running Meson directly. This has a number of drawbacks. For one, the default configuration is very "fat", meaning everything gets enabled and built (aside from examples, which have to be enabled manually), so while

[PATCH v2 0/1] Add DPDK build directory configuration script

2024-11-26 Thread Anatoly Burakov
Note: this patch depends upon Bruce's v4 patchset: https://patches.dpdk.org/project/dpdk/list/?series=34036 This patch is based on initial script for VSCode configuration: https://patches.dpdk.org/project/dpdk/patch/6a6b20c037cffcc5f68a341c4b4e4f21990ae991.1721997016.git.anatoly.bura...@intel.co

Re: [PATCH] ci: remove workaround for ASan in Ubuntu GHA images

2024-11-26 Thread David Marchand
On Thu, Nov 7, 2024 at 2:15 PM David Marchand wrote: > > This workaround is directly applied inside Ubuntu GHA images themselves. > > Link: > https://github.com/actions/runner-images/commit/9485052d98ba055be3355565e23630de8f8c4ef8 > Signed-off-by: David Marchand Applied, thanks. -- David Mar

[PATCH v4 1/8] build: split dependencies into mandatory and optional

2024-11-26 Thread Anatoly Burakov
Allow specifying dependencies as either mandatory or optional. This does not change anything about the build, but it is useful for tooling to know if a dependency is required or not. Signed-off-by: Anatoly Burakov --- app/meson.build | 3 ++- app/proc-info/meson.build

[PATCH v4 2/8] build: output a dependency log in build directory

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson As meson processes our DPDK source tree it manages dependencies specified by each individual driver. To enable future analysis of the dependency links between components, log the dependencies of each DPDK component as it gets processed. This could potentially allow other to

[PATCH v4 0/8] Record and rework component dependencies

2024-11-26 Thread Anatoly Burakov
As part of the meson build, we can record the dependencies for each component as we process it, logging them to a file. This file can be used as input to a number of other scripts and tools, for example, to graph the dependencies, or to allow higher-level build-config tools to automatically enable

[PATCH v4 5/8] build: reduce library dependencies

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson Rather than having each library depend up on EAL + any extra libs, we can take advantage of recursive dependency support in meson and just assign the dependencies of each directory directly, rather than appending to the array. For libraries which only depend upon EAL, keep

[PATCH v4 3/8] devtools: add script to flag unneeded dependencies

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson While not a serious problem, DPDK components often list more dependencies than are actually necessary to build, due to the use of recursive dependencies. In extreme cases, such as with core libraries, this can lead to longer configuration times due to meson having to dedupl

[PATCH v4 6/8] build: reduce driver dependencies

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson Remove any unnecessary dependencies from the driver dependency lists. This will give each driver a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson --- drivers/baseband/fpga_5gnr_fec/meson.build | 2 +- drivers/baseband/fpga_lte_fec/meson.build

[PATCH v4 7/8] build: reduce app dependencies

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson Remove any unnecessary dependencies from the app dependency lists. This will give each app a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson --- app/dumpcap/meson.build | 2 +- app/graph/meson.build| 2 +- app/pdump/meson.b

[PATCH v4 8/8] devtools: add script to generate DPDK dependency graphs

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson Rather than the single monolithic graph that would be output from the deps.dot file in a build directory, we can post-process that to generate simpler graphs for different tasks. This new "draw_dependency_graphs" script takes the "deps.dot" as input and generates an output

[PATCH v4 4/8] build: remove kvargs from driver class dependencies

2024-11-26 Thread Anatoly Burakov
From: Bruce Richardson The kvargs library is used by EAL, and therefore is implicitly a dependency of every DPDK driver. Remove it from the minimum set of dependencies for each driver class as it's unnecessary to call it out there. Signed-off-by: Bruce Richardson --- drivers/event/meson.build

Re: [PATCH v1] net/i40e: updated latest recommended matching list

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 10:45:53AM +0800, hailinx wrote: > Signed-off-by: hailinx > --- > doc/guides/nics/i40e.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst > index ca6caa0cff..35585efc44 100644 > --- a/doc/guides/nics/i4

Re: [PATCH] devtools: download scripts from linux if not found

2024-11-26 Thread Robin Jarry
Thomas Monjalon, Nov 26, 2024 at 16:36: The central question is to know how to get those GPL2 scripts accepted in DPDK. These are scripts, not linked to any DPDK related binary. So I think it is OK in terms of license contamination. We MUST preserve the original license headers in these impor

Re: [PATCH] net/ixgbe: add support for new device

2024-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2024 at 09:04:52AM +, Xu, HailinX wrote: > > -Original Message- > > From: Zhichao Zeng > > Sent: Tuesday, November 26, 2024 11:16 AM > > To: dev@dpdk.org > > Cc: Zeng, ZhichaoX ; Burakov, Anatoly > > ; Medvedkin, Vladimir > > > > Subject: [PATCH] net/ixgbe: add support

[PATCH v2 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-26 Thread Anatoly Burakov
Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non-root user, one has to change the UID/GID of the device to match the user's UID/GID to use the device. This patch adds an option to `dpdk-devbind.py` to ch

Re: [PATCH v1 1/1] net/ixgbe: fix PTP initialization for E610

2024-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2024 at 08:32:09AM +, Xu, HailinX wrote: > > -Original Message- > > From: Anatoly Burakov > > Sent: Friday, November 22, 2024 11:17 PM > > To: dev@dpdk.org; Medvedkin, Vladimir ; > > Kwapulinski, Piotr ; Carolyn Wyborny > > ; Jagielski, Jedrzej > > > > Subject: [PATCH

Re: [PATCH] devtools: download scripts from linux if not found

2024-11-26 Thread Thomas Monjalon
26/11/2024 16:16, Robin Jarry: > Thomas Monjalon, Nov 26, 2024 at 15:03: > > I would prefer we host our own fork of checkpatch.pl. > > There are too many irrelevant checks that we should drop. > > How about get_maintainer.pl? Should we host our copy as well? It may makes sense. The central quest

Re: [PATCH] net/ixgbe: fix RSS redirection table configuration for E610

2024-11-26 Thread Bruce Richardson
On Tue, Nov 26, 2024 at 08:50:47AM +, Xu, HailinX wrote: > > -Original Message- > > From: Yuan Wang > > Sent: Monday, November 25, 2024 5:36 PM > > To: Burakov, Anatoly ; Medvedkin, Vladimir > > > > Cc: dev@dpdk.org; Wang, YuanX > > Subject: [PATCH] net/ixgbe: fix RSS redirection tab

Re: [PATCH v2 1/3] net/ixgbe: initialize PTP to system time

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 11:33:24AM +, Anatoly Burakov wrote: > Currently, ixgbe driver initializes PTP timestamp to 0. This is different > from what kernel driver does (which initializes it to system time). > > Align the DPDK driver to kernel driver by setting PTP timestamp to system > time wh

Re: [PATCH v2 2/3] net/i40e: initialize PTP to system time

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 11:33:25AM +, Anatoly Burakov wrote: > Currently, i40e driver initializes PTP timestamp to 0. This is different > from what kernel driver does (which initializes it to system time). > > Align the DPDK driver to kernel driver by setting PTP timestamp to system > time whe

Re: [PATCH v2 3/3] net/e1000: initialize PTP to system time

2024-11-26 Thread Bruce Richardson
On Mon, Nov 25, 2024 at 11:33:26AM +, Anatoly Burakov wrote: > Currently, e1000 driver initializes PTP timestamp to 0. This is different > from what kernel driver does (which initializes it to system time). > > Align the DPDK driver to kernel driver by setting PTP timestamp to system > time wh

Re: [PATCH] pcapng: avoid potential unaligned data

2024-11-26 Thread Thomas Monjalon
21/11/2024 00:06, Stephen Hemminger: > The buffer used to construct headers (which contain 32 bit values) > was declared as uint8_t which can lead to unaligned access. > Change to declare buffer as uint32_t. > > Signed-off-by: Stephen Hemminger Fixes: dc2d6d20047e ("pcapng: avoid using alloca")

RE: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-26 Thread Gowrishankar Muthukrishnan
Hi, I wanted to follow up on my previous message regarding the development of a vhost vDPA host driver for crypto/virtio. We have proposed creating a driver/common/virtio/ directory to hold common implementations for both net and crypto functionalities. This approach aims to help in fixing commo

Re: [PATCH v3 1/3] ethdev: add description for KEEP CRC offload

2024-11-26 Thread Stephen Hemminger
On Tue, 26 Nov 2024 15:47:32 +0800 Jie Hai wrote: > Hi, Stephen Hemminger > > Thanks for your review. > I will add doc and fix on drivers in the next version. > The test will be done later. > > On 2024/11/23 1:10, Stephen Hemminger wrote: > > On Fri, 19 Jul 2024 17:04:13 +0800 > > Jie Hai wrot

[PATCH v6 25/30] lib/eal: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 10/30] drivers/crypto: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 13/30] drivers/mempool: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 19/30] examples/ip-pipeline: remove packed attributes

2024-11-26 Thread Andre Muezerie
Removed packed attributes from structs that are naturally packed already, or don't require packing. Signed-off-by: Andre Muezerie --- examples/ip_pipeline/cli.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c

[PATCH v6 15/30] drivers/raw: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 12/30] drivers/event: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 05/30] doc/guides: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 18/30] examples/common: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 22/30] examples/l3fwd: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 24/30] examples/vhost_blk: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 17/30] drivers/vdpa: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

release candidate 24.11-rc4

2024-11-26 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v24.11-rc4 There are 47 new patches in this snapshot, mostly fixes and doc. Release notes: https://doc.dpdk.org/guides/rel_notes/release_24_11.html As usual, you can report any issue on https://b

[PATCH v6 00/30] fix packing of structs when building with MSVC

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Provide a macro (__rte_packed_begin) that can be used to push existing pack value and sets packing to 1-byte. The existing __rte_packed macro is replaced with __rte_packed_end and restores the pack value prior to the push. Instead of providing macros

[PATCH v6 03/30] app/test-pmd: remove unnecessary packed attributes

2024-11-26 Thread Andre Muezerie
Removed __rte_packed attribute from structure that is naturally packed already. Signed-off-by: Andre Muezerie --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 2246c22e8e..d77a140641 100644 ---

[PATCH v6 02/30] eal/include: add new packing macros

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Add macro __rte_packed_begin which can be used to push existing pack value and set packing to 1-byte. Add macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler w

[PATCH v6 07/30] drivers/bus: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 08/30] drivers/common: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 04/30] app/test: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 06/30] drivers/baseband: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 09/30] drivers/compress: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 01/30] devtools: check packed attributes

2024-11-26 Thread Andre Muezerie
Ensure __rte_packed_begin and __rte_packed_end show up in pairs when checking patches. Signed-off-by: Andre Muezerie --- devtools/checkpatches.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 4a8591be22..d30

[PATCH v6 11/30] drivers/dma: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 30/30] lib/eal: remove __rte_packed

2024-11-26 Thread Andre Muezerie
Remove macro __rte_packed now that the code was made portable using __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push when MSVC is used. Signed-off-by: Andre Muezerie --- lib/eal/include/rte_common.h |

[PATCH v6 28/30] lib/pipeline: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 21/30] examples/l3fwd-power: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 29/30] lib/vhost: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 26/30] lib/ipsec: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 20/30] examples/ipsec_secgw: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 23/30] examples/ptpclient: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

[PATCH v6 16/30] drivers/regex: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

Re: [PATCH v3 3/3] net/hns3: fix Rx packet without CRC data

2024-11-26 Thread Jie Hai
On 2024/11/27 8:16, Stephen Hemminger wrote: On Fri, 19 Jul 2024 17:04:15 +0800 Jie Hai wrote: From: Dengdui Huang When KEEP_CRC offload is enabled, the CRC data is still stripped in following cases: 1. For HIP08 network engine, the packet type is TCP and the length is less than or equal

RE: [PATCH v4 6/8] build: reduce driver dependencies

2024-11-26 Thread Xu, Rosen
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, November 26, 2024 10:40 PM > To: dev@dpdk.org; Chautru, Nicolas ; > Gagandeep Singh ; Hemant Agrawal > ; Parav Pandit ; Xueming Li > ; Sachin Saxena ; Xu, > Rosen ; Chenbo Xia ; Nipun > Gupta ; Tomasz Duszynski > ; Chengwe

[PATCH V1] doc: add tested Intel platforms with Intel NICs

2024-11-26 Thread Lingli Chen
Add tested Intel platforms with Intel NICs to v24.11 release note. Signed-off-by: Lingli Chen --- doc/guides/rel_notes/release_24_11.rst | 165 + 1 file changed, 165 insertions(+) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.r

Re: [PATCH] doc: correct definition of Stats per queue feature

2024-11-26 Thread Thomas Monjalon
11/10/2024 21:25, Ferruh Yigit: > On 10/11/2024 2:38 AM, Stephen Hemminger wrote: > > Change the documentation to match current usage of this feature > > in the NIC table. Moved this sub heading to be after basic > > stats because the queue stats reported now are in the same structure. > > > > Alt

Re: [PATCH v2] doc: add mlx5 xstats send scheduling counters description

2024-11-26 Thread Stephen Hemminger
On Thu, 31 Oct 2024 10:04:38 +0200 Viacheslav Ovsiienko wrote: > The mlx5 provides the scheduling send on time capability. > To check the operating status of this feature the extended statistics > counters are provided. This patch adds the counter descriptions > and provides some meaningful infor

Re: [PATCH] test: raise fast test timeout to 60s on RISC-V

2024-11-26 Thread Eric Long
On 27/11/2024 04:29, David Marchand wrote: You can extend the timeout via the multiplier option (default timeout of 10s * multiplier). So in your case: $ meson test -C --suite fast-tests -t 6 I hope the RISC-V specific extended timeout could be upstreamed though, in this way we won't need to

[PATCH] examples/ptpclient: revert add frequency adjustment

2024-11-26 Thread Mingjin Ye
This commit references GPL-licensed code and therefore cannot be applied to the DPDK. Therefore the following commit was reverted accordingly. Fixes: 6d55af611fd5 ("examples/ptpclient: add frequency adjustment") By resuming this commit, the basic functionality (PMD support for high-precision clo

Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-26 Thread Chenbo Xia
Hi Gowrishankar, > On Nov 27, 2024, at 14:50, Gowrishankar Muthukrishnan > wrote: > > External email: Use caution opening links or attachments > > > Hi, > I wanted to follow up on my previous message regarding the development of a > vhost vDPA host driver for crypto/virtio. We have proposed

[PATCH v4] vhost/user: clear ring addresses when getting vring base

2024-11-26 Thread Jianping Zhao
Clear ring addresses during vring base retrieval to handle guest reboot scenarios correctly. This is particularly important for vdpa-blk devices where the following issue occurs: When a guest OS with vdpa-blk device reboots, during UEFI stage, only one vring is actually used and configured. Howeve

[PATCH v6 27/30] lib/net: replace packed attributes

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compile

Re: [PATCH v3 3/3] net/hns3: fix Rx packet without CRC data

2024-11-26 Thread Stephen Hemminger
On Fri, 19 Jul 2024 17:04:15 +0800 Jie Hai wrote: > From: Dengdui Huang > > When KEEP_CRC offload is enabled, the CRC data is still stripped > in following cases: > 1. For HIP08 network engine, the packet type is TCP and the length >is less than or equal to 60B. > 2. For HIP09 network engin

Re: [PATCH] dts: remove html dir from dts doc path

2024-11-26 Thread Thomas Monjalon
26/11/2024 17:25, Paul Szczepanek: > To facilitate deploying docs to the website > and make paths more consistent remove the html > directory from the dts doc path. > > Signed-off-by: Paul Szczepanek > Reviewed-by: Luca Vizzarro > --- > # run sphinx, putting the html output in a "html" director

Re: [PATCH 3/3] eventdev: fix uninitialized variable

2024-11-26 Thread Liao, TingtingX
> -Original Message- > From: Ma, WenwuX > Sent: 25 November 2024 14:47 > To: ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > amitpraka...@marvell.com; Gujjar, Abhinandan S; dev@dpdk.org;sta...@dpdk.org > Cc: Liao, TingtingX; Ma, WenwuX > Subject: [PATCH 3/3] eventdev: fix uninit

Re: [PATCH] net/mlx5: fix Rx queue control deref

2024-11-26 Thread Raslan Darawsheh
Hi, From: Bing Zhao Sent: Monday, November 25, 2024 7:23 PM To: Dariusz Sosnowski; Slava Ovsiienko; dev@dpdk.org; Raslan Darawsheh Cc: Ori Kam; Suanming Mou; Matan Azrad; sta...@dpdk.org Subject: [PATCH] net/mlx5: fix Rx queue control deref When the Rx queue is shared, only the control structure

Re: [PATCH v2] doc: update match with compare result item limitation

2024-11-26 Thread Raslan Darawsheh
Hi, From: Suanming Mou Sent: Wednesday, November 6, 2024 11:34 AM To: Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Matan Azrad Cc: dev@dpdk.org; sta...@dpdk.org Subject: [PATCH v2] doc: update match with compare result item limitation In switch mode, when ``repr_matching_en`` flag is

Re: [PATCH] vhost: fix read vs write lock mismatch

2024-11-26 Thread Maxime Coquelin
On 11/18/24 17:24, Stephen Hemminger wrote: If lock is acquired for write, it must be released for write or a deadlock is likely. Bugzilla ID: 1582 Fixes: 9fc93a1e2320 ("vhost: fix virtqueue access check in datapath") Cc: david.march...@redhat.com Cc: sta...@dpdk.org Signed-off-by: Stephen H

  1   2   >