The application send packets only when the buffer is full, or the
buffer is empty and the number of packets to be sent extends half
of the buffer.
The change of MAX_PKT_BURST increases TX buffer size, while the
default size of local cache on each lcore is 256, which not greater
than the limit of t
> The application send packets only when the buffer is full, or the
> buffer is empty and the number of packets to be sent extends half
> of the buffer.
>
> The change of MAX_PKT_BURST increases TX buffer size, while the
> default size of local cache on each lcore is 256, which not greater
> th
LGTM, good job.
Acked-by: Huisong Li
在 2024/11/22 15:13, Jie Hai 写道:
The application send packets only when the buffer is full, or the
buffer is empty and the number of packets to be sent extends half
of the buffer.
The change of MAX_PKT_BURST increases TX buffer size, while the
default size o
> The code was duplicating the same condition three times?
> Reading the commit message, the intention was:
>
>Add unit tests to verify the zero len TLS records. Zero len packets are
>allowed when content type is app data while zero packet length with
>other content type (such as handsh
On Thu, Nov 21, 2024 at 10:23:23AM -0800, Stephen Hemminger wrote:
> The first argument of 'memcmp' function was equal to the second argument.
> Therefore ASSERT would always be true.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: decla
On 11/17/24 18:32, Stephen Hemminger wrote:
The file vduse.h does not have a license that is compatiable
with current DPDK license policy.
This reverts commit 9fec3f0569087de0129c7f2badaf5be2776e.
Signed-off-by: Stephen Hemminger
---
kernel/linux/uapi/linux/vduse.h | 353 -
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> Sent: Friday, 22 November 2024 01.12
>
> On Thu, Nov 21, 2024 at 09:51:36PM +0100, Thomas Monjalon wrote:
> > 21/11/2024 20:39, Andre Muezerie:
> > > On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote:
> > > > > From: Andre
> -Original Message-
> From: Fengchengwen
> Sent: Friday, November 22, 2024 1:33 AM
> To: Andre Muezerie ; dev@dpdk.org
> Cc: Konstantin Ananyev
> Subject: Re: [PATCH v12 04/21] ethdev: remove use of VLAs for Windows built
> code
>
> On 2024/11/22 5:41, Andre Muezerie wrote:
> > From:
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
This patchset replaces strtok with strtok_r in app, example
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
This patch adds check in checkpatches.sh for strtok, which
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
L2fwd examples fails to be compiled because it includes
rte_os_shim.h file but cannot find it. The missing file
is not installed, install it. See [1] for more details.
[1] https://mails.dpdk.org/archives/test-report/2024-November/822571.html
Signed-off-by: Jie Hai
---
lib/eal/linux/include/meso
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it w
On 20-11-2024 08:42, Nandini Persad wrote:
This is a new document covering security protocols
implemented in DPDK.
Signed-off-by: Nandini Persad
Signed-off-by: Thomas Monjalon
Reviewed-by: Stephen Hemminger
---
doc/guides/index.rst | 1 +
doc/guides/security/index.rst | 336 ++
Remove the custom vector Tx backlog entry function and use the standard
"ieth" one, now that all vector drivers are using the same, smaller ring
structure.
Signed-off-by: Bruce Richardson
---
drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 10 --
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c |
The AVX-512 code path used a smaller SW ring structure only containing
the mbuf pointer, but no other fields. The other fields are only used in
the scalar code path, so update all vector driver code paths (AVX2, SSE)
to use the smaller, faster structure.
Signed-off-by: Bruce Richardson
---
drive
The AVX-512 code path used a smaller SW ring structure only containing
the mbuf pointer, but no other fields. The other fields are only used in
the scalar code path, so update all vector driver code paths to use the
smaller, faster structure.
Signed-off-by: Bruce Richardson
---
drivers/common/in
Adjust iavf driver to also use the common mbuf freeing functions on Tx
queue release/cleanup. The implementation is complicated a little by the
need to integrate the additional "has_ctx" parameter for the iavf code,
but changes in other drivers are minimal - just a constant "false"
parameter.
Sign
The AVX-512 code path used a smaller SW ring structure only containing
the mbuf pointer, but no other fields. The other fields are only used in
the scalar code path, so update all vector driver code paths (AVX2, SSE,
Neon, Altivec) to use the smaller, faster structure.
Signed-off-by: Bruce Richard
The code for reassembling a single, multi-mbuf packet from multiple
buffers received from the NIC is duplicated across many drivers. Rather
than having multiple copies of this function, we can create an
"intel_eth" common driver to hold such functions and consolidate
multiple functions down to a si
The Tx entry structures, both vector and scalar, are common across Intel
drivers, so provide a single definition to be used everywhere.
Signed-off-by: Bruce Richardson
---
drivers/common/intel_eth/ieth_rxtx.h | 29 +++
.../net/i40e/i40e_recycle_mbufs_vec_common.c | 2 +
This RFC attempts to reduce the amount of code duplication across a
number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice.
The first patch extract a function from the Rx side, otherwise the
majority of the changes are on the Tx side, leading to a converged Tx
queue structure across
Move the short function used to place mbufs on the SW Tx ring to common
code to avoid duplication.
Signed-off-by: Bruce Richardson
---
drivers/common/intel_eth/ieth_rxtx_vec_common.h | 7 +++
drivers/net/i40e/i40e_rxtx_vec_altivec.c| 4 ++--
drivers/net/i40e/i40e_rxtx_vec_avx2.c
Currently, e1000 driver initializes PTP timestamp to 0. This is different
from what kernel driver does (which initializes it to system time).
Align the DPDK driver to kernel driver by setting PTP timestamp to system
time when enabling PTP.
Note that e1000 driver always uses zero-based timestamps
Currently, ixgbe driver initializes PTP timestamp to 0. This is different
from what kernel driver does (which initializes it to system time).
Align the DPDK driver to kernel driver by setting PTP timestamp to system
time when enabling PTP.
Note that ixgbe driver always uses zero-based timestamps
On Fri, 19 Jul 2024 17:04:13 +0800
Jie Hai wrote:
> From: Dengdui Huang
>
> The data exceeds the pkt_len in mbuf is inavailable for user.
> When KEEP CRC offload is enabled, CRC field length should be
> included in the pkt_len in mbuf. However, almost of drivers
> supported KEEP CRC feature did
On Tue, 5 Nov 2024 08:41:38 +
liwencheng wrote:
> add Phytium NIC MACB ethdev PMD driver.
>
> Signed-off-by: liwencheng
> ---
Several things need to be addressed before this driver can be merged.
For better review, it is preferred that drivers be broken into smaller
chunks when submitting
Current codepath does not have case labels for E610 when initializing PTP.
Add them in relevant places.
Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
Signed-off-by: Anatoly Burakov
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/
On Tue, 5 Nov 2024 08:41:38 +
liwencheng wrote:
> +
> +int genphy_read_status(struct phy_device *phydev)
> +{
> + struct macb *bp = phydev->bp;
> + uint16_t bmcr, bmsr, ctrl1000 = 0, stat1000 = 0;
> + uint32_t advertising, lp_advertising;
> + uint32_t nego;
> + uint16_t p
Add missed error messages to the list to avoid incorrect logs.
Change order base initializers to index base initializers.
Add static assertions to control the completeness of the list of messages.
Fixes: 11ea97805ba1 ("net/ntnic: add minimal flow inline profile")
Signed-off-by: Serhii Iliushyk
-
Toeplitz secret key word order was reversed during programming into
FPGA, which lead to unexpected rss hash values.
Fixes: 7fa0bf29e667 ("net/ntnic: add hash module")
Signed-off-by: Serhii Iliushyk
---
.../profile_inline/flow_api_profile_inline.c | 61 +++
1 file changed, 21 in
On 2024/11/22 18:08, Konstantin Ananyev wrote:
>
>
>> -Original Message-
>> From: Fengchengwen
>> Sent: Friday, November 22, 2024 1:33 AM
>> To: Andre Muezerie ; dev@dpdk.org
>> Cc: Konstantin Ananyev
>> Subject: Re: [PATCH v12 04/21] ethdev: remove use of VLAs for Windows built
>> cod
This patch set provides further fixes:
Feature RSS:
Fix the Toeplitz key and log with a mask.
Toeplitz's secret keyword order was reversed during programming into
FPGA, which leads to unexpected RSS hash values.
Error handling:
The missed error messages were added to the list to avoid inc
Currently, i40e driver initializes PTP timestamp to 0. This is different
from what kernel driver does (which initializes it to system time).
Align the DPDK driver to kernel driver by setting PTP timestamp to system
time when enabling PTP.
Note that i40e driver always uses zero-based timestamps fo
17/11/2024 16:04, Vladimir Medvedkin:
> So, feel free to submit patches adding this feature to the control plane API,
Before discussing more changes, please let's fix the API description in
24.11-rc4:
RTE_FIB_F_NETWORK_ORDER should be renamed RTE_FIB_F_LOOKUP_NETWORK_ORDER
so it matches what it d
Toeplitz secret key word order was reversed during programming into
FPGA, which lead to unexpected rss hash values.
Fixes: 7fa0bf29e667 ("net/ntnic: add hash module")
Signed-off-by: Serhii Iliushyk
---
.../profile_inline/flow_api_profile_inline.c | 61 +++
1 file changed, 21 in
Add missed error messages to the list to avoid incorrect logs
Fixes: 11ea97805ba1 ("net/ntnic: add minimal flow inline profile")
Signed-off-by: Serhii Iliushyk
---
drivers/net/ntnic/nthw/flow_api/flow_api.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ntnic/nt
This patch set provides further fixes:
Feature RSS:
Fix the Toeplitz key and log with a mask.
Toeplitz's secret keyword order was reversed during programming into
FPGA, which leads to unexpected RSS hash values.
Error handling:
The missed error messages were added to the list to avoid inc
Hi Bharati,
Welcome to the DTS mailing list. I will try to provide some answers based
on my experience running DTS at the DPDK Community Lab at UNH. I will also
flag that this "legacy" version of DTS is deprecated and getting minimal
maintenance. The majority of the current efforts for DTS are dir
In preparation for merging the Tx structs for multiple drivers into a
single struct, rename the driver-specific pointers in each struct to
have a prefix on it, to avoid conflicts.
Signed-off-by: Bruce Richardson
---
drivers/net/i40e/i40e_fdir.c | 6 +--
.../net/i40e/i40e_recycl
The queue structures fo i40e and ice drivers are virtually identical, so
merge them into a common struct. This should allow easier function
merging in future using that common struct.
Signed-off-by: Bruce Richardson
---
drivers/common/intel_eth/ieth_rxtx.h | 54 +
driver
Across the various Intel drivers sometimes different names are given to
fields in the Tx queue structure which have the same function. Do some
renaming to align things better for future merging.
Signed-off-by: Bruce Richardson
---
drivers/net/i40e/i40e_rxtx.c| 6 +--
drivers/net/i40
Merge in the few additional fields used by iavf driver and convert it to
using the common Tx queue structure also.
Signed-off-by: Bruce Richardson
---
drivers/common/intel_eth/ieth_rxtx.h| 16 +++-
drivers/net/iavf/iavf.h | 2 +-
drivers/net/iavf/iavf_ethdev.c |
On Fri, 22 Nov 2024 17:50:21 +0100
Serhii Iliushyk wrote:
> diff --git a/drivers/net/ntnic/nthw/flow_api/flow_api.c
> b/drivers/net/ntnic/nthw/flow_api/flow_api.c
> index d4993eb58a..fd470ddd35 100644
> --- a/drivers/net/ntnic/nthw/flow_api/flow_api.c
> +++ b/drivers/net/ntnic/nthw/flow_api/flow
On Fri, 19 Jul 2024 17:04:13 +0800
Jie Hai wrote:
> From: Dengdui Huang
>
> The data exceeds the pkt_len in mbuf is inavailable for user.
unavailable
> When KEEP CRC offload is enabled, CRC field length should be
> included in the pkt_len in mbuf. Howe
Vladimir Medvedkin, Nov 17, 2024 at 16:04:
[Robin]
I had not understood that it was *only* the lookups that were network
order
[Morten]
When I saw the byte order flag the first time, it was not clear to me
either that it only affected lookups - I too thought it covered the
entire API of the
Switch the iavf driver to use the common Tx free function. This requires
one additional parameter to that function, since iavf sometimes uses
context descriptors which means that we have double the descriptors per
SW ring slot.
Signed-off-by: Bruce Richardson
---
.../common/intel_eth/ieth_rxtx_v
Update driver to be similar to the "ice" driver and use the common mbuf
ring cleanup code on shutdown of a Tx queue.
Signed-off-by: Bruce Richardson
---
drivers/net/i40e/i40e_ethdev.h | 4 +-
drivers/net/i40e/i40e_rxtx.c | 71 --
drivers/net/i40e/i40e_rxtx.h
Update driver to use the common cleanup function.
Signed-off-by: Bruce Richardson
---
drivers/net/ixgbe/ixgbe_rxtx.c| 22 +++---
drivers/net/ixgbe/ixgbe_rxtx.h| 1 -
drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 28 ++-
drivers/net/ixgbe/ixg
The functions to loop over the Tx queue and clean up all the mbufs on
it, e.g. for queue shutdown, is not device specific and so can move into
the common/intel_eth driver. Only complication is ensuring that the
correct ring format, either minimal vector or full structure, is used.
Ice driver curren
Merge in additional fields used by the ixgbe driver and then convert it
over to using the common Tx queue structure.
Signed-off-by: Bruce Richardson
---
drivers/common/intel_eth/ieth_rxtx.h | 14 +++-
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +-
.../ixgbe/ixgbe_recycle_mbufs_v
The actions taken for post-Tx buffer free for the SSE and AVX drivers
for i40e, iavf and ice drivers are all common, so centralize those in
common/intel_eth driver.
Signed-off-by: Bruce Richardson
---
.../common/intel_eth/ieth_rxtx_vec_common.h | 72 +++
drivers/net/i40e/i40e_r
AVX-512 code paths for ice and i40e drivers are common, and differ from
the regular post-Tx free function in that the SW ring from which the
buffers are freed does not contain anything other than the mbuf pointer.
Merge these into a common function in common/intel_eth saving
duplication.
Signed-of
Rather than having a two element array of context cache values inside
the Tx queue structure, convert it to a pointer to a cache at the end of
the structure. This makes future merging of the structure easier as we
don't need the "ixgbe_advctx_info" struct defined when defining a
combined queue stru
Move some fields about to better pack the Tx queue structure and make
sure all data used by the vector codepaths is on the first cacheline of
the structure. Checking with "pahole" on 64-bit build, only one 6-byte
hole is left in the structure - on second cacheline - after this patch.
As part of th
76 matches
Mail list logo
