> The code was duplicating the same condition three times? > Reading the commit message, the intention was: > > Add unit tests to verify the zero len TLS records. Zero len packets are > allowed when content type is app data while zero packet length with > other content type (such as handshake) would result in an error. > > Link: > https://urldefense.proofpoint.com/v2/url?u=https-3A__pvs-2Dstudio.com_en_blog_posts_cpp_1179_&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyLWs2n6B- > WYLn1v9SyTMrT5EQqh2TU&m=XameIFsYmmvHMhJycVwGxFucfJNVntjVlTBXIykV7kmsF4i5OLtyrXHT9KSTJnkm&s=JaPpRUXDxqq1KFX_JG2CQI0viz-YZG33I8zoO25Fr6k&e= > > Fixes: 79a58624369a ("test/security: verify zero length TLS records") > Cc: mailto:vvelum...@marvell.com > Cc: mailto:sta...@dpdk.org > > Signed-off-by: Stephen Hemminger <mailto:step...@networkplumber.org>
Good catch. Looks like remnants after a rename exercise. Originally it was intended as separate for TLS 1.2, DTLS 1.2 & TLS 1.3. Acked-by: Anoob Joseph <ano...@marvell.com>