On Tue, 5 Nov 2024 08:41:38 +0000 liwencheng <liwench...@phytium.com.cn> wrote:
> add Phytium NIC MACB ethdev PMD driver. > > Signed-off-by: liwencheng <liwench...@phytium.com.cn> > --- Several things need to be addressed before this driver can be merged. For better review, it is preferred that drivers be broken into smaller chunks when submitting. https://doc.dpdk.org/guides/contributing/new_driver.html 1. Missing documentation all new drivers need to have documentation in doc/guides/nics to describe hardware and features. 2. Missing license tag. These files are missing required SPDX license tags: drivers/net/macb/base/generic_phy.h drivers/net/macb/base/macb_errno.h drivers/net/macb/base/macb_hw.h 3. Missing mailmap entry 4. Missing update to MAINTAINERS 5. Build fails with lastest GCC Warnings found: [1307/3230] Compiling C object drivers/libtmp_rte_net_macb.a.p/net_macb_macb_ethdev.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/macb_ethdev.h:10, from ../drivers/net/macb/macb_rxtx.h:8, from ../drivers/net/macb/macb_ethdev.c:11: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ [1326/3230] Compiling C object drivers/libtmp_rte_net_macb.a.p/net_macb_macb_rxtx.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/macb_ethdev.h:10, from ../drivers/net/macb/macb_rxtx.h:8, from ../drivers/net/macb/macb_rxtx.c:24: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ [2338/3230] Compiling C object drivers/net/macb/base/libmacb_base.a.p/generic_phy.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/base/generic_phy.h:4, from ../drivers/net/macb/base/generic_phy.c:5: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ [2343/3230] Compiling C object drivers/net/macb/base/libmacb_base.a.p/macb_uio.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/base/macb_uio.h:4, from ../drivers/net/macb/base/macb_uio.c:6: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ [2352/3230] Compiling C object drivers/net/macb/base/libmacb_base.a.p/macb_common.c.o In file included from ../drivers/net/macb/base/macb_common.h:36, from ../drivers/net/macb/base/macb_uio.h:4, from ../drivers/net/macb/base/macb_common.c:7: ../drivers/net/macb/base/macb_hw.h:1063:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1063:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1063 | GEM_STAT_TITLE(TX1519CNT, "tx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1088:35: warning: initializer-string for array of ‘char’ is too long [-Wunterminated-string-initialization] 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/macb/base/macb_hw.h:1043:24: note: in definition of macro ‘GEM_STAT_TITLE_BITS’ 1043 | .stat_string = title, \ | ^~~~~ ../drivers/net/macb/base/macb_hw.h:1088:9: note: in expansion of macro ‘GEM_STAT_TITLE’ 1088 | GEM_STAT_TITLE(RX1519CNT, "rx_greater_than_1518_byte_frames"),
