[PATCH v6 4/7] random: keep PRNG state in lcore variable

2024-09-18 Thread Mattias Rönnblom
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the same state in a more cache-friendly lcore variable. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev -- RFC v3: * Remo

[PATCH v6 5/7] power: keep per-lcore state in lcore variable

2024-09-18 Thread Mattias Rönnblom
Replace static array of cache-aligned structs with an lcore variable, to slightly benefit code simplicity and performance. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev -- PATCH v6: * Update FOREACH invocation to match new API. RFC v3: * Replace for l

[PATCH v6 2/7] eal: add lcore variable functional tests

2024-09-18 Thread Mattias Rönnblom
Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup -- PATCH v6: * Update FOREACH invocations to match new API. RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macros. RFC v4: * Check all lcore id's values for all var

[PATCH v6 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-09-18 Thread Mattias Rönnblom
Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/x86/rte_power_intrinsics.c | 17 +++

[PATCH v6 0/7] Lcore variables

2024-09-18 Thread Mattias Rönnblom
This patch set introduces a new API for static per-lcore id data allocation. Please refer to the API documentation for both a rationale for this new API, and a comparison to the alternatives available. The adoption of this API would affect many different DPDK modules, but the author updated onl

[PATCH v6 1/7] eal: add static per-lcore memory allocation facility

2024-09-18 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l

[PATCH v6 3/7] eal: add lcore variable performance test

2024-09-18 Thread Mattias Rönnblom
Add basic micro benchmark for lcore variables, in an attempt to assure that the overhead isn't significantly greater than alternative approaches, in scenarios where the benefits aren't expected to show up (i.e., when plenty of cache is available compared to the working set size of the per-lcore dat

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-09-18 Thread Juraj Linkeš
On 3. 9. 2024 21:49, Dean Marx wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: The scatter Rx offload capability is needed for the pmd_buffer_scatter test suite. The command that retrieves the capability is: show port rx_offload capabilities The command also re

Re: [PATCH v23 04/15] eal: make eal_log_level_parse common

2024-09-18 Thread Stephen Hemminger
On Wed, 18 Sep 2024 15:18:04 +0800 fengchengwen wrote: > > +/* Parse the all arguments looking for log related ones */ > > +int > > +eal_log_level_parse(int argc, char * const argv[]) > > +{ > > + struct internal_config *internal_conf = > > eal_get_internal_configuration(); > > + int option_

Re: [DPDK/core Bug 1547] Build fails on FreeBSD 14.0

2024-09-18 Thread Stephen Hemminger
On Wed, 18 Sep 2024 09:31:19 +0100 Bruce Richardson wrote: > On Wed, Sep 18, 2024 at 01:51:18AM +, bugzi...@dpdk.org wrote: > >[1]Stephen Hemminger changed [2]bug 1547 > > > > What Removed Added > >Status UNCONFIRMED RESOLVED > >Resolution --- INVALID >

[PATCH v9 6/6] eal: extend bitops to handle volatile pointers

2024-09-18 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

[PATCH v9 0/6] Improve EAL bit operations API

2024-09-18 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

[PATCH v9 4/6] eal: add atomic bit operations

2024-09-18 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

Re: [PATCH] test/event: fix incorrect target event queue

2024-09-18 Thread Jerin Jacob
On Thu, Aug 22, 2024 at 1:31 PM Amit Prakash Shukla wrote: > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Thursday, August 22, 2024 2:08 AM > > To: Jerin Jacob ; Amit Prakash Shukla > > > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > > > Subject: [PATCH] tes

Re: [PATCH v3 02/19] net/xsc: add log macro

2024-09-18 Thread David Marchand
On Wed, Sep 18, 2024 at 8:10 AM WanRenyong wrote: > > Add log macro to print runtime messages and trace functions. > > Signed-off-by: WanRenyong > > --- > > v3: > * use RTE_LOG_LINE_PREFIX instead of rte_log > --- > drivers/net/xsc/xsc_ethdev.c | 11 + > drivers/net/xsc/xsc_log.h| 46

[RFC v1 1/1] dmadev: support priority configuration

2024-09-18 Thread Vamsi Krishna
From: Vamsi Attunuru Some DMA controllers offer the ability to configure priority level for the hardware command queues, allowing for the prioritization of DMA command execution based on queue importance. This patch introduces the necessary fields in the dmadev structures to retrieve information

[PATCH] eal: add build-time option to omit trace

2024-09-18 Thread Morten Brørup
Some applications want to omit the trace feature. Either to reduce the memory footprint, to reduce the exposed attack surface, or for other reasons. This patch adds an option in rte_config.h to include or omit trace in the build. Trace is included by default. Omitting trace works by omitting all

Re: [PATCH v3 3/7] eal: add lcore variable performance test

2024-09-18 Thread Jerin Jacob
On Mon, Sep 16, 2024 at 4:20 PM Mattias Rönnblom wrote: > > On 2024-09-13 13:23, Jerin Jacob wrote: > > On Fri, Sep 13, 2024 at 12:17 PM Mattias Rönnblom > > wrote: > >> > >> On 2024-09-12 17:11, Jerin Jacob wrote: > >>> On Thu, Sep 12, 2024 at 6:50 PM Mattias Rönnblom > >>> wrote: > > >>

Re: [PATCH v6 1/6] dpdk: do not force C linkage on include file dependencies

2024-09-18 Thread Mattias Rönnblom
On 2024-09-18 13:15, David Marchand wrote: On Tue, Sep 17, 2024 at 11:30 AM Mattias Rönnblom wrote: On 2024-09-16 14:05, David Marchand wrote: Hello, On Tue, Sep 10, 2024 at 10:41 AM Mattias Rönnblom wrote: diff --git a/lib/acl/rte_acl_osdep.h b/lib/acl/rte_acl_osdep.h index 3c1dc402ca..e4

[PATCH v2] ethdev: optimize the activation of fast-path tracepoints

2024-09-18 Thread Adel Belkhiri
From: Adel Belkhiri Split the tracepoints rte_ethdev_trace_rx_burst and rte_eth_trace_call_rx_callbacks into two separate ones for empty and non-empty calls to avoid saturating quickly the trace buffer. Signed-off-by: Adel Belkhiri --- .mailmap | 1 + doc/guides/

[PATCH v4 1/1] dts: add text parser for testpmd verbose output

2024-09-18 Thread jspewock
From: Jeremy Spewock Multiple test suites from the old DTS framework rely on being able to consume and interpret the verbose output of testpmd. The new framework doesn't have an elegant way for handling the verbose output, but test suites are starting to be written that rely on it. This patch cre

[PATCH v4 0/1] dts: testpmd verbose parser

2024-09-18 Thread jspewock
From: Jeremy Spewock v4: * adjust name of OLFlags class to be PacketOffloadFlags * change values in PacketOffloadFlags to match the ones in rte_mbuf_core.h * added documentation from rte_mbuf_core.h to flag values * added documentation from rte_mbuf_ptype.h to the RtePTypes class

[PATCH v15] dts: VLAN test suite implementation

2024-09-18 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Depends-on: Patch-143966 ("dts: add VLAN methods to testpmd shell") Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestS

[PATCH v24 05/15] eal: do not duplicate rte_init_alert() messages

2024-09-18 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v24 06/15] eal: change rte_exit() output to match rte_log()

2024-09-18 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v24 03/15] windows: add os shim for localtime_r

2024-09-18 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 file changed, 10 insertions

[PATCH v24 04/15] eal: make eal_log_level_parse common

2024-09-18 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

[PATCH v24 00/15] Logging enhancements for 24.11

2024-09-18 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[PATCH v24 02/15] windows: make getopt functions have const properties

2024-09-18 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v24 01/15] maintainers: add for log library

2024-09-18 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v24 14/15] log: colorize log output

2024-09-18 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Ack

[PATCH v24 07/15] log: move handling of syslog facility out of eal

2024-09-18 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_option

[PATCH v24 08/15] eal: initialize log before everything else

2024-09-18 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v24 09/15] log: drop syslog support, and make code common

2024-09-18 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_option

[PATCH v24 12/15] log: add optional support of syslog

2024-09-18 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_eal_

[PATCH v24 10/15] log: add hook for printing log messages

2024-09-18 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 f

[PATCH v24 13/15] log: add support for systemd journal

2024-09-18 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v15 0/1] dts: port over VLAN test suite

2024-09-18 Thread Dean Marx
Port over VLAN capabilities test suite from old DTS. This test suite verifies that VLAN filtering, stripping, and header insertion all function as expected. When a VLAN ID is in the filter list, all packets with that ID should be forwarded and all others should be dropped. While stripping is enable

[PATCH v24 11/15] log: add timestamp option

2024-09-18 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v24 15/15] doc: add release note about log library

2024-09-18 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 27 ++ 1 file changed, 27 insertions(+) diff --git a/doc/guides/rel_n

Re: [PATCH v23 11/15] log: add timestamp option

2024-09-18 Thread fengchengwen
On 2024/9/18 23:05, Stephen Hemminger wrote: > On Wed, 18 Sep 2024 15:37:49 +0800 > fengchengwen wrote: > >> ... >> >>> + >>> +static enum { >>> + LOG_TIMESTAMP_NONE = 0, >>> + LOG_TIMESTAMP_TIME, /* time since start */ >>> + LOG_TIMESTAMP_DELTA,/* time since last message */ >>> +

Re: [PATCH v23 06/15] eal: change rte_exit() output to match rte_log()

2024-09-18 Thread fengchengwen
On 2024/9/18 12:56, Stephen Hemminger wrote: > The rte_exit() output format confuses the timestamp and coloring > options. Change it to use be a single line with proper prefix. > > Before: > [ 0.006481] EAL: Error - exiting with code: 1 > Cause: [ 0.006489] Cannot init EAL: Permission de

Re: [PATCH v23 10/15] log: add hook for printing log messages

2024-09-18 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/18 12:56, Stephen Hemminger wrote: > This is useful for when decorating log output for console > or journal. Provide basic version in this patch. > > Signed-off-by: Stephen Hemminger > Acked-by: Morten Brørup

Re: [PATCH v19 0/5] DTS API docs generation

2024-09-18 Thread Juraj Linkeš
On 21. 8. 2024 17:02, Juraj Linkeš wrote: The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetr

Re: [PATCH v23 11/15] log: add timestamp option

2024-09-18 Thread fengchengwen
On 2024/9/18 12:56, Stephen Hemminger wrote: > When debugging driver or startup issues, it is useful to have > a timestamp on each message printed. The messages in syslog > already have a timestamp, but often syslog is not available > during testing. > > There are multiple timestamp formats simila

Re: [PATCH v23 12/15] log: add optional support of syslog

2024-09-18 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/18 12:56, Stephen Hemminger wrote: > Log to syslog only if option is specified. And if syslog is used > then normally only log to syslog, don't duplicate output. > Also enables syslog support on FreeBSD. > > Signed-off-by: Stephen Hemminger > Acked-by: Morten B

Re: [PATCH v23 14/15] log: colorize log output

2024-09-18 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/18 12:56, Stephen Hemminger wrote: > Like dmesg, colorize the log output (unless redirected to file). > Timestamp is green, the subsystem is in yellow and the message > is red if urgent, boldface if an error, and normal for info and > debug messages. > > Signed-

Re: [PATCH v23 15/15] doc: add release note about log library

2024-09-18 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/18 12:56, Stephen Hemminger wrote: > Significant enough to add some documentation. > > Signed-off-by: Stephen Hemminger > Acked-by: Morten Brørup > --- > doc/guides/rel_notes/release_24_11.rst | 15 +++ > 1 file changed, 15 insertions(+) > > diff

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Juraj Linkeš
On 17. 9. 2024 17:22, Patrick Robb wrote: Dean actually just came down with an illness. Since the changes in his series are minimal (I see the only ones left are updating dts.rst and the devcontainer json) I think that one of us at UNH should submit a patch which is essentially a v2 of his ser

Re: [PATCH v4 1/7] eal: add static per-lcore memory allocation facility

2024-09-18 Thread Mattias Rönnblom
On 2024-09-17 18:29, Konstantin Ananyev wrote: +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE) + +static void *lcore_buffer; +static size_t offset = RTE_MAX_LCORE_VAR; + +static void * +lcore_var_alloc(size_t size, size_t align) +{ + void *handle; + void *value; + +

RE: 21.11.8 patches review and test

2024-09-18 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Thursday, September 5, 2024 3:38 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Kevin > Traynor ; Luca

[v2 00/43] DPAA2 specific patches

2024-09-18 Thread vanshika . shukla
From: Vanshika Shukla This series includes: -> Fixes and enhancements for NXP DPAA2 drivers. -> Upgrade with MC version 10.37 -> Enhancements in DPDMUX code -> Fixes for coverity issues reported V2 changes: Fixed the broken compilation for clang in: "net/dpaa2: dpdmux single flow/multipl

Re: [PATCH v3 03/19] net/xsc: add PCI device probe and remove

2024-09-18 Thread WanRenyong
On 2024/9/18 15:28, David Marchand wrote: > On Wed, Sep 18, 2024 at 8:10 AM WanRenyong wrote: >> +static const struct rte_pci_id xsc_ethdev_pci_id_map[] = { >> + { RTE_PCI_DEVICE(XSC_PCI_VENDOR_ID, XSC_PCI_DEV_ID_MS) }, > You need to null terminate this array with something like: >

[v2 02/43] net/dpaa2: support PTP packet one-step timestamp

2024-09-18 Thread vanshika . shukla
From: Vanshika Shukla This patch adds PTP one-step timestamping support. dpni_set_single_step_cfg() MC API is utilized with offset provided to insert correction time on frame. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c | 61 +++ drivers/net

[v2 05/43] bus/fslmc: change dpcon close as internal symbol

2024-09-18 Thread vanshika . shukla
From: Hemant Agrawal This patch marks dpcon_close API as internal symbol and also adds it into version map file Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/mc/fsl_dpcon.h | 3 ++- drivers/bus/fslmc/version.map| 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/driv

[v2 06/43] bus/fslmc: add close API to close DPAA2 device

2024-09-18 Thread vanshika . shukla
From: Rohit Raj Add rte_fslmc_close API to close all the DPAA2 devices while closing the DPDK application. Signed-off-by: Rohit Raj --- drivers/bus/fslmc/bus_fslmc_driver.h | 3 + drivers/bus/fslmc/fslmc_bus.c| 13 drivers/bus/fslmc/fslmc_vfio.c | 87 +++

[v2 01/43] net/dpaa2: enhance Tx scatter-gather mempool

2024-09-18 Thread vanshika . shukla
From: Jun Yang Create TX SG pool only for primary process and lookup this pool in secondary process. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 46 +++- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethde

[v2 07/43] net/dpaa2: dpdmux: add support for CVLAN

2024-09-18 Thread vanshika . shukla
From: Vanshika Shukla This patch adds the support for DPDMUX_METHOD_C_VLAN_MAC method which implements DPDMUX based on C-VLAN and MAC address. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_mux.c | 59 +-- drivers/net/dpaa2/mc/fsl_dpdmux.h | 18 +

[v2 04/43] net/dpaa2: add support to dump dpdmux counters

2024-09-18 Thread vanshika . shukla
From: Hemant Agrawal This patch add supports to dump dpdmux counters as they are required to identify the reasons for packet drop in dpdmux. Signed-off-by: Hemant Agrawal Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_mux.c | 84 +++ drivers/net/dpaa2/rte

[v2 03/43] net/dpaa2: add proper MTU debugging print

2024-09-18 Thread vanshika . shukla
From: Apeksha Gupta This patch add proper debug info for check information of max-pkt-len and configured params. also store MTU Signed-off-by: Apeksha Gupta Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/d

[v2 08/43] bus/fslmc: upgrade with MC version 10.37

2024-09-18 Thread vanshika . shukla
From: Gagandeep Singh This patch upgrades the MC version compaitbility to 10.37 Signed-off-by: Gagandeep Singh Signed-off-by: Apeksha Gupta --- doc/guides/platform/dpaa2.rst | 4 +- drivers/bus/fslmc/mc/dpio.c | 94 - drivers/bus/fslmc/mc/fsl_dpcon.h

[v2 10/43] net/dpaa2: update DPNI link status method

2024-09-18 Thread vanshika . shukla
From: Brick Yang If SFP module is not connected to the port and flow control is configured using flow control API, link will show DOWN even after connecting the SFP module and fiber cable. This issue cannot be reproduced if only SFP module is connected and fiber cable is disconnected before conf

[v2 11/43] net/dpaa2: add new PMD API to check dpaa platform version

2024-09-18 Thread vanshika . shukla
From: Jun Yang This patch add support to check the DPAA platform type from the applications. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 16 +--- drivers/net/dpaa2/dpaa2_flow.c| 5 ++--- drivers/net/dpaa2/rte_pmd_dpaa2.h | 4 drivers/net/dpaa2/version

[v2 12/43] bus/fslmc: improve BMAN buffer acquire

2024-09-18 Thread vanshika . shukla
From: Jun Yang Ignore reserved bits of BMan acquire response number. Signed-off-by: Jun Yang --- drivers/bus/fslmc/qbman/qbman_portal.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/q

[v2 09/43] net/dpaa2: support link state for eth interfaces

2024-09-18 Thread vanshika . shukla
From: Rohit Raj This patch add support to update the duplex value along with link status and link speed after setting the link UP. Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_ethdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/dpaa

[v2 16/43] bus/fslmc: dynamic IOVA mode configuration

2024-09-18 Thread vanshika . shukla
From: Jun Yang IOVA mode should not be configured with CFLAGS because 1) User can perform "--iova-mode" to configure IOVA. 2) IOVA mode is determined by negotiation between multiple devices. Eal is in VA mode only when all devices support VA mode. Hence: 1) Remove RTE_LIBRTE_DPAA2_USE_PHYS_IO

[v2 19/43] bus/fslmc: fix coverity issue

2024-09-18 Thread vanshika . shukla
From: Rohit Raj Fix Issues reported by coverity (NXP Internal Coverity) Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_debug.c | 49 +-- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_debug.c b/drivers/bus/fslm

[v2 14/43] bus/fslmc: enhance MC VFIO multiprocess support

2024-09-18 Thread vanshika . shukla
From: Jun Yang MC VFIO is not registered into RTE VFIO. Primary process registers MC vfio mp action for secondary process to request. VFIO/Container handlers are provided via CMSG. Primary process is responsible to connect MC VFIO group to container. In addition, MC VFIO code is refactored accor

[v2 13/43] bus/fslmc: get MC VFIO group FD directly

2024-09-18 Thread vanshika . shukla
From: Jun Yang Get vfio group fd directly from file system instead of from RTE API to avoid conflicting with PCIe VFIO. FSL MC VFIO should have it's own logic which doe NOT depend on RTE VFIO. Signed-off-by: Jun Yang --- drivers/bus/fslmc/fslmc_vfio.c | 88 ++ d

[v2 18/43] bus/fslmc: create dpaa2 device with it's object

2024-09-18 Thread vanshika . shukla
From: Jun Yang Create dpaa2 device with object instead of object ID. Assign each dpaa2 object with it's container. Signed-off-by: Jun Yang --- drivers/bus/fslmc/bus_fslmc_driver.h | 39 drivers/bus/fslmc/fslmc_vfio.c | 3 +- drivers/bus/fslmc/portal/dpaa

[v2 17/43] bus/fslmc: remove VFIO IRQ mapping

2024-09-18 Thread vanshika . shukla
From: Jun Yang Remove unused GITS translator VFIO mapping. Signed-off-by: Jun Yang --- drivers/bus/fslmc/fslmc_vfio.c | 50 -- 1 file changed, 50 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index fe18429f42..733423f

[v2 15/43] bus/fslmc: free VFIO group FD in case of add group failure

2024-09-18 Thread vanshika . shukla
From: Rohit Raj Free vfio_group_fd if add group fails to avoid ersource leak NXP coverity-id: 26661846 Signed-off-by: Rohit Raj --- drivers/bus/fslmc/fslmc_vfio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_v

[v2 27/43] net/dpaa2: frame attribute flags parser

2024-09-18 Thread vanshika . shukla
From: Jun Yang FAF parser extracts are used to identify protocol type instead of extracts of previous protocol' type. FAF starts from offset 2 to include user defined flags which will be used for soft protocol distribution. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 475 +

[v2 25/43] net/dpaa2: dump Rx parser result

2024-09-18 Thread vanshika . shukla
From: Jun Yang export DPAA2_PRINT_RX_PARSER_RESULT=1 is used to dump RX parser result and frame attribute flags generated by hardware parser and soft parser. The parser results are converted to big endian described in RM. The areas set by soft parser are dump as well. Signed-off-by: Jun Yang --

[v2 22/43] bus/fslmc: introduce VFIO DMA mapping API for fslmc

2024-09-18 Thread vanshika . shukla
From: Jun Yang Declare rte_fslmc_vfio_mem_dmamap and rte_fslmc_vfio_mem_dmaunmap in bus_fslmc_driver.h for external usage. Signed-off-by: Jun Yang --- drivers/bus/fslmc/bus_fslmc_driver.h | 7 ++- drivers/bus/fslmc/fslmc_bus.c| 2 +- drivers/bus/fslmc/fslmc_vfio.c

[v2 20/43] bus/fslmc: fix invalid error FD code

2024-09-18 Thread vanshika . shukla
From: Rohit Raj Since error code was being set to 0 in case of error which is a valid fd, it caused memory leak issue. This issue have been fixed by changing zero to a valid non fd error. CID: 26661848 Signed-off-by: Rohit Raj --- drivers/bus/fslmc/fslmc_vfio.c | 19 ++- 1 file

[v2 23/43] net/dpaa2: change miss flow ID macro name

2024-09-18 Thread vanshika . shukla
From: Rohit Raj Remove miss flow id macro name to DPNI_FS_MISS_DROP since its conflicting with enum. Also, set default miss flow id to 0. Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_flow.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2

[v2 31/43] net/dpaa2: add GTP flow support

2024-09-18 Thread vanshika . shukla
From: Jun Yang Configure gtp flow to support RSS and FS. Check FAF of parser result to identify GTP frame. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 170 ++--- 1 file changed, 137 insertions(+), 33 deletions(-) diff --git a/drivers/net/dpaa2/dpaa

[v2 26/43] net/dpaa2: enhancement of raw flow extract

2024-09-18 Thread vanshika . shukla
From: Jun Yang Support combination of RAW extract and header extracts. RAW extract can start from any absolute offset. TBD: relative offset support. To support relative offset of previous L3 protocol item, extracts should be expanded to identify if the frame is: vlan or none-vlan. To support re

[v2 29/43] net/dpaa2: protocol inside tunnel distribution

2024-09-18 Thread vanshika . shukla
From: Jun Yang Control flow by protocols inside tunnel. The tunnel flow items applied by application are in order from outer to inner. The inner items start from tunnel item, something like vxlan, GRE etc. For example: flow create 0 ingress pattern ipv4 / vxlan / ipv6 / end actions pf /

[v2 28/43] net/dpaa2: add VXLAN distribution support

2024-09-18 Thread vanshika . shukla
From: Jun Yang Extracts from vxlan header for distribution. The vxlan header is set by soft parser code in soft parser context located from offset 43 of parser results: vxlan protocol is identified by vxlan bit of frame attribute flags. The parser result extracts are added for this functionali

[v2 30/43] net/dpaa2: eCPRI support by parser result

2024-09-18 Thread vanshika . shukla
From: Jun Yang Soft parser extracts ECPRI header and message to specified areas of parser result. Flow is classified according to the ECPRI extracts from praser result. This implementation supports ECPRI over ethernet/vlan/UDP and various types/messages combinations. Signed-off-by: Jun Yang ---

[v2 32/43] net/dpaa2: check if Soft parser is loaded

2024-09-18 Thread vanshika . shukla
From: Jun Yang Access sp instruction area to check if sp is loaded. Signed-off-by: Jun Yang Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++ drivers/net/dpaa2/dpaa2_ethdev.h | 2 + drivers/net/dpaa2/dpaa2_flow.c | 88 3 files cha

[v2 21/43] bus/fslmc: change qbman eq desc from d to desc

2024-09-18 Thread vanshika . shukla
From: Rohit Raj Change qbman_eq_desc name to avoid redefining same variable. Signed-off-by: Rohit Raj --- drivers/bus/fslmc/qbman/qbman_portal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_porta

[v2 37/43] net/dpaa2: check IOVA before sending MC command

2024-09-18 Thread vanshika . shukla
From: Jun Yang Convert VA to IOVA and check IOVA before sending parameter to MC. Invalid IOVA of parameter sent to MC will cause system stuck and not be recovered unless power reset. IOVA is not checked in data path because: 1) MC is not involved and error can be recovered. 2) IOVA check impacts

[v2 34/43] net/dpaa2: add flow support for IPsec AH and ESP

2024-09-18 Thread vanshika . shukla
From: Jun Yang Support AH/ESP flow with SPI field. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 528 - 1 file changed, 385 insertions(+), 143 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c index 7207547

[v2 39/43] net/dpaa2: store drop priority in mbuf

2024-09-18 Thread vanshika . shukla
From: Apeksha Gupta store drop priority in mbuf from fd. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 1 + drivers/net/dpaa2/dpaa2_rxtx.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw

[v2 35/43] net/dpaa2: fix memory corruption in TM

2024-09-18 Thread vanshika . shukla
From: Gagandeep Singh driver was reserving memory in an array for 8 queues only, but it can support many more queues configuration. This patch fixes the memory corruption issue by defining the queue array with correct size. Fixes: 72100f0dee21 ("net/dpaa2: support level 2 in traffic management"

[v2 33/43] net/dpaa2: soft parser flow verification

2024-09-18 Thread vanshika . shukla
From: Jun Yang Add flow supported by soft parser to verification list. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_flow.c | 86 -- 1 file changed, 52 insertions(+), 34 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_fl

[v2 38/43] net/dpaa2: improve DPDMUX error behavior settings

2024-09-18 Thread vanshika . shukla
From: Sachin Saxena compatible with MC v10.36 or later Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_mux.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index 4390be9789..3c9e155b23 10064

[v2 36/43] net/dpaa2: support software taildrop

2024-09-18 Thread vanshika . shukla
From: Gagandeep Singh Add software based taildrop support. Signed-off-by: Gagandeep Singh --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +- drivers/net/dpaa2/dpaa2_rxtx.c | 24 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/bus/fslm

[v2 43/43] net/dpaa2: dpdmux single flow/multiple rules support

2024-09-18 Thread vanshika . shukla
From: Jun Yang Support multiple extractions as well as hardware descriptions instead of hard code. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.h | 1 + drivers/net/dpaa2/dpaa2_flow.c | 22 -- drivers/net/dpaa2/dpaa2_mux.c| 395 --- dr

[v2 42/43] net/dpaa2: add support for C-VLAN and MAC

2024-09-18 Thread vanshika . shukla
From: Vanshika Shukla This patch adds the support for DPDMUX_METHOD_C_VLAN_MAC method which implements DPDMUX based on C-VLAN and MAC address. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_mux.c | 2 +- drivers/net/dpaa2/mc/fsl_dpdmux.h | 16 2 files changed,

[v2 41/43] net/dpaa2: support VLAN traffic splitting

2024-09-18 Thread vanshika . shukla
From: Vanshika Shukla This patch adds support for adding rules in DPDMUX to split VLAN traffic based on VLAN ids. Signed-off-by: Vanshika Shukla --- drivers/net/dpaa2/dpaa2_mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/n

[v2 40/43] net/dpaa2: add API to get endpoint name

2024-09-18 Thread vanshika . shukla
From: Jun Yang Export API in rte_pmd_dpaa2.h Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 24 drivers/net/dpaa2/dpaa2_ethdev.h | 4 drivers/net/dpaa2/rte_pmd_dpaa2.h | 3 +++ drivers/net/dpaa2/version.map | 1 + 4 files changed, 32 inser

<    1   2