Re: 23.11.2 patches review and test

2024-08-28 Thread YangHang Liu
RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M hugepage size) : PASS - VM with device assignment(VF) throughput test

Re: [PATCH] net/ice: support for more flexible loading of DDP package

2024-08-28 Thread Bruce Richardson
On Wed, Aug 28, 2024 at 11:53:35AM +0800, Zhichao Zeng wrote: > The "Dynamic Device Personalization" package is loaded at initialization > time by the driver, but the specific package file loaded depends upon > what package file is found first by searching through a hard-coded list > of firmware pa

Re: 23.11.2 patches review and test

2024-08-28 Thread Xueming Li
Hi YangHang, Thanks for the verification and feedback! Best Regards, Xueming From: YangHang Liu Sent: Wednesday, August 28, 2024 3:23 PM To: Xueming Li Cc: sta...@dpdk.org ; dev@dpdk.org ; Abhishek Marathe ; Ali Alnubani ; David Christensen ; Hemant Agrawal ;

RE: [PATCH] net/mana: support building the driver on arm64

2024-08-28 Thread Long Li
> I released this mail from the moderation queue, so the patch could make it to > patchwork. > > > The sender is lon...@linuxonhyperv.com, the author is > lon...@microsoft.com. I hope that is okay. > > The @linuxonhyperv.com address one is not registered to the dev ml, which is > the reason why

Re: [RFC 0/2] introduce LLC aware functions

2024-08-28 Thread Burakov, Anatoly
On 8/27/2024 5:10 PM, Vipin Varghese wrote: As core density continues to increase, chiplet-based core packing has become a key trend. In AMD SoC EPYC architectures, core complexes within the same chiplet share a Last-Level Cache (LLC). By packing logical cores within the same LLC, we can enhance

RE: [PATCH] net/ice: support for more flexible loading of DDP package

2024-08-28 Thread Zeng, ZhichaoX
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, August 28, 2024 3:55 PM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/ice: support for more flexible loading of DDP package > > On Wed, Aug 28, 2024 at 11:53:35AM +0800, Zhichao Zeng wrote: > > The

RE: Bihash Support in DPDK

2024-08-28 Thread Medvedkin, Vladimir
Hi Rajesh, rte_hash does not support per bucket locks, instead it uses global rwlock. But you can try lock free mode (see documentation, in particular RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF flag) From: rajesh goel Sent: Tuesday, August 27, 2024 4:57 PM To: Medvedkin, Vladimir Cc: Ferruh Yigit

Re: [RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite

2024-08-28 Thread Alex Chapman
Hi, Ive been looking into the MTU terminology and would just like to clarify some naming conventions and doc strings. On 7/26/24 15:13, Nicholas Pratte wrote: +IP_HEADER_LEN = 20 +ETHER_STANDARD_FRAME = 1500 +ETHER_JUMBO_FRAME_MTU = 9000 For these constants, I am confused why one is "FRAME"

[PATCH] bus/pci: don't open uio device in secondary process

2024-08-28 Thread Konrad Sztyber
The uio_pci_generic driver clears the bus master bit when the device file is closed. So, when the secondary process terminates after probing a device, that device becomes unusable in the primary process. To avoid that, the device file is now opened only in the primary process. The commit that in

Re: [PATCH v3 02/12] net/ice: updates for ptp init in E825C

2024-08-28 Thread Bruce Richardson
On Fri, Aug 23, 2024 at 09:56:40AM +, Soumyadeep Hore wrote: > From: Norbert Zulinski > > The implementation was done incorrectly assuming > the TS PLL parameters would be similar to E822/E823 > devices. Fix it by using proper values. > > Define access to SB (sideband) for second PHY and > C

Re: Bihash Support in DPDK

2024-08-28 Thread rajesh goel
Thanks Vladimir for the confirmation. Is there any plan to support bucket level lock support in dpdk hash. Thanks Rajesh On Wed, Aug 28, 2024 at 2:33 PM Medvedkin, Vladimir < vladimir.medved...@intel.com> wrote: > Hi Rajesh, > > > > rte_hash does not support per bucket locks, instead it uses glo

[PATCH dpdk] graph: make graphviz export more readable

2024-08-28 Thread Robin Jarry
Change the color of arrows leading to sink nodes to dark orange. Remove the node oval shape around the sink nodes and make their text dark orange. This results in a much more readable output for large graphs. See the link below for an example. Link: https://f.jarry.cc/rte-graph-dot/ipv6.svg Signed

Re: [PATCH v3 04/12] net/ice: avoid reading past end of PFA

2024-08-28 Thread Bruce Richardson
On Fri, Aug 23, 2024 at 09:56:42AM +, Soumyadeep Hore wrote: > From: Jacob Keller > > The ice_get_pfa_module_tlv() function iterates over the Preserved Fields > Area to read data from the Shadow RAM, including the Part Board Assembly > data, among others. > > If the specific TLV being reques

RE: Bihash Support in DPDK

2024-08-28 Thread Medvedkin, Vladimir
I am not aware of such plans. From: rajesh goel Sent: Wednesday, August 28, 2024 11:22 AM To: Medvedkin, Vladimir Cc: Ferruh Yigit ; Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce ; dev@dpdk.org Subject: Re: Bihash Support in DPDK Thanks Vladimir for the confirmation. Is there any plan to

Re: [PATCH v3 08/12] net/ice: update iteration of TLVs in Preserved Fields Area

2024-08-28 Thread Bruce Richardson
On Fri, Aug 23, 2024 at 09:56:46AM +, Soumyadeep Hore wrote: > From: Fabio Pricoco > > Correct the logic for determining the maximum PFA offset to include the > extra last word. Additionally, make the driver robust against overflows > by using check_add_overflow. This ensures that even if the

Re: [PATCH v3 00/12] Align ICE shared code with Base driver

2024-08-28 Thread Bruce Richardson
On Fri, Aug 23, 2024 at 09:56:38AM +, Soumyadeep Hore wrote: > Updating the latest shared code patches to ICE base driver. > > --- > v3: > - Addressed comments givn by reviewer > --- > v2: > - Addressed comments given by reviewer > - Corrected errors in Camel Case > --- > I've performed on ap

Re: [PATCH v8 2/3] eventdev: add support for independent enqueue

2024-08-28 Thread Mattias Rönnblom
On 2024-08-24 22:41, Pathak, Pravin wrote: -Original Message- From: Mattias Rönnblom Sent: Friday, August 23, 2024 7:03 AM To: Sevincer, Abdullah ; dev@dpdk.org Cc: jer...@marvell.com; Richardson, Bruce ; Pathak, Pravin ; mattias.ronnb...@ericsson.com; Aggarwal, Manish Subject: Re: [

RE: [PATCH v8 2/3] eventdev: add support for independent enqueue

2024-08-28 Thread Sevincer, Abdullah
Thanks Mattias, Hi Jerin, Are you okay with the changes so far?

Re: Bihash Support in DPDK

2024-08-28 Thread Stephen Hemminger
On Wed, 28 Aug 2024 15:54:27 + "Medvedkin, Vladimir" wrote: > Thanks for the reply. > > Bihash I mean bounded index what Vpp supports. > > Iam looking for the bucket level lock support. Currently Iam using hash table > shared by multiple process or multiple core/threads. So I have to take

Re: [PATCH v3 11/12] dts: add Rx offload capabilities

2024-08-28 Thread Jeremy Spewock
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > diff --git a/dts/framework/remote_session/testpmd_shell.py > b/dts/framework/remote_session/testpmd_shell.py > index 48c31124d1..f83569669e 100644 > --- a/dts/framework/remote_session/testpmd_shell.py > +++ b/dts/framework/remote_session/tes

Re: [PATCH v3 03/12] dts: add test case decorators

2024-08-28 Thread Dean Marx
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > Add decorators for functional and performance test cases. These > decorators add attributes to the decorated test cases. > > With the addition of decorators, we change the test case discovery > mechanism from looking at test case names accord

Re: [PATCH v3 04/12] dts: add mechanism to skip test cases or suites

2024-08-28 Thread Dean Marx
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > If a test case is not relevant to the testing environment (such as when > a NIC doesn't support a tested feature), the framework should skip it. > The mechanism is a skeleton without actual logic that would set a test > case or suite to be sk

Re: [PATCH v3 05/12] dts: add support for simpler topologies

2024-08-28 Thread Dean Marx
On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: > We currently assume there are two links between the SUT and TG nodes, > but that's too strict, even for some of the already existing test cases. > Add support for topologies with less than two links. > > For topologies with no links, dummy po

memif insufficient padding

2024-08-28 Thread Morten Brørup
Jakub, While browsing virtual interfaces in DPDK, I noticed a possible performance issue in the memif driver: If "head" and "tail" are accessed by different lcores, they are not sufficiently far away from each other (and other hot fields) to prevent false sharing-like effects on systems with a

32-bit virtio failing on DPDK v23.11.1 (and tags)

2024-08-28 Thread Chris Brezovec (cbrezove)
HI Maxime, My name is Chris Brezovec, we met and talked about some 32 bit virtio issues we were seeing at Cisco during the DPDK summit last year. There was also a back and forth between you and Dave Johnson at Cisco last September regarding the same issue. I have attached some of the email ch

[PATCH v2] net/ice: support customized search path for DDP package

2024-08-28 Thread Zhichao Zeng
This patch adds support for customizing firmware search path for DDP package like the kernel behavior, it will read the search path from "/sys/module/firmware_class/parameters/path", and try to load DDP package. Signed-off-by: Zhichao Zeng --- v2: separate the patch and rewrite the log --- doc/

答复: [RFC 1/2] eal: add llc aware functions

2024-08-28 Thread Feifei Wang
Hi, > -邮件原件- > 发件人: Wathsala Wathawana Vithanage > 发送时间: 2024年8月28日 4:56 > 收件人: Vipin Varghese ; ferruh.yi...@amd.com; > dev@dpdk.org > 抄送: nd ; nd > 主题: RE: [RFC 1/2] eal: add llc aware functions > > > -unsigned int rte_get_next_lcore(unsigned int i, int skip_main, int wrap) > > +#defi

[PATCH v2] net/ice: support customized search path for DDP package

2024-08-28 Thread Zhichao Zeng
This patch adds support for customizing firmware search path for DDP package like the kernel behavior, it will read the search path from "/sys/module/firmware_class/parameters/path", and try to load DDP package. Signed-off-by: Zhichao Zeng --- v2: separate the patch and rewrite the log --- doc/

RE: [EXTERNAL] [PATCH dpdk] graph: make graphviz export more readable

2024-08-28 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Robin Jarry > Sent: Wednesday, August 28, 2024 7:12 PM > To: dev@dpdk.org; Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Subject: [EXTERNAL] [PATCH dpdk] graph: make graphviz export more readable > > Change the color o

RE: [PATCH] bus/pci: don't open uio device in secondary process

2024-08-28 Thread Chaoyong He
> > The uio_pci_generic driver clears the bus master bit when the device file is > closed. So, when the secondary process terminates after probing a device, > that device becomes unusable in the primary process. > > To avoid that, the device file is now opened only in the primary process. The >