On Fri, Aug 23, 2024 at 09:56:42AM +0000, Soumyadeep Hore wrote: > From: Jacob Keller <jacob.e.kel...@intel.com> > > The ice_get_pfa_module_tlv() function iterates over the Preserved Fields > Area to read data from the Shadow RAM, including the Part Board Assembly > data, among others. > > If the specific TLV being requested is not found in the current NVM, the > code will read past the end of the PFA, misinterpreting the last word of > the PFA and the word just after the PFA as another TLV. This typically > results in one extra iteration before the length check of the while loop is > triggered. > > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> > Signed-off-by: Soumyadeep Hore <soumyadeep.h...@intel.com> > --- > drivers/net/ice/base/ice_nvm.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >
Took a bit of digging, but I believe this fixes this previous commit (with code being edited and moved a bit since then): Fixes: 5d0b7b5fc491 ("net/ice/base: add read PBA module function")