[DPDK/core Bug 1524] rte_lcore API treats Service cores and Registered Non-EAL threads as disabled

https://bugs.dpdk.org/show_bug.cgi?id=1524 Bug ID: 1524 Summary: rte_lcore API treats Service cores and Registered Non-EAL threads as disabled Product: DPDK Version: 24.07 Hardware: All OS: All S

RE: 22.11.6 patches review and test

> -Original Message- > From: luca.bocca...@gmail.com > Sent: Wednesday, July 31, 2024 10:37 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; benjamin.wal...@intel.com; David Christensen > ; Hemant Agrawal ; Ian > Stokes ; Jerin Jacob ; John > McNamara ; Ju-H

Re: [PATCH v17 5/5] dts: add API doc generation

On 19. 8. 2024 19:53, Dean Marx wrote: On Mon, Aug 19, 2024 at 10:37 AM Dean Marx > wrote: I ran into some dependency issues while testing that I figured I'd mention here. My build failed while running meson setup with the -Denable_docs=true option since

Re: 22.11.6 patches review and test

On Tue, 20 Aug 2024 at 08:21, Ali Alnubani wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Wednesday, July 31, 2024 10:37 PM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > > Alnubani ; benjamin.wal...@intel.com; David Christensen > > ; H

Re: [PATCH v2 3/4] usertools/dpdk-hugepages.py: sort by NUMA node

On 8/19/2024 1:32 PM, Robin Jarry wrote: Anatoly Burakov, Aug 16, 2024 at 14:16: Currently, the list of per-NUMA node hugepages is displayed in glob order, which can be arbitrary. Fix it to sort the glob order. Signed-off-by: Anatoly Burakov Hey Anatoly, I mean no offense to anyone but dpd

Re: [PATCH v2 3/4] usertools/dpdk-hugepages.py: sort by NUMA node

Burakov, Anatoly, Aug 20, 2024 at 11:04: I do agree it is, umm, let's say not up to Python standards, but I was attempting to minimize changes to ensure this change gets integrated quickly. I can try and rewrite it if that's something that community is willing to accept. I'm not a master Python

Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

On 8/19/2024 1:34 PM, Robin Jarry wrote: Anatoly Burakov, Aug 16, 2024 at 14:16: Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signe

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

On 8/19/2024 1:11 PM, Robin Jarry wrote: Anatoly Burakov, Aug 16, 2024 at 14:16: Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable Signed-off-by

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

Burakov, Anatoly, Aug 20, 2024 at 11:12: > FYI: if we change the minimum supported python version to 3.9, we could > even get rid of this import completely as builtin types `set`, `list`, > `tuple` and `dict` have become subscriptable. > >    https://peps.python.org/pep-0585/ > > You can use

Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

Burakov, Anatoly, Aug 20, 2024 at 11:08: Rewriting this one would take a bit more time because unlike working with hugepages or sysfs CPU layouts, I'm not familiar enough with all of the specifics this script does, so I'd have to learn it more. I can try though, if you think it's worth the effo

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

On 8/20/2024 11:20 AM, Robin Jarry wrote: Burakov, Anatoly, Aug 20, 2024 at 11:12: > FYI: if we change the minimum supported python version to 3.9, we could > even get rid of this import completely as builtin types `set`, `list`, > `tuple` and `dict` have become subscriptable. > >     https://

Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

On 8/20/2024 11:28 AM, Robin Jarry wrote: Burakov, Anatoly, Aug 20, 2024 at 11:08: Rewriting this one would take a bit more time because unlike working with hugepages or sysfs CPU layouts, I'm not familiar enough with all of the specifics this script does, so I'd have to learn it more. I can t

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

Burakov, Anatoly, Aug 20, 2024 at 11:31: > I checked and unless I missed something, dpdk-pmdinfo.py uses the > symbols from the typing module for annotations. Not builtin container > types. It does both. Check e.g. line 147: def scrub_pci_ids(info: dict): Ah, that does not require python 3.

Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

Burakov, Anatoly, Aug 20, 2024 at 11:40: I have heard about driverctl for a long time in context of devbind, and I quickly tried it out just now, and IMO while the *functionality* is there, the usability of devbind is IMO far more friendly: - it filters by device types that are of interest to

Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

On 8/20/2024 11:49 AM, Robin Jarry wrote: Burakov, Anatoly, Aug 20, 2024 at 11:40: I have heard about driverctl for a long time in context of devbind, and I quickly tried it out just now, and IMO while the *functionality* is there, the usability of devbind is IMO far more friendly: - it filte

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

On 8/20/2024 11:45 AM, Robin Jarry wrote: Burakov, Anatoly, Aug 20, 2024 at 11:31: > I checked and unless I missed something, dpdk-pmdinfo.py uses the > symbols from the typing module for annotations. Not builtin container > types. It does both. Check e.g. line 147: def scrub_pci_ids(info: d

Re: [PATCH v2 4/4] usertools/dpdk-devbind: print NUMA node

Burakov, Anatoly, Aug 20, 2024 at 11:56: Actually, I should correct myself (and yourself) somewhat. This is not obvious from help message (I found it through reading the REAME) but driverctl *does* allow listing PCI devices by type, but only one type (e.g. list all network devices), but not mu

Re: [PATCH v7 1/2] dts: add methods for modifying MTU to testpmd shell

I'm trying to use this patch for the capabilities series. It works as I need it to, so we just need to coordinate a bit to use this one patch for both series. diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py @@ -82,12 +84,82 @@ clas

[PATCH v18 0/5] API docs generation

The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetry: poetry install --with docs The build itself

[PATCH v18 1/5] dts: update params and parser docstrings

Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.Eal

[PATCH v18 2/5] dts: replace the or operator in third party types

When the DTS dependencies are not installed when building DTS API documentation, the or operator produces errors when used with types from those libraries: autodoc: failed to import module 'remote_session' from module 'framework'; the following exception was raised: Traceback (most recent call last

[PATCH v18 3/5] dts: add doc generation dependencies

Sphinx imports every Python module (through the autodoc extension) when generating documentation from docstrings, meaning all DTS dependencies, including Python version, should be satisfied. This is not a hard requirement, as imports from dependencies may be mocked in the autodoc_mock_imports autod

[PATCH v18 4/5] dts: add API doc sources

These sources could be generated with the sphinx-apidoc utility, but that doesn't give us enough flexibility, such as sorting the order of modules or changing the headers of the modules. The sources included in this patch were in fact generated by said utility, but modified to improve the look of

[PATCH v18 5/5] dts: add API doc generation

The tool used to generate DTS API docs is Sphinx, which is already in use in DPDK. The same configuration is used to preserve style with one DTS-specific configuration (so that the DPDK docs are unchanged) that modifies how the sidebar displays the content. There's other Sphinx configuration relate

Re: [PATCH v7 4/4] test-pmd: add more packet verbose decode options

Hi Stephen, I have gone through your patch series and the hexdump option would be quite valuable for use in DTS. However I am currently facing the issue of distinguishing noise packets from intentional packets within the verbose output. Prior to your patch, the intention was to use the Layer

Re: [PATCH v7 1/2] dts: add methods for modifying MTU to testpmd shell

On Tue, Aug 20, 2024 at 9:05 AM Juraj Linkeš wrote: > > I'm trying to use this patch for the capabilities series. It works as I > need it to, so we just need to coordinate a bit to use this one patch > for both series. > > > diff --git a/dts/framework/remote_session/testpmd_shell.py > > b/dts/fra

[PATCH v3 1/4] usertools/cpu_layout: update coding style

Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable - read valid CPU ID's from "online" sysfs node Signed-off-by: Anatoly Burakov --- Notes: v1

[PATCH v3 2/4] usertools/cpu_layout: print out NUMA nodes

In traditional NUMA case, NUMA nodes and physical sockets were used interchangeably, but there are cases where there can be multiple NUMA nodes per socket, as well as all CPU's being assigned NUMA node 0 even in cases of multiple sockets. Use sysfs to print out NUMA information. Signed-off-by: Ana

[PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style

Update coding style: - Make the code PEP-484 compliant - Add more comments, improve readability, use f-strings everywhere - Use quotes consistently - Address all Python static analysis (e.g. mypy, pylint) warnings - Improve error handling - Refactor printing and sysfs/procfs access functions - Sor

[PATCH v3 4/4] usertools/dpdk-devbind: print NUMA node

Currently, devbind does not print out any NUMA information, which makes figuring out which NUMA node device belongs to not trivial. Add printouts for NUMA information if NUMA support is enabled on the system. Signed-off-by: Anatoly Burakov Acked-by: Robin Jarry --- Notes: v1 -> v2: - Ad

Re: [PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style

On Tue, 20 Aug 2024 16:35:16 +0100 Anatoly Burakov wrote: > Update coding style: > > - Make the code PEP-484 compliant > - Add more comments, improve readability, use f-strings everywhere > - Use quotes consistently > - Address all Python static analysis (e.g. mypy, pylint) warnings > - Improve

Re: [PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style

Anatoly Burakov, Aug 20, 2024 at 17:35: Update coding style: - Make the code PEP-484 compliant - Add more comments, improve readability, use f-strings everywhere - Use quotes consistently - Address all Python static analysis (e.g. mypy, pylint) warnings - Improve error handling - Refactor printi

Re: [PATCH v3 1/4] usertools/cpu_layout: update coding style

Anatoly Burakov, Aug 20, 2024 at 17:35: Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable - read valid CPU ID's from "online" sysfs node Signed-o

Re: [PATCH v2 5/5] dts: add testpmd set ports queues

On Fri, Aug 9, 2024 at 11:14 AM Jeremy Spewock wrote: > > > + > > +Raises: > > +InternalError: If `number_of` is invalid. > > I might be more in favor of this being an > InteractiveCommandExecutionError or some other DTSError just to have a > little more control over the error

RE: [PATCH v6 2/3] eventdev: add support for independent enqueue

Hi Folks, Any chance to look at the patches? Don’t want to lose the window for API changes again 😊

Re: [PATCH v3 0/5] Improve EAL bit operations API

On 2024-08-12 14:49, Mattias Rönnblom wrote: This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. Is there anyone else that has any opinion on this patch set? Details, or big picture.

Re: [PATCH 1/6] eal: add bitset type

On 2024-08-09 22:14, Mattias Rönnblom wrote: Introduce a set of functions and macros that operate on sets of bits, kept in arrays of 64-bit words. RTE bitset is designed for bitsets which are larger than what fits in a single machine word (i.e., 64 bits). For very large bitsets, the API may be

Re: [PATCH v3 2/4] usertools/cpu_layout: print out NUMA nodes

Anatoly Burakov, Aug 20, 2024 at 17:35: In traditional NUMA case, NUMA nodes and physical sockets were used interchangeably, but there are cases where there can be multiple NUMA nodes per socket, as well as all CPU's being assigned NUMA node 0 even in cases of multiple sockets. Use sysfs to print

DPDK 22.11.6 released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-22.11.6.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=22.11 Luca Boccassi --- .mailmap | 19 +- VERSION