On 8/20/2024 11:28 AM, Robin Jarry wrote:
Burakov, Anatoly, Aug 20, 2024 at 11:08:
Rewriting this one would take a bit more time because unlike working
with hugepages or sysfs CPU layouts, I'm not familiar enough with all
of the specifics this script does, so I'd have to learn it more. I can
try though, if you think it's worth the effort?
If you have better things to do. It is probably not worth the effort.
This script is partially redundant with driverctl:
https://gitlab.com/driverctl/driverctl
I guess we cannot completely get rid of it but it is also OK not to
invest too much into it :)
I have heard about driverctl for a long time in context of devbind, and
I quickly tried it out just now, and IMO while the *functionality* is
there, the usability of devbind is IMO far more friendly:
- it filters by device types that are of interest to us (driverctl just
lists all pci devices)
- it prints out user-friendly names, not just PCI addresses
- it lists loaded drivers, but not alternatives etc. like devbind does
- I didn't test this, but I suspect it would allow overriding driver for
an active NIC
- after my changes, devbind displays NUMA socket, driverctl doesn't :)
What we maybe can do for e.g. next release (currently I do have better
things to do if I can help it), is to make devbind a wrapper around
driverctl? This way, we can still keep the usability bells and whistles
we have, but drop the driver overriding code and leave it to driverctl?
It seems like that would be a good compromise, with the only downside
being that we'll depend on driverctl being installed.
--
Thanks,
Anatoly
