Re: [PATCH v5] virtio: optimize stats counters performance

2024-08-06 Thread Chenbo Xia
> On Aug 2, 2024, at 00:03, Morten Brørup wrote: > > External email: Use caution opening links or attachments > > > Optimized the performance of updating the virtio statistics counters by > reducing the number of branches. > > Ordered the packet size comparisons according to the probability

Re: [PATCH] vhost-user: optimize stats counters performance

2024-08-06 Thread Chenbo Xia
> On Aug 2, 2024, at 22:32, Morten Brørup wrote: > > External email: Use caution opening links or attachments > > > Optimized the performance of updating the statistics counters by reducing > the number of branches. > > Ordered the packet size comparisons according to the probability with >

Re: [PATCH v2 0/7] record and rework component dependencies

2024-08-06 Thread Bruce Richardson
On Fri, Aug 02, 2024 at 06:18:26PM +0100, Ferruh Yigit wrote: > On 8/2/2024 1:44 PM, Bruce Richardson wrote: > > As part of the meson build, we can record the dependencies for each > > component as we process it, logging them to a file. This file can be > > used as input to a number of other script

Re: [PATCH v5 4/4] test: rearrange test_cfgfiles cases

2024-08-06 Thread Bruce Richardson
On Fri, Aug 02, 2024 at 10:06:35AM -0700, Stephen Hemminger wrote: > On Fri, 2 Aug 2024 17:51:01 +0100 > Bruce Richardson wrote: > > > On Fri, Aug 02, 2024 at 09:45:03AM -0700, Stephen Hemminger wrote: > > > The input files don't need to be in a separate subdirectory. > > > > > > Signed-off-by:

[v1 0/7] DPAA2 crypto changes

2024-08-06 Thread Gagandeep Singh
Changes related to crypto driver Gagandeep Singh (1): crypto/dpaa2_sec: fix memory leak Jun Yang (5): crypto/dpaa2_sec: enhance IPsec RFLC handling crypto/dpaa2_sec: enhance pdcp FLC handling net/dpaa2: support FLC stashing API crypto/dpaa2_sec: remove prefetch code in event mode cryp

[v1 1/7] crypto/dpaa2_sec: fix memory leak

2024-08-06 Thread Gagandeep Singh
fixing memory leak while creating the PDCP session with invalid data. Fixes: bef594ec5cc8 ("crypto/dpaa2_sec: support PDCP offload") Cc: akhil.go...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1 + 1 file changed, 1 insertion(+)

[v1 2/7] common/dpaax: caamflib: fix PDCP SNOW-ZUC wdog DECO err

2024-08-06 Thread Gagandeep Singh
From: Varun Sethi Adding a Jump instruction with CALM flag to ensure previous processing has been completed. Fixes: 8827d94398f1 ("crypto/dpaa2_sec/hw: support AES-AES 18-bit PDCP") Cc: vakul.g...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Varun Sethi Acked-by:

[v1 3/7] crypto/dpaa2_sec: enhance IPsec RFLC handling

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Point Response FLC to FLC(SEC descriptor context). Response FLC can be used for debug purpose in dequeue process. Enable data stashing only. Annotation stashing is disabled which is not suitable for SEC and impacts performance. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --

[v1 5/7] net/dpaa2: support FLC stashing API

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Configure flow steering action with FLC enabled to align stashing setting with RSS configuration. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 44 + drivers/net/dpaa2/dpaa2_ethdev.c| 25 +++---

[v1 4/7] crypto/dpaa2_sec: enhance pdcp FLC handling

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Set RFLC with FLC IOVA address and data stashing only. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci

[v1 6/7] crypto/dpaa2_sec: remove prefetch code in event mode

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Should not prefetch mbuf and crypto_op which are not touched by hardware. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c

[v1 7/7] crypto/dpaa2_sec: rework debug code

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Output debug information according to various modes. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 63 - 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/

[PATCH v13 0/6] API docs generation

2024-08-06 Thread Juraj Linkeš
The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetry: poetry install --with docs The build itself

[PATCH v13 1/6] dts: update params and parser docstrings

2024-08-06 Thread Juraj Linkeš
Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.Eal

[PATCH v13 2/6] dts: replace the or operator in third party types

2024-08-06 Thread Juraj Linkeš
When the DTS dependencies are not installed when building DTS API documentation, the or operator produces errors when used with types from those libraries: autodoc: failed to import module 'remote_session' from module 'framework'; the following exception was raised: Traceback (most recent call last

[PATCH v13 3/6] dts: add doc generation dependencies

2024-08-06 Thread Juraj Linkeš
Sphinx imports every Python module (through the autodoc extension) when generating documentation from docstrings, meaning all DTS dependencies, including Python version, should be satisfied. This is not a hard requirement, as imports from dependencies may be mocked in the autodoc_mock_imports autod

[PATCH v13 4/6] dts: add API doc sources

2024-08-06 Thread Juraj Linkeš
These sources could be generated with the sphinx-apidoc utility, but that doesn't give us enough flexibility, such as sorting the order of modules or changing the headers of the modules. The sources included in this patch were in fact generated by said utility, but modified to improve the look of

[PATCH v13 5/6] doc: meson doc API build dir variable

2024-08-06 Thread Juraj Linkeš
The three instances of the path 'dpdk_build_root/doc/api' are replaced with a variable, moving the definition to one place. Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock Acked-by: Bruce Richardson Tested-by: Luca Vizzarro Tested-by: Nicholas Pratte --- d

[PATCH v13 6/6] dts: add API doc generation

2024-08-06 Thread Juraj Linkeš
The tool used to generate DTS API docs is Sphinx, which is already in use in DPDK. The same configuration is used to preserve style with one DTS-specific configuration (so that the DPDK docs are unchanged) that modifies how the sidebar displays the content. Sphinx generates the documentation from

Re: [v1 7/7] crypto/dpaa2_sec: rework debug code

2024-08-06 Thread Hemant Agrawal
Hi Gagan, On 06-08-2024 14:11, Gagandeep Singh wrote: From: Jun Yang Output debug information according to various modes. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 63 - 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/dri

Re: [v1 5/7] net/dpaa2: support FLC stashing API

2024-08-06 Thread Hemant Agrawal
Hi Gagan, I think this patch shall come before the 4th patch:   [v1 4/7] crypto/dpaa2_sec: enhance pdcp FLC handling - Hemant On 06-08-2024 14:11, Gagandeep Singh wrote: From: Jun Yang Configure flow steering action with FLC enabled to align stashing setting with RSS configuration. Sig

[v2 0/7] DPAA2 crypto changes

2024-08-06 Thread Gagandeep Singh
v2 changes: * fix patch sequence * add missing code in "crypto/dpaa2_sec: rework debug code" Changes related to crypto driver Gagandeep Singh (1): crypto/dpaa2_sec: fix memory leak Jun Yang (5): net/dpaa2: support FLC stashing API crypto/dpaa2_sec: enhance IPsec RFL

[v2 1/7] crypto/dpaa2_sec: fix memory leak

2024-08-06 Thread Gagandeep Singh
fixing memory leak while creating the PDCP session with invalid data. Fixes: bef594ec5cc8 ("crypto/dpaa2_sec: support PDCP offload") Cc: akhil.go...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1 + 1 file changed, 1 insertion(+)

[v2 2/7] common/dpaax: caamflib: fix PDCP SNOW-ZUC wdog DECO err

2024-08-06 Thread Gagandeep Singh
From: Varun Sethi Adding a Jump instruction with CALM flag to ensure previous processing has been completed. Fixes: 8827d94398f1 ("crypto/dpaa2_sec/hw: support AES-AES 18-bit PDCP") Cc: vakul.g...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Varun Sethi Acked-by:

[v2 3/7] net/dpaa2: support FLC stashing API

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Configure flow steering action with FLC enabled to align stashing setting with RSS configuration. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 44 + drivers/net/dpaa2/dpaa2_ethdev.c| 25 +++---

[v2 4/7] crypto/dpaa2_sec: enhance IPsec RFLC handling

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Point Response FLC to FLC(SEC descriptor context). Response FLC can be used for debug purpose in dequeue process. Enable data stashing only. Annotation stashing is disabled which is not suitable for SEC and impacts performance. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --

[v2 6/7] crypto/dpaa2_sec: remove prefetch code in event mode

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Should not prefetch mbuf and crypto_op which are not touched by hardware. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c

[v2 5/7] crypto/dpaa2_sec: enhance pdcp FLC handling

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Set RFLC with FLC IOVA address and data stashing only. Signed-off-by: Jun Yang Acked-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci

[v2 7/7] crypto/dpaa2_sec: rework debug code

2024-08-06 Thread Gagandeep Singh
From: Jun Yang Output debug information according to various modes. Signed-off-by: Jun Yang --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 87 +++-- 1 file changed, 63 insertions(+), 24 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/

[DPDK/meson Bug 1515] Meson install replaces api doc index.html

2024-08-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1515 Bug ID: 1515 Summary: Meson install replaces api doc index.html Product: DPDK Version: 24.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH v14 0/6] API docs generation

2024-08-06 Thread Juraj Linkeš
The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetry: poetry install --with docs The build itself

[PATCH v14 1/6] dts: update params and parser docstrings

2024-08-06 Thread Juraj Linkeš
Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.Eal

[PATCH v14 2/6] dts: replace the or operator in third party types

2024-08-06 Thread Juraj Linkeš
When the DTS dependencies are not installed when building DTS API documentation, the or operator produces errors when used with types from those libraries: autodoc: failed to import module 'remote_session' from module 'framework'; the following exception was raised: Traceback (most recent call last

[PATCH v14 3/6] dts: add doc generation dependencies

2024-08-06 Thread Juraj Linkeš
Sphinx imports every Python module (through the autodoc extension) when generating documentation from docstrings, meaning all DTS dependencies, including Python version, should be satisfied. This is not a hard requirement, as imports from dependencies may be mocked in the autodoc_mock_imports autod

[PATCH v14 5/6] doc: meson doc API build dir variable

2024-08-06 Thread Juraj Linkeš
The three instances of the path 'dpdk_build_root/doc/api' are replaced with a variable, moving the definition to one place. Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock Acked-by: Bruce Richardson Tested-by: Luca Vizzarro Tested-by: Nicholas Pratte --- d

[PATCH v14 4/6] dts: add API doc sources

2024-08-06 Thread Juraj Linkeš
These sources could be generated with the sphinx-apidoc utility, but that doesn't give us enough flexibility, such as sorting the order of modules or changing the headers of the modules. The sources included in this patch were in fact generated by said utility, but modified to improve the look of

[PATCH v14 6/6] dts: add API doc generation

2024-08-06 Thread Juraj Linkeš
The tool used to generate DTS API docs is Sphinx, which is already in use in DPDK. The same configuration is used to preserve style with one DTS-specific configuration (so that the DPDK docs are unchanged) that modifies how the sidebar displays the content. Sphinx generates the documentation from

[PATCH 0/4] dts: add pktgen and testpmd changes

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro Hello, sending some framework changes that will be required in my upcoming l2fwd test suite. Best, Luca Luca Vizzarro (5): dts: add ability to send/receive multiple packets dts: add random generation seed setting dts: add random packet generator dts: add ability to

[PATCH 1/5] dts: add ability to send/receive multiple packets

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro The framework allows only to send one packet at once via Scapy. This change adds the ability to send multiple packets, and also introduces a new fast way to verify if we received several expected packets. Moreover, it reduces code duplication by keeping a single packet sendin

[PATCH 2/5] dts: add random generation seed setting

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro When introducing pseudo-random generation in the test runs we need to ensure that these can be reproduced by setting a pre-defined seed. This commits adds the ability to set one or allow for one to be generated and reported back to the user. Signed-off-by: Luca Vizzarro Revi

[PATCH 3/5] dts: add random packet generator

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro Add a basic utility that can create random L3 and L4 packets with random payloads and port numbers (if L4). Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczpanek Reviewed-by: Alex Chapman --- dts/framework/utils.py | 79 -- 1 fil

[PATCH 4/5] dts: add ability to start/stop ports

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro Add the commands to start and stop all the ports, so that they can be configured. Because there is a distinction of commands that require the ports to be stopped and started, also add decorators for commands that require a specific state, removing this logic from the test writ

[PATCH 4/5] dts: add ability to start/stop testpmd ports

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro Add testpmd commands to start and stop all the ports, so that they can be configured. Because there is a distinction of commands that require the ports to be stopped and started, also add decorators for commands that require a specific state, removing this logic from the test

[PATCH 5/5] dts: add testpmd set ports queues

2024-08-06 Thread Luca Vizzarro
From: Luca Vizzarro Add a facility to update the number of TX/RX queues during the runtime of testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczpanek --- dts/framework/remote_session/testpmd_shell.py | 16 1 file changed, 16 insertions(+) diff --git a/dts/framework

Re: [PATCH 3/4] test: make red test part of fast suite

2024-08-06 Thread David Marchand
On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger wrote: > > The red tests were not run because not part of any suite. > Meson warning is: > WARNING: Test "red_autotest" is not defined in any test suite > > Signed-off-by: Stephen Hemminger There is an open bz about this unit test. https://bugs.

Re: [PATCH 1/4] test: update alarm test

2024-08-06 Thread David Marchand
On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger wrote: > > This test should be using the TEST_ASSERT macros, and can be > run as part of the fast test suite now. > > Signed-off-by: Stephen Hemminger [...] > + ret = rte_eal_alarm_cancel(test_alarm_callback, NULL); > + /* return is

[PATCH v2 0/5] dts: add pktgen and testpmd changes

2024-08-06 Thread Luca Vizzarro
Apologies, re-sending again due to errors in sending v1. v2: - rebased Luca Vizzarro (5): dts: add ability to send/receive multiple packets dts: add random generation seed setting dts: add random packet generator dts: add ability to start/stop testpmd ports dts: add testpmd set ports qu

[PATCH v2 1/5] dts: add ability to send/receive multiple packets

2024-08-06 Thread Luca Vizzarro
The framework allows only to send one packet at once via Scapy. This change adds the ability to send multiple packets, and also introduces a new fast way to verify if we received several expected packets. Moreover, it reduces code duplication by keeping a single packet sending method only at the t

[PATCH v2 2/5] dts: add random generation seed setting

2024-08-06 Thread Luca Vizzarro
When introducing pseudo-random generation in the test runs we need to ensure that these can be reproduced by setting a pre-defined seed. This commits adds the ability to set one or allow for one to be generated and reported back to the user. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepan

[PATCH v2 3/5] dts: add random packet generator

2024-08-06 Thread Luca Vizzarro
Add a basic utility that can create random L3 and L4 packets with random payloads and port numbers (if L4). Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Alex Chapman --- dts/framework/utils.py | 79 -- 1 file changed, 77 inserti

[PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-08-06 Thread Luca Vizzarro
Add testpmd commands to start and stop all the ports, so that they can be configured. Because there is a distinction of commands that require the ports to be stopped and started, also add decorators for commands that require a specific state, removing this logic from the test writer's duty. Signed

[PATCH v2 5/5] dts: add testpmd set ports queues

2024-08-06 Thread Luca Vizzarro
Add a facility to update the number of TX/RX queues during the runtime of testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 16 1 file changed, 16 insertions(+) diff --git a/dts/framework/remote_session/testp

Re: [PATCH 3/4] test: make red test part of fast suite

2024-08-06 Thread Bruce Richardson
On Tue, Aug 06, 2024 at 02:28:13PM +0200, David Marchand wrote: > On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger > wrote: > > > > The red tests were not run because not part of any suite. > > Meson warning is: > > WARNING: Test "red_autotest" is not defined in any test suite > > > > Signed-off

[PATCH] dts: add l2fwd test suite

2024-08-06 Thread Luca Vizzarro
Add a basic L2 forwarding test suite which tests the correct functionality of the forwarding facility built-in in the DPDK. The tests are performed with different queues numbers per port. Bugzilla ID: 1481 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- Depends-on: series-32714 (

[v1 0/3] meson options related changes

2024-08-06 Thread Gagandeep Singh
meson options related changes Gagandeep Singh (3): meson: add a meson option to install examples meson: add a meson option to install examples source meson: skip symlinks to PMDs script on no sub directory config/meson.build | 7 +-- examples/meson.build | 13 - meson.bu

[v1 1/3] meson: add a meson option to install examples

2024-08-06 Thread Gagandeep Singh
Adding a meson option "enable_examples_bin_install" to install the examples binaries in bin. Default value is false. Signed-off-by: Gagandeep Singh --- examples/meson.build | 13 - meson_options.txt| 2 ++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/examples/

[v1 2/3] meson: add a meson option to install examples source

2024-08-06 Thread Gagandeep Singh
Adding a meson option "enable_examples_source_install" to enable or disable installation of examples source code. Default value is true. Signed-off-by: Gagandeep Singh --- meson.build | 7 --- meson_options.txt | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/mes

[v1 3/3] meson: skip symlinks to PMDs script on no sub directory

2024-08-06 Thread Gagandeep Singh
if user gives option -Ddrivers_install_subdir= or -Ddrivers_install_subdir=. to install all the PMDs in parent directory, The post installation script "symlink-drivers-solibs.sh" can create invalid library file named 'librte_*.so*' or meson installation errors: ln: './librte_*' and './librte_*' ar

[DPDK/DTS Bug 1516] Port over checksum offload suite to new DTS

2024-08-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1516 Bug ID: 1516 Summary: Port over checksum offload suite to new DTS Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [v1 3/3] meson: skip symlinks to PMDs script on no sub directory

2024-08-06 Thread Bruce Richardson
On Tue, Aug 06, 2024 at 07:12:18PM +0530, Gagandeep Singh wrote: > if user gives option -Ddrivers_install_subdir= or > -Ddrivers_install_subdir=. to install all the PMDs in > parent directory, The post installation script > "symlink-drivers-solibs.sh" can create invalid library file > named 'librte

Re: [v1 1/3] meson: add a meson option to install examples

2024-08-06 Thread Bruce Richardson
On Tue, Aug 06, 2024 at 07:12:16PM +0530, Gagandeep Singh wrote: > Adding a meson option "enable_examples_bin_install" > to install the examples binaries in bin. > > Default value is false. > > Signed-off-by: Gagandeep Singh > --- > examples/meson.build | 13 - > meson_options.txt

Re: [v1 2/3] meson: add a meson option to install examples source

2024-08-06 Thread Bruce Richardson
On Tue, Aug 06, 2024 at 07:12:17PM +0530, Gagandeep Singh wrote: > Adding a meson option "enable_examples_source_install" > to enable or disable installation of examples source code. > > Default value is true. > > Signed-off-by: Gagandeep Singh > --- > meson.build | 7 --- > meson_opt

Re: [PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-06 Thread Tathagat Priyadarshi
hi Ferruh, Could you please accept the updated patch?! let us know what's pending. https://patches.dpdk.org/project/dpdk/patch/1722575288-2408630-1-git-send-email-tathagat.d...@gmail.com/ TIA On Fri, Aug 2, 2024 at 10:40 AM Tathagat Priyadarshi wrote: > > Updated the if-else block with an opti

[PATCH] net/octeon_ep: extend mailbox functionality

2024-08-06 Thread Vamsi Attunuru
Patch extends mbox functionality to handle pf to vf mbox messages and also updates current mbox version to V3. As part of PF FLR notify event, event handler invokes device removal event callback to tear down the driver. Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/cnxk_ep_vf.h|

[PATCH v15 0/5] API docs generation

2024-08-06 Thread Juraj Linkeš
The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetry: poetry install --with docs The build itself

[PATCH v15 1/5] dts: update params and parser docstrings

2024-08-06 Thread Juraj Linkeš
Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.Eal

[PATCH v15 2/5] dts: replace the or operator in third party types

2024-08-06 Thread Juraj Linkeš
When the DTS dependencies are not installed when building DTS API documentation, the or operator produces errors when used with types from those libraries: autodoc: failed to import module 'remote_session' from module 'framework'; the following exception was raised: Traceback (most recent call last

[PATCH v15 3/5] dts: add doc generation dependencies

2024-08-06 Thread Juraj Linkeš
Sphinx imports every Python module (through the autodoc extension) when generating documentation from docstrings, meaning all DTS dependencies, including Python version, should be satisfied. This is not a hard requirement, as imports from dependencies may be mocked in the autodoc_mock_imports autod

[PATCH v15 4/5] dts: add API doc sources

2024-08-06 Thread Juraj Linkeš
These sources could be generated with the sphinx-apidoc utility, but that doesn't give us enough flexibility, such as sorting the order of modules or changing the headers of the modules. The sources included in this patch were in fact generated by said utility, but modified to improve the look of

[PATCH v15 5/5] dts: add API doc generation

2024-08-06 Thread Juraj Linkeš
The tool used to generate DTS API docs is Sphinx, which is already in use in DPDK. The same configuration is used to preserve style with one DTS-specific configuration (so that the DPDK docs are unchanged) that modifies how the sidebar displays the content. Sphinx generates the documentation from

[PATCH 0/4] improve rte_tm APIs

2024-08-06 Thread Bruce Richardson
This patchset makes some small updates to the traffic manager (TM) APIs in ethdev. * For functions for creating profiles, shapers and hierarchy nodes, make the parameter structure pointer a pointer to a const object. This guarantees to the user that the struct won't be modified by the functi

[PATCH 1/4] ethdev: make parameters to TM node add fn constant

2024-08-06 Thread Bruce Richardson
The function to add a new scheduling node in rte_tm should not (and does not) modify the actual node parameters passed in via struct pointer. We should guarantee this by marking the parameter pointer as const. This allows SW to create multiple scheduling nodes using the same parameter struct withou

[PATCH 2/4] ethdev: make parameters to TM profile add fn constant

2024-08-06 Thread Bruce Richardson
The function to add a new profile in rte_tm should not (and does not) modify the profile parameters passed in via struct pointer. We should guarantee this by marking the parameter pointer as const. This allows SW to create multiple profiles using the same parameter struct without having to reset i

[PATCH 3/4] ethdev: make TM shaper parameters constant

2024-08-06 Thread Bruce Richardson
The function to add a new shaper profile in rte_tm should not (and does not) modify the profile parameters passed in via struct pointer. We should guarantee this by marking the parameter pointer as const. This allows SW to create multiple profiles using the same parameter struct without having to r

[PATCH 4/4] ethdev: add traffic manager query function

2024-08-06 Thread Bruce Richardson
Add function to allow querying a node in the scheduler tree. Returns the parameters as were given to the add function. Adding this function allows apps to just query the hierarchy rather than having to maintain their own copies of it internally. Signed-off-by: Bruce Richardson --- lib/ethdev/et

[PATCH v2] dts: add flow rule dataclass to testpmd shell

2024-08-06 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58 +

[RFC PATCH v1 0/3] dts: pf_smoke port

2024-08-06 Thread jspewock
From: Jeremy Spewock This series ports the functionality of the pf_msoke test sutie from old DTS to the new framework. It is listed as an RFC mainly due to the fact that is uses different verification steps than most other test suites by utilizing checksums to differentiate packets sent by the fr

[RFC PATCH v1 1/3] dts: add ability to modify number of queues on a port to testpmd

2024-08-06 Thread jspewock
From: Jeremy Spewock The ability to change the configuration of a port at runtime is a crucial aspect of DPDK. This patch adds both the steps required to modify the number of queues on a port at runtime and also the verification steps to ensure that the command behaved as expected. Depends-on: p

[RFC PATCH v1 2/3] dts: add pf smoke testing suite

2024-08-06 Thread jspewock
From: Jeremy Spewock This patch adds a smoke testing suite for Physical Function features. The goal of this suite is to test some of the most basic features of DPDK on a physical function and bail out early if any of these features aren't supported as expected. Unlike DTS smoke tests, these ones

[RFC PATCH v1 3/3] dts: added pf_smoke_tests to yaml schema

2024-08-06 Thread jspewock
From: Jeremy Spewock Add the PF smoke testing suite to the yaml schema so that it can be specified in conf.yaml. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_sch

RE: [v1 2/3] meson: add a meson option to install examples source

2024-08-06 Thread Gagandeep Singh
Hi, > -Original Message- > From: Bruce Richardson > Sent: Tuesday, August 6, 2024 7:32 PM > To: Gagandeep Singh > Cc: dev@dpdk.org > Subject: Re: [v1 2/3] meson: add a meson option to install examples source > > On Tue, Aug 06, 2024 at 07:12:17PM +0530, Gagandeep Singh wrote: > > Adding

RE: [v1 1/3] meson: add a meson option to install examples

2024-08-06 Thread Gagandeep Singh
Hi, > -Original Message- > From: Bruce Richardson > Sent: Tuesday, August 6, 2024 7:28 PM > To: Gagandeep Singh > Cc: dev@dpdk.org > Subject: Re: [v1 1/3] meson: add a meson option to install examples > > On Tue, Aug 06, 2024 at 07:12:16PM +0530, Gagandeep Singh wrote: > > Adding a meso