Hi, > -----Original Message----- > From: Bruce Richardson <bruce.richard...@intel.com> > Sent: Tuesday, August 6, 2024 7:32 PM > To: Gagandeep Singh <g.si...@nxp.com> > Cc: dev@dpdk.org > Subject: Re: [v1 2/3] meson: add a meson option to install examples source > > On Tue, Aug 06, 2024 at 07:12:17PM +0530, Gagandeep Singh wrote: > > Adding a meson option "enable_examples_source_install" > > to enable or disable installation of examples source code. > > > > Default value is true. > > > > Signed-off-by: Gagandeep Singh <g.si...@nxp.com> > > --- > > meson.build | 7 ++++--- > > meson_options.txt | 2 ++ > > 2 files changed, 6 insertions(+), 3 deletions(-) > > > Is installing sample code for DPDK a problem that we need to disable it? I > was expecting that such filtering out of unwanted files could be done via > packaging rather than us having to add lots of DPDK build options to control > these things. > I understand your point that packaging could handle filtering out unwanted files. However, adding a build option to disable DPDK examples source code installation provides more control and flexibility for users who may have specific requirements or constraints.
While packaging can filter out files, this option allows users to avoid downloading and compiling the examples altogether, which can be beneficial for: - Users with limited disk space or network bandwidth - Users who only need the core DPDK libraries and binaries and don't want the examples source code. By default, the option is set to true, so the behavior remains unchanged. This option is only for those who need more control over their build process. I believe this optional flag adds flexibility without imposing unnecessary files on users and is a minor and useful extension to the build system. > /Bruce
