New version uploaded, please discard.
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 20 May 2024 00.49
>
> On Sun, 19 May 2024 19:10:30 +0200
> Morten Brørup wrote:
>
> > Absolutely; whenever possible, local counters should be maintained
> inside the loop, and added to the public counters at the end of
https://bugs.dpdk.org/show_bug.cgi?id=1445
Bug ID: 1445
Summary: [dpdk-24.07] dpdk-test-dma-perf hang on Ubuntu24.04
Product: DPDK
Version: 24.07
Hardware: All
OS: Linux
Status: UNCONFIRMED
Severity: norma
On Sun, May 12, 2024 at 09:10:49AM +0200, Stanisław Kardach wrote:
> On Thu, May 2, 2024 at 4:44 PM Daniel Gregory
> wrote:
> > diff --git a/config/riscv/meson.build b/config/riscv/meson.build
> > index 07d7d9da23..4cfdc42ecb 100644
> > --- a/config/riscv/meson.build
> > +++ b/config/riscv/meson.b
On Sun, 19 May 2024 at 22:11, Thomas Monjalon wrote:
>
> 19/05/2024 19:23, Luca Boccassi:
> > On Sun, 19 May 2024 at 18:13, Thomas Monjalon wrote:
> > >
> > > 19/05/2024 18:36, Luca Boccassi:
> > > > On Sun, 19 May 2024 at 15:01, Thomas Monjalon
> > > > wrote:
> > > > > 17/05/2024 13:29, Luca B
AMD 24.07 roadmap
# library
- AMD uncore power support
# driver
- axgbe TSO support and base code update
- ionic crypto driver
Thanks,
ferruh
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 01/25] net/axgbe: fix mdio
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 02/25] net/axgbe: reset lin
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 03/25] net/axgbe: fix fluct
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 04/25] net/axgbe: update DM
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 05/25] net/axgbe: disable i
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 06/25] net/axgbe: yellow ca
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 07/25] net/axgbe: enable PL
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 08/25] net/axgbe: fix the S
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 09/25] net/axgbe: fix logic
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 11/25] net/axgbe: flow Tx C
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 12/25] net/axgbe: delay AN
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 10/25] net/axgbe: check onl
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 13/25] net/axgbe: remove use of comm owned f
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 14/25] net/axgbe: remove field of SFP diagno
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 15/25] net/axgbe: improve SFP 100Mbps auto-n
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 16/25] net/axgbe: remove unnecessary convers
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 17/25] net/axgbe: use definitions for mailbo
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 18/25] net/axgbe: add support for 10 Mbps sp
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 19/25] net/axgbe: separate C22 and C45 trans
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 20/25] net/axgbe: replace mii generic macro
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 21/25] net/axgbe: add 2.5GbE support to 10G
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 22/25] net/axgbe: add support for Rx adaptat
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
; sta...@dpdk.org
Subject: [PATCH v2 23/25] net/axgbe: fix the f
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 24/25] net/axgbe: extend 10Mbps support to M
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Selwin Sebastian
-Original Message-
From: Ande, Venkat Kumar
Sent: Tuesday, May 7, 2024 6:13 PM
To: dev@dpdk.org
Cc: Sebastian, Selwin ; Ande, Venkat Kumar
Subject: [PATCH v2 25/25] net/axgbe: modify debug messages
Mod
Hi,
From: Itamar Gozlan
Sent: Monday, May 6, 2024 2:44 PM
To: Itamar Gozlan; Erez Shitrit; Hamdan Agbariya; Yevgeny Kliteynik; Slava
Ovsiienko; NBU-Contact-Thomas Monjalon (EXTERNAL); Suanming Mou; Dariusz
Sosnowski; Ori Kam; Matan Azrad; Mark Bloch; Alex
Hi,
From: Minggang(Gavin) Li
Sent: Thursday, May 9, 2024 3:44 PM
To: Matan Azrad; Slava Ovsiienko; Ori Kam; NBU-Contact-Thomas Monjalon
(EXTERNAL); Dariusz Sosnowski; Suanming Mou; Itamar Gozlan
Cc: dev@dpdk.org; Raslan Darawsheh; Bing Zhao
Subject: [PATCH] net/mlx5: fix HWS support for item NSH
Hi,
From: Rongwei Liu
Sent: Tuesday, May 14, 2024 6:21 AM
To: dev@dpdk.org; Matan Azrad; Slava Ovsiienko; Ori Kam; Suanming Mou;
NBU-Contact-Thomas Monjalon (EXTERNAL)
Cc: Alex Vesker; Dariusz Sosnowski
Subject: [PATCH v1] net/mlx5/hws: match VXLAN all fields
Support VxLAN all fields support.
T
Hi,
From: Haifei Luo
Sent: Wednesday, May 15, 2024 12:36 PM
To: Matan Azrad; Ori Kam; Slava Ovsiienko; ferruh.yi...@intel.com; Dariusz
Sosnowski; Suanming Mou
Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL); Raslan Darawsheh;
sta...@dpdk.org
Subject: [PATCH] net/mlx5: fix bug trunk is
On 5/7/2024 1:42 PM, Venkat Kumar Ande wrote:
> PLL control setting(RRC) is needed only in fixed PHY configuration to
> fix the peer-peer issues. Without the PLL control setting, the link up
> takes longer time in a fixed phy configuration.
>
> Without the fix the user will not get the link come U
On 5/7/2024 1:43 PM, Venkat Kumar Ande wrote:
> In the event of a change in AXGBE mode, the current auto-negotiation
> needs to be reset and the AN cycle needs to be re-triggered. However,
> the current code ignores the return value of axgbe_set_mode(), leading to
> false information as the link is
On 5/7/2024 1:43 PM, Venkat Kumar Ande wrote:
> The axgbe driver reuses MII_ADDR_C45 for its own purpose. The values
> derived with it are never passed to phylib or a linux MDIO bus driver.
> In order that MII_ADDR_C45 can be removed, add an AXGBE specific
>
Last sentences feels like it is not fin
On 5/7/2024 1:42 PM, Venkat Kumar Ande wrote:
> The XGBE supports performing MDIO operations using an MDIO command
> request. The driver mistakenly uses the mdio port address as the
> MDIO command request device address instead of the MDIO command
> request port address. Additionally, the driver do
On 5/1/2024 8:43 AM, Morten Brørup wrote:
>> From: Alan Elder [mailto:alan.el...@microsoft.com]
>> Sent: Monday, 15 April 2024 16.41
>>
>> The previous code allowed the number of Tx queues to be set higher than the
>> number of Rx queues. If a packet was sent on a Tx queue with index
>>> = number
I've been running some local tests using a mock test suite. Each
method you created generates output as expected, but
show_port_stats_all() is printing out an empty list; I'm not sure this
is intentional or not. I don't have much experience with regular
expressions to be able to discern what is goi
While the queue/rss action was added to sample action lists,
the rx hash queue resource was allocated in the sample action
translation to create the sample DR action later.
While there's a failure in the flow creation, the Rx hash queue
resource of the sample action list was destroyed in the wrong
Acked-by: Nicholas Pratte
On Thu, May 9, 2024 at 5:59 AM Luca Vizzarro wrote:
>
> On 01/05/2024 17:16, jspew...@iol.unh.edu wrote:
> > This version addresses comments from the last and adds an additional
> > improvement to the logging output that comes from interactive shells.
> > The new way of
Ran into no issues with this when testing your port stats and info
patch, so I'll provide a tested tag as well. Other than a couple of
issues listed in dts-check-format, everything looks good.
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Tue, May 14, 2024 at 7:34 AM Luca Vizzarro
Looks good to me! Thank you for your work.
Reviewed-by: Luca Vizzarro
On 14/05/2024 21:14, jspew...@iol.unh.edu wrote:
+class CriticalInteractiveShell(InteractiveShell):
+_get_priviledged_command: Callable[[str], str] | None
typo: privileged
+
+def __init__(
+self,
+interactive_session: SSHClient,
+logger: DTSLogger,
+ge
On 14/05/2024 21:14, jspew...@iol.unh.edu wrote:
diff --git a/dts/framework/remote_session/testpmd_shell.py
b/dts/framework/remote_session/testpmd_shell.py
index 33b3e7c5a3..4e608998f9 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The check for receive queue fd in flow_isolate is incorrect.
> If queue has not been setup then fd will be -1 not 0.
>
> Signed-off-by: Stephen Hemminger
>
Acked-by: Ferruh Yigit
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The TAP device can use same file descriptor for both rx and tx queues.
> This allows up to 8 queues (versus 4) to be used with secondary process.
>
It would be nice to briefly update where this limit comes from, as
removing this limitation can be l
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The driver doesn't support these other hash types, and there
> is no reason to implement these in future. The rss_flows list
> was set but never used.
>
> Signed-off-by: Stephen Hemminger
>
Acked-by: Ferruh Yigit
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The flow RSS support via BPF was not using the key, or
> hash type parameters. Which is good because they were never
> properly setup.
>
> Fix the setup and validate the flow parameters, the BPF
> side gets fixed later.
>
> Signed-off-by: Stephen H
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The proper place for finding bpf structures and functions is
> in linux/bpf.h. The original version was trying to workaround the
> case where the build environment was running on old pre BPF
> version of Glibc, but the target environment had BPF.
>
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> There were multiple issues in the RSS queue support in the TAP
> driver. This required extensive rework of the BPF support.
>
> Change the BPF loading to use bpftool to
> create a skeleton header file, and load with libbpf.
> The BPF is always compi
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The BPF api was replaced by use of libbpf.
> And the BPF instruction header was replaced by the skeleton.
>
Mentioned 'skeleton' here is auto generated skeleton header file
'tap_rss.skel.h', right? Should we elaborate this?
> Signed-off-by: Steph
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The names of Linux network devices are IFNAMSIZ(16) not the
> same as DPDK which has up to 64 characters. Don't need to
> hold onto the whole ifreq to save the remote interface flags.
>
> Make sure packet and byte counters are read once, so that glo
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> Some log messages contained extra newlines.
>
> Signed-off-by: Stephen Hemminger
>
Acked-by: Ferruh Yigit
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> If tap device in kernel returns EAGAIN that means it is full.
> That is not an error.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/tap/rte_eth_tap.c | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git
On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> The driver support of flows has changed and the wording in
> the guide was awkward.
>
> Drop references to DPDK pktgen in this documentation since
> it is not required and confusing.
>
> Signed-off-by: Stephen Hemminger
> ---
> doc/guides/nics/ta
On 14/05/2024 21:14, jspew...@iol.unh.edu wrote:
+# adjust the MTU of the SUT ports
+testpmd.set_port_mtu(0, 9000)
+testpmd.set_port_mtu(1, 9000)
should you perhaps do this for every port in the testpmd shell instead?
for port_id in range(testpmd.number_of
On Mon, 20 May 2024 18:46:30 +0100
Ferruh Yigit wrote:
> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> > The TAP device can use same file descriptor for both rx and tx queues.
> > This allows up to 8 queues (versus 4) to be used with secondary process.
> >
>
> It would be nice to briefly u
On Mon, 20 May 2024 18:49:19 +0100
Ferruh Yigit wrote:
> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> > There were multiple issues in the RSS queue support in the TAP
> > driver. This required extensive rework of the BPF support.
> >
> > Change the BPF loading to use bpftool to
> > create a
On Mon, 20 May 2024 04:44:15 +
Shaiq Wani wrote:
> +static uint8_t
> +get_running_host_id(void)
> +{
> + char buf[BUFSIZ];
> + FILE *fd;
> + uint8_t host_id = CPFL_INVALID_HOST_ID;
> +
> + fd = fopen("/etc/issue.net", "r");
> + if (fd == NULL) {
> + PMD_INIT_LO
> On May 15, 2024, at 5:54 AM, Abdullah Ömer Yamaç wrote:
>
> This patch adds a new feature to the hash library to allow the user to
> reclaim the defer queue. This is useful when the user wants to force
> reclaim resources that are not being used. This API is only available
> if the RCU is ena
20/05/2024 17:39, Stephen Hemminger:
> On Mon, 20 May 2024 10:53:07 +0100
> Luca Boccassi wrote:
>
> > On Sun, 19 May 2024 at 22:11, Thomas Monjalon wrote:
> > >
> > > 19/05/2024 19:23, Luca Boccassi:
> > > > On Sun, 19 May 2024 at 18:13, Thomas Monjalon
> > > > wrote:
> > > > >
> > > > >
On Mon, 20 May 2024 at 19:43, Stephen Hemminger
wrote:
>
> On Mon, 20 May 2024 18:49:19 +0100
> Ferruh Yigit wrote:
>
> > On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> > > There were multiple issues in the RSS queue support in the TAP
> > > driver. This required extensive rework of the BPF sup
On 5/20/2024 7:18 PM, Stephen Hemminger wrote:
> On Mon, 20 May 2024 18:49:19 +0100
> Ferruh Yigit wrote:
>
>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
>>> There were multiple issues in the RSS queue support in the TAP
>>> driver. This required extensive rework of the BPF support.
>>>
>>> C
On 5/20/2024 10:42 PM, Luca Boccassi wrote:
> On Mon, 20 May 2024 at 19:43, Stephen Hemminger
> wrote:
>>
>> On Mon, 20 May 2024 18:49:19 +0100
>> Ferruh Yigit wrote:
>>
>>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
There were multiple issues in the RSS queue support in the TAP
dri
On 4/19/2024 6:23 AM, Chaoyong He wrote:
> Refactor data structure and related logic to make the secondary process
> can work as expect.
>
Hi Chaoyong,
Patchset looks good, but I have a question related to the motivation of
moving so many structs to process private data?
Normally ethdev is proc
On 4/25/2024 4:03 PM, Loftus, Ciara wrote:
>> Subject: [v1 1/1] MAINTAINERS: add another AF_XDP maintainer
>>
>> Add Maryam Tahhan as an additional maintainer for AF_XDP
>> PMD and it's documentation.
>>
>> Signed-off-by: Maryam Tahhan
>
> Thanks Maryam.
>
> Acked-by: Ciara Loftus
>
Acked-by:
On 5/14/2024 9:41 AM, Ciara Loftus wrote:
> Series of fixes for the AF_XDP PMD.
>
> Ciara Loftus (4):
> net/af_xdp: fix port ID not set in Rx mbuf
> net/af_xdp: fix mbuf alloc failed statistic
> net/af_xdp: fix stats reset
> net/af_xdp: remove unused local statistic
>
> drivers/net/af_xd
On Mon, 20 May 2024 at 23:08, Ferruh Yigit wrote:
>
> On 5/20/2024 10:42 PM, Luca Boccassi wrote:
> > On Mon, 20 May 2024 at 19:43, Stephen Hemminger
> > wrote:
> >>
> >> On Mon, 20 May 2024 18:49:19 +0100
> >> Ferruh Yigit wrote:
> >>
> >>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
>
https://bugs.dpdk.org/show_bug.cgi?id=1446
Bug ID: 1446
Summary: Fortify warnings in rte_pcapng
Product: DPDK
Version: 24.03
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: minor
Priority: No
On Mon, 20 May 2024 23:08:04 +0100
Ferruh Yigit wrote:
> >
> > It can be done, but it is a _lot_ of work and requires a lot of shims,
> > so for something optional it's not really worth it. Given libbpf 1.0
> > also broke ABI, Ubuntu 22.04 and older cannot really get a new version
> > as it's in
On 5/14/2024 9:41 AM, Ciara Loftus wrote:
> The imissed statistic was not properly reset because it was
> read directly from the kernel statistics. To fix this, take note
> of the kernel statistic when the stats are reset and deduct this
> value from the kernel statistic read during statistics get.
When adding option with no data, the rte_pcapng_add_option would
call memcpy with src of NULL and size of zero. This generates a
warning if fortify is enabled.
Bugzilla ID: 1446
Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files")
Signed-off-by: Stephen Hemminger
---
lib/pca
If fortify is enabled, it will generate a warning if memcpy
src is NULL even if size is zero. This happens if the MP message
sync is called with no file descriptors.
Bugzilla ID 1446
Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer")
Signed-off-by: Stephen Hemminger
---
drive
> On 4/19/2024 6:23 AM, Chaoyong He wrote:
> > Refactor data structure and related logic to make the secondary
> > process can work as expect.
> >
>
> Hi Chaoyong,
>
> Patchset looks good, but I have a question related to the motivation of moving
> so many structs to process private data?
>
> No
Spread the word, registration is now open for the DPDK Summit APAC in
Bangkok!
🔗 Register here: https://lnkd.in/gu4zvXf
Join us in-person for a gathering of DPDK developers and enthusiasts at the
DPDK Summit APAC. Connect with the community, get the latest technological
advancements, and contri
On Mon, 20 May 2024 18:53:19 +0100
Ferruh Yigit wrote:
> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
> > The driver support of flows has changed and the wording in
> > the guide was awkward.
> >
> > Drop references to DPDK pktgen in this documentation since
> > it is not required and confusin
The check for receive queue fd in flow_isolate is incorrect.
If queue has not been setup then fd will be -1 not 0.
Signed-off-by: Stephen Hemminger
Acked-by: Ferruh Yigit
---
drivers/net/tap/tap_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/tap_flow.
The support of doing RSS for rte_flow_action was a cool idea
but it has been broken for several releases of DPDK as the
underlying kernel and BPF infrastructure changed.
This series cleans up the BPF program, implements several
features that were never completed in the original code
and changes to
The TAP device can use same file descriptor for both rx and tx queues
which reduces the number of fd's required.
MP process support passes file descriptors from primary
to secondary process; but because of the restriction on
max fd's passed RTE_MP_MAX_FD_NUM (8) the TAP device was restricted
to on
The driver doesn't support these other hash types, and there
is no reason to implement these in future. The rss_flows list
was set but never used.
Signed-off-by: Stephen Hemminger
Acked-by: Ferruh Yigit
---
drivers/net/tap/rte_eth_tap.h | 4 +---
drivers/net/tap/tap_flow.c| 1 -
drivers/net
The flow RSS support via BPF was not using the key, or
hash type parameters. Which is good because they were never
properly setup.
Fix the setup and validate the flow parameters, the BPF
side gets fixed later.
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/tap_flow.c | 75
The proper place for finding bpf structures and functions is
in linux/bpf.h. The original version was trying to workaround the
case where the build environment was running on old pre BPF
version of Glibc, but the target environment had BPF.
Having own private (and divergent) version headers leads
Rewrite of the BPF program used to do queue based RSS.
Important changes:
- uses newer BPF map format BTF
- accepts key as parameter rather than constant default
- can do L3 or L4 hashing
- supports IPv4 options
- supports IPv6 extension headers
- re
There were multiple issues in the RSS queue support in the TAP
driver. This required extensive rework of the BPF support.
Change the BPF loading to use bpftool to
create a skeleton header file, and load with libbpf.
The BPF is always compiled from source so less chance that
source and instructions
The names of Linux network devices are IFNAMSIZ(16) not the
same as DPDK which has up to 64 characters. Don't need to
hold onto the whole ifreq to save the remote interface flags.
Make sure packet and byte counters are read once, so that global
and per-queue values add up. No need for separate rx_
The BPF api was replaced by use of libbpf.
And the BPF instruction header is replaced by the new
tap_rss.skel.h which is generated via bpftool.
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/tap_bpf_api.c | 196
drivers/net/tap/tap_bpf_insns.h | 1741 ---
Some log messages contained extra newlines.
Signed-off-by: Stephen Hemminger
Acked-by: Ferruh Yigit
---
drivers/net/tap/rte_eth_tap.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 3614aaf
The driver support of flows has changed and the wording in
the guide was awkward.
Drop references to DPDK pktgen in this documentation since
it is not required, confusing and abandoned.
Signed-off-by: Stephen Hemminger
---
doc/guides/nics/tap.rst | 274 +++-
On Mon, May 20, 2024 at 1:49 PM Ferruh Yigit wrote:
>
> @Patric, I assume test environment also doesn't have 'libbpf', version:
> '>= 1.0' which we need to test this feature.
> Is it possible to update test environment to justify this dependency?
>
Hi, the libbpf version on our Ubuntu 22.04 conta
92 matches
Mail list logo
