RE: [RFC v2] net/af_packet: make stats reset reliable

2024-05-08 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 8 May 2024 08.35 > > On 2024-05-07 21:19, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Tuesday, 7 May 2024 09.24 > >> > >> On 2024-04-28 17:11, Mattias Rönnblom wrote: > >>> On

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-05-08 Thread Mattias Rönnblom
On 2024-05-04 00:00, Stephen Hemminger wrote: On Fri, 3 May 2024 16:45:47 +0100 Ferruh Yigit wrote: For stats reset, use an offset instead of zeroing out actual stats values, get_stats() displays diff between stats and offset. This way stats only updated in datapath and offset only updated in

Re: [RFC v2] net/af_packet: make stats reset reliable

2024-05-08 Thread Mattias Rönnblom
On 2024-05-08 09:10, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 8 May 2024 08.35 On 2024-05-07 21:19, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Tuesday, 7 May 2024 09.24 On 2024-04-28 17:11, Mattias Rönnblo

RE: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 8 May 2024 08.47 > > On 2024-05-07 21:17, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Sunday, 5 May 2024 10.38 > >> > >> Add test/set/clear/assign/flip functions which

Re: [RFC v2] net/af_packet: make stats reset reliable

2024-05-08 Thread Mattias Rönnblom
On 2024-05-07 18:00, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Tuesday, 7 May 2024 16.51 I would prefer that the SW statistics be handled generically by ethdev layers and used by all such drivers. I agree. Please note that maintaining counters in

Re: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Mattias Rönnblom
On 2024-05-08 09:33, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 8 May 2024 08.47 On 2024-05-07 21:17, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Sunday, 5 May 2024 10.38 Add test/set/clear/assign/fli

RE: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 8 May 2024 10.00 > > On 2024-05-08 09:33, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Wednesday, 8 May 2024 08.47 > >> > >> On 2024-05-07 21:17, Morten Brørup wrote: > Fro

[PATCH] dma/hisilicon: remove support for HIP09 platform

2024-05-08 Thread Chengwen Feng
The DMA for HIP09 is no longer available, so delete it. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- doc/guides/dmadevs/hisilicon.rst | 1 - doc/guides/rel_notes/release_24_07.rst | 2 ++ drivers/dma/hisilicon/hisi_dmadev.c| 40 +- drivers/dma/hisilic

Re: [PATCH v4 0/6] refine argparse library

2024-05-08 Thread fengchengwen
Hi Thomas, On 2024/3/22 1:27, Thomas Monjalon wrote: > 18/03/2024 12:18, Chengwen Feng: >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: refine error message >> argparse: remove dead code >> argparse:

Re: [PATCH v3 0/7] fix race-condition of proactive error handling mode

2024-05-08 Thread fengchengwen
Hi Ferruh, This patchset fixes potentially race-condition, could you help review and merge? Thanks On 2024/2/18 11:41, fengchengwen wrote: > Hi Ferruh, > > This patchset will modify lib/ethdev/, Could you help review it before RC1? > > Thanks > > On 2024/1/29 9:16, fengchengwen wrote: >> Hi F

Re: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Mattias Rönnblom
On 2024-05-08 10:11, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 8 May 2024 10.00 On 2024-05-08 09:33, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Wednesday, 8 May 2024 08.47 On 2024-05-07 21:17, Morten Brørup

Re: 23.11.1 patches review and test

2024-05-08 Thread YangHang Liu
RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M hugepage size) : PASS - VM with device assignment(VF) throughput test

[PATCH] eal/unix: support ZSTD compression for firmwares

2024-05-08 Thread David Marchand
Ubuntu 24.04 started to compress firmwares with ZSTD compression. Bugzilla ID: 1437 Signed-off-by: David Marchand --- lib/eal/unix/eal_firmware.c | 42 + 1 file changed, 33 insertions(+), 9 deletions(-) diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix

RE: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 8 May 2024 11.27 > > On 2024-05-08 10:11, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Wednesday, 8 May 2024 10.00 > >> > >> On 2024-05-08 09:33, Morten Brørup wrote: > Fro

Re: [PATCH] eal/unix: support ZSTD compression for firmwares

2024-05-08 Thread Bruce Richardson
On Wed, May 08, 2024 at 11:52:14AM +0200, David Marchand wrote: > Ubuntu 24.04 started to compress firmwares with ZSTD compression. > > Bugzilla ID: 1437 > > Signed-off-by: David Marchand > --- > lib/eal/unix/eal_firmware.c | 42 + > 1 file changed, 33 insert

[dpdk-dev] [PATCH] common/cnxk: fix flow aging cleanup

2024-05-08 Thread psatheesh
From: Satheesh Paul The aged flows poll thread is not stopped before NPC cleanup resulting in a segmentation fault. Fixing this by stopping aged flows poll thread before proceeding with NPC cleanup. Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging") Cc: sta...@dpdk.org Signed-off-by: Sathe

Re: 23.11.1 patches review and test

2024-05-08 Thread Xueming Li
Hi YangHang, Thanks for the verification and feedback! Best Regards, Xueming From: YangHang Liu Sent: Wednesday, May 8, 2024 5:49 PM To: Xueming Li Cc: sta...@dpdk.org ; dev@dpdk.org ; Abhishek Marathe ; Ali Alnubani ; David Christensen ; Hemant Agrawal ; Ian

Compiling error using make for pktgen, libfgen not found

2024-05-08 Thread Florian Düsing
Dear Developers of dpdk and pktgen, I try to use pktgen for my Bachelor Thesis where I want to create a Penetration- and Loadtester for Firewalls. But I encountered numerous problems and hoped you could help me out. To sort the problems: 1. I want to use the newest pktgen version, instead of 22.0

Re: [RFC PATCH] eal/riscv: add support for zawrs extension

2024-05-08 Thread Stanisław Kardach
I'm terribly sorry for the delay in review. I'll try to get to it in the next 2 days. On Thu, May 2, 2024 at 4:44 PM Daniel Gregory wrote: > > The zawrs extension adds a pair of instructions that stall a core until > a memory location is written to. This patch uses one of them to > implement RISC

DPDK Summit APAC - CFP

2024-05-08 Thread Thomas Monjalon
The next DPDK Summit will take place in Bangkok, Thailand for 2 days: July 9-10. All details can be found at https://events.linuxfoundation.org/dpdk-summit-apac Sessions will be recorded and live-streamed. Participating in-person is a unique opportunity to meet community members. We are

Re: Compiling error using make for pktgen, libfgen not found

2024-05-08 Thread Bruce Richardson
On Wed, May 08, 2024 at 12:57:26PM +0200, Florian Düsing wrote: > Dear Developers of dpdk and pktgen, > > I try to use pktgen for my Bachelor Thesis where I want to create a > Penetration- and Loadtester for Firewalls. But I encountered numerous > problems and hoped you could help me out. > To sor

Re: [PATCH] eal/unix: support ZSTD compression for firmwares

2024-05-08 Thread Bruce Richardson
On Wed, May 08, 2024 at 11:50:02AM +0100, Bruce Richardson wrote: > On Wed, May 08, 2024 at 11:52:14AM +0200, David Marchand wrote: > > Ubuntu 24.04 started to compress firmwares with ZSTD compression. > > Minor nit, "firmware" doesn't really have a plural in English. I'd suggest using "firmware

Re: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Stephen Hemminger
On Wed, 8 May 2024 09:33:43 +0200 Morten Brørup wrote: > > What more specifically did you have in mind? READ_ONCE() and > > WRITE_ONCE()? They give almost no guarantees. Very much relaxed. > > The way I read it, they do provide memory ordering guarantees. > > Ignore that the kernel's "once" f

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-05-08 Thread Stephen Hemminger
On Wed, 8 May 2024 09:19:02 +0200 Mattias Rönnblom wrote: > On 2024-05-04 00:00, Stephen Hemminger wrote: > > On Fri, 3 May 2024 16:45:47 +0100 > > Ferruh Yigit wrote: > > > >> For stats reset, use an offset instead of zeroing out actual stats values, > >> get_stats() displays diff between st

RE: [PATCH 2/2] maintainers: update for crypto performance

2024-05-08 Thread Dooley, Brian
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Tuesday, May 7, 2024 12:18 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Dooley, Brian > ; gak...@marvell.com; tho...@monjalon.net; > Power, Ciara > Subject: [PATCH 2/2] maintainers: update for crypto performance > > Replacin

RE: [RFC v7 3/6] eal: add exactly-once bit access functions

2024-05-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 May 2024 17.16 > > On Wed, 8 May 2024 09:33:43 +0200 > Morten Brørup wrote: > > > > What more specifically did you have in mind? READ_ONCE() and > > > WRITE_ONCE()? They give almost no guarantees. Very much relaxe

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-05-08 Thread Ferruh Yigit
On 5/8/2024 4:23 PM, Stephen Hemminger wrote: > On Wed, 8 May 2024 09:19:02 +0200 > Mattias Rönnblom wrote: > >> On 2024-05-04 00:00, Stephen Hemminger wrote: >>> On Fri, 3 May 2024 16:45:47 +0100 >>> Ferruh Yigit wrote: >>> For stats reset, use an offset instead of zeroing out actual st

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-05-08 Thread Stephen Hemminger
On Wed, 8 May 2024 20:48:06 +0100 Ferruh Yigit wrote: > > > > The idea of load tearing is crazy talk of integral types. It would break so > > many things. > > It is the kind of stupid compiler thing that would send Linus on a rant and > > get > > the GCC compiler writers in trouble. > > > >

[PATCH v4] devtools: add .clang-format file

2024-05-08 Thread Abdullah Ömer Yamaç
clang-format is a tool to format C/C++/Objective-C code. It can be used to reformat code to match a given coding style, or to ensure that code adheres to a specific coding style. It helps to maintain a consistent coding style across the DPDK codebase. .clang-format file overrides the default style

Re: [RFC] graph/node: feedback and future improvements

2024-05-08 Thread Robin Jarry
Hi Jerin, Jerin Jacob, May 04, 2024 at 12:03: 2) Control plane code: IMO, if you are willing, I will be glad to see it is hosted at https://www.dpdk.org/hosted-projects/ like pktgen. This may attract more developers for control plane code for brouter and show good reference of using