On Wed, May 08, 2024 at 11:50:02AM +0100, Bruce Richardson wrote: > On Wed, May 08, 2024 at 11:52:14AM +0200, David Marchand wrote: > > Ubuntu 24.04 started to compress firmwares with ZSTD compression. > >
Minor nit, "firmware" doesn't really have a plural in English. I'd suggest using "firmware files" here rather than "firmwares". > > Bugzilla ID: 1437 > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > lib/eal/unix/eal_firmware.c | 42 +++++++++++++++++++++++++++++-------- > > 1 file changed, 33 insertions(+), 9 deletions(-) > > > > diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c > > index 1d47e879c8..065e251f9d 100644 > > --- a/lib/eal/unix/eal_firmware.c > > +++ b/lib/eal/unix/eal_firmware.c > > @@ -16,6 +16,21 @@ > > #include "eal_firmware.h" > > #include "eal_private.h" > > > > +#ifndef RTE_HAS_LIBARCHIVE > > +/* Fake definitions for the compression_algorithms array below. */ > > +struct archive; > > +extern int archive_read_support_filter_xz(struct archive *a); > > +extern int archive_read_support_filter_zstd(struct archive *a); > > +#endif > > + > > Do these not lead to unresolved symbols on link? > Confirmed; in my tests, I do get unresolved symbols on linking without libarchive. On the plus side, this does fix the issues when libarchive-dev package is installed. /Bruce
