[PATCH v7] ethdev: fix strict aliasing lead to link cannot be up

2024-04-18 Thread Chengwen Feng
Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3), which will lead the hns3 NIC can't link up. The root cause is strict aliasing violation in rte_eth_linkstatus_set() with hns3 driver, see [1] for more details. This commit use union to avoid such aliasing violation. Note: DPD

[PATCH v3 0/7] Fix outer UDP checksum for Intel nics

2024-04-18 Thread David Marchand
This series aims at fixing outer UDP checksum for Intel nics (i40e and ice). The net/hns3 is really similar in its internals and has been aligned. As I touched testpmd csumonly engine, this series may break other vendors outer offloads, so please vendors, review and test this ASAP. Thanks. --

[PATCH v3 1/7] net/ice: fix check for outer UDP checksum offload

2024-04-18 Thread David Marchand
ICE_TX_CTX_EIPT_NONE == 0. There is a good chance that !(anything & 0) is true :-). While removing this noop check is doable, let's check that the descriptor does contain a outer ip type. Fixes: 2ed011776334 ("net/ice: fix outer UDP Tx checksum offload") Signed-off-by: David Marchand Reviewed-b

[PATCH v3 2/7] net/ice: enhance debug when HW fails to transmit

2024-04-18 Thread David Marchand
At the moment, if the driver sets an incorrect Tx descriptor, the HW will raise a MDD event reported as: ice_interrupt_handler(): OICR: MDD event Add some debug info for this case. Signed-off-by: David Marchand --- Changes since v2: - dropped VF index from logs, --- drivers/net/ice/ice_ethdev.

[PATCH v3 3/7] app/testpmd: fix outer IP checksum offload

2024-04-18 Thread David Marchand
Resetting the outer IP checksum to 0 is not something mandated by the mbuf API and is done by rte_eth_tx_prepare(), or per driver if needed. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/csumonly.c | 10 ++ 1 file c

[PATCH v3 4/7] net: fix outer UDP checksum in Intel prepare helper

2024-04-18 Thread David Marchand
Setting a pseudo header checksum in the outer UDP checksum is a Intel (and some other vendors) requirement. Applications (like OVS) requesting outer UDP checksum without doing this extra setup have broken outer UDP checksums. Move this specific setup from testpmd to the "common" helper rte_net_int

[PATCH v3 5/7] net/i40e: fix outer UDP checksum offload for X710

2024-04-18 Thread David Marchand
According to the X710 datasheet (and confirmed on the field..), X710 devices do not support outer checksum offload. """ 8.4.4.2 Transmit L3 and L4 Integrity Offload Tunneling UDP headers and GRE header are not offloaded while the X710/XXV710/XL710 leaves their checksum field as is. If a checksum

[PATCH v3 6/7] net/iavf: remove outer UDP checksum offload for X710 VF

2024-04-18 Thread David Marchand
According to the X710 datasheet, X710 devices do not support outer checksum offload. """ 8.4.4.2 Transmit L3 and L4 Integrity Offload Tunneling UDP headers and GRE header are not offloaded while the X710/XXV710/XL710 leaves their checksum field as is. If a checksum is required, software should pr

[PATCH v3 7/7] net: clear outer UDP checksum in Intel prepare helper

2024-04-18 Thread David Marchand
If requesting an inner (L3/L4 checksum or L4 segmentation) offload, when the hardware does not support recomputing outer UDP checksum, automatically disable it in the common helper. Signed-off-by: David Marchand --- Changes since v2: - fixed GRE tunneling, - dropped documentation update, --- ap

[RFC 0/6] core libs: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev This RFC is submitted as part of ongoing VLA removal discussion: https://patchwork.dpdk.org/project/dpdk/list/?series=31680 The main aim is to explore amount of code changes that would be required for that, plus explore alternate approaches instead of simple replacing VL

[RFC 1/6] eal/linux: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16: warning: ISO C90 forbids variable length array ‘events’ [-Wvla] eal_intr_handle_interrupts() is called by eal_intr_thread_main() so it seems ok to simply alloc space for events from heap and reuse the same buffer through the

[RFC 2/6] eal/common: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15: warning: variable length array used [-Wvla] char control[CMSG_SPACE(fd_size)]; ^~~ As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed

[RFC 3/6] ethdev: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16: warning: ISO C90 forbids variable length array ‘xstats_names’ [-Wvla] 2) ./lib/ethdev/rte_ethdev.c:3345:17: warning: ISO C90 forbids variable length array ‘ids_copy’ [-Wvla] 3) ./lib/ethdev/rte_ethdev.c:3538:16: warning: ISO C90 for

[RFC 4/6] hash: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9: warning: ISO C90 forbids variable length array ‘positions’ [-Wvla] 2) ../lib/hash/rte_cuckoo_hash.c:2478:9: warning: ISO C90 forbids variable length array ‘positions’ [-Wvla] Both rte_hash_lookup_bulk_data() and rte_hash_lookup_w

[RFC 5/6] hash/thash: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9: warning: ISO C90 forbids variable length array ‘tmp_tuple’ [-Wvla] >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Kons

[RFC 6/6] rcu: remove VLA warnings

2024-04-18 Thread Konstantin Ananyev
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9: warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9: warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred queue. Righ

Re: [PATCH v3] mailmap: clean up vmware entries

2024-04-18 Thread Ferruh Yigit
On 4/17/2024 5:19 PM, Jochen Behrens wrote: > VMware was acquired by Broadcom, and vmware e-mail addresses will > be invalid in the future. > > Add broadcom.com addresses for those still in the company. > Place broadcom.com addresses first, as they are now the active ones. > Retain the old address

Re: [PATCH 4/5] dts: add `show port info` command to TestPmdShell

2024-04-18 Thread Luca Vizzarro
On 18/04/2024 07:41, Juraj Linkeš wrote: The equivalent /\n\*.+?(?=\n\*|$)/gs (but slightly more optimised) takes approximately 3*input_length steps to run (according to regex101 at least). If that's reasonable enough, I can do this: iter = re.finditer(input, "\n\*.+?(?=\n\*|$)", re.S) r

RE: [PATCH 00/16] remove use of VLAs for Windows built code

2024-04-18 Thread Konstantin Ananyev
Hi Tyler, > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the details for incorporation > into the series. I s

21.11.7 patches review and test

2024-04-18 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for stable release 21.11.7. The planned date for the final release is 30th April. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validatio

net/ixgbe: all interrupt disabled after enabling lsc on X552/X557-AT card

2024-04-18 Thread Edwin Brossette
Hello, I have found a bug in the ixgbe pmd, concerning this model of nic in particular: -> Intel Corporation Ethernet Connection X552/X557-AT 10GBASE-T I was able to detect this bug after enabling the use of Link state change interrupt in the card via the following flag: - port->rte_conf

[PATCH] net/ixgbe: don't create a delayed interrupt handler if one already exists

2024-04-18 Thread edwin . brossette
From: Edwin Brossette Since link state may need some time to stabilize after a link state change, we cannot update the link state right after one occurs. So link state change interrupts (lsc) are handled after a delay. To do this, an alarm to call a delayed handler is programmed. This delayed han

Re: 22.11.5 patches review and test

2024-04-18 Thread Luca Boccassi
On Wed, 17 Apr 2024 at 13:41, Ali Alnubani wrote: > > > -Original Message- > > From: luca.bocca...@gmail.com > > Sent: Thursday, April 4, 2024 2:11 AM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; benjamin.wal...@intel.com; David > > Christensen ; Hem

DPDK Release Status Meeting 2024-04-18

2024-04-18 Thread Mcnamara, John
Release status meeting minutes 2024-04-18 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Red Hat Release Dates - The following are the current/updated working date

Re: [PATCH 16/16] build: enable vla warnings on Windows built code

2024-04-18 Thread Tyler Retzlaff
On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > MSVC does not support optional C11 VLAs. When building for Windows > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > Minor detail, doesn't affect my Ack for the series... > > Applications built for Windows w

Re: [PATCH 00/16] remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
On Thu, Apr 18, 2024 at 12:11:35PM +, Konstantin Ananyev wrote: > Hi Tyler, > > > As per guidance technical board meeting 2024/04/17. This series > > removes the use of VLAs from code built for Windows for all 3 > > toolchains. If there are additional opportunities to convert VLAs > > to regul

Re: [PATCH 16/16] build: enable vla warnings on Windows built code

2024-04-18 Thread Bruce Richardson
On Thu, Apr 18, 2024 at 08:12:26AM -0700, Tyler Retzlaff wrote: > On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > > MSVC does not support optional C11 VLAs. When building for Windows > > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > > > Minor detail, doe

[DPDK/other Bug 1417] RTE_FLOW not matching UDP ports in head fragments

2024-04-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1417 Bug ID: 1417 Summary: RTE_FLOW not matching UDP ports in head fragments Product: DPDK Version: 24.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [PATCH v2] app/testpmd: fix closing softnic port before ethdev ports

2024-04-18 Thread Ferruh Yigit
On 3/9/2023 4:02 PM, Yogesh Jangra wrote: > SoftNIC runs on the service core, it uses the resources from > the testpmd application. When we run quit command, the testpmd > application stops ethdev ports first, SoftNIC will try to > access the port and sometimes that results in segmentation > error.

RE: [PATCH 00/16] remove use of VLAs for Windows built code

2024-04-18 Thread Konstantin Ananyev
> On Thu, Apr 18, 2024 at 12:11:35PM +, Konstantin Ananyev wrote: > > Hi Tyler, > > > > > As per guidance technical board meeting 2024/04/17. This series > > > removes the use of VLAs from code built for Windows for all 3 > > > toolchains. If there are additional opportunities to convert VLA

Re: [PATCH v6] app/testpmd: enable cli for programmable action

2024-04-18 Thread Ferruh Yigit
On 2/8/2024 1:10 AM, Ferruh Yigit wrote: > On 10/11/2023 1:03 PM, Qi Zhang wrote: >> Parsing command line for rte_flow_action_prog. >> >> Syntax: >> >> "prog name [arguments \ >>... end]" >> >> Use parse_string0 to parse name string. >> Use parse_hex to parse hex string. >> Use struct action

[PATCH v4] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-18 Thread Nicholas Pratte
The previous implementation configures and allocates hugepage sizes based on a system default. This can lead to two problems: overallocation of hugepages (which may crash the remote host), and configuration of hugepage sizes that are not recommended during runtime. This new implementation allows on

[PATCH] common/qat: add legacy algorithm option

2024-04-18 Thread Arkadiusz Kusztal
This commit adds legacy algorithms flag to the qat_device struct. This will allow handling this flag within the device itself, and not using the global variable. Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_common.h | 9 + drivers/common/qat/qat_device.c

Community CI Meeting Minutes - April 18, 2024

2024-04-18 Thread Patrick Robb
April 18, 2024 # Attendees 1. Patrick Robb 2. Paul Szczepanek 3. Juraj Linkeš 4. Aaron Conole 5. Ali Alnubani # Minutes

RE: [PATCH 16/16] build: enable vla warnings on Windows built code

2024-04-18 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 18 April 2024 17.24 > > On Thu, Apr 18, 2024 at 08:12:26AM -0700, Tyler Retzlaff wrote: > > On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > > > MSVC does not support optional C11 VLAs. When building f

[PATCH v2 01/19] eal: include header required for alloca

2024-04-18 Thread Tyler Retzlaff
Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/linux/incl

[PATCH v2 00/19] remove use of VLAs for Windows

2024-04-18 Thread Tyler Retzlaff
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v2 04/19] ethdev: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v2 03/19] eal/common: remove use of VLAs

2024-04-18 Thread Tyler Retzlaff
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

[PATCH v2 02/19] eal/linux: remove use of VLAs

2024-04-18 Thread Tyler Retzlaff
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ eal_intr_handle_interrupts() is called by eal_intr_thread_main() so it seems ok to simply alloc space for events from heap and reuse the same buffer through the life

[PATCH v2 06/19] hash/thash: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ [-Wvla] >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by:

[PATCH v2 05/19] hash: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v2 08/19] gro: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- lib/gro/rte_gro.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib

[PATCH v2 10/19] lpm: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- lib/lpm/rte_lpm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lpm

[PATCH v2 07/19] rcu: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v2 09/19] latencystats: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- lib/latencystats/rte_latencystats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v2 11/19] app/testpmd: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c| 2 +- app/test-pmd/cmdline_flow.c | 9 - app/test

[PATCH v2 12/19] test: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_string.c| 2 +-

[PATCH v2 16/19] net/ixgbe: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++-- drivers/net/ixgbe/ixgbe_rxtx_vec_common.

[PATCH v2 14/19] net/i40e: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/i40e/i40e_testpmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) d

[PATCH v2 17/19] common/mlx5: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++--

[PATCH v2 18/19] net/mlx5: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c | 6 +++--- 2 files chan

[PATCH v2 13/19] common/idpf: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/idpf/idpf_common_rxtx.c| 2 +- drivers/common/idpf/idpf_common_rxtx_av

[PATCH v2 15/19] net/ice: remove use of VLAs for Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/ice/ice_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 19/19] build: enable vla warnings on Windows built code

2024-04-18 Thread Tyler Retzlaff
MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meson.build index 8c8b019..

Re: [PATCH v2] app/testpmd: fix releasing action handle flush memory

2024-04-18 Thread Ferruh Yigit
On 3/25/2024 10:58 AM, Bing Zhao wrote: > The memory of the indirect action handles should be freed after > being destroyed in the flush. The behavior needs to be consistent > with the single handle destroy port_action_handle_destroy(). > > Or else, there would be some memory leak when closing / d

Re: [v14 0/3] net/af_xdp: fix multi interface support for K8s

2024-04-18 Thread Ferruh Yigit
Recheck-request: iol-unit-arm64-testing On 4/8/2024 2:09 PM, Maryam Tahhan wrote: > The original `use_cni` implementation was limited to > supporting only a single netdev in a DPDK pod. This patchset > aims to fix this limitation transparently to the end user. > It will also enable compatibility w

Re: [PATCH] net/nfp: use Tx ring pointer write back

2024-04-18 Thread Ferruh Yigit
On 4/1/2024 7:56 AM, Chaoyong He wrote: > From: Long Wu > > This follows the mainline Linux kernel commit > 0dcf7f500b0a (nfp: use TX ring pointer write back) by Jakub Kicinski. > > This will speed up Tx completions, because we avoid a read from > device memory (replacing PCIe read with DMA read

Re: [PATCH 0/5] net/hns3: add some bugfix

2024-04-18 Thread Ferruh Yigit
On 4/3/2024 11:16 AM, Jie Hai wrote: > This patchset adds some bugfixes. > > Dengdui Huang (4): > net/hns3: fix offload flag of IEEE 1588 > net/hns3: fix read Rx timestamp handle > net/hns3: fix double free for Rx/Tx queue > net/hns3: fix variable overflow > > Jie Hai (1): > net/hns3: d

Re: [PATCH v2 0/2] Wangxun support vector Rx/Tx

2024-04-18 Thread Ferruh Yigit
On 4/9/2024 7:31 AM, Jiawen Wu wrote: > Add SSE/NEON vector instructions for TXGBE and NGBE driver to process > packets. > > v2: > - Add performance test results. > - Cleanup codes and rebase. > - Remove GCC "-Wcast-qual". > > Jiawen Wu (2): > net/txgbe: add vectorized functions for Rx/Tx > n

Re: [PATCH v2 2/2] net/ngbe: add vectorized functions for Rx/Tx

2024-04-18 Thread Ferruh Yigit
On 4/9/2024 7:31 AM, Jiawen Wu wrote: > --- a/drivers/net/ngbe/meson.build > +++ b/drivers/net/ngbe/meson.build > @@ -19,4 +19,10 @@ sources = files( > > deps += ['hash'] > > +if arch_subdir == 'x86' > + sources += files('ngbe_rxtx_vec_sse.c') > +elif arch_subdir == 'arm' > + sources +

Re: [PATCH] net/nfp: fix parsing non-exist meta data

2024-04-18 Thread Ferruh Yigit
On 4/15/2024 3:47 AM, Chaoyong He wrote: > From: Long Wu > > If the packet without meta data, the initialization logic of > 'meta->flags' will be skipped and lead to the wrong logic > because of 'meta->flags' has random value. > > Fix it by make sure 'meta->flags' can be initialized in any situa

[PATCH 0/8] refactor logic to support secondary process

2024-04-18 Thread Chaoyong He
Refactor data structure and related logic to make the secondary process can work as expect. Chaoyong He (8): net/nfp: fix resource leak of secondary process net/nfp: fix configuration BAR problem net/nfp: adjust the data field of Rx/Tx queue net/nfp: add the process private structure net

[PATCH 1/8] net/nfp: fix resource leak of secondary process

2024-04-18 Thread Chaoyong He
Fix one resource leak problem in the abnormal logic of secondary process. Fixes: 016141b18b3a ("net/nfp: refactor secondary process probe") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 4 +++- 1 file changed, 3

[PATCH 2/8] net/nfp: fix configuration BAR problem

2024-04-18 Thread Chaoyong He
All the configuration bars are sit in an array, and the initial logic sort all the configuration BAR from small to large based on size and index, which result all valid bars are behind the invalid bars. But the BAR alloc logic search this array from the very beginning and only try limited times (eq

[PATCH 3/8] net/nfp: adjust the data field of Rx/Tx queue

2024-04-18 Thread Chaoyong He
Adjust the data field of Rx/Tx queue structure, move the cold data back and hold position for hot data. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.h | 71 +++--- 1 file changed, 36 insertions(+), 35 delet

[PATCH 4/8] net/nfp: add the process private structure

2024-04-18 Thread Chaoyong He
Add a new data structure to hold the process private data, and modify logic to make sure only get 'pf_dev' from the process private data. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 69 +-- drivers/net/nfp

[PATCH 5/8] net/nfp: move device info data field

2024-04-18 Thread Chaoyong He
Move 'dev_info' data field from process shared data structure into process private data structure. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 9 +++-- drivers/net/nfp/flower/nfp_flower.h | 3 +-- drivers/net/nfp/nfd3/

[PATCH 6/8] net/nfp: unify CPP acquire method

2024-04-18 Thread Chaoyong He
Getting CPP from 'struct nfp_net_hw' is not right in multiple process user case. Modify the data structure and related logic to get it from process private data structure. Signed-off-by: Chaoyong He Signed-off-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c

[PATCH 7/8] net/nfp: remove ethernet device data field

2024-04-18 Thread Chaoyong He
Remove the 'eth_dev' field in process shared data 'struct nfp_net_hw', and modify the related logic. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 16 ++-- drivers/net/nfp/flower/nfp_flower.h | 2 + driver

[PATCH 8/8] net/nfp: unify port create and destroy interface

2024-04-18 Thread Chaoyong He
The interface 'rte_eth_dev_create()' and 'rte_eth_dev_destroy()' are available for both primary and secondary process. Signed-off-by: Chaoyong He Signed-off-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 31 +++-- .../net/nfp/flower/nfp_flower_represen

[PATCH v2 0/2] fix secondary process PCI UIO resource problem

2024-04-18 Thread Chaoyong He
This patch series aims to fix some problems in secondary process PCI UIO resource map logic. --- v3: * Modify logic as the comments of reviewers. --- Zerun Fu (2): bus/pci: fix secondary process PCI uio resource map problem bus/pci: fix secondary process save 'FD' problem drivers/bus/pci/li

[PATCH v3 1/2] bus/pci: fix secondary process PCI uio resource map problem

2024-04-18 Thread Chaoyong He
From: Zerun Fu For the primary process, the logic loops all BARs and will skip the map of BAR with an invalid physical address (0), also will assign 'uio_res->nb_maps' with the real mapped BARs number. But for the secondary process, instead of loops all BARs, the logic using the 'uio_res->nb_map'

[PATCH v3 2/2] bus/pci: fix secondary process save 'FD' problem

2024-04-18 Thread Chaoyong He
From: Zerun Fu In the previous logic the 'fd' was only saved in the primary process, but for some devices this value is also used in the secondary logic. For example, the call of 'rte_pci_find_ext_capability()' will fail in the secondary process. Fix this problem by getting and saving the value

[PATCH 0/8] refactor logic to support secondary process

2024-04-18 Thread Chaoyong He
Refactor data structure and related logic to make the secondary process can work as expect. --- v2: * Solve the build problem. --- Chaoyong He (8): net/nfp: fix resource leak of secondary process net/nfp: fix configuration BAR problem net/nfp: adjust the data field of Rx/Tx queue net/nfp:

[PATCH v2 1/8] net/nfp: fix resource leak of secondary process

2024-04-18 Thread Chaoyong He
Fix one resource leak problem in the abnormal logic of secondary process. Fixes: 016141b18b3a ("net/nfp: refactor secondary process probe") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 4 +++- 1 file changed, 3

[PATCH v2 2/8] net/nfp: fix configuration BAR problem

2024-04-18 Thread Chaoyong He
All the configuration bars are sit in an array, and the initial logic sort all the configuration BAR from small to large based on size and index, which result all valid bars are behind the invalid bars. But the BAR alloc logic search this array from the very beginning and only try limited times (eq

[PATCH v2 3/8] net/nfp: adjust the data field of Rx/Tx queue

2024-04-18 Thread Chaoyong He
Adjust the data field of Rx/Tx queue structure, move the cold data back and hold position for hot data. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.h | 71 +++--- 1 file changed, 36 insertions(+), 35 delet

[PATCH v2 4/8] net/nfp: add the process private structure

2024-04-18 Thread Chaoyong He
Add a new data structure to hold the process private data, and modify logic to make sure only get 'pf_dev' from the process private data. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 71 ++-- drivers/net/nf

[PATCH v2 5/8] net/nfp: move device info data field

2024-04-18 Thread Chaoyong He
Move 'dev_info' data field from process shared data structure into process private data structure. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 9 +++-- drivers/net/nfp/flower/nfp_flower.h | 3 +-- drivers/net/nfp/nfd3/

[PATCH v2 6/8] net/nfp: unify CPP acquire method

2024-04-18 Thread Chaoyong He
Getting CPP from 'struct nfp_net_hw' is not right in multiple process user case. Modify the data structure and related logic to get it from process private data structure. Signed-off-by: Chaoyong He Signed-off-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c

[PATCH v2 7/8] net/nfp: remove ethernet device data field

2024-04-18 Thread Chaoyong He
Remove the 'eth_dev' field in process shared data 'struct nfp_net_hw', and modify the related logic. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 16 ++-- drivers/net/nfp/flower/nfp_flower.h | 2 + driver

[PATCH v2 8/8] net/nfp: unify port create and destroy interface

2024-04-18 Thread Chaoyong He
The interface 'rte_eth_dev_create()' and 'rte_eth_dev_destroy()' are available for both primary and secondary process. Signed-off-by: Chaoyong He Signed-off-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 31 +++-- .../net/nfp/flower/nfp_flower_represen

[PATCH v3 0/7] Add ODM DMA device

2024-04-18 Thread Anoob Joseph
Add Odyssey ODM DMA device. This PMD abstracts ODM hardware unit on Odyssey SoC which can perform mem to mem copies. The hardware unit can support upto 32 queues (vchan) and 16 VFs. It supports 'fill' operation with specific values. It also supports SG mode of operation with upto 4 src pointers an

[PATCH v3 1/7] dma/odm: add framework for ODM DMA device

2024-04-18 Thread Anoob Joseph
Add framework for Odyssey ODM DMA device. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- MAINTAINERS | 6 +++ drivers/dma/meson.build | 1 + drivers/dma/odm/meson.build | 14 +++ drivers/dma/odm/odm.h

[PATCH v3 2/7] dma/odm: add hardware defines

2024-04-18 Thread Anoob Joseph
Add ODM registers and structures. Add mailbox structs as well. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm.h | 116 + drivers/dma/odm/odm_priv.h | 49

[PATCH v3 3/7] dma/odm: add dev init and fini

2024-04-18 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Add ODM device init and fini. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/meson.build | 2 +- drivers/dma/odm/odm.c| 97 drivers/d

[PATCH v3 4/7] dma/odm: add device ops

2024-04-18 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Add DMA device control ops. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm.c| 144 ++- drivers/dma/odm/odm.h| 58 ++

[PATCH v3 5/7] dma/odm: add stats

2024-04-18 Thread Anoob Joseph
From: Gowrishankar Muthukrishnan Add DMA dev stats. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm_dmadev.c | 63 ++-- 1 file changed, 61 insertions(+), 2 deletions(-) diff --g

[PATCH v3 6/7] dma/odm: add copy and copy sg ops

2024-04-18 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add ODM copy and copy SG ops. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- drivers/dma/odm/odm_dmadev.c | 236 +++ 1 file changed, 236 insertions(+) diff --git a/drive

[PATCH v3 7/7] dma/odm: add remaining ops

2024-04-18 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add all remaining ops such as fill, burst_capacity etc. Also update the documentation. Signed-off-by: Anoob Joseph Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Vidya Sagar Velumuri --- MAINTAINERS | 1 + doc/guides/dmadevs/index.rst |