On Thu, Apr 18, 2024 at 08:12:26AM -0700, Tyler Retzlaff wrote: > On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > > MSVC does not support optional C11 VLAs. When building for Windows > > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > > > Minor detail, doesn't affect my Ack for the series... > > > > Applications built for Windows with mingw and clang might use VLAs in > > the application itself. > > > > Perhaps we should let them continue doing that for now. > > i guess you mean our examples or if dpdk is configured as a sub-project? > > for examples i could explicitly suppress in examples with -Wno-vla but > that means any that use VLAs could not be built with MSVC. > > for sub-module and sub-project of dpdk i feel like these > add_project_arguments are not imparted on the application with > encapsulating project meson setup no? > > anyone know? Bruce? Stephen? > Project args are not used when building external applications - either those using DPDK as a subproject or via pkg-config. So therefore, this change should be safe. It will only impact built-in DPDK apps and examples.
/Bruce
