On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > MSVC does not support optional C11 VLAs. When building for Windows > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > Minor detail, doesn't affect my Ack for the series... > > Applications built for Windows with mingw and clang might use VLAs in the > application itself. > > Perhaps we should let them continue doing that for now.
i guess you mean our examples or if dpdk is configured as a sub-project? for examples i could explicitly suppress in examples with -Wno-vla but that means any that use VLAs could not be built with MSVC. for sub-module and sub-project of dpdk i feel like these add_project_arguments are not imparted on the application with encapsulating project meson setup no? anyone know? Bruce? Stephen? > > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > --- > > config/meson.build | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/config/meson.build b/config/meson.build > > index 8c8b019..9e887f2 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -344,6 +344,10 @@ if cc.get_id() == 'intel' > > warning_flags += '-diag-disable=@0@'.format(i) > > endforeach > > endif > > +# no VLAs in code built on Windows > > +if is_windows > > + warning_flags += '-Wvla' > > +endif > > foreach arg: warning_flags > > if cc.has_argument(arg) > > add_project_arguments(arg, language: 'c') > > -- > > 1.8.3.1 >
