Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-04-02 Thread huangdengdui
On 2024/4/2 4:07, Thomas Monjalon wrote: > 30/03/2024 12:38, huangdengdui: >> But, there are different solutions for the device to report the setting >> lane capability, as following: >> 1. Like the current patch, reporting device capabilities in speed and >>lane coupling mode. However, if w

Re: [PATCH] version: 24.07-rc0

2024-04-02 Thread Thomas Monjalon
30/03/2024 18:54, David Marchand: > Start a new release cycle with empty release notes. > Bump version and ABI minor. > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon

Re: Error in rte_eal_init() when multiple PODs over single node of K8 cluster

2024-04-02 Thread Bruce Richardson
On Mon, Apr 01, 2024 at 07:38:10AM +, Avijit Pandey wrote: >Hello Bruce, > > >Thank you for your mail! > > >I have attached the complete log that we observed. > > >Upon your suggestion, we experimented with the --in-memory option and >it worked! Since this option ena

Re: [PATCH] version: 24.07-rc0

2024-04-02 Thread David Marchand
On Tue, Apr 2, 2024 at 10:52 AM Thomas Monjalon wrote: > > 30/03/2024 18:54, David Marchand: > > Start a new release cycle with empty release notes. > > Bump version and ABI minor. > > > > Signed-off-by: David Marchand > Acked-by: Thomas Monjalon Applied, thanks. -- David Marchand

Re: [PATCH v6 1/8] net/rnp: add skeleton

2024-04-02 Thread Ferruh Yigit
On 3/29/2024 2:45 PM, 11 wrote: > Hi Ferruh, > > Thanks for your reminder, I'm sorry for that I had been work on anothing > before. > Recendly, I have been reworked on this work. It will miss on release of > v24.03. > > For another thing, I'm always confused for the secondary process call like

Re: [PATCH v1 0/2] deque: add multithread unsafe deque library

2024-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2024 08:05:41 +0200 Mattias Rönnblom wrote: > On 2024-04-02 02:47, Stephen Hemminger wrote: > > On Mon, 1 Apr 2024 22:28:52 + > > Aditya Ambadipudi wrote: > > > >> Thanks, Stephen, for the comment. > >> > >> Unfortunately, we don't have the dev setup nor the resources to tes

Re: [PATCH v7 6/6] baseband/fpga_5gnr_fec: cosmetic comment changes

2024-04-02 Thread Thomas Monjalon
08/02/2024 17:50, Hernan Vargas: > Cosmetic changes for comments. > No functional impact. > > Signed-off-by: Hernan Vargas > Reviewed-by: Maxime Coquelin Looks like this patch was missed.

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2024 16:37:39 +0800 huangdengdui wrote: > On 2024/4/2 4:07, Thomas Monjalon wrote: > > 30/03/2024 12:38, huangdengdui: > >> But, there are different solutions for the device to report the setting > >> lane capability, as following: > >> 1. Like the current patch, reporting device

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Ashish Sadanandan
Hi everyone, I've made the updates as suggested. Could someone please review the latest patchset? Not sure if I followed the new patchset instructions correctly, I've always had trouble with that part. Thanks, Ashish. On Sun, Mar 17, 2024 at 8:44 PM Ashish Sadanandan < ashish.sadanan...@gmail.com

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Bruce Richardson
On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Also updated the coding style cont

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-02 Thread Tyler Retzlaff
On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Also updated the coding style cont

[PATCH 0/4] Replace references to ifconfig in doc

2024-04-02 Thread Stephen Hemminger
Replace references to ifconfig in documentation. The ifconfig command is deprecated and has been replaced by iproute2 for 20 years. Stephen Hemminger (4): doc: remove references to ifconfig doc: replace ifconfig and brctl usage in howto doc: replace ifconfig in testpmd doc doc: replace use

[PATCH 1/4] doc: remove references to ifconfig

2024-04-02 Thread Stephen Hemminger
The ifconfig command is legacy and may not be supported in some distributions in future. Replace by current ip command in the documentation. Signed-off-by: Stephen Hemminger --- doc/guides/linux_gsg/linux_drivers.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/

[PATCH 2/4] doc: replace ifconfig and brctl usage in howto

2024-04-02 Thread Stephen Hemminger
The brctl command is deprecated and not supported on lastest distros. Ifconfig command is legacy and no longer maintained; replace it with ip commands in documentation. Signed-off-by: Stephen Hemminger --- doc/guides/howto/lm_bond_virtio_sriov.rst | 58 +++ doc/guides/howto/l

[PATCH 3/4] doc: replace ifconfig in testpmd doc

2024-04-02 Thread Stephen Hemminger
The ifconfig command is legacy and no longer maintained; replace it with equivalent ip command. Signed-off-by: Stephen Hemminger --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/do

[PATCH 4/4] doc: replace use of ifconfig in nics

2024-04-02 Thread Stephen Hemminger
The ifconfig command is BSD legacy and no longer maintained. Replace it with modern (20 year old) ip command. Signed-off-by: Stephen Hemminger --- doc/guides/nics/bnx2x.rst | 4 ++-- doc/guides/nics/cxgbe.rst | 13 ++--- doc/guides/nics/e1000em.rst | 2 +- doc/guides/nics/i40e.rst

Re: [PATCH 0/4] Replace references to ifconfig in doc

2024-04-02 Thread Bruce Richardson
On Tue, Apr 02, 2024 at 09:29:32AM -0700, Stephen Hemminger wrote: > Replace references to ifconfig in documentation. > The ifconfig command is deprecated and has been replaced by > iproute2 for 20 years. > Nit: replaced on Linux, not on BSD (or replacing ipconfig on windows!). However, given the

[PATCH] build: exclude rather than include libs in MSVC build

2024-04-02 Thread Tyler Retzlaff
Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. Signed-off-by: Tyler Retzlaff --- lib/argparse/meson.build | 6 ++ lib/dmadev/meson.build

[PATCH] build: exclude rather than include libs in MSVC build

2024-04-02 Thread Tyler Retzlaff
Some libraries that could be built with MSVC were not being built. Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds. With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile

Re: [PATCH] build: exclude rather than include libs in MSVC build

2024-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2024 09:55:48 -0700 Tyler Retzlaff wrote: > Some libraries that could be built with MSVC were not being built. > > Switch from explicit include to exclude of libs to get immediate CI > coverage of libraries that already work with MSVC Windows builds. > > Signed-off-by: Tyler Retz

[PATCH v5 0/8] net/tap: cleanups and fix BPF flow

2024-04-02 Thread Stephen Hemminger
The support of doing RSS for rte_flow_action was a cool idea but it has been broken for several releases of DPDK as the kernel and BPF infrastructure changed. This series cleans up the BPF program, implements several features that were never completed in the original code and changes to use the cu

[PATCH v5 1/8] net/tap: do not duplicate fd's

2024-04-02 Thread Stephen Hemminger
The TAP device can use same file descriptopr for both rx and tx queues. This allows up to 8 queues (versus 4). Signed-off-by: Stephen Hemminger --- drivers/net/tap/meson.build | 2 +- drivers/net/tap/rte_eth_tap.c | 197 +++--- drivers/net/tap/rte_eth_tap.h | 3

[PATCH v5 2/8] doc: fix the requirements and building of TAP flow

2024-04-02 Thread Stephen Hemminger
The build process for TAP eBPF RSS is now changed, so documentation needs to be updated. Since kernel 4.19 is the oldest current LTS supported kernel, the TAP documentation can be simplified. Any complaints about flow not working means the kernel is out of scope of current DPDK. Signed-off-by: St

[PATCH v5 3/8] net/tap: remove unused RSS hash types

2024-04-02 Thread Stephen Hemminger
The driver doesn't support these other hash types, and there is no reason to implement these in future. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_rss.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..

[PATCH v5 4/8] net/tap: validate and setup parameters for BPF RSS

2024-04-02 Thread Stephen Hemminger
The flow RSS support via BPF was not using the key, or hash type parameters. Which is good because they were never properly setup. Fix the setup and validate the flow parameters, the BPF side gets fixed later. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c | 65

[PATCH v5 5/8] net/tap: stop "vendoring" linux bpf headers

2024-04-02 Thread Stephen Hemminger
The proper place for finding bpf structures and functions is in linux/bpf.h. The original version was trying to workaround the case where the build environment was running on old pre BPF version of Glibc, but the target environment had BPF. This is not a supportable build method, and not how rest o

[PATCH v5 6/8] net/tap: rewrite the RSS BPF program

2024-04-02 Thread Stephen Hemminger
Rewrite the BPF program used to do queue based RSS. Important changes: - uses newer BPF map format BTF - accepts key as parameter rather than constant default - can do L3 or L4 hashing - supports IPv4 options - supports IPv6 extension headers - restru

[PATCH v5 7/8] net/tap: use libbpf to load new BPF program

2024-04-02 Thread Stephen Hemminger
There were multiple issues in the RSS queue support in the TAP driver. This required extensive rework of the BPF support. Change the BPF loading to use bpftool to create a skeleton header file, and load with libbpf. The BPF is always compiled from source so less chance that source and instructions

[PATCH v5 8/8] net/tap: remove no longer used files

2024-04-02 Thread Stephen Hemminger
The BPF api was replaced by use of libbpf. And the BPF instruction header was replaced by the skeleton. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_api.c | 196 drivers/net/tap/tap_bpf_insns.h | 1743 --- 2 files changed, 1939 deletions(-) de

Re: [PATCH] build: exclude rather than include libs in MSVC build

2024-04-02 Thread Tyler Retzlaff
On Tue, Apr 02, 2024 at 10:15:50AM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2024 09:55:48 -0700 > Tyler Retzlaff wrote: > > > Some libraries that could be built with MSVC were not being built. > > > > Switch from explicit include to exclude of libs to get immediate CI > > coverage of lib

Re: [PATCH 00/83] move alignment attribute on types

2024-04-02 Thread Tyler Retzlaff
ping, call for reviewers. it's relatively straight forward since it follows the same series that was applied in lib but still more eyes are appreciated. thanks! On Wed, Mar 20, 2024 at 08:36:53AM -0700, Tyler Retzlaff wrote: > The current location used for __rte_aligned(a) for alignment of types

[PATCH v9 1/4] net/i40e: use inline prefetch function

2024-04-02 Thread Tyler Retzlaff
Don't directly access the cacheline1 field in rte_mbuf struct for prefetch instead just use rte_mbuf_prefetch_part2() to prefetch. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v9 0/4] remove use of RTE_MARKER fields in libraries

2024-04-02 Thread Tyler Retzlaff
As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting descriptor fields and removing cachline fields. RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields. For cacheline{0,1} fields remove fields entirely and use inline functions to prefetch. Prov

[PATCH v9 2/4] mbuf: remove rte marker fields

2024-04-02 Thread Tyler Retzlaff
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Provide new rearm_data and rx_descriptor_fields1 fields in anonymous unions as

[PATCH v9 3/4] security: remove rte marker fields

2024-04-02 Thread Tyler Retzlaff
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- doc/guides/rel_

[PATCH v9 4/4] cryptodev: remove rte marker fields

2024-04-02 Thread Tyler Retzlaff
RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- doc/guides/rel_

Re: [PATCH v5 8/8] net/tap: remove no longer used files

2024-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2024 10:12:40 -0700 Stephen Hemminger wrote: > The BPF api was replaced by use of libbpf. > And the BPF instruction header was replaced by the skeleton. > > Signed-off-by: Stephen Hemminger The build for this fails on CI because CI is testing on CentOs7. RHEL/CentOs 7 is no long

Re: [PATCH v9 2/4] mbuf: remove rte marker fields

2024-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2024 13:08:48 -0700 Tyler Retzlaff wrote: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Provid

Re: [PATCH v9 2/4] mbuf: remove rte marker fields

2024-04-02 Thread Tyler Retzlaff
On Tue, Apr 02, 2024 at 01:45:49PM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2024 13:08:48 -0700 > Tyler Retzlaff wrote: > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. > > > > Maintain alignment of fields after removed

[PATCH v3 00/30] replace rte_memcpy of fixed size with memcpy

2024-04-02 Thread Stephen Hemminger
The DPDK has a lot of unnecessary usage of rte_memcpy. This patch set replaces cases where rte_memcpy is used with a fixed size constant size. Typical example is: rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); which can be replaced with: memcpy(mac_addrs, mac.addr_bytes

[PATCH v3 01/30] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Rte_memcpy should not be used for the simple case of copying a fix size structure because it is slower and will hide problems from code analysis tools. Coverity, fortify and other analyzers special case memcpy(). Gcc (and Clang) are smart enough to inline copies which will be faster. Signed-off-b

[PATCH v3 02/30] eal: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index e541f079

[PATCH v3 03/30] ethdev: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.c | 3 +-- lib/ethdev/rte_flow.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index f1c658f49e..e

[PATCH v3 04/30] eventdev: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_crypto_adapter.c | 2 +- lib/eventdev/rte_event_dma_adapter.c| 4 ++-- lib/eventdev/rte_event_timer_adapter.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v3 05/30] cryptodev: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/cryptodev/rte_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c index 886eb7adc4..137525 100644 ---

[PATCH v3 06/30] ip_frag: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv6_fragmentation.c | 4 +--- lib/ip_frag/rte_ipv6_reassembly.c| 6 ++ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/ip_frag/rte_ipv6_fragmentation.c b/l

[PATCH v3 07/30] net: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/net/rte_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/rte_ether.c b/lib/net/rte_ether.c index f59c20289d..761b38f805 100644 --- a/lib/net/rte_ether.c +++ b/li

[PATCH v3 08/30] lpm: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/lpm/rte_lpm6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 46d8f71a2d..242695dd4d 100644 --- a/lib/lpm/rte_lpm6.c +++ b/lib/

[PATCH v3 09/30] node: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/node/ip6_lookup.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c index 309964f60f..b8e567ccd9 100644 --- a/lib/node/ip6_l

[PATCH v3 10/30] pdcp: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pdcp/pdcp_process.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib/pdcp/pdcp_process.c b/lib/pdcp/pdcp_process.c index 9b9b881124..6

[PATCH v3 11/30] pipeline: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_table_action.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/pipeline/rte_table_action.c b/lib/pipeline/rte_table_action.c index 87c3e0e2c9..aec84dee

[PATCH v3 12/30] rib: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Mostly automatically generated by devtools/cocci/rte_memcpy.cocci The fib/trie.c was relying on headers rte_rib6 -> rte_memcpy -> rte_vect since rib6 is no longer using rte_memcpy need to get rte_vect.h Signed-off-by: Stephen Hemminger --- lib/fib/trie.c | 2 +- lib/rib/rte_rib6.h | 5 +++-

[PATCH v3 14/30] bus: remove unneeded rte_memcpy.h include

2024-04-02 Thread Stephen Hemminger
Included here but never used. Signed-off-by: Stephen Hemminger --- drivers/bus/auxiliary/linux/auxiliary.c | 1 - drivers/bus/fslmc/fslmc_bus.c| 1 - drivers/bus/fslmc/fslmc_vfio.c | 1 - drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 1 - drivers/bus/fslmc/portal/dpaa2_hw_dpc

[PATCH v3 13/30] security: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- lib/security/rte_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index e5c862f5f5..28d59ef388 100644 --- a/

[PATCH v3 16/30] raw: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/afu_pmd_he_hssi.c | 3 +-- drivers/raw/ifpga/afu_pmd_he_lpbk.c | 3 +-- drivers/raw/ifpga/afu_pmd_he_mem.c | 3 +-- drivers/raw/ifpga/afu_pmd_n3000.c

[PATCH v3 17/30] baseband: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/baseband/acc/rte_acc100_pmd.c | 17 - drivers/baseband/acc/rte_vrb_pmd.c | 21 ++--- drivers/baseband/la12xx/bbdev_la12xx.c | 4 ++-- 3 files changed, 20

[PATCH v3 18/30] common: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Also, remove unnecessary includes of rte_memcpy.h Signed-off-by: Stephen Hemminger --- drivers/common/idpf/idpf_common_device.c | 4 ++-- drivers/common/idpf/idpf_common_virtchnl.c | 10 ++ drivers/common/qat/qat_qp.c

[PATCH v3 19/30] crypto: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_crypto.c | 14 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_se.h| 2 +- 3 files changed, 7 insertions(+), 11 d

[PATCH v3 20/30] crypto: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c| 2 +- drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 +- drivers/crypto/qat/qat_sym_session.c | 52 +

[PATCH v3 21/30] event: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Also, remove unnecessary includes of rte_memcpy.h Signed-off-by: Stephen Hemminger --- drivers/event/cnxk/cnxk_eventdev_selftest.c | 1 - drivers/event/cnxk/cnxk_tim_evdev.c | 4 ++-- drivers/event/dlb2/dlb2.c

[PATCH v3 22/30] mempool: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 4 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH v3 23/30] ml/cnxk: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/ml/cnxk/cn10k_ml_model.c | 8 +--- drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++ drivers/ml/cnxk/cnxk_ml_ops.c| 2 +- drivers/ml/cnxk/mvtvm_ml_model.c | 8 +--- drivers/ml/

[PATCH v3 24/30] app/test-pmd: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 48 ++--- app/test-pmd/cmdline_flow.c | 24 +-- app/test-pmd/config.c | 8 +++ app/test-pmd/csumonly.c | 1

[PATCH v3 25/30] app/graph: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/graph/neigh.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/graph/neigh.c b/app/graph/neigh.c index 79fd542c89..77f0766133 100644 --- a/app/graph/neigh.c +++ b/ap

[PATCH v3 26/30] app/test-eventdev: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test-eventdev/test_pipeline_common.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pip

[PATCH v3 27/30] app/test: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- app/test/commands.c | 1 - app/test/packet_burst_generator.c | 4 +-- app/test/test_crc.c | 5 ++-- app/test/test_cryptodev.c | 18 ++

[PATCH v3 28/30] app/test-pipeline: remove unused rte_memcpy.h include

2024-04-02 Thread Stephen Hemminger
This included but never used here. Signed-off-by: Stephen Hemminger --- app/test-pipeline/config.c | 1 - app/test-pipeline/init.c| 1 - app/test-pipeline/main.c| 1 - app/test-pipeline/runtime.c | 1 - 4 files changed, 4 deletions(-) diff --git a/app/test-pipeline/config.c b/app/test-

[PATCH v3 29/30] app/test-bbdev: remove unnecessary include of rte_memcpy.h

2024-04-02 Thread Stephen Hemminger
Includes rte_memcpy.h but no rte_memcpy used. Signed-off-by: Stephen Hemminger --- app/test-bbdev/test_bbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c index cf224dca5d..7309d85bc5 100644 --- a/app/test-bbdev/test_bbdev.c +++ b/

[PATCH v3 30/30] examples: replace use of fixed size rte_memcpy

2024-04-02 Thread Stephen Hemminger
Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 2 +- examples/bond/main.c | 1 - examples/ip_fragmentation/main.c | 1 - examples/ip_reassembly/ma

Re: [PATCH v1 0/2] deque: add multithread unsafe deque library

2024-04-02 Thread Stephen Hemminger
On Mon, 1 Apr 2024 21:20:13 -0700 Tyler Retzlaff wrote: > On Tue, Apr 02, 2024 at 03:03:13AM +, Aditya Ambadipudi wrote: > > Hello Stephen, > > > > I have a copy of CLRS with me. And Deque is a very standard word in > > computer science. Even CLRS which is considered one of the most > > fo

Re: [PATCH v1 0/2] deque: add multithread unsafe deque library

2024-04-02 Thread Honnappa Nagarahalli
> On Apr 2, 2024, at 6:44 PM, Stephen Hemminger > wrote: > > On Mon, 1 Apr 2024 21:20:13 -0700 > Tyler Retzlaff wrote: > >> On Tue, Apr 02, 2024 at 03:03:13AM +, Aditya Ambadipudi wrote: >>> Hello Stephen, >>> >>> I have a copy of CLRS with me. And Deque is a very standard word in >>>

Re: Issues around packet capture when secondary process is doing rx/tx

2024-04-02 Thread Stephen Hemminger
On Mon, 8 Jan 2024 15:13:25 + Konstantin Ananyev wrote: > > I have been looking at a problem reported by Sandesh > > where packet capture does not work if rx/tx burst is done in secondary > > process. > > > > The root cause is that existing rx/tx callback model just doesn't work > > unless

[PATCH] vhost: fix crash caused by accessing a freed vsocket

2024-04-02 Thread Gongming Chen
When a vhost user message handling error in the event dispatch thread, vsocket reconn is added to the reconnection list of the reconnection thread. Since the reconnection, event dispatching and app configuration thread do not have common thread protection restrictions, the app config thread freed v

[PATCH] vhost: fix crash caused by accessing a freed vsocket

2024-04-02 Thread Gongming Chen
From: Gongming Chen When a vhost user message handling error in the event dispatch thread, vsocket reconn is added to the reconnection list of the reconnection thread. Since the reconnection, event dispatching and app configuration thread do not have common thread protection restrictions, the app

[PATCH] vhost: fix crash caused by accessing a freed vsocket

2024-04-02 Thread Gongming Chen
From: Gongming Chen When a vhost user message handling error in the event dispatch thread, vsocket reconn is added to the reconnection list of the reconnection thread. Since the reconnection, event dispatching and app configuration thread do not have common thread protection restrictions, the app

Reminder - DPDK Tech Board Call tomorrow - Wed. 4/3/24 - 8am Pacific/11am Eastern/1500h UTC

2024-04-02 Thread Nathan Southern
You have been invited to a recurring meeting for Data Plane Development Kit (DPDK) Agenda (read-only): https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db

Re: [PATCH] vhost: cleanup vq resubmit info when set_inflight_fd

2024-04-02 Thread Haoqian He
> 2024年3月21日 17:57,Haoqian He 写道: > > We should cleanup vq resubmit info when set_inflight_fd > before set_vring_kick which will check if there is any > inflight io waiting for resubmission. > > Otherwise, when the vm is rebooting immediately after > reconnecting to the vhost target (inflight

[PATCH] vhost: fix crash caused by accessing a freed vsocket

2024-04-02 Thread Gongming Chen
From: Gongming Chen When a vhost user message handling error in the event dispatch thread, vsocket reconn is added to the reconnection list of the reconnection thread. Since the reconnection, event dispatching and app configuration thread do not have common thread protection restrictions, the app